Commit Graph

78507 Commits

Author SHA1 Message Date
Vadim Tryshev 47bcb2b6c5 Increasing wait time for Launcher restart after enabling test provider
Of the the logcats indicates that Launcher gets killed eventually, but
it takes 17 sec, while the test waits for the Launcher restart to
compete in 10 sec.

Perhaps restart take longer than usual because the system is still busy
killing setup wizard.

This is the second attempt to land this CL; the first one was reverted
because the revert author believed this breaks their tests.

This time I'm icreasing the wait from 10 to 30 (not 60) secs.

Bug: 308489613
Test: presubmit
Flag: N/A
Change-Id: I18cff219cf6ec2732ed181c970cb5315bf568cab
2023-11-14 10:16:05 -08:00
Schneider Victor-tulias 3b9d80d2d8 Clean up NPEs in AbsSwipeUpHandler
AbsSwipeUphandler has many potential and common NPEs. Added more null checks to AbsSwipeUpHandler

Flag: N/A
Fixes: 295905702
Fixes: 309535060
Test: StartLauncherViaGestureTests, quick switched and launched app from recents
Change-Id: I11f62eac423ae3c5792ce97ca49963f1e005b289
2023-11-14 10:48:10 -05:00
Jordan Silva 646c95e643 Merge "Fix wrong number of columns for AllApps calculation" into main 2023-11-14 14:35:00 +00:00
Himanshu Gupta 08badb3f6f Adding Private Space views to Launcher.
This CL adds the following:
* Static View Elements to be added to AllApps recycler View
* View Controller to load the above elements dynamically
* Private Space Section Decorator
* PrivateProfile Manager containing the logic related to Private Space
* Abstract UserProfileManager as the super class of Work/Private
ProfileManager

Private Space Views Figma
[link](https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=14535-111985&mode=design&t=JLz9W0O551TpzQYH-0)

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I8aa4247c78064a551e5e0d0b46d3fc033873f99d
2023-11-14 11:58:16 +00:00
Jordan Silva 8b3fa14ef9 Fix wrong number of columns for AllApps calculation
Fix: 310657769
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Change-Id: Id46c9e4529176b68f6d92d31a71016ed4f8134d1
2023-11-14 10:37:32 +00:00
Uwais Ashraf 6dfa8521e5 Merge "Revert "Refactor/clean up Overview Actions buttons"" into main 2023-11-14 10:25:11 +00:00
Uwais Ashraf 60a2d85b68 Revert "Refactor/clean up Overview Actions buttons"
Revert submission 25292769-cleanup-action-buttons

Reason for revert: Causes a 100% failure of OverviewImageTest

Reverted changes: /q/submissionid:25292769-cleanup-action-buttons

Change-Id: Iedd51290e2d6fb7efafc814f1d3d51863b3d3ab7
2023-11-14 09:45:55 +00:00
Luca Zuccarini a3b8854951 Merge "Refine way to trigger the keyboard for a controlled insets animation." into main 2023-11-14 08:23:22 +00:00
Luca Zuccarini 6ab61069f3 Refine way to trigger the keyboard for a controlled insets animation.
Before we did it as normal just without requesting focus. However, we
also need to not log the new state, as this must happen only after the
controlled animation has completed (or been cancelled).

Bug: 309756056
Flag: NA
Test: manual
Change-Id: I7f1564d2b29d91c9fdb0afce586fe5cc1148bac0
2023-11-14 08:20:40 +00:00
Jagrut Desai cd016b5a41 Merge "Revert "Revert "Remove TaplTestsQuickstep tests from PlatinumTes..."" into main 2023-11-14 02:39:14 +00:00
Bill Yi f3fa713864 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 46ee79f345 -s ours am: 6cc2a50548 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25361153

Change-Id: I4873bef3879741b607ea2a943596fa0aec1566bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-14 00:21:20 +00:00
Bill Yi 6cc2a50548 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 46ee79f345 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25361153

Change-Id: Ib875338b5af2f0d50dc334e72090740125ac35e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-14 00:09:45 +00:00
Tracy Zhou 07e2e43311 Merge "Migrate ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS to aconfig" into main 2023-11-13 22:49:44 +00:00
Jeremy Sim ed56be4fbc Merge "Refactor/clean up Overview Actions buttons" into main 2023-11-13 22:20:47 +00:00
Jagrut Desai a407abfbec Revert "Revert "Remove TaplTestsQuickstep tests from PlatinumTes..."
Revert submission 25359412-revert-25316575-CUJ-TaplTestQuickstep-part2-VHLGZMEHQT

Reason for revert: The excluding all of these test cl is landed now, so we can safely revert this revert change. 


Reverted changes: /q/submissionid:25359412-revert-25316575-CUJ-TaplTestQuickstep-part2-VHLGZMEHQT

Change-Id: I9ddb7a8140c5172b708b43938ce224b7e8051051
2023-11-13 21:58:24 +00:00
Bill Yi 46ee79f345 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If997e3da63c6318856c45c33ac2a61b3efd508c0
2023-11-13 13:42:49 -08:00
Tracy Zhou 859edd00e9 Migrate ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS to aconfig
Bug: 270394122
Test: N/A
Change-Id: I9bacd906099518b4a4c43a9f80ab0c753beac89a
2023-11-13 13:12:09 -08:00
Priyanka Advani c0f35ccea1 Merge "Revert "Remove TaplTestsQuickstep tests from PlatinumTest Part2"" into main 2023-11-13 21:10:24 +00:00
Priyanka Advani 07c9ca69c3 Revert "Remove TaplTestsQuickstep tests from PlatinumTest Part2"
Revert submission 25316575-CUJ-TaplTestQuickstep-part2

Reason for revert: b/310687289

Reverted changes: /q/submissionid:25316575-CUJ-TaplTestQuickstep-part2

Change-Id: I3a253e42f2ea00921658317edae2423fe909ebb2
2023-11-13 20:47:35 +00:00
Vadim Tryshev 18c1038ddf Merge "Making killing setup wizard a permanent solution" into main 2023-11-13 20:20:07 +00:00
Jagrut Desai 2c7556d4c7 Merge "Fix RTL issue with all apps meta icon" into main 2023-11-13 20:13:34 +00:00
Jagrut Desai bd997801e9 Merge "Migrate ENABLE_TASKBAR_PINNING to aconfig flag" into main 2023-11-13 20:13:15 +00:00
Jagrut Desai 6401f298a1 Merge "Remove TaplTestsQuickstep tests from PlatinumTest Part2" into main 2023-11-13 18:29:56 +00:00
Jordan Silva 1fb00ea561 Merge "Responsive grid cleanup" into main 2023-11-13 15:03:29 +00:00
Mike Schneider a9e73583bc Merge "Revert "Increasing wait time for Launcher restart after enabling test provider"" into main 2023-11-13 14:57:49 +00:00
Mike Schneider 27f0b77357 Revert "Increasing wait time for Launcher restart after enabling test provider"
This reverts commit a333756f0c.

Reason for revert: Seems to permanently break flickr tests with a timeout (https://android-build.corp.google.com/test_investigate/?invocationId=I84700010216659574&testResultId=TR17229044551287787)

Bug: 310269045
Change-Id: I49631dc10111e7bcd4b663ec5b26ee79885da246
2023-11-13 13:25:48 +00:00
Vinit Nayak a20e964cbd Merge "Prevent widgets from entering split" into main 2023-11-13 06:06:41 +00:00
Jagrut Desai 56c85bbbc1 Merge "Fix RTL issue with TaskbarDividerPopupMenu" into main 2023-11-11 16:25:45 +00:00
Tracy Zhou ab1dc752e8 Make sure the hotseat icons are always visible in phone mode
With task bar in unfolded state, we animate from app to home by morphing the task bar into the hotseat. In the folded state, the visibility of the hotseat should never be affected by the task bar state.

Fixes: 309477352
Test: Swipe up from app in folded state with task bar / nav bar unification flag on, make sure that the transition is smooth and the hotseat is always visible. Also make sure unfolded state works as usual.
Change-Id: I1064a0c03e8f7539f8ea4d0322f58be9dff8513e
2023-11-11 07:46:30 +00:00
Bill Yi 2d545b5c45 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: a2f83ad671 -s ours am: f20eeaa820 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25332226

Change-Id: Ie463a7d7ddefd59c07b37b9b89d7efa9da4f86cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-11 04:57:09 +00:00
Bill Yi f20eeaa820 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: a2f83ad671 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25332226

Change-Id: I7087bdcb6e8b5606e2a01e46859f9ed3406d07c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-11 04:28:54 +00:00
Vadim Tryshev aecbc650fc Merge "Disabling strict activity leak check more aggressively than in ag/25340909" into main 2023-11-11 02:26:06 +00:00
Vadim Tryshev 4c2bf22c8d Merge "Demoting a couple of presubmit blocker tests" into main 2023-11-11 00:53:21 +00:00
Vadim Tryshev 94cb915d38 Disabling strict activity leak check more aggressively than in ag/25340909
That CL wasn't sufficient, still seeing:
https://android-build.corp.google.com/test_investigate/?blocking=warning&invocationId=I37300010216048087&status=none&testResultId=TR78329041431354974

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I36979a8929ccb996b81e8d41ec75b9713258c1c3
2023-11-10 16:41:42 -08:00
Vadim Tryshev dcead30d1e Merge "Disabling strict activity leak check" into main 2023-11-11 00:35:33 +00:00
Vadim Tryshev 761b735728 Demoting a couple of presubmit blocker tests
Bug: 310242894
Test: presubmit
Flag: N/A
Change-Id: Ifd4dd430dbb645b5ab066742dd3ec861de3dfffa
2023-11-10 15:14:04 -08:00
Vadim Tryshev 7df94cca65 Disabling strict activity leak check
Started seeing presubmit blockers like:
https://android-build.corp.google.com/test_investigate/?invocationId=I51800010216065294&testResultId=TR60829041305611993

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ic88f67e54d2dec4b244784abd2a15fbdfdf9e711
2023-11-10 15:04:46 -08:00
Kevin Lim c3909d970b Merge "[Tiger] Re-adding PlatinumTest annotation" into main 2023-11-10 21:56:12 +00:00
Bill Yi 0edcdb2943 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-11-10 21:15:38 +00:00
Bill Yi 72cef203b2 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-11-10 21:15:38 +00:00
Vadim Tryshev 1f8ff66235 Making killing setup wizard a permanent solution
It will be killed only in presubmit. In postsubmit, we want to be a true
e2e test exposed to all actual problems, including setup wizard that
doesn't go away.

Bug: 309471958
Test: presubmit
Flag: N/A
Change-Id: I2e877eade060e75e277eb3603d90b659207b5a47
2023-11-10 12:20:45 -08:00
Vinit Nayak 1d3035e024 Prevent widgets from entering split
Bug: 296502210
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Change-Id: I1a166f6ca0fe5fd2fa1d29b97b8856e52985e0c1
2023-11-10 12:17:12 -08:00
Vadim Tryshev d315ffcb8f Merge "Increasing wait time for Launcher restart after enabling test provider" into main 2023-11-10 19:58:20 +00:00
Vadim Tryshev a333756f0c Increasing wait time for Launcher restart after enabling test provider
Of the the logcats indicates that Launcher gets killed eventually, but
it takes 17 sec, while the test waits for the Launcher restart to
compete in 10 sec.

Perhaps restart take longer than usual because the system is still busy
killing setup wizard.

Bug: 308489613
Test: presubmit
Flag: N/A
Change-Id: Idd576cacc300bce071bb40743209b4a111f18473
2023-11-10 10:31:14 -08:00
Pat Manning da5baa981a Merge "Fix focus nav of AllApps when Searching." into main 2023-11-10 18:20:01 +00:00
Jagrut Desai dc165fcf90 Fix RTL issue with TaskbarDividerPopupMenu
Test: Presubmit, Manual
Bug: 310217447
Flag: LEGACY ENABLE_TASKBAR_PINNING TEAMFOOD
Change-Id: I00a9088274ee6716250da7f6c79caf6820955803
2023-11-10 09:50:25 -08:00
Jagrut Desai 1ab8da20f5 Fix RTL issue with all apps meta icon
Test: Presubmit, Manual
Bug: 309453796
Flag: NONE
Change-Id: I5d8bda2c48a0815d7005a0727f67f871f75d4f0f
2023-11-10 09:44:51 -08:00
Pat Manning e7cb65009e Fix focus nav of AllApps when Searching.
- Do not focus the Icon in Small Icon Result Rows
- Use FocusIndicatorHelper when focusing search result icons

Flag: NONE
Bug: 296844600
Fix: 310173226
Test: Test: TaplKeyboardFocusTest
Change-Id: Icfc82ae41ffc8ef7c7ad42950f98f3d2dc805795
2023-11-10 16:48:21 +00:00
Kevin Lim 9bb62ee9c1 [Tiger] Re-adding PlatinumTest annotation
This undoes ag/24559527 as this test is no longer flaky.

Actual PlatinumTest presubmit restoration is done in cl/581071347

Bug: b/293944634
Flag: N/A
Test: Test only change
Change-Id: I605f8911fa3a3658c49642efee8d6166545ae89b
2023-11-10 01:37:15 +00:00
Bill Yi edf4826a63 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6a7c7c137d375c77c1660371634aa0aa8ccc003f
2023-11-09 16:39:37 -08:00