Commit Graph

4240 Commits

Author SHA1 Message Date
Hyunyoung Song da4fcfea63 Move tapl build rule to Android.bp
Bug: 113683301
Test: make Launcher3Tests

Change-Id: I9f279bb80f3f399a2271ed8ee94445afbebacb2e
2018-09-05 10:18:28 -07:00
TreeHugger Robot b75f5366f9 Merge "Removing tryGetAllApps" into ub-launcher3-master 2018-09-04 21:01:05 +00:00
Vadim Tryshev 46e81de3d2 Not assuming that all accessibility events contain bundle
Bundles come from Launcher being explicitly asked a question.
When waiting for ANY event, it may contain any parcelable, so it's
incorrect to cast it to Bundle.

See this:
https://sponge.corp.google.com/target?show=FAILED&sortBy=STATUS&id=9b8d0d26-f81d-427f-8857-b8d71e012504&target=android.test.appsmoke

Bug: 110103162
Test: will watch for reducing flakes in platform tests.
Change-Id: I989cee018183140d7fd672c0a925f03441ca339c
2018-08-30 12:07:39 -07:00
Vadim Tryshev a90d17b411 Removing tryGetAllApps
There were plans to use it from platform tests, but this turned to be
unnecessary.

Bug: 110103162
Test: compiling
Change-Id: I39bf3f4cff57018bec87dcb3e8dfee522121d85b
2018-08-29 11:54:49 -07:00
Vadim Tryshev 530c3cd018 Removing AllApps.getObjectDeprecated()
I was planning to use it from platform tests, but managed to avoid this.

Bug: 110103162
Test: TaplTests
Change-Id: Ic7bd6afe2097d64f8baca59b74d61e2ff7ff9c76
2018-08-29 18:33:39 +00:00
Hyunyoung Song b441a7e765 Create a distinction between prebuilt tapl and tapl built from source.
Bug: 113128349

Change-Id: Ib1e09f13ee677a903f607b89d6bbb6af419677c4
2018-08-28 14:55:19 -07:00
TreeHugger Robot a537578498 Merge "Fixing AOSP tests after AndroidX migration" into ub-launcher3-master 2018-08-27 17:02:19 +00:00
Vadim Tryshev a3fd1e5bfe Fixing AOSP tests after AndroidX migration
Test: adb shell am instrument -w -r -e debug false com.android.launcher3.tests/androidx.test.runner.AndroidJUnitRunner
Change-Id: I72bf7095087b012a6eceac71ee02f2d7a5c8c51b
2018-08-24 17:48:38 -07:00
Vadim Tryshev 12daab5597 Enabling some test suites that miss from ATP
ATP requires the test size attribute, or else the test won't be run.

Test: Will see on ATP
Change-Id: If231781b5188c022e47cc40e46af933d753fa114
2018-08-24 14:04:43 -07:00
Vadim Tryshev 98afc96461 Increasing wait time to populate suggested apps
Bug: 110103162
Test: ReflectionBasicUiTest
Change-Id: Iee5d4f328bdde93e6d9c2db9869314aa3a8eb00f
2018-08-23 15:06:37 -07:00
Vadim Tryshev d819b8f743 Comment fix
Bug: 110103162
Test: ReflectionBasicUiTest
Change-Id: Ic9cfe925bb396e3fa0257009d5d9f53db728f9f0
2018-08-23 18:48:06 +00:00
Vadim Tryshev 9aca88cbf9 Fixing tests on a larger device
See atp for failed tests.

Widget container may return objects outside of screen, hence the test
failures.

Test: AddConfigWidgetTest.com.android.launcher3.ui.widget.AddConfigWidgetTest etc
Change-Id: Ia402dae0c9bc8f0585e57ac5f562a59e8ff4ed53
2018-08-22 17:35:18 -07:00
Vadim Tryshev fd34b94b33 Passing instrumentation to LauncherInstrumentation
UiDevice, the old param, belongs to a support lib; as TAPL switched to
AndroidX, it became impossible to pass it from platform tests
that still use the old support lib.

Bug: 110103162
Test: TaplTests
Change-Id: I1f82099b432912fa40da96df0d6179579aab66a3
2018-08-21 18:45:02 -07:00
TreeHugger Robot 23bb710b3d Merge "Converting tests to Androidx" into ub-launcher3-master 2018-08-22 01:22:56 +00:00
Vadim Tryshev 0a9f3ab4a6 Converting tests to Androidx
Bug: 112610679
Change-Id: I712826e668f1fbeb4e47cc541d4f5296d8eb74c0
2018-08-21 15:04:48 -04:00
Vadim Tryshev 923b81c14f Reducing time of TaplTests run
From ~245 to ~150 sec.

Done by removing testing behaviors that don't depend on QS from tests
marked with QuickstepOnOff attribute.

Also fixing a bug that went unnoticed: now restoring Launcher QS mode
after each test.

Bug: 110103162
Test: TaplTests suite
Change-Id: I715158b47ac1e370f578b8d4f13d9633283763fe
2018-08-16 17:55:34 -07:00
Vadim Tryshev b6398a1eb8 Sharing protocol constants between Launcher and TAPL
Bug: 110103162
Test: TaplTests
Change-Id: I5b2a2b8576a7a6ea4a156f00858711496d6b5bba
2018-08-14 19:53:43 -07:00
Sunny Goyal d230307a95 Migrating to android-x
Change-Id: I9a774152d13a541e8496dd84f2469bfed407f86d
2018-08-14 15:22:12 -07:00
TreeHugger Robot a950d40d09 Merge "Started converting Launcher to be gesture-stable" into ub-launcher3-master 2018-08-14 19:18:46 +00:00
Vadim Tryshev dc755e718d Started converting Launcher to be gesture-stable
All tests keep passing.

WorkTabTest.workTabExists was made gesture-stable. There is no need to
use TAPL, as the point is not to check answering to gestures, but to
check presence of tabs, which is better to do using launcher internal
state. (It still fails if run as a part of all tests, presumably,
because after Launcher's start, changes in user configuration are not
recognized, so I've commented the failing part)

Bug: 110103162
Test: Run all tests
Change-Id: Ic30b8e8475d16cee3880332f12311a44ddfa26cb
2018-08-14 10:29:57 -07:00
Sunny Goyal 6edb1b84bf Changing Condition to an interface to allow using lambdas
Change-Id: Ib7ad6a45d2ce556f843cd3a9767001904707dced
2018-08-14 10:27:48 -07:00
Vadim Tryshev 3b5793fdf5 Support for running Overview tests with quickstep on and off
Bug: 110103162
Test: TaplTests suite
Change-Id: Ic479156f2973aeec5cc3d288e1c891b8086d9daa
2018-08-10 17:35:43 -07:00
TreeHugger Robot 8f7137b769 Merge "Removing magic constant 0.1f from Overview" into ub-launcher3-master 2018-08-10 22:03:12 +00:00
Vadim Tryshev 309053fff9 Using SWIPE_UP_SETTING_NAME in TAPL
Bug: 110103162
Test: TaplTests suite
Change-Id: Ia62207773a156aca1e226307ccc462c252cc9227
2018-08-10 14:30:59 -07:00
Vadim Tryshev 846718a79a Removing magic constant 0.1f from Overview
Bug: 110103162
Test: TaplTests suite
Change-Id: If3af510360158a2c2b1c3d13c75321c49ece67e2
2018-08-09 14:21:46 -07:00
Vadim Tryshev b02bcd4c76 Removing code duplication for getting swipe-up setting
This is between Tapl and Launcher

Bug: 110103162
Test: TaplTests suite
Change-Id: I5b458438834204ca257f45c707577b4d2793fb4e
2018-08-07 18:01:12 -07:00
Vadim Tryshev 7d0cf2a748 Increasing wait time.
Extremely rarely starting an app takes more than 10 sec.

Bug: 110103162
Test: TaplTests suite
Change-Id: Ic6127e373b76c610eea5126e53e6048ba0f9bd3e
2018-08-06 11:11:25 -07:00
TreeHugger Robot 589f53cf89 Merge "Enabling more checks in TAPL tests." into ub-launcher3-master 2018-08-03 21:07:20 +00:00
Vadim Tryshev 7acde48955 Enabling more checks in TAPL tests.
Hiding workspace from tests when in AllApps or Overview.

Also, we don’t need workspace_page_container.

Bug: 110103162
Test: Running TaplTests suite
Change-Id: I10875a1ce5d41a015c63034160676578f52d2e98
2018-08-03 10:29:36 -07:00
TreeHugger Robot 7f63682742 Merge "Adding AOSP into the tapl library name." into ub-launcher3-master 2018-08-03 02:10:06 +00:00
TreeHugger Robot e98aab058e Merge "Fixing scrolling up in App Apps." into ub-launcher3-master 2018-08-02 22:58:25 +00:00
TreeHugger Robot ce15b325e8 Merge "Retiring some feature flags" into ub-launcher3-master 2018-08-02 21:48:54 +00:00
Vadim Tryshev ff3fa34a7a Fixing scrolling up in App Apps.
Done by scrolling only when scroll position is not zero. This way, the
scroll gesture can't close All Apps.

Bug: 110103162
Test: TaplTests suite
Change-Id: Icfe47d2bcc0210ae221df169d6c35cd1be10ff86
2018-08-02 14:15:05 -07:00
Vadim Tryshev 44780bad8f Adding AOSP into the tapl library name.
The idea is to prevent accidentally
adding non-AOSP code to it, which would make it wrong to
drop it to AOSP parts of the platform.

Bug: 110103162
Test: Building TaplTests suite
Change-Id: Ide68f469d59fefb72b5195c7916bd1515a9bbed2
2018-08-01 13:08:19 -07:00
Vadim Tryshev a279b2ea3e Adding a build rule for Tapl static library
Bug: 110103162
Test: TaplTests suite
Change-Id: Ibff017b68b1a31728d3a8d0c1ede2da6ebfecbb1
2018-07-24 17:16:25 -07:00
TreeHugger Robot 1143469a79 Merge "Tapl library" into ub-launcher3-master 2018-07-24 19:39:54 +00:00
Vadim Tryshev 2ce6a13f60 Tapl library
The public API of the library has finalized; flakiness has been removed;
code polished.

Bug: 110103162
Test: TaplTests suite
Change-Id: Ic156bbfeedb1cb9c4a48ef907f97e396e8e81936
2018-07-20 14:43:05 -07:00
Hyunyoung Song 484c643f7e Delete unnecessary line to trigger build
Change-Id: I905560cb3bb461ff44b76d782b370ea9b8bff320
2018-07-18 17:30:29 -07:00
Sunny Goyal 36b54228fc Retiring some feature flags
Change-Id: I80a00ecaec0785ce2ba6a5f14a54c8a76f555d43
2018-07-10 13:52:17 -07:00
Android Build Merger (Role) 0095d14ec0 [automerger] Add @Test and @Ignore to untested test methods in RequestPinItemTest. am: ca02f00eb1
Change-Id: I396c673bf256e1003f109201ebac9bb87b864622
2018-06-22 00:21:45 +00:00
Jon Miranda ca02f00eb1 Add @Test and @Ignore to untested test methods in RequestPinItemTest.
Error prone complains when trying to merge launcher3 code to platform pi-dev.

"This looks like a test method but is not run; please add @Test and @Ignore,
or, if this is a helper method, reduce its visibility."

Output:

Executing tasks: [:assembleGoogleDebug, :assembleGoogleDebugAndroidTest]
Gradle build finished in 1s 631ms
Tests Ignored: 1 passed, 4 ignored

Bug: 78589564
Change-Id: Icde57fd8307e1ef409822d1417f629cd1aaa57ba
2018-06-21 17:20:23 -07:00
Android Build Merger (Role) 4a724052af [automerger] Add @Test and @Ignore to untested test methods. am: 1aaaac8343
Change-Id: Ife9d31c9cf55e17275f8dfa0b70662a94948d395
2018-06-21 21:05:04 +00:00
Jon Miranda 1aaaac8343 Add @Test and @Ignore to untested test methods.
Error prone complains when trying to merge launcher3 code to platform pi-dev.

"This looks like a test method but is not run; please add @Test and @Ignore,
or, if this is a helper method, reduce its visibility."

Change-Id: I95f55b95d8f7752c9c941f0828ca22d6427528c6
2018-06-21 14:04:52 -07:00
TreeHugger Robot bc57c64d6a Merge "Comment out part of WorkTabTest as it is not succeeding in the build server. Bug: 78589564" into ub-launcher3-edmonton-polish 2018-06-20 18:46:30 +00:00
Android Build Merger (Role) 73c0010a91 [automerger] Comment out part of WorkTabTest as it is not succeeding in the build server. Bug: 78589564 am: 70e36604a4
Change-Id: I2acebdf20bef9f5c94e53129cb34590d174af80a
2018-06-20 18:25:53 +00:00
Hyunyoung Song 70e36604a4 Comment out part of WorkTabTest as it is not succeeding in the build server.
Bug: 78589564

Change-Id: I7a979d9a62e222b8b2217844883d4a41c42f8209
2018-06-20 11:25:39 -07:00
TreeHugger Robot 9a36abc179 Merge "Increase timeout for WorkTabTest Bug: 78589564" into ub-launcher3-edmonton-polish 2018-06-19 23:20:33 +00:00
Android Build Merger (Role) 7b26b7e435 [automerger] Increase timeout for WorkTabTest Bug: 78589564 am: e8d5bcfb92
Change-Id: Ib0e8029c56b6822d19f1803544b1259d3ecac9c1
2018-06-19 22:57:29 +00:00
Hyunyoung Song e8d5bcfb92 Increase timeout for WorkTabTest
Bug: 78589564

Change-Id: Ie52843d08488d4c7444dd3c0231054cfecc00922
2018-06-19 15:57:02 -07:00
TreeHugger Robot 3c83d4ed72 Merge "Fix the Launcher3Tests Bug: 78589564" into ub-launcher3-edmonton-polish 2018-06-19 21:23:48 +00:00