Commit Graph

6493 Commits

Author SHA1 Message Date
Charlie Anderson d52925f9c4 Merge "polish for the app shortcut popup, fixing padding on several elements." into tm-qpr-dev am: da4e07812a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21791366

Change-Id: I83ac6a587bf29869708958a86064b55b2f4f756f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-15 21:38:47 +00:00
TreeHugger Robot d7d58e2abe Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-03-15 21:24:12 +00:00
Bill Yi 519db9ba13 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie6bed63e03409e5a80eadd0e88cf53dbce4abbe4
2023-03-15 01:27:02 -07:00
Charlie Anderson 63be5b53db polish for the app shortcut popup, fixing padding on several elements.
Bug: 269343928
Test: manually verify against spec
Change-Id: Ib8dd7ab2778644e2220622d43f9774c1de6357e9
2023-03-14 11:33:38 -04:00
Sebastián Franco 96c514406d Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev am: 4122868216 am: b8614e298c am: fef518da3d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778872

Change-Id: I39f2ac583208a2668ecb27fdbea1a5eb6b876e1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 21:01:37 +00:00
Sebastián Franco fef518da3d Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev am: 4122868216 am: b8614e298c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778872

Change-Id: I124c235e0dcdeab04b3fe2eb40083118778b9fa2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 20:32:00 +00:00
Sebastián Franco b8614e298c Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev am: 4122868216
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778872

Change-Id: I274f6eae4cda80ea45ee48328b6d2a5abfb1e648
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 19:47:55 +00:00
Sebastián Franco 4122868216 Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev 2023-03-10 19:19:42 +00:00
Brandon Dayauon 1dabec1de5 Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev am: 5ddc6ab4da am: e0bddb5b42 am: 061cf0d4e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898210

Change-Id: I164ff3309e31768543172bf82496a6d8b5cefb08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 19:13:46 +00:00
Brandon Dayauon 061cf0d4e9 Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev am: 5ddc6ab4da am: e0bddb5b42
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898210

Change-Id: I097b55e72e2c07d75a45ff044f581b1f5d30af6c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 18:34:30 +00:00
Brandon Dayauon e0bddb5b42 Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev am: 5ddc6ab4da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898210

Change-Id: Ibf5cb36dc8e5ec0def0012b17b14e848a33d9d83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 17:58:48 +00:00
Brandon Dayauon cf88ea1e62 Support two line text in AllApps/OnDeviceSearch w/ feature flag
Made separate feature flag for on device search
Add unit test to test twoLine string
- Unit tests for testing newStringThatShouldSupportTwoLineText() in BubbleTextView.java. This class tests a couple of strings
and uses the getLineCount() to determine if the test passes. Verifying with getLineCount() is sufficient since BubbleTextView can only be in one line or two lines,
and this is enough to ensure whether the string should be specifically wrapped onto the second line and to ensure truncation.

bug: 201388851
test: presubmit, ran locally on big and small device, before: https://screenshot.googleplex.com/3Q6pwveFDZqxDXL (ORIGINAL TWO LINE TEXT)
after:  https://screenshot.googleplex.com/7pkwUto6HGzMYoT

Change-Id: I93e6ed179e1081d5cdffc6db9c7ae34de8021c24
2023-03-09 15:13:04 -08:00
Sebastian Franco 239ae0a995 Making sure there is a propper Chrome icon for the test to long press
In some cases, the test was long pressing on a recommendation for
google chrome and not a regular chrome icon and the events didn't
match. I don't think is good to relly on chrome getting recommended
so I'm making sure there is always a chrome app icon on the hotseat

Fix: 269163620
Test: atest TaplTestsLauncher3:testWorkspace (run on pixel 7 pro)
Change-Id: Ic8ee744a9af18d60de9bbedd42043f5abbbd7356
2023-03-09 14:59:21 -08:00
Sihua Ma 3b702b3056 Merge "Set the original drawable for floating widget view" into tm-qpr-dev am: 792dda2344 am: fc9d3a50ad am: 27ce0f4212
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20899726

Change-Id: I6736938971dee15b56965e3a47c392e7b7536568
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 20:17:40 +00:00
Sihua Ma 27ce0f4212 Merge "Set the original drawable for floating widget view" into tm-qpr-dev am: 792dda2344 am: fc9d3a50ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20899726

Change-Id: I91904f267dbca7fc30b8ed5d17c8bcb1fd2a889b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 19:44:37 +00:00
Sihua Ma fc9d3a50ad Merge "Set the original drawable for floating widget view" into tm-qpr-dev am: 792dda2344
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20899726

Change-Id: I345f74a393fb994b7b83ccde884263c8a43b4678
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 19:09:19 +00:00
Sihua Ma 792dda2344 Merge "Set the original drawable for floating widget view" into tm-qpr-dev 2023-03-08 18:26:59 +00:00
Charlie Anderson 866716dc1c Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev am: 3b072b9a07 am: 04d2397c43 am: d6ada70040
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21559561

Change-Id: Ic2129f0dc31bdbfaabbf05828a367720ddcad6a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 15:46:49 +00:00
Charlie Anderson d6ada70040 Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev am: 3b072b9a07 am: 04d2397c43
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21559561

Change-Id: I5bd08c1af0b0180bb6b8cce5101bd714509fb822
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 15:11:23 +00:00
Charlie Anderson 04d2397c43 Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev am: 3b072b9a07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21559561

Change-Id: I070d83e8389c5a4df8b60923b9615a00e2bbc037
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 14:35:52 +00:00
Charlie Anderson 3b072b9a07 Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev 2023-03-08 14:15:17 +00:00
Sihua Ma 914549b482 Set the original drawable for floating widget view
This ensures that the background of the widget will not disappear after cancelling opening the widget activity.

Normally, when opening and closing the widget activity, the following procedures are executed:

tap on widget
-> opening animation initialized -> opening animation finished
-> close the activity
-> closing animation initialized -> closing animation finished

The steps above would work fine. However, a different set of procedures is followed if we try to cancel opening the widget activity:

tap on widget
-> opening animation initialized
-> opening animation started
-> swipe back before opening animation is completed
-> closing animation initialized
-> opening animation finished
-> closing animation started
-> closing animation finished

During the animation initialization process, FloatingWidgetBackgroundView would be initialized. It will then cache the original background and replace with a temporary drawable with alpha set to 0. The background is only restored at the end of the animation.

If two FloatingWidgetBackgroundView is initialized on the same app widget view before one of them is finished, the second floating view will treat the temporary drawable as the original background. At the end of the closing animation, the temporary drawable with an alpha value of 0 will be set for the app widget view, causing the background of the widget view to disappear.

This CL stores the original drawables into the background view so they could be retrieved during the initialization process of the floating background view.

Test: Manual
Fix: 259526083
Change-Id: Iefa29b22b690076a4fc3fc77fe6eea4b6316f852
2023-03-07 15:20:22 -08:00
Brandon Dayauon eebeb2dd8b Merge "Correctly make to spec the color for "Turn on work apps" button and add stroke" into tm-qpr-dev am: d0838d3ac1 am: 76e123820a am: aab27044a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21470669

Change-Id: I97893debbd86370fb4da47b1ff9d3a4e0c0bbdc9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 21:40:39 +00:00
Brandon Dayauon aab27044a1 Merge "Correctly make to spec the color for "Turn on work apps" button and add stroke" into tm-qpr-dev am: d0838d3ac1 am: 76e123820a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21470669

Change-Id: I7281d4c3968a220c2d2fbb0a2468623b02047c84
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 21:24:44 +00:00
TreeHugger Robot e6c58387a6 Merge "Fix margins/padding in widget picker" into tm-qpr-dev am: 8fd957e323 am: a50856e4ba am: a69666477f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21467066

Change-Id: Icc804b645b3f5abe28499c36af7b2200f07314a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 03:49:56 +00:00
Brandon Dayauon 76e123820a Merge "Correctly make to spec the color for "Turn on work apps" button and add stroke" into tm-qpr-dev am: d0838d3ac1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21470669

Change-Id: I2a0d9cccea4a9593af9d4079b0c58f16e27f5156
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 03:25:10 +00:00
TreeHugger Robot a69666477f Merge "Fix margins/padding in widget picker" into tm-qpr-dev am: 8fd957e323 am: a50856e4ba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21467066

Change-Id: I697ee21139daeb28cdbd2d3716d40ae05a22ea64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 03:19:24 +00:00
Brandon Dayauon d0838d3ac1 Merge "Correctly make to spec the color for "Turn on work apps" button and add stroke" into tm-qpr-dev 2023-03-07 02:55:01 +00:00
Brian Isganitis ef9514beab Merge "Implement light mode for persistent Taskbar." into tm-qpr-dev am: 2790c9dbbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21592661

Change-Id: Idbf2609daac8c6e35c9edae08e05b379eae80a0c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 23:48:02 +00:00
Brian Isganitis 2790c9dbbf Merge "Implement light mode for persistent Taskbar." into tm-qpr-dev 2023-03-06 23:07:41 +00:00
Charlie Anderson 52caf63404 Fixes several Visual issues with the app shortcut popup
- Fix system shortcut alignment and ordering.
- Replace horizontal split icon with correct size drawable.
- Remove popup shortcut reversing logic, and instead show same order of shortcuts regardless of orientation.

Test: tested manually on tablet and phone
Bug:269343928
Change-Id: I1700ad1ee04abf0820c87d89e1dc07d6880fd519
2023-03-06 16:40:51 -05:00
TreeHugger Robot a50856e4ba Merge "Fix margins/padding in widget picker" into tm-qpr-dev am: 8fd957e323
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21467066

Change-Id: Ie12cdf36f283af8b1cafd5f00a97a49ad458ad41
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:44:17 +00:00
TreeHugger Robot 8fd957e323 Merge "Fix margins/padding in widget picker" into tm-qpr-dev 2023-03-04 00:20:53 +00:00
Brandon Dayauon ffc7084b37 Correctly make to spec the color for "Turn on work apps" button and add stroke
- define color in base and quickstep

bug: 267975252
test: Manual - video: lightTheme: https://drive.google.com/file/d/1noY5Grq4jOxFIheL91KB_sOYRwp8XIyD/view?usp=sharing
test: darkTheme: https://drive.google.com/file/d/1o1uaTedAKbPy3BTG1GKJ0ldyHFs0-jGN/view?usp=sharing
Change-Id: I266b6624aa6f045c1f30c0db984fa9e1c5f6fe7e
2023-03-03 15:42:13 -08:00
Brian Isganitis a87fc8cd28 Merge "Implement light mode for persistent Taskbar." into udc-dev am: 977a62fa41
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21617425

Change-Id: I6c5c35637b9b96a15eb6a906469977218e198d38
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 01:32:02 +00:00
Brian Isganitis 473cfe0a1a Implement light mode for persistent Taskbar.
NavbarButtonsViewController has been massaged to make sure the buttons
contrast well with the color of the Taskbar background that they are on,
if applicable.

Test: Manual
Fix: 268052229
Change-Id: I917a1a1be013c304910b0f674ae8a13abb8e47a1
Merged-In: I917a1a1be013c304910b0f674ae8a13abb8e47a1
2023-03-03 00:35:20 +00:00
Brian Isganitis 977a62fa41 Merge "Implement light mode for persistent Taskbar." into udc-dev 2023-03-03 00:34:02 +00:00
Alex Chau bf03a207a1 Merge "Land ENABLE_TASKBAR_IN_OVERVIEW" into tm-qpr-dev am: 6a10a003d6 am: a1907c710e am: cbab01c721
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21538759

Change-Id: Ia6fdd2efb1d75e0286402e2ae03b80b745c7fb71
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 19:04:52 +00:00
Alex Chau cbab01c721 Merge "Land ENABLE_TASKBAR_IN_OVERVIEW" into tm-qpr-dev am: 6a10a003d6 am: a1907c710e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21538759

Change-Id: Ibf2a35e5d54d2938a00cb251ddb71656f6308207
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 18:19:32 +00:00
Bill Yi c1c141e358 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-03-01 18:12:37 +00:00
Alex Chau a1907c710e Merge "Land ENABLE_TASKBAR_IN_OVERVIEW" into tm-qpr-dev am: 6a10a003d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21538759

Change-Id: I47517820ce6448ac3b123ac1044ef07ccc60308b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 17:43:43 +00:00
Alex Chau 8aa3f00238 Land ENABLE_TASKBAR_IN_OVERVIEW
Fix: 270393449
Test: manual
Change-Id: I731bfa8ee86154fd034781e27272abc81a6fe6c6
2023-02-28 20:18:32 +00:00
Sunny Goyal e7fe6b57ff Merge "Moving flag creation to a separate file" into tm-qpr-dev am: 1297f400bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21586607

Change-Id: I0b50d9286e8abab8b3d5f54853f8bfc74141cbb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 19:48:41 +00:00
Sunny Goyal 2b4cd6d648 Merge "Moving flag creation to a separate file" into udc-dev am: 11c8b4f594
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21616343

Change-Id: I072cf00a902e00381f3156750687d27a8f2a4ce3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 19:28:23 +00:00
Sunny Goyal 1297f400bc Merge "Moving flag creation to a separate file" into tm-qpr-dev 2023-02-28 19:18:25 +00:00
Sunny Goyal 98204add71 Moving flag creation to a separate file
> This provides better control over proguarding descriptions
> Enforcing bug number in flag creation

Bug: 270386012
Test: Presubmit and verified on device
Change-Id: I31014e397690379024d2e42c0e913ce806b9569c
Merged-In: I31014e397690379024d2e42c0e913ce806b9569c
2023-02-28 18:05:42 +00:00
Brian Isganitis cae62a563a Implement light mode for persistent Taskbar.
NavbarButtonsViewController has been massaged to make sure the buttons
contrast well with the color of the Taskbar background that they are on,
if applicable.

Test: Manual
Fix: 268052229
Change-Id: I917a1a1be013c304910b0f674ae8a13abb8e47a1
2023-02-27 23:25:42 +00:00
Sunny Goyal 749983b192 Moving flag creation to a separate file
> This provides better control over proguarding descriptions
> Enforcing bug number in flag creation

Bug: 270386012
Test: Presubmit and verified on device
Change-Id: I31014e397690379024d2e42c0e913ce806b9569c
2023-02-27 23:19:39 +00:00
Bill Yi f0bc8c15b8 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia294676a97b2dfe2490b5bed2606101f9ac524d3
2023-02-27 06:58:51 -08:00
Jagrut Desai 923ec74d91 Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev am: 3addf0b66d am: 8a8bda5b3c am: 70db29a34d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21470199

Change-Id: I3ef1e214eeabec0998ea4ce7be11ab59c19e21d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-25 03:53:30 +00:00