Commit Graph

2060 Commits

Author SHA1 Message Date
Sunny Goyal 9cd3154952 Moving PluginManager to dagger
Multiple singletons depend on Plugin which can cause deadlock
if PluginManager is initialized on main thread

Test: presubmit
Bug: 361850561
Bug: 373557167
Flag: EXEMPT dagger
Change-Id: I79f17ac6b78a2ce60df2d27a6e794b9e4eba1b51
2024-10-17 11:48:38 -07:00
Liam, Lee Pong Lam d4488bfd72 Implement focus state on personal/work tab button
figma: https://www.figma.com/design/ccBEWEnusF6lE4edgCw7bG/Android-Interactions-Library?node-id=6315-109525&node-type=frame&t=SBKtwrMnJ0ppeUxa-0
result: https://photos.app.goo.gl/LEWF6tsKz3BXXWuv5
hsv: https://hsv.googleplex.com/4794951907934208

Bug: 327430110
Flag: EXEMPT bugfix
Test: Manual
Change-Id: Ia953c92f30cbd65a83f8e60e8bb2d4b17073b369
2024-09-25 20:34:49 +00:00
Saumya Prakash 4cf02b8538 Merge "Add "New Window" option to Taskbar menu." into main 2024-09-20 18:20:36 +00:00
Saumya Prakash 8e0ed4b01b Add "New Window" option to Taskbar menu.
This change adds a new menu option to Taskbar that is invoked when long
pressing an icon. It createds a new instance for an app if the app
supports multi instance in Desktop Mode.

Bug: 315344726
Test: Manual
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ibc42fbb1ad485496cd938af730b86e051cea559a
2024-09-19 21:30:43 +00:00
Sunny Goyal 2a359916ca Moving some utility class to IconCache to make it easier to use outside Launcher
Bug: 366237794
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I7583ae162b652e73a33f1aee76714e292b707e39
2024-09-18 10:05:05 -07:00
Marcelo Arteiro 13d9588f88 Merge "Updates many launcher color to new dynamic tokens" into main 2024-09-04 11:27:16 +00:00
Marcelo Arteiro c6fca0e16b Fixes wrong colors in SUW -> AllSet
Screenshot: https://screenshot.googleplex.com/6Yy9bQuQqox2rPB.png
Fixes: 355462084
Flag: EXEMPT bugfix
Test: Manual
Change-Id: I92b9839d345ab16f0229b546fb6c0e00ced02671
2024-08-30 12:41:34 +00:00
Charlie Anderson 0c54dbd4a5 Slightly lower icon shadow insets to avoid accidental shrinking or padding
Bug: 350758155
Test: locally
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: I5d0396c3e4710873ff797a35b97fad7e79a14495
2024-08-27 22:41:42 +00:00
Brandon Dayauon 412821fadf Merge "Create an alpha letter scroller" into main 2024-08-26 20:21:17 +00:00
Brandon Dayauon 1f8f88696b Create an alpha letter scroller
- The function used is a raised cosine function to determine the sections to animate.

Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary

bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
2024-08-26 11:21:26 -07:00
Uwais Ashraf 37752f5e19 Merge changes I31d9a51e,I1bc14be7 into main
* changes:
  Prevent requestLayout() when updating drawables that don't change size
  Fix splash icon size to 52dp
2024-08-22 09:13:41 +00:00
Uwais Ashraf f1c14902ca Fix splash icon size to 52dp
Fix: 360804090
Test: presubmits passing, manual
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I1bc14be7d2d25a985d26709eb59b8aa4887d4764
2024-08-21 15:44:03 +00:00
Shuming Hao f1d0df2867 Remove unused resources for split screen handle
Bug: 338079912
Test: Manually
Flag: EXEMPT cleanup
Change-Id: I09c02de82186f2080ce10ee75ecb75f9d7f8859a
2024-08-19 09:54:25 -07:00
Helen Cheuk 801f86ecac Merge "[Contextual Edu] Enable updating Edu data in Launcher" into main 2024-08-13 12:52:02 +00:00
Mady Mellor de28dc32eb Merge "Add a bubble option to launcher long press menus" into main 2024-08-09 17:25:02 +00:00
helencheuk 39a6093369 [Contextual Edu] Enable updating Edu data in Launcher
- Added ContextualEduStatsManager (in Launcher3) and SystemContextualEduStatsManager(in Quickstep) to enable classes in Launcher3 and quickstep to update contextual edu data
- Implemented new updateContextualEduData method in SystemUiProxy file, so the EduStatsManager could use it for update
- AbsSwipeUpHandler handles the logic to go home/overview when in app. Added code to update contextual edu data when these action is triggered.

Test: LauncherSwipeHandlerV2Test
Bug: 357542123
Flag: com.android.systemui.keyboard_touchpad_contextual_education
Change-Id: I6fc5a285ba1a1d770c54cc7af444ff8b3051bd00
2024-08-09 13:38:21 +01:00
Mady Mellor 1cc100844c Add a bubble option to launcher long press menus
- Add a launcher "system shortcut" to bubble deep shortcuts or apps
- For shortcuts, save the shortcut info to use to produce the bubble
- Add an interface so that the system shortcut can call through to
  sysui proxy

Flag: com.android.wm.shell.enable_bubble_anything
Test: manual - enable the flag and try to bubble a shortcut via the
               longpress menu on launcher
             - try bubbling an app on launcher
             - try bubbling an app from the taskbar
Bug: 342245211
Change-Id: I1ef49e1628ba0be9cea05073ecd9cd66bf67f88f
2024-08-08 21:23:13 +00:00
Charlie Anderson 99147f53e0 Use DoubleShadowIconDrawable to draw shadow behind archived cloud icon
- Refactor Launcher3 ShadowInfo out of DoubleShadowBubbleTextView

Bug: 350758155
Test: locally verified + screenshot test
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: I8e5e5936296fafbfbf3caf80a936ca1038c125e3
2024-08-07 11:56:33 -04:00
Brandon Dayauon 785f8c1f03 Merge "Fix app install icon colors by "reverting" small color change that applies to the private install icon." into main 2024-08-03 04:17:02 +00:00
Brandon Dayauon 766411813d Fix app install icon colors by "reverting" small color change that applies to the private install icon.
Original big color change for reference: ag/28129361

bug:355065774
Test manually:
after LT: https://drive.google.com/file/d/1Wi09fvakgGev_kbRso4LggXRb4GLYCsL/view?usp=sharing
after DT: https://drive.google.com/file/d/1g5NOeV50ekEJl0-7hiSWYLPKsCCGbndP/view?usp=sharing
Flag: NONE color fix

Change-Id: Ie078eefe2b4b2ecf6aa1a086242ba643f42c038b
2024-08-02 11:32:14 -07:00
Brandon Dayauon 085ee66233 Remove padding on background and icon.
This padding causes the x to look pointy.

bug:342246204
Test:
before padding:https://screenshot.googleplex.com/GU8ZKEcGPH7DaAD
after padding: https://screenshot.googleplex.com/aRGtiKMQ8jyMWsw
Flag: NONE Padding change

Change-Id: I910914b742bfbb5bf0122ebb1b950ce95c43e9ed
2024-07-22 11:26:11 -07:00
Marcelo Arteiro 0d6190eb52 Updates many launcher color to new dynamic tokens
Bug: 335442983
Test: Manual
Flag: EXEMPT bugfix
Change-Id: Ic453ae6a717bb274682242f7af5b0551313672a4
2024-07-19 21:31:31 +00:00
Marcelo Arteiro f38d98d1a6 Align color resources in launcher projects.
This is an effort to align/unify color usage across all launcher projects and the system itself.
This fix recreates all dynamic color attributes present in the OS since many launcher areas cannot access private attributes.
It is recomemnded to use these new local attributes in all launcher areas and avoid creating new color resources when these can be used directly.

Bug: 352690172
Test: Presubmits
Flag: EXEMPT bugfix
Change-Id: Ic36b8bf70ee37f2fdd32e459e66f0e2d001d6ba2
2024-07-19 14:22:21 +00:00
Shamali P 9aabb9a9cb Show only filtered / default widgets in standalone activity by default
Bug: 347288851
Flag: EXEMPT flag in sysui
Test: b/339716822 to set it up
Change-Id: I71baac8897ce600f3c588eb3d48b9677e507145b
2024-07-17 22:56:49 +00:00
Shamali P 2e2d4ff603 Add a 3 dot vertical menu and styles (child cl makes it functional)
Bug: 347288851
Flag: EXEMPT standalone picker
Test: Manual
Change-Id: I99985098034f6336f683b1ff3a47dce2aa8e596a
2024-07-17 22:56:41 +00:00
Shamali P 96ebf67b9f Update the title and description provided by intent params.
Bug: 347288851
Flag: EXEMPT flagged in sys ui
Test: Manual (automated covered in b/339716822)
Change-Id: I71f21bc48fd03dbbe2b3804b7fcade5940606917
2024-07-03 15:49:32 +00:00
Saumya Prakash f3e12f2b31 Merge "Change Pinned taskbar corners to be fixed." into main 2024-06-13 20:17:37 +00:00
Saumya Prakash f9c602d1d9 Change Pinned taskbar corners to be fixed.
Based on new UX guidelines, the corners for the pinned taskbar should be 16 dp.

Fix: 337872323
Test: Put device in 3 button mode and pinned taskbar and observe
sharper, fixed corners. Transient taskbar remains unchanged.
Flag: EXEMPT bugfix

Change-Id: I2130e91dcdc0afb007fde93438f3fa603bc15af8
2024-06-11 22:18:09 +00:00
Himanshu Gupta 261a62219b Prompting the user to set Pixel/Quickstep as default Home app.
requestQuietMode API throws SecurityException in case its called
from a non-default Launcher app.
To mitigate this, we catch the exception and prompt the user
to set their default launcher to the current app.

Video(Pixel): https://photos.app.goo.gl/ni5X1c6vBbYW2JMJ9
Video(Pixel-aosp): https://photos.app.goo.gl/cYLJpTYW76Jnbonc9

Bug: 320446272
Test: Manual
Flag: NONE Bug fix tweak.
Change-Id: I6afb2ae85cabc038e1503e9c34eebd974c4f7a50
2024-06-11 19:11:21 +01:00
Ats Jenk 96396eea95 Move bubble bar strings
Move strings to quickstep as bubble bar is in that folder.

Bug: 344670947
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, check talkback on bubble bar and bubbles
Change-Id: I2da1f0c8fc6ec13f04b2c75c9eb1a27ec598d564
2024-06-05 10:13:27 -07:00
Ats Jenk cd4c9d153d Add content description to bubble bar and bubbles
Set content description on the bubble bar when it is collapsed. Only
allow focus on the bar itself. In collapsed mode, bubbles in the bar
can't be focused.
Content description for the bar matches what we have in floating mode.
We include the text for the first bubble and then how many bubbles are
there more.

Set content description on bubbles in bubble bar. When bubble bar is
expanded, only the bubbles are focusable.
Bubble content description matches the floating bubbles content
description. Includes the notification title and app name.

Bug: 344670947
Flag: com.android.wm.shell.enable_bubble_bar
Test: enable talkback, focus on bubble bar when it is collapsed, check
  that only bubble bar receives focus
Test: enable talkback and expand bubble bar, check that only the bubbles
  receive focus
Change-Id: Id931f0360b9ebadd01dd16b05b75546fcc4df803
2024-06-05 10:13:22 -07:00
Jordan Silva a74d1e419b Merge "Add Accessibility Menu support for multiple DWB banners" into main 2024-05-31 11:15:00 +00:00
Jordan Silva 1b487619a0 Add Accessibility Menu support for multiple DWB banners
Fix: 341672022
Flag: EXEMPT Bug fix
Test: Manual. With Talkback on, open two apps in split screen and both with DWB enabled, go to Overview, access the Accessibility Menu > Actions.
Change-Id: Iff6adf8d549aa00ea42598cbfbdaf8c7a4164b29
2024-05-30 18:22:38 +01:00
Shamali P 3dabf391f2 Scale down the widget previews on similar scale as the spring load scale
Currently entire workspace scales down, but the original view sticks
to user's finger at same size as before. This makes the view look larger
obstructing the view of workspace behind it - specifically, when the
widgets are of larger size.

Additionally, with this scaling change, the preview images that aren't
of same aspect ratio don't break the transition to final widget as
before.

Bug: 338290585
Test: Unit test
Flag: None bugfix
Change-Id: I1d1818e60506898c7b28074f01cee91282032a94
2024-05-29 22:38:22 +00:00
Pierre Barbier de Reuille 2de842b558 Merge "Update desktop mode to identify minimized tasks" into main 2024-05-24 08:26:48 +00:00
Pierre Barbier de Reuille f60dd5471c Update desktop mode to identify minimized tasks
When a task is minimised, it becomes invisible but is still running.
WMShell now signals to the launcher when a task's visibility changes.
The task bar takes the visibility into account to know if a running task
is, in fact, minimised.

Test: atest NexusLauncherTests:DesktopTaskbarRunningAppsControllerTest
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 333872717
Change-Id: Iaff6b1240d354bb3c4de8e4884948acf9bf40112
2024-05-23 20:59:16 +01:00
Brandon Dayauon bd3eaa898e Merge changes I64e9a228,I300e8513 into main
* changes:
  Update private space divider thickness and padding per spec.
  Update install app icon colors to spec:
2024-05-22 21:22:00 +00:00
Zak Cohen 73fe0b439e Merge "WidgetPicker - Fix sliding scrim on add widget dialog." into main 2024-05-22 21:03:46 +00:00
Zak Cohen 10cf086910 WidgetPicker - Fix sliding scrim on add widget dialog.
Use the system dimming for standalone widget picker activity, as the system
is applying a default transition.


Bug: 342230362
Flag: NONE animation tweak
Test: visual

Change-Id: I278f8bf97acbfbfca652e1e6b616e2d2885ca92a
2024-05-22 13:32:59 -07:00
Anushree Ganjam ef9427c709 Merge "Add "Uninstall app" string for private space shortcut." into main 2024-05-22 16:08:31 +00:00
Anushree Ganjam 87e875e702 Add "Uninstall app" string for private space shortcut.
Before: https://screenshot.googleplex.com/8RvbiWnJmgAvSYf.png
After: https://screenshot.googleplex.com/4e7N3rr8EAH7k6B.png

Bug: 335451332
Flag: com.android.launcher3.enable_private_space
Flag: EXEMPT resource only update
Test: Manual
Change-Id: I759005f51562683cb6c095abcca27d448acd10f8
2024-05-21 16:36:02 -07:00
Brandon Dayauon ae0e957eea Update private space divider thickness and padding per spec.
Thickness (height) is 2dp.
Padding above and below the divider is 32dp.

bug: 340307977
test manually:
before: https://drive.google.com/file/d/1H364XUILz3gTLOENQL5zQBOELcza7YBk/view?usp=sharing
after: https://drive.google.com/file/d/1HCsnj2s9TwlzIjKL1aHbBqO15nkPoOLj/view?usp=sharing
after vertical padding: https://drive.google.com/file/d/1HS1SFVj9RfvuxHPGyk0PH5dGQum3spqe/view?usp=sharing
Flag: None

Change-Id: I64e9a228e9095449c4ef5f7680d92d234ab96f9f
2024-05-20 16:24:14 -07:00
Oli Thompson 9305badf5a Merge "Show edu card when managed profile removed" into main 2024-05-20 10:38:19 +00:00
Song Chun Fan 59fa915e9e Merge "[Archive] Update the content description for the archived app" into main 2024-05-15 16:18:18 +00:00
Oli Thompson 3ea1acb8ca Show edu card when managed profile removed
Reset the work edu card bit so the edu card shows if the managed profile is removed

Also remove padding from the close button so it doesn't clip. screenshot https://screenshot.googleplex.com/96Yc6yExZ57btxG

Bug: 315449027
Bug: 293642345
Test: manual
Flag: NONE
Change-Id: I60cfc0c258d28a6674aec41862c1770550a14955
2024-05-15 14:19:03 +00:00
Brandon Dayauon e369bd6502 Merge changes I7c303e66,Idc03b9d3 into main
* changes:
  Add floatingMaskView when animating to mimic bottom container.
  Add private_space_floating_mask_view flag.
2024-05-14 23:15:40 +00:00
Shamali Patwa 8a5eddb923 Merge changes from topic "update-strings" into main
* changes:
  Add comments on suggestion category related strings
  Clean-up unused categories (follow up cleans up strings)
2024-05-14 18:38:54 +00:00
Luca Zuccarini de2e793f53 Merge "Tune the window to icon and home scaling animation." into main 2024-05-14 09:12:24 +00:00
Shamali P d07ed6b49b Add comments on suggestion category related strings
Also, deletes unused strings.

Bug: 339570620
Test: N/A
Flag: N/A
Change-Id: I3c53f9788c9734b6962b61d2a13b4445b91892ca
2024-05-13 23:23:34 +00:00
Shamali P 4f492626bd Clean-up unused categories (follow up cleans up strings)
Bug: N/A
Test: Unit tests
Flag: N/A
Change-Id: Id3bd76858d731b9e0eb977c094ebd3b19e1338ce
2024-05-13 23:13:56 +00:00