Commit Graph

1133 Commits

Author SHA1 Message Date
Treehugger Robot 1160d080f4 Merge "Fix cropped folder name text in arabic" into main 2024-10-09 19:35:13 +00:00
Liam Lee Pong Lam 644aad280b Merge "Implement focus state on personal/work tab button" into main 2024-10-04 20:33:00 +00:00
Shamali P adc171b313 Move padding from parent to WidgetPagedView and siblings in 2-pane pkr
WidgetPagedView seems to rely on padding to position it such that
 talkback doesn't focus on it before sticky header.

Bug: 348107507
Test: With talkback
Flag: EXEMPT bugfix

Change-Id: I2fcdc0cbf027a7a8c1bee104f85a61f700faf776
2024-10-02 16:55:59 +00:00
Toni Barzic 2c72b9bd1a Fix cropped folder name text in arabic
Centralize the folder name within folder footer using gravity property
instead of adding padding to the folder name view. Padding as calculated
was cropping the folder name to the text line height, which was
insuficient in some cases, as eveidenced by the linked bug.

Bug: b/358006967
Test: Open a folder on home screen with arabic system language.
      Verify that the folder name displays correctly.
Flag: EXEMPT bugfix

Change-Id: I4436c224f7f6541f447e3a5354ff870cf4d50698
2024-09-26 04:57:45 +00:00
Liam, Lee Pong Lam d4488bfd72 Implement focus state on personal/work tab button
figma: https://www.figma.com/design/ccBEWEnusF6lE4edgCw7bG/Android-Interactions-Library?node-id=6315-109525&node-type=frame&t=SBKtwrMnJ0ppeUxa-0
result: https://photos.app.goo.gl/LEWF6tsKz3BXXWuv5
hsv: https://hsv.googleplex.com/4794951907934208

Bug: 327430110
Flag: EXEMPT bugfix
Test: Manual
Change-Id: Ia953c92f30cbd65a83f8e60e8bb2d4b17073b369
2024-09-25 20:34:49 +00:00
Toni Barzic 667fe050ff Make widget sheet layout container not focusable
SpringRelativeLayout views in widgets sheets UI are non-actionable
containers, and as such they would ideally not receive focus. They were
made focusable as a workaround for an issue where back action was no-op
when widget search text box was focused, and there were no other
focusable elements in the UI b/197129170.
WidgetSearchBarController handles back action by clearing
focus, which ends up refocusing the search text box. This CL, removes
this back action override, and let's back action through - it will end
up being handled by `WidgetsFullSheet.onBackInvoked` which resets the
search.

Bug: 365120544
Test: Manual - verified back action with widget search active (and in
      case with no results) in emulator
Flag: EXEMPT bugfix

Change-Id: I1fed37372521947b7d4644047807dc451b0119a4
2024-09-11 18:50:56 +00:00
Sunny Goyal 42becd041b Cleanup unused workspacePageIndicator
Fix: 270395278
Flag: NONE removing dead code
Test: verify everything still works the same
Change-Id: Id0eda5c5994c3323a8d16900678fbd7b39911b62
2024-08-27 12:23:21 -07:00
Brandon Dayauon 412821fadf Merge "Create an alpha letter scroller" into main 2024-08-26 20:21:17 +00:00
Brandon Dayauon 1f8f88696b Create an alpha letter scroller
- The function used is a raised cosine function to determine the sections to animate.

Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary

bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
2024-08-26 11:21:26 -07:00
Shamali P 8c965c67dc Adjust tap target of the profile tabs in picker
Uses insets on background drawable to maintain visual size.

Bug: 360245807
Test: Accessibility scanner
Flag: EXEMPT bugfix
Change-Id: I1fbc7c2c782a1e331dd1ba77b0a3bf8aad277792
2024-08-20 00:42:32 +00:00
Brandon Dayauon 4f7d4c2975 Set maxLines for private space header to 1.
This is an issue for large font/display that in the arabic language will clip the Private text.

bug: 357942579
Test manually: https://drive.google.com/file/d/1FFZpXmfwKlRG7mvmSCtc1dtjwUjuXjfW/view?usp=sharing
Flag: NONE bugix

Change-Id: I22943237e10b502edb6aae6845fbe6027fda1323
2024-08-14 13:47:37 -07:00
Brandon Dayauon 085ee66233 Remove padding on background and icon.
This padding causes the x to look pointy.

bug:342246204
Test:
before padding:https://screenshot.googleplex.com/GU8ZKEcGPH7DaAD
after padding: https://screenshot.googleplex.com/aRGtiKMQ8jyMWsw
Flag: NONE Padding change

Change-Id: I910914b742bfbb5bf0122ebb1b950ce95c43e9ed
2024-07-22 11:26:11 -07:00
Marcelo Arteiro f38d98d1a6 Align color resources in launcher projects.
This is an effort to align/unify color usage across all launcher projects and the system itself.
This fix recreates all dynamic color attributes present in the OS since many launcher areas cannot access private attributes.
It is recomemnded to use these new local attributes in all launcher areas and avoid creating new color resources when these can be used directly.

Bug: 352690172
Test: Presubmits
Flag: EXEMPT bugfix
Change-Id: Ic36b8bf70ee37f2fdd32e459e66f0e2d001d6ba2
2024-07-19 14:22:21 +00:00
Shamali Patwa 1407aeca8d Merge changes from topic "ls-picker-filter" into main
* changes:
  Consider the widget option menu choice in search results
  Show only filtered / default widgets in standalone activity by default
  Add a 3 dot vertical menu and styles (child cl makes it functional)
  Set default widgets and all widgets separately from standalone activity
  Update the widget picker activity theme for popup menus styling
2024-07-18 14:14:42 +00:00
Shamali P 2e2d4ff603 Add a 3 dot vertical menu and styles (child cl makes it functional)
Bug: 347288851
Flag: EXEMPT standalone picker
Test: Manual
Change-Id: I99985098034f6336f683b1ff3a47dce2aa8e596a
2024-07-17 22:56:41 +00:00
Brandon Dayauon 0e5640376e Remove enableLayoutTransitions for private space.
Get rid of layoutTransitions as they are not reliable, see here: https://docs.google.com/document/d/1ExSemBvzzVv-I9tUCVzdLeN-lDb2hTSOM886UYSH-Qk/edit?usp=sharing&resourcekey=0-aBCCLnrB7KtkhIeyUOkKyw
Instead use actual animatorSet to do the animating.
- This also fixes the timings so that the pill transition happens at the same time of the icon alpha animation.
Made member variable for lockText and settingButton.

bug:346298256
Test:
before: See bug
after manually- video: https://drive.google.com/file/d/1B7PIgrGWMJTphc1b5CvCkyg-QYx3TTN3/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I049b84dbe1279a0becb090db8660975dc5c5961e
2024-07-17 10:35:53 -07:00
Brandon Dayauon 197fbabf2c Merge "Make close button to use google symbol library icon and update close color button" into main 2024-07-09 21:53:49 +00:00
Brandon Dayauon 6073fa296c Make close button to use google symbol library icon and update close color button
spec: https://docs.google.com/presentation/d/1tTODboxGqJ3ypEyYnr0-bUpSXcvX1cl6Sj8y0Nut5hU/edit?resourcekey=0-9GT8EJG43kTT4aKPWVWRig#slide=id.g2df5f2c9773_4_0
CloseButtonColor to be scLOW
CloseIconColor to be onSurface

bug: 342246204
Test: manually photos:
beforeLT: https://drive.google.com/file/d/14O61WzHmeAhOdGirUci2u9vot3FWcSKo/view?usp=sharing
beforeDT: https://drive.google.com/file/d/1Dt75_sRIWNHMuwqnYzE1WvjRTZFHWJ8-/view?usp=sharing
afterLT: https://drive.google.com/file/d/1npg-icWcsEN5OCgMtP1oU7mB-gGuT6_n/view?usp=sharing
afterDT: https://drive.google.com/file/d/11LTC_61QTg4tX0SUO23cAbLaP7aoSnh-/view?usp=sharing
Flag: NONE Color change
Change-Id: I0c47c927c5c8094a018e6f18061e99fc4bd901de
2024-07-09 09:39:03 -07:00
Shamali P 96ebf67b9f Update the title and description provided by intent params.
Bug: 347288851
Flag: EXEMPT flagged in sys ui
Test: Manual (automated covered in b/339716822)
Change-Id: I71f21bc48fd03dbbe2b3804b7fcade5940606917
2024-07-03 15:49:32 +00:00
Mady Mellor 58a6bbac4a Update bubble bar overflow to have a unique resId
This allows the overflow to be tested properly in end-to-end tests.

Flag: com.android.wm.shell.enable_bubble_bar
Test: atest OverflowBubbleTest (with other CL)
Bug: 347312208
Change-Id: Ice969434f9c40602c4b2d1a5baf6ba0509534a56
2024-06-18 16:43:32 -07:00
Brandon Dayauon 736527a127 Make PrivateSpaceSettingsButton instead of having just the imageView.
This way we can keep the click listener in this PrivateSpaceSettingsButton.java class.
- Moved itemInfo creation to PrivateSpaceSettingsButton and created a test class

bug: 341053089
Test: manually - presubmit video: https://drive.google.com/file/d/1_TCGrILvwmMpxbgIcbOcpB2AxeBJbyNf/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I79cd319274f4445dd00bc257be81728360d09684
2024-05-31 17:05:13 -07:00
Brandon Dayauon ae0e957eea Update private space divider thickness and padding per spec.
Thickness (height) is 2dp.
Padding above and below the divider is 32dp.

bug: 340307977
test manually:
before: https://drive.google.com/file/d/1H364XUILz3gTLOENQL5zQBOELcza7YBk/view?usp=sharing
after: https://drive.google.com/file/d/1HCsnj2s9TwlzIjKL1aHbBqO15nkPoOLj/view?usp=sharing
after vertical padding: https://drive.google.com/file/d/1HS1SFVj9RfvuxHPGyk0PH5dGQum3spqe/view?usp=sharing
Flag: None

Change-Id: I64e9a228e9095449c4ef5f7680d92d234ab96f9f
2024-05-20 16:24:14 -07:00
Oli Thompson 9305badf5a Merge "Show edu card when managed profile removed" into main 2024-05-20 10:38:19 +00:00
Oli Thompson 3ea1acb8ca Show edu card when managed profile removed
Reset the work edu card bit so the edu card shows if the managed profile is removed

Also remove padding from the close button so it doesn't clip. screenshot https://screenshot.googleplex.com/96Yc6yExZ57btxG

Bug: 315449027
Bug: 293642345
Test: manual
Flag: NONE
Change-Id: I60cfc0c258d28a6674aec41862c1770550a14955
2024-05-15 14:19:03 +00:00
Brandon Dayauon 1d3ddb877d Add floatingMaskView when animating to mimic bottom container.
- On expand, we add the floating mask view and translate it out at the end.
- On collapse, we translate off the mask view in the beginning once the floating mask view is added
so that we can translate it in before the actual collapsing part of the animation

bug:339850589
Test manually:
https://drive.google.com/file/d/1YNc3vq9Cb5BcbcPOHp8H3lhe6KmYBdLI/view?usp=sharing
Flag:ACONFIG com.android.launcher3.private_space_floating_mask_view STAGING

Change-Id: I7c303e6629d83408bd314886fe10113246e44dcb
2024-05-13 11:08:05 -07:00
Willie Koomson 49e364cd0b Remove shadow on Add button
Set android:stateListAnimator to @null to remove default shadow on Add
button.

Bug: 333736273
Test: manual, check shadow on device
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ifa66801963e69582935806eb8a39dcfe624ffdc7
2024-05-06 22:26:24 +00:00
Willie Koomson 1156e8419a Hide add button text if cell is too narrow
If the WidgetCell is not wide enough, hide the add button text and show
an icon-only plus button.

Bug: 333735974
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ieb0b2e679bd4a5785a0f7f01e177ad412a355ce7
2024-05-02 19:55:41 +00:00
Willie Koomson 61dc97ecb2 Update font settings to match POR
Updates font color, size, weight, and line height for text in the widget
picker to match POR and pass a11y test.

Bug: 317948371
Flag: NONE
Test: Accessibility Scanner contrast test
Change-Id: I3c7676c507b81a616876206681972ebb9fefd0c3
2024-05-02 19:55:33 +00:00
Willie Koomson 21379bfbbc Merge "Remove widget education tip dialog" into main 2024-04-26 20:23:21 +00:00
Willie Koomson d731ba2ff1 Remove widget education tip dialog
This change removes the widget education tip dialog, and the arrow
tip view. These are no longer needed now that taps are handled by
showing an add button.

Bug: 335318980
Test: `pm clear com.google.android.apps.nexuslauncher` and open widget
 picker
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: I9b24a41604880f5f94939c02b94f1a9f6a6c83d5
2024-04-25 22:56:36 +00:00
Himanshu Gupta 578f1a474e Merge "Fix Accessbility bugs for PS." into main 2024-04-25 17:03:54 +00:00
Himanshu Gupta 42e3196011 Fix Accessbility bugs for PS.
This Cl contains:
1. Alt text for Lock/Unlock button as per state.
2. Alt text for Header when Locked.
3. Removing Header from accessibility target when unlocked.

Bug: 328024119
Test: Manual
Flag: NA
Change-Id: I791176afdae4fc6eb9387080aa036c1aed2a03a9
2024-04-25 11:57:53 +01:00
Shamali Patwa 587c3ce049 Merge changes from topic "bottomsheet-with-insets" into main
* changes:
  Align the margins between handle, text, and container with main picker.
  Update the app-specific picker to have a container like the main picker
2024-04-24 21:16:28 +00:00
Shamali P d4997cf063 Align the margins between handle, text, and container with main picker.
Also aligns style to match main picker which doesn't set header style.

Requested by Jane / UX.

Bug: 328812171
Flag: N/A
Test: Manual - need to build a SS test for this opened - 336284716
Change-Id: I15fb82e807fdaa55bbfaaf73872273d1d6e84f97
2024-04-24 19:15:11 +00:00
Shamali P 9478a40898 Update the app-specific picker to have a container like the main picker
This is to ensure widgets are displayed with same container across the
two pickers.

* http://screencast/cast/NDYxNjMzNDExNjY1MTAwOHwwMTBlYzkwZC0wNg
* http://screencast/cast/NjY1NzAyNzY5NzgwMzI2NHwyYTg3ZWIzNS0wNw
* http://screencast/cast/NTYyMzcwMTc4NDQ5NDA4MHw3Y2JlZDEwZS04Mw

Bug: 328812171
Flag: N/A
Test: Manual - need to build a SS test for this opened - 336284716
Change-Id: I42b743b99cf6f47b7bade57de01b130df78ac1e9
2024-04-24 19:14:50 +00:00
Shamali P 3132947812 Limit number of items grouped on a row to 3.
With shortcuts this allows for more space to display two word title
below without ellipsizing it. (screen/4pJvcFFKJhooqZU)

Also let widget description show upto 3 lines to more of it to show
when stacked (screen/7xv8ng4H7iRLU79)

Bug: N/A
Flag: N/A
Test: Screenshot
Change-Id: Ia4e30f943f602b811e607d9cb52152f78cdc20e5
2024-04-24 19:14:23 +00:00
Himanshu Gupta faafb3a19a Fix horizontal spacing in PS Header
1. Removes padding between settings cog and lock button,
as the insets already provide the required padding.
2. Reduces the lock button margin from left to accomodate
the inbuilt inset in the button.

Fix: 336510036
Test: Verified on device.
Flag: NA
Change-Id: I077097c7beb2cc8fe14f4367c66ca4e1ad4270d0
2024-04-23 15:28:01 +01:00
Shamali Patwa a80e199798 Merge "Keep rounded corners while scrolling in right pane & fix scrollbar size." into main 2024-04-19 22:43:39 +00:00
Brandon Dayauon 24db282ed4 Merge changes Ied2efcf6,I07579635 into main
* changes:
  Polish workFAB with updated spec.
  Fix workFAB alignment.
2024-04-19 00:59:19 +00:00
Shamali P 5f7eb1f2ee Keep rounded corners while scrolling in right pane & fix scrollbar size.
[demo](http://screencast/api/gif/NDU4MTQ5ODE3Mzc4NDA2NHxhYmUzMDcxNy04MA/image)

Bug: 333734241
Test: screencast
Flag: N/A
Change-Id: Ifb522ca2c0a1092bf41c630e336b19c81d504c26
2024-04-18 22:32:30 +00:00
Brandon Dayauon baf5f6ec3d Polish workFAB with updated spec.
Updating the workFAB to the new spec: https://docs.google.com/presentation/d/1tTODboxGqJ3ypEyYnr0-bUpSXcvX1cl6Sj8y0Nut5hU/edit?resourcekey=0-9GT8EJG43kTT4aKPWVWRig#slide=id.g2c8f3ae8e02_0_0
Have the background endPadding to be 4 and icon have an endMargin of 12 and the text endMargin of 16.
So that when the text is disappeared, the space between the icon and the right bound is 16dp to spec.

bug:332761814
Test manually:
after LTR expanded:https://drive.google.com/file/d/1NZQW0CF9VFZBoM3673LFiUknqW2nf4r8/view?usp=sharing
after LTR collapsed: https://drive.google.com/file/d/1NRpdTuYQntSs5-yeRL1fJIJy2ETDOYLM/view?usp=sharing
after RTL collapsed: https://drive.google.com/file/d/1NE51MIsS5Fk0DwAuzCehEQzTa42OGj_o/view?usp=sharing
after RTL expanded: https://drive.google.com/file/d/1NPgiPfzw3DOa_xbB_TtlwK-G1Y5WCi53/view?usp=sharing
Flag:None

Change-Id: Ied2efcf6b1bd19c191d80e47bae4f8f6e3794803
2024-04-18 14:40:42 -07:00
Brandon Dayauon cf0ae01a51 Private space header to support RTL
bug:335658774
Test manually:
before: https://drive.google.com/file/d/1N8kFl28OhCJ7kTTo8VK74x-Mvaqi8GJ4/view?usp=sharing
after:https://drive.google.com/file/d/1N6AyVXcOSA48NveklIeqypueu7WLfP0V/view?usp=sharing
Flag: ACONFIG com.android.launcher3.enable_private_space TRUNKFOOD

Change-Id: I1c80e33f84251d42cd5821735457548de41db40d
2024-04-18 09:50:39 -07:00
Sunny Goyal 4a22ed81ea Using resource overrides for PluginManager instead of code-swap
Bug: 330920490
Test: Presubmit
Flag: None
Change-Id: Ib1cd50f95873928b9ce104e8e95d21f1dca9c6e3
2024-04-12 11:38:32 -07:00
Sunny Goyal 8049369af8 Freezing legacy feature flags
Legacy feature flags will be locked to their current values in code.
All new feature development should use aconfig flags

Bug: 332588958
Flag: None
Test: Presubmit
Change-Id: Ie72dd8276b7135620de279835d6721a34f82ede4
2024-04-09 15:26:07 -07:00
Sunny Goyal 8ecbaa422f Merge "Moving various nav-bar configs out of feature flags" into main 2024-04-09 05:45:21 +00:00
Sunny Goyal 89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00
Shamali P 11aa56e48f Add maxlines bounds to the category title.
- So far, none of the translations exceeded 1-line, but setting maxlines
to avoid it to happen in future.

* http://screen/35PYFHV5SCeBhqC (at max font size)

Bug: N/A
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_suggestions TEAMFOOD
Test: Manual - see videos.
Change-Id: I263706a5d85dd4a37a4150abd58222283d5e039a
2024-04-08 18:23:25 +00:00
Zak Cohen 02f0c92ea8 Merge "Widget Picker - center text description vertically to align with add button" into main 2024-04-05 16:46:44 +00:00
Zak Cohen 106cd240de Widget Picker - center text description vertically to align with add button
Bug: 332287648
Test: Widget picker tests
Flag: NA bug fix
Change-Id: I4d600633c3cfdc40973134903f4ba7a04090ccfe
2024-04-04 15:59:00 -07:00
Zak Cohen ea3fe15fa8 Merge "Widget Picker - Always center add widget button text vertically" into main 2024-04-04 22:19:21 +00:00