Commit Graph

20478 Commits

Author SHA1 Message Date
Schneider Victor-tulias 871d7fc351 Moved TISBinder lifecycle handling to TISBinderHelper
- All instances where we used TISBinder will now use TISBinderHelper#getBinder. This will allow TISBinderHelper to handle its lifecycle
- Moved all instance of TaskbarManager and OverviewCommandHelper as well since TIS and TISBinder handle their lifecycles
- Cleaning up launcher instance from TaskbarManager when TISBinder is being destroyed

Flag: not needed
Bug: 283490010
Test: ran launcher and performed gestures
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:248794e698417b1156bf911adb31682186fe2e34)
Change-Id: I8415a6b2c1dba0776e7c0e1ee32ad3c683100bde
2023-06-07 17:15:18 +00:00
Schneider Victor-tulias bfa0fae851 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev 2023-06-07 16:49:20 +00:00
Liran Binyamin 2f1b547a4b Crash fix in BubbleStachedHandleViewController.
Switching between gesture nav and 3 button nav may lead to a state where
the RegionSamplingHelper is unexpectedly null.

Bug: 269670598
Test: In Settings switch navigation modes until launcher crashes.
Change-Id: I56d6eea81070f367db292c1ded9866452f6e2650
2023-06-07 11:55:02 -04:00
Andy Wickham adce95394e Enable returning to the previous app after Overview -> All Apps.
Back gesture from All Apps (history for state):
If previous state was background, use quick switch state to return
to the previous app.

Swipe down from All Apps:
Return to previous state (which will be Normal or Quick Switch).

This animates from All Apps overview scale/translation to full
screen of the previous task. In this case we are animating from
0.5x Overview scale and 0 translation (centered).

Video: https://drive.google.com/file/d/1cpQjtFemtJ4zu9aWu7IiUftWWVGFrbtM/view?usp=drive_link&resourcekey=0-1zuMEvYNsk81YBxv8o10hA

Note: This is mostly for the gesture/state handling but it would
be nice to polish this transition in the future.

Bug: 283336332
Test: Manual
Flag: ENABLE_ALL_APPS_FROM_OVERVIEW
Change-Id: Iec92df933ce6522f181d3d5ca889b6a6469f4cc6
2023-06-06 17:13:59 -07:00
Treehugger Robot 46b958eb35 Merge "Re-enabling a couple of tests" into udc-qpr-dev am: fb261c428b am: ee34e8ca3b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23567994

Change-Id: I84e7ec73b2f4bb1985610ce9e233979c95a55497
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 23:37:19 +00:00
Treehugger Robot ee34e8ca3b Merge "Re-enabling a couple of tests" into udc-qpr-dev am: fb261c428b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23567994

Change-Id: Ib74170ca9d8b69846cfb4aa16f3ef23e26052e66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 22:58:39 +00:00
Ats Jenk 7a48f57043 Dismiss all task ids from TaskView
In recents we were hardcoding that only two task ids can be dismissed
when dismissing a TaskView. Update the logic to dismiss arbitrary
number of task ids that are returned from TaskView.

Fixes task dismissal logic for desktop where there can be more than 2
tasks represented by one taskview.

Flag: not needed, trivial change
Bug: 280830106
Test: Add chrome, files and calculator to desktop. Dismiss the desktop
  tile with 3 apps from overview. Open youtube and move it to desktop.
  Observe that desktop only contains youtube. None of the 3 previous
  apps are added back.
Test: Move 2 apps to split screen, dismiss the split tile from overview.
  Observe both apps are dismissed.
Test: Dismiss a single app from overview.
Change-Id: I139943f5d678d63f449116de26debae9be122b21
2023-06-06 22:38:39 +00:00
Treehugger Robot fb261c428b Merge "Re-enabling a couple of tests" into udc-qpr-dev 2023-06-06 22:03:26 +00:00
Fengjiang Li 2940fd75cc Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a am: 69a9a4cd52 am: 01f105cf7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: Ia3f0405d4ef2e86b0596149ee711a4a89fb0bc59
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 20:24:14 +00:00
Fengjiang Li 7d6a8b1c3a Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a am: 69a9a4cd52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: If1ffa619e26ab7b76d6e0b946bcd29d121cd7219
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 19:43:54 +00:00
Fengjiang Li 01f105cf7a Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a am: 69a9a4cd52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: I969f49632b0c1dfafcb3508043a52f6af10c0f56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 19:40:24 +00:00
Fengjiang Li 4665fac53d Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a am: 65fb6a1968
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: Ifeafec62aff2140b7e5cfd7b1cc2d27c5081e8ab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 19:40:18 +00:00
Fengjiang Li 65fb6a1968 Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: I7860cadd48d33bee50db3b5d9c22d597ef3a167e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 19:07:56 +00:00
Fengjiang Li cdfe299459 Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: Ic563b3f997f85fc8a4736be07ed1eacf73e132e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 19:07:48 +00:00
Fengjiang Li 829a3c5a0d Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: I7f82f49604b102aab5a943d01cf04d4ce8061f36
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 19:03:37 +00:00
Ats Jenk c2024da0c7 Merge "Animate in desktop app select toast" into udc-qpr-dev am: 826b28d703 am: 536f28d3f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23574221

Change-Id: I1e0316fc359844caf4c0820e42847ad8df269792
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 18:30:45 +00:00
Saumya Prakash 056dac0b34 Merge "Update Lottie animations in Back gesture tutorial" into udc-dev am: b95182353d am: 1ba1b49db7 am: 7dbc2036b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23537267

Change-Id: I1b23d9780c102e8bc3a31e3755b792cd098bac1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 18:19:42 +00:00
Fengjiang Li 3dca7b3c6a Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev 2023-06-06 18:19:38 +00:00
Saumya Prakash 039a34cce6 Merge "Update Lottie animations in Back gesture tutorial" into udc-dev am: b95182353d am: 04e4ba0fd6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23537267

Change-Id: I69798d2654895b48c01bf5491b7b0ea7b867d492
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 18:02:37 +00:00
Schneider Victor-tulias ab51f2110a Add null-check to findLastActiveTaskAndRunCallback
ItemInfo.getTargetComponent is nullable, so we can't always create a ComponentKey. Added a null-check and proper creation of ComponentKeys

Flag: not needed
Fixes: 286053950
Test: started and completed splitscreen selection from home, taskbar and overview
Change-Id: Ifa30f194ae064fab8aad79c5116f8c859dfd8cf1
2023-06-06 11:02:09 -07:00
Saumya Prakash a3c9b1b6eb Merge "Update Lottie animations in Back gesture tutorial" into udc-dev am: b95182353d am: da3eca638f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23537267

Change-Id: I039389d8e49a8f77748370e298ca0d80f9ef48dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 17:59:11 +00:00
Ats Jenk 536f28d3f1 Merge "Animate in desktop app select toast" into udc-qpr-dev am: 826b28d703
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23574221

Change-Id: I8b9dbdf39562c8cb6d3d1050f5bc667cc23a800e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 17:42:48 +00:00
Saumya Prakash da3eca638f Merge "Update Lottie animations in Back gesture tutorial" into udc-dev am: b95182353d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23537267

Change-Id: I6b244ff0ba7e5cbfa085f50973a2ecffef6d582a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 17:19:31 +00:00
Saumya Prakash f5792e54c3 Merge "Update Lottie animations in Back gesture tutorial" into udc-dev am: b95182353d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23537267

Change-Id: If60d812ccf9955e4eaa3258de6a4d8c621ca637b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 17:19:05 +00:00
Saumya Prakash 1ba1b49db7 Merge "Update Lottie animations in Back gesture tutorial" into udc-dev am: b95182353d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23537267

Change-Id: Ic8a420755dbc4e0a5e8801a0d0929bf06295308e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 17:14:41 +00:00
Saumya Prakash b95182353d Merge "Update Lottie animations in Back gesture tutorial" into udc-dev 2023-06-06 17:01:12 +00:00
Ats Jenk 826b28d703 Merge "Animate in desktop app select toast" into udc-qpr-dev 2023-06-06 16:49:27 +00:00
Schneider Victor-tulias b5c7086323 Fix layout issues in suw all set page
putting contents of the suw all set page in a scroll view to fix layout issues in large display/font sizes

Flag: not needed
Fixes: 275018092
Test: launched all set page on smallest and largest display/font sizes on handheld, tablet and foldable
Change-Id: I921b1becfc0627e9b77e467efe309613aa3ca9d0
2023-06-06 09:42:36 -07:00
TreeHugger Robot c593e15b13 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-06-06 15:05:23 +00:00
Treehugger Robot 6aeae7ba85 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-06-06 14:43:16 +00:00
Bill Yi 32e2287dbb Merge "Import translations. DO NOT MERGE ANYWHERE" 2023-06-06 13:27:19 +00:00
TreeHugger Robot b2884b3ea4 Merge "Don't allow Taskbar unstash during Assistant gesture" into udc-dev am: e2a6113e93 am: 39748f8883 am: 4e012e8229
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23565985

Change-Id: I8efc56fc9caec1ad003ddae89a0aa8179a134602
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 03:46:03 +00:00
TreeHugger Robot 8704476235 Merge "Don't allow Taskbar unstash during Assistant gesture" into udc-dev am: e2a6113e93 am: 39748f8883
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23565985

Change-Id: I26e34597aa96c2eb304ef40404b4492faf7f1074
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 03:03:33 +00:00
TreeHugger Robot 4e012e8229 Merge "Don't allow Taskbar unstash during Assistant gesture" into udc-dev am: e2a6113e93 am: 39748f8883
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23565985

Change-Id: I6b523da0d72e455d57dd9e6181d02bf67974764f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 03:00:41 +00:00
TreeHugger Robot 3dc7048f72 Merge "Don't allow Taskbar unstash during Assistant gesture" into udc-dev am: e2a6113e93 am: b3c96b9443
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23565985

Change-Id: I2fc6eea716df51ffe890fc2952cce70d3adfa2a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 02:37:37 +00:00
TreeHugger Robot 21c61e80e9 Merge "Don't allow Taskbar unstash during Assistant gesture" into udc-dev am: e2a6113e93
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23565985

Change-Id: I660c58403744b737a2819378b8ffd62f8c8a0bd7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 02:19:10 +00:00
TreeHugger Robot 2d85fe7c59 Merge "Don't allow Taskbar unstash during Assistant gesture" into udc-dev am: e2a6113e93
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23565985

Change-Id: I63f8fce59cc75da12a816a77f673bfabddbe9f5a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 02:18:10 +00:00
TreeHugger Robot b3c96b9443 Merge "Don't allow Taskbar unstash during Assistant gesture" into udc-dev am: e2a6113e93
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23565985

Change-Id: I5e1a8b43f3e444d7853efc29c4832252122bb410
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 02:18:05 +00:00
TreeHugger Robot 55a05f7e34 Merge "Simplifying some test utility methods" into udc-qpr-dev am: 859d0d87e2 am: 8302a41cf2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23443976

Change-Id: If34ee520d7cccbf5fc6befc7ad39394a49af4bdf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 01:55:22 +00:00
TreeHugger Robot 689dc9a4fc Merge "Prevent initiating split with task excluded from recents" into udc-dev am: 0d3edbfeb6 am: 4418ade8ef am: 39a37a9458
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23495351

Change-Id: Icd4784adb49dbe258cc41ca1fe39f1b7b8f4dada
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 01:10:20 +00:00
TreeHugger Robot 9bf69ea28d Merge "Prevent initiating split with task excluded from recents" into udc-dev am: 0d3edbfeb6 am: 4418ade8ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23495351

Change-Id: Ib86e56e308adf538911531dc8296d2d0dd865c9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 00:27:11 +00:00
TreeHugger Robot e2f49546e3 Merge "Prevent initiating split with task excluded from recents" into udc-dev am: 0d3edbfeb6 am: 97df54f62a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23495351

Change-Id: I63c7f0e9fef2bdae2cab6fb1692daa6cf43a86fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 00:23:09 +00:00
TreeHugger Robot 39a37a9458 Merge "Prevent initiating split with task excluded from recents" into udc-dev am: 0d3edbfeb6 am: 4418ade8ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23495351

Change-Id: I02005bd41d3f072d4863408726a75735c3b153ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 00:23:09 +00:00
TreeHugger Robot 97df54f62a Merge "Prevent initiating split with task excluded from recents" into udc-dev am: 0d3edbfeb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23495351

Change-Id: Ic7c7cfe25236b16942188d87426a92e4516646c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-05 23:41:46 +00:00
TreeHugger Robot ebe5a662b2 Merge "Prevent initiating split with task excluded from recents" into udc-dev am: 0d3edbfeb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23495351

Change-Id: I20127910badbe9f65c89a3eeba1517b1c9849e72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-05 23:41:30 +00:00
Ats Jenk a37f3f2c2c Animate in desktop app select toast
Add an animation for the desktop app select toast.
Played when the toast is added to the screen.

Bug: 261234402
Test: have an app on desktop, swipe up to home, verify that the toast
  has an appear animation, per the spec
Test: when toast is visible, tap on cancel button, observe toast fades
  out
Test: when toast is visible, launch an app, verify toast fades out
Change-Id: I593d6c326d6d638f1bc06e8c6add31b0244e4cb5
2023-06-05 16:39:29 -07:00
TreeHugger Robot 8755f5df8d Merge "Prevent initiating split with task excluded from recents" into udc-dev am: 0d3edbfeb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23495351

Change-Id: I8cc7db47b039d28745386b8b6d8e65a3b3b8188a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-05 23:37:26 +00:00
Tony Wickham 97bada6339 Don't allow Taskbar unstash during Assistant gesture
Test: manual with "swipe to invoke assistant" enabled
Flag: none
Fixes: 282060498
Change-Id: I317d01dbbb59d020338b17d424c853a00ef03cce
2023-06-05 23:23:40 +00:00
TreeHugger Robot 8302a41cf2 Merge "Simplifying some test utility methods" into udc-qpr-dev am: 859d0d87e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23443976

Change-Id: I8894188d382d41196bed569b366ba60f2ec6ae64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-05 23:22:21 +00:00
TreeHugger Robot 859d0d87e2 Merge "Simplifying some test utility methods" into udc-qpr-dev 2023-06-05 23:10:06 +00:00