Commit Graph

20478 Commits

Author SHA1 Message Date
Sunny Goyal 6eb256d794 Simplifying settings activity
> Removing multiple fragments
> Exposing support to select preference root
> Adding support for recreating preferences
> Moving Developer options to same fragment

Bug: 305084752
Flag: N/A
Test: Manual
Change-Id: I499be1938ef8ed58cbc7f9b0f4ad3510d4b306c8
2023-10-24 11:40:12 -07:00
Uwais Ashraf aa7fa886d6 Add margins to top and bottom when grid only overview enabled
Fix: 299100244
Test: OverviewImageTest and dump tests
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I22ebced5bf1e27974036d6e2ef72d2b8d63df824
2023-10-24 16:15:39 +00:00
Pat Manning 3a2fde4db4 Go home before getting overview in test to ensure overview will exist.
Also when opening settings, do not wait for A11Y event which never fires. (added in ag/24777489, but seems to fail as mentioned here b/303329286#comment2 and tracked here b/298114205)

Fix: 307379525
Fix: 307397957
Bug: 298114205
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TRUNKFOOD
Test: TaplOverviewIconTest
Change-Id: Icd8a47b47d22ddb32db7df6882ec655f0e6f54c1
2023-10-24 14:43:11 +00:00
Luca Zuccarini d7e3d8ab90 Merge "Reuse the main depth controller for launch animations." into main 2023-10-24 14:31:20 +00:00
Schneider Victor-tulias a028cd11ba Fix NPE in overview action buttons
Flag: N/A
Fixes: 305894735
Test: pressed screenshot overview action button shortly before/after dismissing the current task
Change-Id: Ife93fa9af5416af60cf8ae24275f14bd6857901a
2023-10-24 14:13:39 +00:00
Tracy Zhou fbc8b715c3 Merge "Null check on RecentsView for endLiveTile" into main 2023-10-24 04:26:35 +00:00
Tracy Zhou 7cf1884d92 Null check on RecentsView for endLiveTile
Fixes: 304914019
manual: N/A
Change-Id: I6c6e3f0f52e57589f71b3c63debac21734fc88bf
2023-10-23 17:17:42 -07:00
Saumya Prakash c14d48c214 Merge "Check status of mEdgeBackGestureHandler to prevent NPE" into main 2023-10-23 20:22:54 +00:00
Tracy Zhou 9070b93f40 Merge "Do not show task bar edu in folded state with task bar / nav bar unification" into main 2023-10-23 18:34:30 +00:00
Pat Manning 1f5d5be70d Merge "Move overview tests to quickstep package." into main 2023-10-23 18:26:38 +00:00
Pat Manning 1eb8bd8735 Merge "Increase pinned taskbar height to fit tooltips." into main 2023-10-23 16:13:03 +00:00
Jon @ b61dcac34e Merge "Add HomeTransitionListener to launcher." into main 2023-10-23 15:56:36 +00:00
Pat Manning 954e3b8dee Move overview tests to quickstep package.
Fix: 305394234
Test: TaplOverviewIconAppChipMenuTest, TaplOverviewIconTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT
Change-Id: Ib39e2ec7f53de0c4b557558776c7ad428e4cab22
2023-10-23 16:15:33 +01:00
Pat Manning 5643e7c047 Increase pinned taskbar height to fit tooltips.
Fix: 305706286
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states TRUNKFOOD
Test: TaskbarHoverToolTipControllerTest

Change-Id: I767947a752eae7a928d59fe332bc62b9fd5b5f37
2023-10-23 15:52:48 +01:00
Andreas Agvard e3fbfaca73 Synchonizes touch slop across input consumers
This is done so that an outer input consumer isn't inside it's touch slop while an inner consumer has passed it's touch slop. An inner consumer cannot inform the outer consumers that it has intercepted in the current design.

Removes MotionEvent.CLASSIFICATION_AMBIGUOUS_GESTURE handling from NavHandleLongPressInputConsumer since other input consumers do not use this mechanism leading to misalligned touch slops.

OtherActivityInputConsumer now uses touch slop from the device configuration (it already did so for the squared touch slop).

Flag: LEGACY CUSTOM_LPNH_THRESHOLDS DISABLED
Bug: 305924072
Test: Manual
Change-Id: Idf5e88d75914255923fbbcfb602cf2a53773ff9a
2023-10-23 15:36:51 +02:00
Tracy Zhou aa783da782 Do not show task bar edu in folded state with task bar / nav bar unification
Fixes: 306208742
Test: manual
Change-Id: I8321e9d41ea041f77cea3f140d92316c702ce531
2023-10-20 19:47:29 -07:00
Mateusz Cicheński 4d59d52d1e Merge "Validate source rect hint for enter PIP in gesture nav" into main 2023-10-21 00:03:34 +00:00
Jon Miranda 00c3d78191 Add HomeTransitionListener to launcher.
Fixes: 279514548
Bug: 284474103
Bug: 306053414

Flag: LEGACY ENABLE_HOME_TRANSITION_LISTENER DISABLED
Test: App launch -> Hotseat -> Taskbar stashes
      Transluscent app launch and launcher still visible -> No change
      Going home -> Hotseat visible

Change-Id: I6db5253ada3e3b37dfae124f3ee88a9805804fb8
2023-10-20 15:46:11 -07:00
Sunny Goyal e4900713b9 Merge "Remove RPC due to unnecessary permission check" into main 2023-10-20 21:48:36 +00:00
Jagrut Desai 2e53885e86 Merge "Adding screen record TaplTestsQuickStep#testOverviewForTablet" into main 2023-10-20 20:23:16 +00:00
Pat Manning 4c27e8c6f0 Migrate cursor feature flag to trunk stable flag.
Fix: 300054410
Test: TaplTestsTransientTaskbar, TaplTestsQuickstep
Flag: enableCursorHoverStates
Change-Id: I5c320e0fd2bdd2ed39b00b62b1399e163c3384e7
2023-10-20 12:17:36 +01:00
Jagrut Desai caf5c815f3 Adding screen record TaplTestsQuickStep#testOverviewForTablet
Test: Presubmit
Bug: 306089019
Flag: NONE
Change-Id: I1e7474fe5f32e895859ca726fc63f40833ada118
2023-10-20 00:38:14 +00:00
Mateusz Cicheński d21cf61e86 Validate source rect hint for enter PIP in gesture nav
If the source rect hint is going outside of visible app bounds,
we should use icon overlay instead.

Test: before http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/fPfOfGUlrBkJ8WbJDqAr2i
Test: after http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/fMcHGqfpA5HCXYoAPV4vTT
Bug: 305090652
Flag: NA

Change-Id: I161f60bf62888c7922227e5d3185810dbe88e317
2023-10-19 23:45:37 +00:00
Andreas Agvard 257f431da2 Merge "Adds haptic build-up during LPNH behind feature flag" into main 2023-10-19 21:48:21 +00:00
Jagrut Desai 34d135e21a Merge "Always use Transient Taskbar All apps icon for taskbar pinning" into main 2023-10-19 20:03:14 +00:00
Andreas Agvard d1674985d6 Adds haptic build-up during LPNH behind feature flag
Flag: Omnient flags + ENABLE_SEARCH_HAPTIC_HINT
Test: Manual
Bug: 303023676
Change-Id: Ic43d1f34a05622328add6727f36406ce75d5a115
2023-10-19 21:10:42 +02:00
Liran Binyamin 78f444bdad Adds content description to the overflow bubble.
Flag: LEGACY persist.wm.debug.bubble_bar DISABLED
Bug: 273994695
Test: SystemUIMicrobenchmark:android.platform.test.scenario.sysui.bubble.BubbleBarTest

Change-Id: Ie3fe451c69a39560aa91a6dfd4d615f172cf3299
2023-10-19 14:00:41 -04:00
Nicolò Mazzucato 3a412d0471 Merge "Instrument unfold animation on launcher" into main 2023-10-19 12:45:06 +00:00
Alex Chau 0e4e703215 Merge "Migrate ENABLE_OVERVIEW_ICON_MENU to aconfig flag" into main 2023-10-19 08:18:41 +00:00
Sunny Goyal 8bbd8d4c43 Remove RPC due to unnecessary permission check
Bug: 302400996
Test: Presubmit
Flag: N/A
Change-Id: I9c03e95f37e6e7be8a61ad6f5f7548b4860a1704
2023-10-18 10:52:17 -07:00
Pat Manning 131495745c Merge "Add flag guarding around setText in TaskView." into main 2023-10-18 17:38:47 +00:00
Nicolo' Mazzucato 28ee5d441e Instrument unfold animation on launcher
Test: inspected perfetto traces
Bug: 294043453
Bug: 303438877
Flag: not needed
Change-Id: Iec6fe1cbbfdc68adc49c332c15add1333fed7590
2023-10-18 16:37:34 +00:00
Randy Pfohl 8fb1d8f295 Merge "Removing obselete logging used for flaky test investigation" into main 2023-10-18 16:33:06 +00:00
Pat Manning 04dcce8333 Add flag guarding around setText in TaskView.
Bug: 303266975
Test: Forrest runs & Crystalball performance metrics.
Flag: enableOverviewIconMenu
Change-Id: I79e325f9d3377bc078634232c53fd3587d05acc4
2023-10-18 17:13:28 +01:00
Andreas Agvard 6a9f888201 Update LPNH detection
Replaces GestureDetector usage in LPNH handler with internal implementation that we can tweak
in follow up CLs. It's also a pre-requisite for doing a hint haptic.

Flag: CUSTOM_LPNH_THRESHOLDS
Bug: 300219375
Test: Manual
Change-Id: I5a010d8828bf400e9151236554b29f60edba044c
2023-10-18 09:33:51 +02:00
Alex Chau fb2f4b1a6f Avoid drawing live tile behind recents when launching on grid overview
Fix: 304911154
Flag: none
Test: Swipe up in tablet, scroll to side, launch focused task
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1f5de2483bc9eb36128a7f700ca4539591afd186)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c44b3cdda9b8d51ec2142e65674617d34d9a5c9d)
Merged-In: I91dd8b4088f02af9dc5e603853d8e26606acc38f
Change-Id: I91dd8b4088f02af9dc5e603853d8e26606acc38f
2023-10-18 01:55:44 +00:00
Holly Jiuyu Sun 0fadf743cc Merge "[DMA] Add withFeature API in StatsLogManager." into main 2023-10-17 21:17:38 +00:00
Tracy Zhou 0254ae5480 Merge "Dynamically adjust the paddings of the contextual buttons" into main 2023-10-17 19:26:41 +00:00
randypfohl e07068a0c9 Removing obselete logging used for flaky test investigation
Bug: 293191790

Test: not needed.

Flag: not needed.

Change-Id: I0378c1cc16ae25006d226db3b858394e5f20a22b
2023-10-17 11:47:00 -07:00
Alex Chau a0e3ed90ac Avoid drawing live tile behind recents when launching on grid overview am: c44b3cdda9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25086887

Change-Id: I4f3a129dd63a672f66fe2997c6a8bda58c5c2244
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-17 18:29:16 +00:00
Saumya Prakash a65c198f23 Check status of mEdgeBackGestureHandler to prevent NPE
Sometimes onAttachedToWindow() can be called before
mEdgeBackGestureHandler is created, which led to a NPE. This change adds
a null check to prevent the crash.

Fix: 303820749
Test: Set mEdgeBackGestureHandler to null and ensured no NPE occured in
onAttachedWindow()

Change-Id: I43ab8bcfc4d720bc537a7ca36e08068a6a27fbea
2023-10-17 18:01:28 +00:00
Pat Manning df72740384 Merge "Revert "Revert "Combine icon app tests to allow overriding flag ..."" into main 2023-10-17 17:28:24 +00:00
Schneider Victor-tulias 3c732aa71b Merge "Default to using AppLaunchAnimationRunner when no LaunchableView can be found" into main 2023-10-17 17:22:07 +00:00
Pat Manning 24cec69361 Revert "Revert "Combine icon app tests to allow overriding flag ..."
Revert submission 25032768-revert-25007147-tapl-flag-SBORVHYDTI

Reason for revert: Resubmitting for b/304470271

Reverted changes: /q/submissionid:25032768-revert-25007147-tapl-flag-SBORVHYDTI

Change-Id: Ib0bd13a5c2a366160b185a2c6409c607ed7525a1
2023-10-17 15:56:48 +00:00
Schneider Victor-tulias 7802dfb44d Default to using AppLaunchAnimationRunner when no LaunchableView can be found
Flag: not needed:
Fixes: 305699288
Test: ran launcher and launched apps
Change-Id: I5ab4f3c7d976e463c29340a4a00edf37e15abf47
2023-10-17 11:30:21 -04:00
Uwais Ashraf c1eecf21e9 Merge "[Trunk Stable] Use SetFlagsRule.initAllFlagsToReleaseConfigDefault instead of disabling all flags in setUp." into main 2023-10-17 14:09:47 +00:00
Luca Zuccarini ff2b38e366 Reuse the main depth controller for launch animations.
The two controllers don't own any unique state, other than the current
depth state. These two _should_ never diverge anyway, because there is
only one valid depth at any given time. By using the same controller all
the time we can enforce this invariant.

Everything else is basically just registered and unregistered listeners,
which the main controller already does properly and always has the same
state in that regard as the ad-hoc one that we're removing.

Finally we don't need to take care of any cleanup explicitly, as we did
before.

Bug: 293427436
Flag: N/A
Test: manual
Change-Id: If6ea68847a60254df76e806eac2679ae0415bfe0
2023-10-17 12:16:25 +00:00
Riddle Hsu a60c091c94 Merge "Finish recents animation for standalone recents on home" into main 2023-10-17 10:56:28 +00:00
Anushree Ganjam 6ee3a32b12 [Trunk Stable] Use SetFlagsRule.initAllFlagsToReleaseConfigDefault instead of disabling all flags in setUp.
Bug: 294913042
Flag: NA
Test: Unit tests
Change-Id: Ib570ce67f53d4af7407b36f6fee1a3517800155f
2023-10-17 10:27:54 +00:00
Alex Chau c44b3cdda9 Avoid drawing live tile behind recents when launching on grid overview
Fix: 304911154
Flag: none
Test: Swipe up in tablet, scroll to side, launch focused task
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1f5de2483bc9eb36128a7f700ca4539591afd186)
Merged-In: I91dd8b4088f02af9dc5e603853d8e26606acc38f
Change-Id: I91dd8b4088f02af9dc5e603853d8e26606acc38f
2023-10-17 08:32:22 +00:00