Commit Graph

20478 Commits

Author SHA1 Message Date
Saumya Prakash 1613fe6b13 Increase the character limit for translations in taskbar pinning edu
The current character limit for the taskbar pinning edu subtitle does
not fit many translations. We are increasing the character limit to
enable proper translations.

Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Fix: 323943380
Test: N/A
Change-Id: I56225711c475e617451e5db0b1c226e3603e5c02
2024-02-05 21:40:38 +00:00
Schneider Victor-tulias 853d7d3b4c Add TAPL test cases for KQS from taskbar all apps.
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 323218341
Test: TaplTestsKeyboardQuickSwitch
Change-Id: Ie8f23ad14e4a32abbc5b49edc05ce407bbb774e6
2024-02-05 15:41:19 -05:00
Vinit Nayak 562fe01e5e Merge "Update fail fast check logic" into main 2024-02-05 20:00:08 +00:00
Fengjiang Li 1f0465e9f2 Add unit test for StatusBarTouchController.java
Test: this one
Flag: NONE
Bug: 282945183
Change-Id: I76eb4389d71d7a03e038ed6b01b6f5b7923fd11a
2024-02-05 11:51:01 -08:00
Vinit Nayak ccab39e714 Merge "Revert "Prevent taskbar animation for contextual split from home"" into main 2024-02-05 19:39:00 +00:00
Vadim Tryshev 3517550379 Merge "Starting measuring displacement from the edge of the slop zone" into main 2024-02-05 18:22:12 +00:00
Vinit Nayak 628a039721 Update fail fast check logic
* Incorrectly wasn't erroring out when flag was not enabled

Bug: 295467097
Change-Id: I5716309f832d1170ea92ad357897299c0438d2d0
2024-02-05 10:21:26 -08:00
Jagrut Desai c5be03f062 Merge "Change Persistent/Pinned Taskbar App Icon Size to 40dp" into main 2024-02-05 16:54:32 +00:00
Jordan Silva ebd71c6cc9 Refactoring TAPL functions for OverviewTask
This CL refactors some methods in OverviewTask to rely on OverviewSplitTask. It also changes the BaseOverview getTasks function to retrieve the parent task and support cases where only the bottomright_snapshot is available in the recent tasks.

Bug: 320633351
Test: TaplTestsSplitscreen
Flag: N/A
Change-Id: I226f895810ce3b46cc107f76cd85e2918abf7088
2024-02-05 13:50:23 +00:00
Uwais Ashraf 810a82f13e Merge "Extract GroupedTaskView size calcs to a method to prevent measure calls" into main 2024-02-05 11:35:11 +00:00
Uwais Ashraf 0d355abe38 Extract GroupedTaskView size calcs to a method to prevent measure calls
Bug: 313644427
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest
Change-Id: I494f09455104372209b9087d13a704a4fe52bb62
2024-02-05 10:27:12 +00:00
Tracy Zhou e9f4635426 Show hotseat instead of stashed taskbar handle after entering stage split from fullscreen app via keyboard shortcut
Besides finishing the recents animation from fullscreen app, we also need to update the taskbar state

Fixes: 323561157
Test: Go to a fullscreen app, trigger the split shortcut, make sure the hotseat icons are visible on the home screen
Change-Id: I36f47846ed0bc7f7036ae22452a28efc9cb09bc7
2024-02-03 06:04:00 +00:00
Tracy Zhou 6474a3b455 Merge "Add split instructions to stage split from keyboard shortcut" into main 2024-02-03 06:02:48 +00:00
Tony Wickham cac7c6f682 Merge "Send finish callback even if there is no icon to animate to" into main 2024-02-02 22:37:44 +00:00
Vinit Nayak 92dd621d8e Merge "Intercept clicks for non-supported split targets on workspace" into main 2024-02-02 22:07:53 +00:00
Mady Mellor 5912d0f6d9 Merge "Launcher: use aconfig flag for bubble bar" into main 2024-02-02 21:04:32 +00:00
Vadim Tryshev 94477b23e9 Send finish callback even if there is no icon to animate to
Fixes: 321297170
Test: TaplAllAppsIconsWorkingTest#testAppIconLaunchFromAllAppsFromHome
Flag: none
Change-Id: Ia6084dd14715bab36c7dd1c983fabedcf9b10630
2024-02-02 20:42:02 +00:00
Tracy Zhou d0b9aae52c Add split instructions to stage split from keyboard shortcut
Fixes: 319098298
Test: When launching split from fullscreen app via keyboard shortcut, the split instruction shows
Change-Id: Ie64e5e65384a24825edc7ae6c8dea3203e2bd916
2024-02-02 11:29:10 -08:00
helencheuk 04cd8f2852 Show taskbar when external keyboard is attached, in 3 button nav mode and desktop windowing mode
Bug: 280497051
Test: Manual, turn on desktop windowing mode. Enter input mode in an app, drag it from the top to be  window mode. Verify if taskbar is present
Flag: N/A
Change-Id: I31dc922c480cd0b39a64763155777b906e3bd14a
2024-02-02 17:31:13 +00:00
Vinit Nayak ec52ed9f99 Intercept clicks for non-supported split targets on workspace
* If we're in split selection state we disable the following
- G icon on PSB
- Lens icon on PSB
- Smartspace
- Widgets

Bug: 295467097
Test: Enter split contextual and observe split instructions
view going boing when tapping on unsupported target
Flag: com.android.wm.shell.enable_split_contextual

Change-Id: Ia7783472f3de9359c2784788be5f35596cbc8deb
2024-02-02 08:17:13 -08:00
Sam Cackett 8b997289f0 Merge "Fix issue with IconAppChipView animated states" into main 2024-02-02 12:27:45 +00:00
samcackett fee52acb29 Fix issue with IconAppChipView animated states
Cancel in progress animations and resume from previous position.
Display TaskMenuView once.

Fixes: 322813710
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I73410d6116876ca83f3b16311d2e9eb372308295
2024-02-02 11:08:47 +00:00
Vinit Nayak 8b78849c44 Revert "Prevent taskbar animation for contextual split from home"
This reverts commit febd61fb3f.

Reason for revert: b/323418145, testing to see if this is the culprit

Change-Id: Ie72ce0d24c6008e93340c1868b18bce68902c7cc
2024-02-02 01:55:18 +00:00
Sunny Goyal b2f38376c4 Merge "Blocking gestureNav on taskFragments within the Launcher activity" into main 2024-02-02 00:23:29 +00:00
Mady Mellor cc138663ca Launcher: use aconfig flag for bubble bar
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DISABLED
Test: make & enable / disable flag to check if it works:
      adb shell device_config put multitasking
         com.android.wm.shell.enable_bubble_bar true
Test: PlatformScenarioTests:
      android.platform.test.scenario.sysui.bubble.BubbleBarTest
Bug: 286246694
Change-Id: I0820973848675e8596e0e1605c7e43158d870382
2024-02-01 23:18:53 +00:00
Brandon Dayauon ff89c5c9dc Fix color contrast in All Apps text by setting the color to onSurfaceVariant
bug: 322293478
Test:
All Apps divider:
before lightTheme: https://drive.google.com/file/d/1MTL1iEX_icYWfT52WeZIgqLK46koLM_s/view?usp=sharing
after lightTheme: https://drive.google.com/file/d/1ME1Gk8bUIXIe1P_Z5pvcpi3VS0_L0mVK/view?usp=sharing
before darkTheme: https://drive.google.com/file/d/1MLcv32M2JWyVqPklMdZLJAkj8KnyXwtB/view?usp=sharing
after darkTheme: https://drive.google.com/file/d/1MJjgP42xgp7SCifHAfREzgWvw6KupvlR/view?usp=sharing
All Apps text:
before light theme:https://drive.google.com/file/d/1MCu6xtpCMCxtDpnAv3fhCDSafBJGX4rx/view?usp=sharing
after light theme:https://drive.google.com/file/d/1M6ilveUw2q0FIlo-NSxt8KEWKRbQvwhk/view?usp=sharing
before dark theme:https://drive.google.com/file/d/1MCOxt9MeWxgN65T2s0OKzybiPu4qI4PD/view?usp=sharing
after dark theme: https://drive.google.com/file/d/1MAXnRmG8NVMu1bCseVWn6GC2322gQ0sX/view?usp=sharing
Flag: None

Change-Id: Iedb12d7b11b215c6668e7b5e6637189da3d67ebc
2024-02-01 14:55:23 -08:00
Sunny Goyal 2829c361f3 Blocking gestureNav on taskFragments within the Launcher activity
Bug: 273828110
Flag: aconfig use_activity_overlay disabled
Test: Verified on device
Change-Id: Ie812e17012feb8e99e06d0593207a87ef0c768e3
2024-02-01 13:35:30 -08:00
Schneider Victor-tulias 3dafeb2d09 Merge "Update KQS overview launch animation" into main 2024-02-01 17:55:54 +00:00
Schneider Victor-tulias 8b9ca27cb8 Merge "Handle slow gesture handling" into main 2024-02-01 16:27:21 +00:00
Schneider Victor-tulias 1ca66992c1 Update KQS overview launch animation
Updated the KQS overview launch animation to match the spec: open overview and scroll to the focused task in one fluid motion

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313608085
Test: Opened KQS from home and overview
Change-Id: I2d617db29ff46e89fab50bb6f8aee900b6fe649f
2024-02-01 14:49:29 +00:00
Johannes Gallmann 8a631d09d0 Fix crash for predictive back to home fallback animation
Bug: 323046568
Flag: ACONFIG com.android.window.flags.predictive_back_system_anims TEAMFOOD
Test: Manual, i.e. verify no crash for predictive back to home fallback
animation
Change-Id: I8bd5ddb3f97376a9d9bc4bdf1e3a55e7f53a192f

Change-Id: I1f53b3fafb8d508a0e0b67dda16eae36191f197c
2024-02-01 12:40:37 +01:00
Vadim Tryshev 717ea2cdff Starting measuring displacement from the edge of the slop zone
This makes displacement calculations robust against skipped MOVE events

Test: presubmit
Bug: 297377792
Flag: N/A
Change-Id: I6c2c3486139baa5e456c6787c2afc7b3f7fe7cfd
2024-01-31 17:23:51 -08:00
Tracy Zhou e757578908 Merge "Fix non-null check crash" into main 2024-02-01 00:21:05 +00:00
Jeremy Sim 99cfd0905b Merge "Add error logging and better crash safety for app pairs" into main 2024-01-31 22:25:04 +00:00
Jordan Silva 2e75eeae32 Merge "Refactoring PagedOrientationHandler to extract functions from to quickstep" into main 2024-01-31 22:21:56 +00:00
Jagrut Desai 4d24ad9cbf Change Persistent/Pinned Taskbar App Icon Size to 40dp
Test: Manual, Presubmit
Bug: 322315240
Flag: NONE
Change-Id: Ibef82e18bbe33af51b27310ccd8052a02a35522c
2024-01-31 13:53:12 -08:00
William Leshner de36f8a8ec Merge "Filter widgets in widget picker activity by size." into main 2024-01-31 21:38:45 +00:00
Tracy Zhou e22d4f7eea Fix non-null check crash
onConfigurationChanged can be triggered before all the buttons are initialized, including Space, in which case, we currently skip that rendering

Bug: 230395757
Test: cold start doesn't crash
Change-Id: If451ddbb6b2055a207372d6470eb0fe0faff0301
2024-01-31 19:31:59 +00:00
Jordan Silva 715e25adf4 Refactoring PagedOrientationHandler to extract functions from to quickstep
This CL extracts RecentsView methods from PagedOrientationHandler to RecentsPagedOrientationHandler. It will allow to have quickstep specific components in the newer interface, like IconAppChipView.

Bug: 320633351
Flag: N/A
Test: atest NexusLauncherTests
Test: atest TaplTestsSplitscreen
Test: atest TaplTestsQuickstep
Change-Id: Ie7de23bddccbdb8eac93eff66a5d929f5bf0ee3a
2024-01-31 18:58:15 +00:00
Schneider Victor-tulias 7e768fbf3b Handle slow gesture handling
Fixed broken gesture handling when RecentsAnimationCallbacks signals take too long.

Flag: NONE
Fixes: 285636175
Test: added a programmatic delay in RecentsAnimationCallbacks.onAnimationStart, attempted home/overview/quick switch gestures then quickly attempted another gesture during the delay
Change-Id: I59261d21ca4e2bd4b5496822e78c6db74eac10c7
2024-01-31 10:23:24 -05:00
Luca Zuccarini ae741dec9f Merge "Update dependency on Shell utils." into main 2024-01-31 10:06:19 +00:00
Jeremy Sim cfcf2255dc Add error logging and better crash safety for app pairs
This causes app pairs to log an error message if creation or icon inflation is attempted with contents != 2. App pairs with wrong numbers of members should not be created anymore.

Fixes: 317283244
Fixes: 322892793
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I5e454042719bb67187f900c546380bb44cfc34ac
2024-01-31 15:42:20 +08:00
Tracy Zhou 89fa4e35d8 Merge "Make sure touch only goes to the nearest button when it makes sense" into main 2024-01-31 06:26:32 +00:00
Tracy Zhou c7d7418cae Merge "Center a11y button" into main 2024-01-31 06:25:55 +00:00
Anushree Ganjam 8ee9076f0e Merge "[PS] Show "Uninstall" in Long Press menu for Private Space apps." into main 2024-01-31 02:22:11 +00:00
Tracy Zhou 1a92257520 Center a11y button
Bug: 25768138
Test: a11y button is centered when visible
Change-Id: If9099575c12b51a90bc9e15e712cb629811d36e3
2024-01-30 16:54:10 -08:00
Anushree Ganjam 45ef544ae5 [PS] Show "Uninstall" in Long Press menu for Private Space apps.
Video : https://b.corp.google.com/issues/319250810#comment18

- Add SecondaryDropTarget.performUninstall()
- Make SecondaryDropTarget.getUninstallTarget() public static.

Test: Manual
Flag: aconfig com.android.launcher3.enable_private_space TEAMFOOD
Bug: 319250810

Change-Id: If6488033a976914fdc0a50658fc0561dc1a6586a
2024-01-30 16:54:04 -08:00
Will Leshner f0be49e693 Filter widgets in widget picker activity by size.
Bug: 322191186
Test: atest Launcher3Tests
Flag: NA

Change-Id: I003e05cc16ae576cda07d249d036d2f9dbacdcc2
2024-01-30 15:42:00 -08:00
Tracy Zhou 419140aede Make sure touch only goes to the nearest button when it makes sense
- In NearestTouchFrame, we can't use view bounds alone since the buttons do not have the same root (3 buttons are in the main container, while the contextual buttons are in the contextual button container). This currently caused the issue that contextual button region, when the contextual buttons are invisible, triggers overview
- Need to add an empty space in the left / top area of the button nav to prevent view clicks from going into back (that's how it works in navigationbar/)

Bug: 25768138
Test: left and right of 3 buttons don't trigger back or overview
Change-Id: Idc26c0c8ac0ecc000300a6db2e3e6251f678dada
2024-01-30 14:27:48 -08:00
Saumya Prakash dc23966243 Merge "Don't show the Tasbar Pinning edu for 3 button nav users" into main 2024-01-30 21:20:45 +00:00