Commit Graph

20478 Commits

Author SHA1 Message Date
Sunny Goyal 68ee15d758 Merge "Simplefying listener interface for TriggerSwipeUpTouchTracker" into main 2024-03-12 19:12:19 +00:00
Federico Baron 4d1fe6b854 Revert "Add screenrecord for testOverviewDeadzones"
This reverts commit eb65ca1600.

Reason for revert: issue stopped happening 

Change-Id: Ib9313e0df9768ad17f3c8c7bd52cb45eb457b5cd
2024-03-12 18:43:28 +00:00
Alex Chau 26e487c6ac Allow Task menu to draw down to screen bottom
- Use all available spaces minus inset to draw the task menu
- Also enabled scrolling for app chi1p menu

Fix: 329271577
Bug: 326952853
Test: manual
Flag: Nonee
Change-Id: Ibdff07043f2c64495f97e11e80209bcc3f5dcb4f
2024-03-12 17:55:37 +00:00
Treehugger Robot 0cd5024c6b Merge "Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-03-12 17:52:22 +00:00
Vinit Nayak 1c8bd71675 Merge "Using fractions in MultiValueUpdateListener instead of absolute durations" into 24D1-dev 2024-03-12 17:48:18 +00:00
Schneider Victor-tulias f3edea44e1 Disable slow recents animation handling
Flag: N/A
Fixes: 324228222
Test: programmatic delay and several gestures
Change-Id: I98f3575047e442a4f57582b40cc0f36f1f113356
(cherry picked from commit 5b9d94adc5)
2024-03-12 17:47:03 +00:00
Vinit Nayak 872d6953a1 Merge "Update Launcher state anim duration for pinned & transient taskbar" into main 2024-03-12 17:25:54 +00:00
Alex Chau 618d7ed2c6 Merge "Re-calculate mLastComputedCarouselTaskSize when its empty before getMaxScaleForFullScreen" into main 2024-03-12 13:07:02 +00:00
Shamali Patwa 7574bed02e Merge "Update labels for the categories to match the UX writer provided strings" into main 2024-03-12 11:37:25 +00:00
Sukesh Ram 8229228132 Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Add logging for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 324940434
Change-Id: I7c30fb2f3c94770fa79780d2e7748e931552ba56
2024-03-12 02:17:59 +00:00
Treehugger Robot 54ae7b9dc3 Merge "Disable slow recents animation handling" into main 2024-03-12 01:01:55 +00:00
Brian Isganitis 1956246b6e Reset stashed in Taskbar All Apps for gestures instead of IME insets.
Test: Manual
Flag: NONE
Fix: 328960039
Change-Id: I62c53c21bf850b7080e12086235cba28164f4d70
2024-03-11 20:30:32 -04:00
Vinit Nayak a7789a4593 Update Launcher state anim duration for pinned & transient taskbar
* We were syncing the duration of the animation to be at most
that of the taskbar/hotseat animation but only for transient taskbar.
* Now we sync for transient and pinned

Fixes: 328052756
Test: Anim jank doesn't repro
Change-Id: I21f20cbc08a2018498dde3eff871929e5a5b7d7d
2024-03-11 23:58:47 +00:00
Vinit Nayak 9a3c48468b Update Launcher state anim duration for pinned & transient taskbar
* We were syncing the duration of the animation to be at most
that of the taskbar/hotseat animation but only for transient taskbar.
* Now we sync for transient and pinned

Fixes: 328052756
Test: Anim jank doesn't repro
Change-Id: I21f20cbc08a2018498dde3eff871929e5a5b7d7d
2024-03-11 16:53:39 -07:00
Himanshu Gupta 616a1b828d Using LauncherApps API for PS Settings and Setup Flow.
Bug: 310027945
Test: Launcher3 tests
Flag: ACONFIG com.android.launcher3.enable_private_space TRUNKFOOD
Change-Id: I6e04a4b0c33d4526d83b51e512e1e4372ce1cca4
2024-03-11 16:13:08 -07:00
Sunny Goyal df71298af6 Using fractions in MultiValueUpdateListener instead of absolute durations
This ensures that any global animation scale applies properly

Bug: 327645429
Flag: NONE
Test: Manual
Change-Id: I12205429dca5a87208fa9964b3307fb718af4fd0
(cherry picked from commit f584b32811)
2024-03-11 22:06:41 +00:00
Vinit Nayak 84ca0e859a Fix split selection for 3P launcher with animations off
* When animations were off, the currentState in
FallbackRecentsStateController is incorrect (we didn't need
that check at all)
* Surfaced a bug in MultiValueUpdateListener that is being
fixed in ag/26416537

Test: 1P + 3P launcher all of the following:
starting split from overview with animations and without
rotation
selecting second app before and after rotation
Fixes: 327346105

Change-Id: I4f19119c30a8669bba6ced06e30773f085a78047
(cherry picked from commit b274152194)
2024-03-11 22:00:27 +00:00
Jeremy Sim 2692ca8925 Merge "Prevent Save App Pair from showing up on 3p launcher" into main 2024-03-11 20:49:06 +00:00
Vadim Tryshev ba219fbe25 Merge "Verifying that current Launcher is the test Launcher in fallback recents tests" into main 2024-03-11 20:05:31 +00:00
Schneider Victor-tulias 5b9d94adc5 Disable slow recents animation handling
Flag: N/A
Fixes: 324228222
Test: programmatic delay and several gestures
Change-Id: I98f3575047e442a4f57582b40cc0f36f1f113356
2024-03-11 14:46:28 -04:00
Alex Chau f03524ae74 Re-calculate mLastComputedCarouselTaskSize when its empty before getMaxScaleForFullScreen
- Follow-up on ag/26499257 to do the same on mLastComputedCarouselTaskSize
- Also changing the mLastComputedTaskSize check to isEmpty

Bug: 326550571
Flag: none
Test: Swipe up, quick switch with Pixel / 3P launcher
Change-Id: If934bf4baf2782cd752b5621ad5e9be4a2013c49
2024-03-11 17:57:00 +00:00
Saumya Prakash 50ae58df57 Merge "Revert "Ensure taskbar insets for camera cutout only apply on the needed sides"" into main 2024-03-11 17:36:24 +00:00
Vinit Nayak 14d28ad455 Revert "Revert "Implements the "Save App Pair" button in Overvie..."
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Reason for revert: Test failure in question wasn't related to this topic b/328016248

Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
Merged-In: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
2024-03-11 05:00:47 +00:00
Brandon Dayauon 68c18236ad Disable two line text legacy flag.
Will now repurpose the twolinetoggle flag to be the flag that will
make twoline text enabled/disabled.

bug: 316027081
Test: presubmit
manually: https://screenshot.googleplex.com/BsZGCm7DrTZLwG4
Flag: com.android.launcher3.enable_twoline_toggle Staging
Change-Id: Idef427bad6551ae56b13e35393e076b8e000af5a
2024-03-08 21:32:22 -08:00
Treehugger Robot f190ede681 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-09 04:28:04 +00:00
Treehugger Robot 41770fbc60 Merge "Fix overview live tile flickers when clicking on overview action buttons" into main 2024-03-09 02:03:56 +00:00
Ats Jenk d573fde5bf Merge "Remove line between bubble bar and arrow" into main 2024-03-08 21:31:08 +00:00
Vadim Tryshev daf428a142 Merge "Demoting unstable test testSwipeToStashAndUnstash" into main 2024-03-08 21:21:14 +00:00
Shamali P 20a5f4e8d1 Update labels for the categories to match the UX writer provided strings
Also fix issue that user was not passed when getting application info.
(error noticed by Zak)
http://screen/8fiiTSHvo2SfYdE

Bug: 318410881
Flag: N/A
Test: Unit test
Change-Id: Id85feec0d95d3d4d183a673f7eed40906b0043e2
2024-03-08 19:58:23 +00:00
Jordan Silva 024a1018e4 Fix overview live tile flickers when clicking on overview action buttons
When a Live Tile is present on overview and an action is triggered (e.g., Split, Select, Screenshot), the live tile flickers due to a competing snapshot modification and animation on UI thread. The live tile is updated to switch to screenshot and at the same time the finishRecentsAnimation is triggered.

This CL bumps the number of frames to wait after the view is updated to run the Runnable code. Bumping back the mDeferFrameCount to 2 solves the sync between rendering the snapshot and hiding the Live Tile.

Fix: 327380570
Flag: N/A
Test: Manual. Open an App -> Swipe to Overview (Live title) -> Click on Split.
Change-Id: Ibd22a58580b2e5e5b866deb4e7dc87945c7e38c4
2024-03-08 19:33:25 +00:00
Vadim Tryshev 96aca9eb0b Verifying that current Launcher is the test Launcher in fallback recents tests
Test: presubmit
Flag: N/A
Bug: 321775748
Change-Id: Id22993785f9674bc746dfbcf979e7b6f775a9680
2024-03-08 11:24:02 -08:00
Randy Pfohl 79c34b4dfe Merge "When mLastComputedTaskSize is empty we will recalculate and set it before determining scale and pivot" into main 2024-03-08 17:08:23 +00:00
Federico Baron f9aa2a4a47 Merge "Remove logspam for resolved bug" into main 2024-03-08 16:29:17 +00:00
Ats Jenk a8e77927b4 Remove line between bubble bar and arrow
Bubble bar background is a drawable that consists of a rounded rect and
a pointer arrow.
In light theme, the rounded rect has a 1 pixel wide border around it.
When drawing the arrow just above the rounded rect, the border is
visible as a line between the background rounded rect and the arrow.
Shifting the arrow down by 1 pixel to ensure that there is no visible
arrow between bubble bar and arrow.

Other option could be to draw the entire background as a single path.
This path can combine the rounded rect background and arrow. But we need
to control the alpha of the arrow separately from the background. This
we can't do with a single path.

Bug: 324442574
Flag: NA
Test: manual
Change-Id: Iaa58ae4700ed9ad43051cd386f03381e0c14e72c
2024-03-07 23:37:49 -08:00
Bill Yi 845c11af1b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I21acc4be9862de6fceb44dd0764c72e99804166b
2024-03-07 22:07:22 -08:00
Bill Yi 4266c83ed6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I862c3d90608b8b67f3b5d10ec8cc2152c38a39fd
2024-03-07 22:06:56 -08:00
Andy Wickham 3081537398 Consolidate settings for Assist.
Now there is just 1 toggle for all entrypoints.

Bug: 324036308
Test: Manual and unit tests
Flag: NA
Change-Id: Id4463345c44fa4daba4eac67b5ad00aff7f3a606
2024-03-08 03:43:41 +00:00
Jagrut Desai 754f171a98 Revert "Ensure taskbar insets for camera cutout only apply on the needed sides"
This reverts commit 40fc6eb323.

Reason for revert: <b/328182219>

Change-Id: I5b846919823d696933b7d9f4220c1797409fc8b8
2024-03-07 20:55:48 +00:00
Jeremy Sim 2b2d8cc90b Prevent Save App Pair from showing up on 3p launcher
This CL adds a check so that app pairs can't be saved on 3p launchers. This affects the Overview icon dropdown menu and the Overview Actions Bar.

Fixes: 326155701
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, option does not show up when Nova Launcher is set as default home app, and shows up again for Pixel Launcher.
Change-Id: I60d6fd3b3eb39921edafb12faace743d16de270f
2024-03-07 20:23:47 +00:00
randypfohl fca7ee23ba When mLastComputedTaskSize is empty we will recalculate and set it before determining scale and pivot
Bug: 326550571

Test: manually set computed task size to 0 simulating unset circumstance, and ran logs verifying infinite, added fix, and verified logs showing the same scale before and after with get tasksize set

Flag: none

Change-Id: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
2024-03-07 12:09:28 -08:00
Ats Jenk 60101ae7fc Merge changes from topic "bubble-bar-drag" into main
* changes:
  Fix bubble bar arrow visibility during animation
  Animate bubble bar location changes
  Introduce bubble bar location that is driven by shell
2024-03-07 19:42:17 +00:00
Sunny Goyal 014e15a86e Simplefying listener interface for TriggerSwipeUpTouchTracker
Merging two callbacks into a single interface

Bug: 327616437
Flag: None
Test: Presubmit
Change-Id: I026df7dca15acbd04b59df1abbf375684d9bfffb
2024-03-07 11:40:29 -08:00
fbaron 7e5d855886 Remove logspam for resolved bug
b/318394698 was fixed so we can now remove these logs.

Fix: 321837497
Test: N/A
Flag: NONE
Change-Id: Ifc8b18238778f6aa2c0ad1be5df627c07cbaf1d8
2024-03-07 11:11:36 -08:00
Vadim Tryshev 8e2a024d96 Demoting unstable test testSwipeToStashAndUnstash
Test: presubmit
Flag: N/A
Bug: 321083190
Change-Id: I10643a9340e78a97df3e8501a8a55d0312e61353
2024-03-07 10:45:19 -08:00
Himanshu Gupta 68532621bb Merge "Disable Saving App Pairs for Private Space Apps" into main 2024-03-07 08:49:59 +00:00
Vinit Nayak 583739f1dd Disable gestures when split apps are animating in from shell
Bug: 286509643
Test: See other CL in topic
Change-Id: Idf16d6db15ea5ed46c3249a10856c7ee96e981ef
2024-03-06 17:28:10 -08:00
Uwais Ashraf 21393f4651 Merge "Add required setup for quickstep tests to be run devicelessly" into main 2024-03-06 23:32:14 +00:00
Ats Jenk 4186cf1b96 Fix bubble bar arrow visibility during animation
Bubble bar pointer arrow was being drawn outside of BubbleBarView
bounds.
This caused issues when alpha was applied to the BubbleBarView. With
alpha, BubbleBarView draw was clipped to its bounds and arrow was no
longer visible. This led to the arrow flickering during move animations.
Move animation updates alpha.
Move the pointer arrow inside the bounds of the bar view. Update the bar
height to include the arrow.
Update callers who rely on bubble bar content height to take into
account extra height for the arrow.

Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: move bubble bar left and right, observe arrow is visible
Change-Id: I05866b5c944361b2f10437c3641527ed3c594047
2024-03-06 15:06:05 -08:00
Ats Jenk 77b6225d91 Animate bubble bar location changes
When it is not the initial bubble data, animate bubble bar location
change.

Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual, move expanded view from one side to the other, observe the
  location change animates

Change-Id: I52117a31d02e7160ca1d3dc3e724bda2e38f6cbf
2024-03-06 15:03:57 -08:00
Ats Jenk cd0f35383f Introduce bubble bar location that is driven by shell
Adds bubble bar location to the update object that is sent by shell.
Allows repositioning the bubble bar if the location changes.

Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT

Test: manually sending the update to reposition, dragging coming soon
Change-Id: Id430a98116d860a7badcf607edc166c751e12cf8
2024-03-06 10:17:11 -08:00