Commit Graph

20478 Commits

Author SHA1 Message Date
Tony Wickham 737d67fa0f TaskView controls currently drawn insets and radius
Previously this was controlled by TaskThumbnailView. Having TaskView
handle it allows it to update its outline provider to match the
thumbnail when setting fullscreen progress.

Bug: 129883568
Change-Id: I067fcdd31676af4d4792d18eaaac031c2ac0b18a
2019-04-30 20:26:50 -07:00
Jon Miranda 361ccf3490 Fix RTL bug when swiping up to home.
When you switch to RTL when an app is open, we try to use the BubbleTextView
that is no longer attached on the animation back to home. This causes the
item location to return the wrong values (since now the view doesn't have
valid padding/width we can use). In this case, we'll use the fallback
animation.

Bug: 131242470
Change-Id: I0ce27ee10bd6402cc6b2065813b034fc04592622
2019-04-30 14:04:16 -07:00
TreeHugger Robot 943ce93bd5 Merge "Enabling quick-switch gesture in landscape mode (2 button UI)" into ub-launcher3-qt-dev 2019-04-30 19:29:14 +00:00
Sunny Goyal 27283f7ea8 Setting predition enabled/disabled state based on callbacks from the service
> If no callback is received within a timeout, it is set to disabled

Bug: 131188880
Change-Id: Ie6022b190a2504739f1569a500d6f5cc1566d373
2019-04-30 12:06:25 -07:00
Jon Miranda 063211f620 Fix app open animation in landscape.
Bug: 130828765
Change-Id: Ic447d05a8fe2097a6afd0bfec73039a62bbf5a4b
2019-04-30 12:03:39 -07:00
Winson Chung e6ef8dac28 Removing screen pinning flag check
- The flag may be inaccurate, revert to the activity manager check
  for now

Bug: 131552865
Test: Manual
Change-Id: If7c00ba7a1cbb726dcd65993451e82d76778fd4b
2019-04-30 18:19:24 +00:00
TreeHugger Robot 287f5d5aef Merge "Fix some MW visual issues" into ub-launcher3-qt-dev 2019-04-30 16:48:43 +00:00
Winson Chung 8d86cf0bcc Fix some MW visual issues
- Ensure that we don't apply apply crop from device coordinates (reset to
  surface coordinates)
- Disable rounded window corners in MW

Bug: 128364741

Change-Id: Ia91500ca97b44537829983945cd3d3cc82747aeb
2019-04-30 09:35:22 -07:00
TreeHugger Robot 32d475bca4 Merge "Add null check before removing live tile overlay" into ub-launcher3-qt-dev 2019-04-30 01:22:32 +00:00
Vadim Tryshev 9736474072 Merge "Disabling fallback overview tests until the bug is fixed" into ub-launcher3-qt-dev 2019-04-30 01:10:51 +00:00
Tony Wickham de68f8097c Add null check before removing live tile overlay
Bug: 131630813
Change-Id: I6d2c39c61aa918b11dd3d15703fe6ca52c19778d
2019-04-30 00:31:38 +00:00
vadimt de84db9890 Disabling fallback overview tests until the bug is fixed
Please reenable once fixed.

Bug: 131630813
Change-Id: Idb6f59c5e785180c96fce10365a2b070558abcdd
2019-04-29 16:28:29 -07:00
Vadim Tryshev 203dde3999 Merge "Disabling AppPredictionsUITests" into ub-launcher3-qt-dev 2019-04-29 23:03:17 +00:00
TreeHugger Robot c6e7a38fb6 Merge "Adding support for accessibiliy gesture" into ub-launcher3-qt-dev 2019-04-29 21:54:41 +00:00
Sunny Goyal 4580149897 Adding support for accessibiliy gesture
Bug: 130905838
Change-Id: If796b6e6036c2f216abf87386d8eebcaa6368d02
2019-04-29 14:40:41 -07:00
Sunny Goyal 2acea9f872 Enabling quick-switch gesture in landscape mode (2 button UI)
Bug: 130689544
Change-Id: I6b424be4d80b3bf8263f456a024a81c63100030e
2019-04-29 14:33:56 -07:00
Sunny Goyal 0382dd76e8 Releasing SurfaceControl when they are no longer needed
Bug: 123874711
Change-Id: I9c06723a3e5d4a23b8a6c60352806bb12daba598
2019-04-29 12:04:11 -07:00
TreeHugger Robot 34c630bf14 Merge "Updating the touch proxy logic:" into ub-launcher3-qt-dev 2019-04-29 16:27:03 +00:00
TreeHugger Robot 308f356eb4 Merge "Reset the task's curve scale prior to calculating the recents view scale" into ub-launcher3-qt-dev 2019-04-27 00:07:30 +00:00
Winson Chung 8153b69da8 Reset the task's curve scale prior to calculating the recents view scale
Bug: 131436393
Test: Swipe to next task, before it can settle, touch and start quick
      switching again

Change-Id: I568ec059be4c5c2f8c663980da0931c01d784f1f
2019-04-26 16:45:33 -07:00
vadimt 1d20590310 Disabling AppPredictionsUITests
Also I recommend not using TAPL here, but follow this:
https://docs.google.com/presentation/d/1jyS_AIqevT22mk3SpfFS6paW98QLoJ_Fu7DgpXIgZ2g/edit#slide=id.g3f7630d0d8_0_9
https://docs.google.com/presentation/d/1jyS_AIqevT22mk3SpfFS6paW98QLoJ_Fu7DgpXIgZ2g/edit#slide=id.g435cf3d76d_1_113

Bug: 131188880
Change-Id: Ib01197acbe3ea68e27f121b1c6d8304bbff9696f
2019-04-26 14:12:29 -07:00
vadimt 9565c2a071 Running tests only in 1 nav mode
Pixel1: 3-button
Pixel2: 2-button
Pixel3: 0-button

This is a temporary workaround for the listed bugs.

Bug: 130558787
Bug: 131419978
Change-Id: Ic57422c7ca8e9985fc0613239c803149e66d907f
2019-04-26 13:22:28 -07:00
Vadim Tryshev 6f09dd61af Merge "Temporarily disabling 3-button testing mode" into ub-launcher3-qt-dev 2019-04-26 19:00:45 +00:00
Matthew Ng cd5ed8b28f Merging ub-launcher3-qt-dev, build 5508646
Test: Manual

Bug:112934365 [STOP SHIP BUG] Sysui Navigation Bar Prototype Tracking Bug:114136250 Have a more spartan RecentsActivity on android go Bug:118758133 Add logging to track undo box usage Bug:119992316 Widget screen won't close when tapping back or home button Bug:128857973 With dark display and black accent device theme, App list header not visible on all apps screen. Bug:129279637 [Logging] Long press|tap on app icon from Task should be logged Bug:129497226 Remove setInteractionState from the contract Bug:129723135 Broken tests: swipe from killed launcher doesn't open overview Bug:129806241 [a11y][Qt] Remove an app icon in Home screen, the popup "Item removed" with UNDO doesn't follow the settings of Time to take action. Bug:129985827 [Fully Gestural Navigation] Delay Recents animation when swiping up Bug:130851537 Recents and notification shelf both became nonresponsive after I "palmed" the screen while it was on. Bug:131095241 Recents Go should support landscape app => landscape thumbnail transition Bug:131303610 Backedup shortcut icons are not badged Bug:131339235 Don't layout empty task views if we have the real content Bug:131364673 [Failing test] FallbackRecentsTest
Change-Id: I04018e14bd6d9ba77005e72fe20f4a3ede886abf
2019-04-26 11:59:39 -07:00
vadimt 042f2e33fb Temporarily disabling 3-button testing mode
Bug: 131419978
Change-Id: I9a817140ee5e0fb8d40da67759399f85b0625da0
2019-04-26 11:44:52 -07:00
Sunny Goyal bfaa9760dd Updating the touch proxy logic:
In draglayer, we always dispatch touch events to child views. If the
touch originated from gesture area, when we dont route it through touch
controllers.
The proxy events are only send to touch controller. If any controller consumes
the event, then we cancel the view touch (pilferPointers)

This allows the controllers to work outside the dragView area, and prevents normal
view interaction when there is a window on top (like keyboard) while keeping our
activity focused

Bug: 131088901
Bug: 130618737
Change-Id: If033dde3a0f9cb6a6e449c9586c1fa050af5bdcb
2019-04-26 11:08:42 -07:00
Matthew Ng 06e0d80d15 Added back code removed earlier from OverviewInterationState
Change: ag/7199900

Test: manual
Fixes: 129497226
Change-Id: Ibf0b1d4ade8ef5a2f0ceb545df505e9de419ec50
(cherry picked from commit cad531248e)
2019-04-26 18:00:12 +00:00
Vadim Tryshev 8bb8e56580 Merge "Set portrait orientation for FallbackRecentsTest" into ub-launcher3-qt-dev 2019-04-26 01:11:43 +00:00
vadimt dd4d390f38 Set portrait orientation for FallbackRecentsTest
Bug: 131364673
Change-Id: I77f3058e09eadc5bcbfe48c768f78883082a526d
2019-04-25 17:53:26 -07:00
Vadim Tryshev f099fb45b8 Merge "Annotating DigitalWellBeingToastTest so that it actually runs in lab :)" into ub-launcher3-qt-dev 2019-04-26 00:44:04 +00:00
vadimt 55fa21eb95 Annotating DigitalWellBeingToastTest so that it actually runs in lab :)
And starting a test app :)))))

Change-Id: I3b326a40651b0e4293dee26e4ef5f991cd7b7d0d
2019-04-25 17:34:23 -07:00
Tony Wickham 0cc53e7f6a Merge "Decouple recents view from window while swiping up" into ub-launcher3-qt-dev 2019-04-26 00:10:34 +00:00
TreeHugger Robot 529bff9a66 Merge "Remove interaction flag code replaced by QuickStepContract (1/2)" into ub-launcher3-qt-dev 2019-04-25 23:36:23 +00:00
TreeHugger Robot 3c007368a7 Merge "Cleanup unnecessary override dump method" into ub-launcher3-qt-dev 2019-04-25 23:22:04 +00:00
Hyunyoung Song 9e7d2acc22 Cleanup unnecessary override dump method
Change-Id: Ic2909a4d382362ddec9bcc2c738d13120e792fd8
2019-04-25 16:08:52 -07:00
Matthew Ng b60dce7268 Remove interaction flag code replaced by QuickStepContract (1/2)
Test: manual
Bug: 112934365
Fixes: 129497226
Change-Id: Id128eee4eaa620f0b9c461ef5adf0a16e9ea9a2c
2019-04-25 23:01:12 +00:00
Hyunyoung Song efe8475093 Merge "Add important dump logging Bug: 130851537 Bug: 119992316" into ub-launcher3-qt-dev 2019-04-25 22:33:31 +00:00
Hyunyoung Song a310a80c7b Add important dump logging
Bug: 130851537
Bug: 119992316

Change-Id: I3de7c1d910d1aecd80b47a85284565c79fe0e2cc
2019-04-25 15:14:44 -07:00
Hyunyoung Song 1e4a43ac67 Merge "Add logging for Task Icon interaction" into ub-launcher3-qt-dev 2019-04-25 20:30:43 +00:00
vadimt ab03a7eb19 Enable testStressSwipeToOverview()
Underlying issue has been fixed.

Bug: 129723135
Change-Id: I336de8bb38360ee83023caa17bc90a601db3b9e2
2019-04-25 11:57:41 -07:00
Hyunyoung Song fd94cd5498 Add logging for Task Icon interaction
Bug: 129279637
Change-Id: I135bad16015129b3b60bb13e86783d623e504b1b
2019-04-25 11:56:04 -07:00
Tony Wickham 2a3c936440 Merge "Call initTransitionEndpoints in constructor" into ub-launcher3-qt-dev 2019-04-25 18:46:45 +00:00
Winson Chung d4e8bdbc62 Merging ub-launcher3-qt-dev, build 5505393
Test: Manual
Bug:111411630 Dark theme popup blends in with the normal background
Bug:113952590 [STOP SHIP BUG] WM Experiment: Slim the navigation bar
Bug:114136250 Have a more spartan RecentsActivity on android go
Bug:117106893 Enable all @Ignore-d Launcher tests
Bug:118678948 A11Y: TalkBack: After adding shortcut app icon on the homescreen, sometimes shortcuts app icons are not accessible with TalkBack.
Bug:122700646 Launcher crashed after uninstalling app
Bug:123985787 Respect dialogCornerRadius for all apps / widgets / settings / shortcut menu / dwb / task / overview (everything)
Bug:126229665 Launcher home screen should properly use Headline/ body font
Bug:126450861 Tab structure update and tips for Theme Picker
Bug:126587956 Create an app to use with Launcher testing
Bug:126596502 [touchflow] Use platform long press in launcher
Bug:126738409 Icon packs for launcher
Bug:126822309 Launcher > Overview > "No recent item" is not using theme font
Bug:127689526 [icons] hourglass_bottom and hourglass_top
Bug:127840207 [logging] quickswitch usage
Bug:128531133 Make TAPL diagnostics clearer
Bug:128649657 Define overlayable.xml for icon packs
Bug:128808922 [QT-QP1A] Click to change orientation in GCA secure mode will lead to unlock screen.
Bug:128857973 With dark display and black accent device theme, App list header not visible on all apps screen.
Bug:129145824 When predictions are disabled, the hotseat does not appear in quickstep
Bug:129146717 Do not allow overlays to change attribute format
Bug:129297464 [Gesture Nav] Exclude edges from most Launcher / Overview states.
Bug:129328259 [Regression] Suspended app icons turn full colour during open animation
Bug:129421279 FloatingIconView should be removed when user interacts with launcher
Bug:129434166 Lab-only flake: drag to workspace doesn't happen
Bug:129785904 [Gesture Nav] Verify that gestures are disabled appropriately in transient states
Bug:129955150 Launcher settings' icon is not using consistent grey
Bug:129985827 [Fully Gestural Navigation] Delay Recents animation when swiping up
Bug:130053407 [Tests broken] testLearn: settings is not present in the prediction row
Bug:130160876 Full gesture navigation with fast switcher shows part of "clear all" message
Bug:130415177 Launcher displays app as suspended when it is not if setPackagesSuspended is called multiple times
Bug:130440957 Recents Go view visibility not updating while loading UI is up
Bug:130442915 Jank observed while navigating from long press app shortcut.
Bug:130562632 DefaultLayoutProviderTest.testCustomProfileLoaded_with_folder is flaking
Bug:130580680 Recents Go does not load views right after boot
Bug:130635650 Recents Go thumbnails not updating on app => recents transition
Bug:130735711 Should fix overview shortcut in Recents Go landscape mode
Bug:130739123 Tests failure: Attempt to invoke virtual method 'int com.android.launcher3.views.BaseDragLayer.getChildCount()' on a null object reference
Bug:130740246 Recents Go crashes from ViewTreeObserver being dead
Bug:130746661 Fix NPE for getting task from loading task UI in Recents Go
Bug:130820737 Recents Go remove animation doesn't always work
Bug:130914022 Add a test for DWB toast
Bug:130917995 onConfigChanged when apps are auto installed
Bug:131095241 Recents Go should support landscape app => landscape thumbnail transition
Bug:131102753 crosshatch_svelte doesn't boot on ToT master on 4/22 because of FATAL exception in launcher3
Bug:131170582 [Flaky test] TaplTestsLauncher3.testDragShortcut
Bug:131250710 ControlType.CLEAL_ALL_BUTTON logging is gone
Bug:78240090 (Quickstep) Swiping down on the shelf while scrolling carousel
Change-Id: I4ef9beb24fab6be4fcff44b330e30d486fc01f03
2019-04-25 10:02:23 -07:00
TreeHugger Robot 1c9d3974b5 Merge "Re-adding clear-all button logging" into ub-launcher3-qt-dev 2019-04-25 01:50:42 +00:00
Tony Wickham 4f24370f72 Pass correct value to updatePaused() in setDisallowPause()
Change-Id: Iabc3a3aac85bcf426ab18437e006cc95fa89fbc0
2019-04-24 18:20:23 -07:00
vadimt 325a48b01a Re-adding clear-all button logging
Bug: 131250710
Change-Id: If31a84bf6db37b295fc0e2c4d8db8ed4b7baa037
2019-04-24 17:50:29 -07:00
Tony 5c13972e11 Decouple recents view from window while swiping up
Add setRecentsAttachedToWindow(boolean attached, boolean animate) with
the following conditions:

Conditions for attached
- Motion is paused and shelf is peeking
- xDisplacement > yDisplacement (to ensure seamless quick switch)
- We are continuing the previous quick switch gesture
- Gesture has ended and endTarget is RECENTS or NEW_TASK

Conditions for animate
- Recents is visible. Since the running task is invisible, this is
  true if either an adjacent TaskView is visible, or if we’re
  continuing the previous gesture

Currently the attach/detatch animation is just fading recents in/out.

Test:
- Swipe up to go home does not show the recents list at all. Instead,
  all the visuals/motion focus on the app window animating into the
  home screen.
- Recents appears when swiping and holding, to indicate that letting
  go will land in recents. The shelf also appears with haptic feedback
  in this case to reinforce this.
- The next task is immediately visible when quick switching (swiping
  left to right on the nav bar).

Bug: 129985827
Change-Id: Ib0c16f583bfd5b02d2f9f68c9688edc980a39d75
2019-04-24 17:36:42 -07:00
Tony Wickham d0d39f1769 Merge "Move logic that overrides MotionPauseDetector to callers" into ub-launcher3-qt-dev 2019-04-25 00:34:47 +00:00
TreeHugger Robot 23060080fe Merge "Hide Clear all button during quick switch" into ub-launcher3-qt-dev 2019-04-25 00:19:34 +00:00
Tony Wickham 5e58b447b0 Call initTransitionEndpoints in constructor
Before, the soonest we initTransitionEndpoints() is in
onRecentsAnimationStart(), which might be too late if launcher was
killed. (In that case, the gesture might end before we ever get
onRecentsAnimationStart(), and thus will never consider the distance
traveled great enough to trigger recents since we don't have endpoints.)

Bug: 129723135
Change-Id: I349f62244aaba8369926b14f90acd994fd40a93a
2019-04-24 17:19:07 -07:00