Commit Graph

20478 Commits

Author SHA1 Message Date
Sunny Goyal c302baced0 Notifying the geature guide app when back gesture is performed
so that user onboarding can the updated accordingly

Bug: 138403212
Change-Id: Ib4e1cde0b2c746f955d5a58251c8ab653dadbc67
2019-07-29 11:55:11 -07:00
TreeHugger Robot c5b8e77a80 Merge "Separating apps list callback from model callback and simplifying various events" into ub-launcher3-master 2019-07-29 16:56:35 +00:00
Winson Chung 7404f35490 Updating to use deferred cancel api am: fa652a8a4f
am: c0974870e4

Change-Id: Ifcab654d42c286c6d7288d219d2ad7b06cd249d5
2019-07-28 12:14:00 -07:00
Winson Chung fa652a8a4f Updating to use deferred cancel api
- Also updating the sysui flag to home's flags when passing some
  threshold
- Also ensure we don't allow swipe up when QS is open

Bug: 137196872
Bug: 135969043
Change-Id: I476eee7f02ae86aa795fceabb304bcaa7416ef9c
2019-07-27 10:08:52 -07:00
Adam Cohen 574d6c152c Merging ub-launcher3-qt-r1-dev, build 5758528
Test: Manual

Bug:128940249 P2 Investigate performance options for 90Hz when swiping to -1
Bug:134074554 P2 Enable test testPressHomeOnAllAppsContextMenu()
Bug:134181439 P3 Missing drag down gesture to open shade while in landscape
Bug:134981174 P1 [Google] Search bar disappears from home screen
Bug:136800511 P1 Brightness shifts when swipe up + hold to recents
Bug:137137090 P2 Improve swipe down noti shade (landscape, logging) and other swipe up home gesture logging
Bug:138025252 P4 Pixel Launcher keeps stopping when changing system language
Bug:138144992 P4 NullPointer in TouchInteractionService.dump
Bug:138227387 P1 Remove 2-button option where not appropriate
Bug:138245847 P4 On a third party wallpaper, long press not highlighting home screen folder name.
Bug:138251824 P1 Flake: want to switch from background to overview; Swipe failed to receive an event for the swipe end
Bug:138401738 P1 Master: java.lang.AssertionError: Navigation mode didn't change to TWO_BUTTON
Change-Id: Ib66a27de5515957a42d0791b76dfca8ed7b248d7
2019-07-26 22:08:16 +00:00
Vinit Nayak a04997b081 Use new onTaskListUpdated() callback
Migrated to general method for receiving updates
whenever the recents list undergoes any additions or
removals.

Test: Opened apps, and as I closed them I ensured
via debugger and log statements that the callback was
being triggered from the framework module. See
tests in RecentTasksTest

fixes: 111077107
Change-Id: Ia9bddb50861a1b107e6a88c9f9bb89944800d5d8
2019-07-26 12:19:57 -07:00
Winson Chung 3874e556a5 Merge "Fix NPE in service dump" into ub-launcher3-qt-r1-dev am: 1d3d19f2e1
am: a7d12b227f

Change-Id: Ic97e416874c2989ab293b69d54190a02f281a043
2019-07-26 10:09:45 -07:00
Winson Chung 1d3d19f2e1 Merge "Fix NPE in service dump" into ub-launcher3-qt-r1-dev 2019-07-26 16:46:35 +00:00
Winson Chung 02a9aec015 Skip tests for overlays that don't exist on device am: 0ef10a458d
am: 6439337cee

Change-Id: I14243ecbda7ade7c1e7db9794bc22a533cc6dd73
2019-07-25 18:01:03 -07:00
vadimt da0d8de65e More diags in TouchInteractionService am: f88d0b5a8a
am: 808b788c14

Change-Id: I8a1acb9d42bab44ba0a866394b63bcb3acdcbadd
2019-07-25 18:00:46 -07:00
Tony Wickham efa4a48231 Merge "Fix incorrect task index bounds" into ub-launcher3-qt-r1-dev am: 3bbb20262b
am: cc740c8932

Change-Id: I14cbb1dd9e0e6366e13d1f62575d162eb6c4adb3
2019-07-25 18:00:16 -07:00
Winson Chung 0ef10a458d Skip tests for overlays that don't exist on device
Bug: 138401738
Bug: 138227387
Change-Id: If661fd342e1382915485bccdf6ae2c9e77a92bc4
2019-07-26 00:09:43 +00:00
vadimt f88d0b5a8a More diags in TouchInteractionService
Bug: 138251824
Change-Id: I0909a2c85b1b2bdd8b67da59c978d6a3bbb58ee5
2019-07-25 16:38:39 -07:00
TreeHugger Robot 3bbb20262b Merge "Fix incorrect task index bounds" into ub-launcher3-qt-r1-dev 2019-07-25 23:17:21 +00:00
Winson Chung 5089140cda Fix NPE in service dump
Bug: 138144992
Change-Id: I608ea209b04fce13a63190ec424849dc909a6a9a
2019-07-25 15:22:47 -07:00
Hyunyoung Song c37af4325f Merge "Add several missing swipe logging Enable swipe down to open noti shade from landscape" into ub-launcher3-qt-r1-dev
am: 2cccb134a4

Change-Id: I6fd477dc398e55358a5110a552430eb61c29373d
2019-07-25 15:14:33 -07:00
TreeHugger Robot 2cccb134a4 Merge "Add several missing swipe logging Enable swipe down to open noti shade from landscape" into ub-launcher3-qt-r1-dev 2019-07-25 21:55:16 +00:00
James O'Leary b1d239405f Merge "Fix QSB becoming invisible" into ub-launcher3-qt-r1-dev
am: 93dceb8a48

Change-Id: Id0a72f39d828535f177992fdf2c674cc84c5a629
2019-07-25 13:57:54 -07:00
James O'Leary 93dceb8a48 Merge "Fix QSB becoming invisible" into ub-launcher3-qt-r1-dev 2019-07-25 20:41:34 +00:00
Hyunyoung Song e299a45944 Add several missing swipe logging
Enable swipe down to open noti shade from landscape

Bug: 137137090
Bug: 137954767
Bug: 134181439

Change-Id: I47b4d17c9ae0586565fce101eb478e33ed8f7e3d
2019-07-25 13:18:48 -07:00
Vadim Tryshev 46d0c36cc6 Merge "NavigationModeSwitchRule: log exception before 'finally'" into ub-launcher3-qt-r1-dev
am: 2870df0776

Change-Id: I37cbd53aaa575915374e41d9535a6d7cf21b72d2
2019-07-25 13:11:45 -07:00
Vadim Tryshev 2870df0776 Merge "NavigationModeSwitchRule: log exception before 'finally'" into ub-launcher3-qt-r1-dev 2019-07-25 19:47:42 +00:00
Tony Wickham 2b365ae7f0 Fix incorrect task index bounds
Should have been using min, not max. Added lower bound for good measure.

Bug: 138025252
Change-Id: Icd8c7d62dca7605fe63e83602e4c9fceb91f68a6
2019-07-25 12:27:29 -07:00
vadimt 7593dc995b NavigationModeSwitchRule: log exception before 'finally'
Change-Id: I158105da467e2759fec6fa5d8acd582b2e95f7c5
2019-07-25 12:16:31 -07:00
Sunny Goyal 87dcde6d6c Separating apps list callback from model callback and simplifying various events
Bug: 137568159
Change-Id: I4d8bb5c01cabe642731ebd3f57fe15bdc5a569b7
2019-07-25 11:29:16 -07:00
James O'Leary 74ece6b021 Fix QSB becoming invisible
This could not be reproduced until I removed a line that wouldn't call
onAssistantVisiblityChanged if the argument was the same value as the
argument as the previous call.

After that, the bug became readily reproducible. I traced through
Launcher till I found that FallbackActivityControllerHelper
.onAssistantVisibilityChanged was being called while the screen was
locked, proving that onAssistantVisiblityChanged was _not_ reaching
launcher.

Test: Verify bug no longer reproduces.
Bug: 134981174
Bug: 135247753
Bug: 135572849
Bug: 135733393
Bug: 136386749
Bug: 136776987
Bug: 137534772
Bug: 137764419

Change-Id: Ib5e8df3b5030a77c5df351a1fcd993db6bd602fc
2019-07-25 10:22:02 -04:00
Jon Miranda b6ce5eb1de Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev
am: 95bc50fafa

Change-Id: Ia00ea7d1298a6f46c1ff779f13a3bf015ec5cd8a
2019-07-24 19:16:18 -07:00
Tony Wickham 503575a9e4 Merge "Distinguish mDragHandleProgress from mMidProgress" into ub-launcher3-qt-r1-dev
am: cfbdb91a7f

Change-Id: Id41c02c6543a4b0a12fc364e5c8e41dd6ccf9fc1
2019-07-24 12:57:34 -07:00
Sunny Goyal 6d9eed757f Merge "Using the first frame delay based on the display refresh rate instead of hardcoding it to 16ms" into ub-launcher3-qt-r1-dev
am: b7094fcf36

Change-Id: Icd4e52b33b33718cb91b2fd082d85637e820390f
2019-07-24 12:57:15 -07:00
Tony Wickham cfbdb91a7f Merge "Distinguish mDragHandleProgress from mMidProgress" into ub-launcher3-qt-r1-dev 2019-07-24 19:39:48 +00:00
TreeHugger Robot b7094fcf36 Merge "Using the first frame delay based on the display refresh rate instead of hardcoding it to 16ms" into ub-launcher3-qt-r1-dev 2019-07-24 19:32:17 +00:00
Jon Miranda e734efba8d Fix bug where rounded corners were being set despite being disabled.
Bug: 138117089
Change-Id: Icb852e2e07d80c45ad3406ef432b89720887fccf
2019-07-24 17:15:13 +00:00
Sunny Goyal 4e6c45bcd3 Using the first frame delay based on the display refresh rate instead of
hardcoding it to 16ms

> Creating a utility class for caching display property changes

Bug: 128940249
Change-Id: I6f9a214548de65bd1c8530508d665ee88312da4a
2019-07-24 10:12:37 -07:00
Winson Chung 3fc9a1cf69 Merging ub-launcher3-qt-r1-dev, build 5749827
Test: Manual

Bug:136282913 P1 Swipe up from Assistant Fulfillment Card Jank
Bug:137129923 P1 Pixel launcher is leaking memory
Bug:137161198 P1 Unable to pull notification panel down with a swipe on home screen
Bug:137253043 P1 "Pixel Launcher keeps stopping" when scrolling through recent apps
Bug:137487381 P1 Overview goes back to fullscreen when swiping up during transition
Bug:137836033 P4 Fail to stop music due to "Swipe failed to receive an event for the swipe end"
Bug:138152531 P2 [Android Q][04713598] Launcher test cases are failed
Bug:138236583 P1 Icon scale is wrong when dragging from all apps or folders
Bug:138251824 P1 Flake: want to switch from background to overview; Swipe failed to receive an event for the swipe end
Bug:138252347 P1 qt-r1-dev Pixel Launcher flag ENABLE_HINTS_IN_OVERVIEW is Disable by Default
Change-Id: Idd0e987d26e1ffc75cdb9f90e9c08c26bb8c6503
2019-07-23 20:54:13 -07:00
Winson Chung 73b4cf7bb2 Merge "Fix regression in assistant window handling" into ub-launcher3-qt-r1-dev
am: 0727d59576

Change-Id: I9fbde5b101705ad9254a6ba668ff079a4f15c41f
2019-07-23 17:29:14 -07:00
vadimt 443f05052c Merge "Adding debug tracing" into ub-launcher3-qt-r1-dev
am: 8578309f1b

Change-Id: If2f3b4d4a849e94449c4b06a567c12610547fc61
2019-07-23 17:28:32 -07:00
Winson Chung 0727d59576 Merge "Fix regression in assistant window handling" into ub-launcher3-qt-r1-dev 2019-07-24 00:12:28 +00:00
TreeHugger Robot 8578309f1b Merge "Adding debug tracing" into ub-launcher3-qt-r1-dev 2019-07-24 00:01:25 +00:00
Tony Wickham fbd77c48cc Distinguish mDragHandleProgress from mMidProgress
mMidProgress is intended to be the point at which we reach Overview when
swiping up and thus start scrimming it as All Apps shows above it. For
that reason, mMidProgress needs to match OverviewState's progress. In
contrast, the drag handle (accessibility arrow) can move up sooner to
avoid overlapping with the QSB; for this, we added mDragHandleProgress.

Bug: 136800511
Change-Id: I2825ff798707530420855257350e492b4b9b77dc
2019-07-23 16:58:45 -07:00
vadimt cd7b00853b Adding debug tracing
Bug: 138251824
Change-Id: Ibe3de964aeacbf83fd46cc53fda7d15c9401fe4d
2019-07-23 16:49:48 -07:00
Winson Chung 48ba8c864c Fix regression in assistant window handling
- Skip the assistant as the running task when handling swipe up
- Also ensure that we fall into the overview input consumer if we are
  swiping it from the assistant over home
- Skip accounting for the scroll offset when there is no running task

Bug: 136282913
Change-Id: I28e45e407702d6d6aebaa0232cd96ccb10047644
2019-07-23 16:25:46 -07:00
Zak Cohen 344bc96ae1 Merge "TaskView - add a getter for the bitmap data." into ub-launcher3-qt-r1-dev
am: 87477f5996

Change-Id: Id798408bcbf5a9ad10a58b6987a970b6c5ed28b8
2019-07-23 16:13:16 -07:00
Zak Cohen 87477f5996 Merge "TaskView - add a getter for the bitmap data." into ub-launcher3-qt-r1-dev 2019-07-23 22:51:28 +00:00
Jon Miranda 9566a04400 Fix bug where rounded corners were being set despite being disabled.
Bug: 138117089
Change-Id: Icb852e2e07d80c45ad3406ef432b89720887fccf
2019-07-23 22:24:35 +00:00
Vinit Nayak 15abc500ea Refactor RecentTasksList ctor to be testable
Made ctor accept more arguments so we can
pass in mock objects for unit testing.

Test: Created RecentsTasksListTest.java, passes
adb shell am instrument -w -r -e debug false -e \
class 'com.android.quickstep.RecentTasksListTest' \
com.google.android.apps.nexuslauncher.tests/androidx.test.runner.AndroidJUnitRunner

Fixes: 135687618
Change-Id: Iffda661e9d5329a2a403060bde674ab81e4e720e
2019-07-23 11:49:19 -07:00
Tony Wickham f05d3f8fd4 Revert the changes that prevented touch on RecentsView during animation
am: b6841ac630

Change-Id: Ia0c9ec7a600e5d3064297630d16eb862d486bf45
2019-07-22 15:57:55 -07:00
Tony Wickham b6841ac630 Revert the changes that prevented touch on RecentsView during animation
The original bug that was solving seems to be fixed by other changes,
and this allows users to scroll, dismiss, etc on recent tasks before
fully reaching overview from an app.

Bug: 137487381
Change-Id: I28a708811bba3ce739ce261f19eb29558d8f0e7d
2019-07-22 12:39:59 -07:00
Tony Wickham d9515f72f5 Finish recents animation when touching during animation to recents
am: 3fca6aaec2

Change-Id: Ibb855543b828a47f110275343d7b18b771c583bd
2019-07-22 11:57:51 -07:00
Tony Wickham 3fca6aaec2 Finish recents animation when touching during animation to recents
This regressed in ag/8542000, where we cancel the animation instead of
ending it. We should only cancel when going to home; in other cases, we
should still call end().

Bug: 137487381
Change-Id: I093954908c3ac747ec3132aa700c8be2f927631a
2019-07-19 16:53:00 -07:00
Zak Cohen bc4d213535 TaskView - add a getter for the bitmap data.
This allows other components to get it directly from the view, rather
than retaining their own copy.

Bug: 137129923
Tested: Manual

Change-Id: Ibab307517c31cd3cb59b4d77ff390fd97546e86d
2019-07-19 15:14:53 -07:00