Commit Graph

20478 Commits

Author SHA1 Message Date
Tony Wickham 5c229885fc Merge "Don't crash when swiping up if there are no TaskViews" into ub-launcher3-qt-qpr1-dev 2019-09-20 22:44:28 +00:00
TreeHugger Robot 25986ffd64 Merge "Adding test to check view inflation during swipe up" into ub-launcher3-master 2019-09-20 22:44:01 +00:00
Sunny Goyal 8f90d5da8a Adding test to check view inflation during swipe up
Bug: 137851409
Change-Id: Ic8e6f0b3c667051b921d1d4fad03c94122ee92e9
2019-09-20 15:36:02 -07:00
Winson Chung 1b231ecc56 Updating launcher interface for recents animation change
Bug: 140626334
Change-Id: Ib8e837c157bb99db429b7936fdf111e05170ac25
2019-09-20 15:15:43 -07:00
Tony Wickham 60bf8c117b Don't crash when swiping up if there are no TaskViews
This can happen in LockTask mode, after enabling Overview. In that case,
you are locked to the current task, but are allowed to go to overview
but no tasks are shown there.

Bug: 139917483
Change-Id: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
Merged-In: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
2019-09-20 22:01:18 +00:00
Tony Wickham 9e88a6d8be Don't crash when swiping up if there are no TaskViews
This can happen in LockTask mode, after enabling Overview. In that case,
you are locked to the current task, but are allowed to go to overview
but no tasks are shown there.

Bug: 139917483
Change-Id: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
2019-09-20 21:58:30 +00:00
TreeHugger Robot 3a5d7cca9e Merge "Updating animation start callback" into ub-launcher3-master 2019-09-20 21:31:20 +00:00
Becky Qiu 4df06903bc Fill in LauncherTarget fields with values extracted from LauncherLogProto.Target.
Test: manual
Bug: 137777105

Log result:
1. Swipe to -1:
  data {
    elapsed_timestamp_nanos: 1372265229686264
    atom {
      launcher_event {
        action: SWIPE_LEFT
        src_state: HOME
        dst_state: HOME
        extension {
          src_target {
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
2. Swipe out of -1:
  data {
    elapsed_timestamp_nanos: 1372368006970305
    atom {
      launcher_event {
        action: SWIPE_RIGHT
        src_state: HOME
        dst_state: HOME
        extension {
          src_target {
            page_id: -1
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
3. Launch app from homescreen:
  data {
    elapsed_timestamp_nanos: 1372397640628726
    atom {
      launcher_event {
        action: LAUNCH_APP
        src_state: HOME
        dst_state: BACKGROUND
        extension {
          src_target {
            item: APP_ICON
            grid_x: 2
            grid_y: 1
          }
          src_target {
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
4. Launch app from hotseat:
  data {
    elapsed_timestamp_nanos: 1372399813031963
    atom {
      launcher_event {
        action: LAUNCH_APP
        src_state: HOME
        dst_state: BACKGROUND
        extension {
          src_target {
            item: APP_ICON
            grid_x: 2
          }
          src_target {
            container: HOTSEAT
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
5. Launch app from allapps prediction:
  data {
    elapsed_timestamp_nanos: 1372403080724736
    atom {
      launcher_event {
        action: LAUNCH_APP
        src_state: ALLAPPS
        dst_state: BACKGROUND
        extension {
          src_target {
            item: APP_ICON
          }
          src_target {
            container: PREDICTION
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }

Change-Id: I981401d06577c15948cfee0062b8a6f8a5594345
2019-09-20 21:26:59 +00:00
TreeHugger Robot 8fbbbe0687 Merge "Fixing some tests for 2-button mode" into ub-launcher3-master 2019-09-20 17:54:25 +00:00
Winson Chung f779e78789 Updating animation start callback
Bug: 140626334
Test: Builds
Change-Id: I86e8d448188d21f0318ac2ea053a8394a1d0cf1a
2019-09-20 17:40:17 +00:00
Sunny Goyal 3d56046ff8 Fixing some tests for 2-button mode
Bug: 141315387
Change-Id: I66db3e790f5fbe6bc30999ed599cce03874509be
2019-09-20 10:40:14 -07:00
Winson Chung c1f89d921a Updating animation start callback
Bug: 140626334
Test: Builds
Change-Id: I86e8d448188d21f0318ac2ea053a8394a1d0cf1a
2019-09-20 10:39:08 -07:00
Sunny Goyal eb71cef629 Playing wallpaper animation if Launcher is destroyed
Bug: 140539007
Change-Id: I6573eafda353f4f399768613ef068de86c8f37f4
2019-09-20 09:53:47 -07:00
vadimt 151fddfb71 Adding tracing for a lab-only flake. am: 9f6cde1443
am: ca939f073c

Change-Id: I5218b4792ca2e37f61ec54a67d7dbb04b1d42872
2019-09-19 17:32:43 -07:00
vadimt ca939f073c Adding tracing for a lab-only flake.
am: 9f6cde1443

Change-Id: I31ce596847aa1506cefbde711ae6ad6f3e3b777e
2019-09-19 17:25:43 -07:00
vadimt 9f6cde1443 Adding tracing for a lab-only flake.
Bug: 141275518
Change-Id: I95544a55ef13002f696a82e52d54ffb6251d0e39
2019-09-19 16:07:05 -07:00
Hyunyoung Song e861391aec Merging ub-launcher3-master, build 5887983
Test: Manual

Bug:113287687 P3 App shortcut overlapping app icon when selecting the app using USB mouse.
Bug:113952590 P2 [STOP SHIP BUG] WM Experiment: Slim the navigation bar
Bug:114136250 P1 Have a more spartan RecentsActivity on android go
Bug:122333437 P2 Mk2bp: packages/apps/Launcher3
Bug:123298377 P4 App shortcut menu does not close after launching from hotseat while that app is in splitscreen
Bug:124817089 P4 Uninstalling an app doesn't remove the icon(s)
Bug:124967099 P2 Support 5 column layout for all apps (independent of what the workspace layout is)
Bug:125027540 P2 Apps to be searchable in different languages
Bug:126587956 P2 Create an app to use with Launcher testing
Bug:127689526 P2 [icons] hourglass_bottom and hourglass_top
Bug:129497226 P2 Remove setInteractionState from the contract
Bug:130225926 P2 Cannot unpin app while in gesture nav
Bug:130272454 P1 [C1/B1] Message app crash when opening a video MMS.
Bug:130440957 P2 Recents Go view visibility not updating while loading UI is up
Bug:130580680 P2 Recents Go does not load views right after boot
Bug:130635650 P2 Recents Go thumbnails not updating on app => recents transition
Bug:130740246 P2 Recents Go crashes from ViewTreeObserver being dead
Bug:130746661 P2 Fix NPE for getting task from loading task UI in Recents Go
Bug:130820737 P2 Recents Go remove animation doesn't always work
Bug:131095241 P2 Recents Go should support landscape app => landscape thumbnail transition
Bug:132336512 P2 Notification dots on pinned shortcuts
Bug:132461400 P1 Fatal exceptions in Launcher3
Bug:134712476 P4 Add Duo contact to home screen, icon froze and vanished while over home screen
Bug:135419782 P2 [Q-Preview4] "Freeform" feature on developer options keeps crashing
Bug:135633159 P3 [QPR] Promise icons on home screen
Bug:135684365 P1 Build error when building from Android Studio
Bug:135687618 P4 Task shows between back and swiping up to overview
Bug:135864059 P4 [Live Tiles] Empty launcher
Bug:137200188 P3 Home screen app title disappears during animation
Bug:137404499 P4 Don't persist invalid previews to cache
Bug:137568159 P4 Refactor LauncherCallback to support multiple clients
Bug:137653564 P2 Support Agassi (Search Engine choice) in Android R
Bug:138195597 P2 Wrong icon animated on return to home screen
Bug:139020180 P4 Add a "Dismiss" option for predicted apps in Launcher
Bug:139021165 P2 [TEST TRACKER] [QPR] Promise icons on home screen
Bug:139051851 P2 Optimize folder binding
Bug:139137636 P2 Create memory tests for Launcher
Bug:139281702 P2 [Enterprise - Cloud DO] GSOC and Mobile Utilities launcher icons are in broken state
Bug:139436782 P4 Sorting people by key crashes launcher
Bug:139540363 P1 Launcher goes in crash loop
Bug:139551306 P4 [Polish] Reduce shelf paddings in Overview
Bug:139703885 P4 Add support for searchwidget in layout files.
Bug:139880994 P1 RequestPinItemTest is broken
Bug:139885365 P3 App open animation different between launcher suggested apps and launcher home screen/drawer
Bug:139888225 P2 Convert custom widget into plugins
Bug:139893571 P4 Light QSB to Dark QSB transition lags
Bug:139913027 P2 [a11y] App title in Widget list shouldn't be actionable by a11y methods. (It would cause Pixel launcher crash.)
Bug:139942462 P1 Dragging an icon from prediction row to workspace crashes launcher
Bug:140230739 P4 Android Q update missed home screen shortcut
Bug:140242324 P2 Cache shortcutInfo icons in Launcher
Bug:140243695 P4 Add plugin around UserEventDispatcher
Bug:140244969 P4 Investigate flickerlib for sysui/launcher
Bug:140246642 P4 Add binder tests for launcher interactions
Bug:140405990 P2 [a11y] Unable to add shortcut to Home screen by Voice access or Switch access.
Bug:140406263 P2 [a11y] Unable to scroll to the left of the main Home screen to Display google app by Voice access or Switch access.
Bug:140633033 P4 Reduces calls to get default display
Bug:140749967 P2 Add gesture nav tests for 3P launcher support
Bug:140771636 P2 ub-launcher-master should track R API
Bug:140819317 P4 Pixel launcher crashing
Bug:140837771 P1 Failing test: AddConfigWidgetTests and AddWidgetTests are failing
Bug:141024521 P2 Tapping nav bar during quick switch causes scroll animation to cancel and not resume
Bug:141184247 P1 Clear all button not present in fallback recents in 3-button mode
Bug:141279939 P1 LauncherAppWidgetHost.onAppWidgetRemoved not compatible with master
Bug:64712476 P3 Import translations for dev branches
Bug:78611156 P4 Default name's language of folder won't change after changing the system language
Bug:79164903 P4 With work profile added, unable to scroll through the apps vertically using Mouse wheel
Bug:79462255 P3 Disabling cross profile widget provider doesn't remove widget (until you interact with it)
Bug:issue priority summary
Change-Id: I9c36a901e5b3625ae6c5c86d1bd82d90ec784c56
2019-09-19 15:37:12 -07:00
Shashwat Razdan 0c2a248109 Added AppLaunchEventsPlugin which relays app launch/dismiss events to
all connected plugins.
Listener for this plugin is added in PredictionAppTracker which receives
all app events.

Change-Id: Iec53d20272f6a587f78e3d84666efa4f02cf6962
(cherry picked from commit ae084dafd9)
2019-09-19 05:08:54 +00:00
Winson Chung a879f9c481 Adding binder tracking support in tests
- Whitelist specific binder calls when handling touch during swipe up
  gestures
- Only track binding for touch handling and certain launcher lifecycle
  changes for now

Bug: 140246642
Change-Id: I6ba30280dd17da358662870f8719ae851536ad8b
2019-09-18 17:08:05 -07:00
Tony Wickham 1d61043002 Merge "Allow scroll to clear all in 3 button+fallback mode" into ub-launcher3-qt-qpr1-dev am: 24fb1526e2
am: cdcfd98c05

Change-Id: Iecef9fc4fb5c1dd467581468f6b8edc5becc95fa
2019-09-18 08:18:42 -07:00
Tony Wickham cdcfd98c05 Merge "Allow scroll to clear all in 3 button+fallback mode" into ub-launcher3-qt-qpr1-dev
am: 24fb1526e2

Change-Id: I59bf92b05d45c31705166e1211cf02ccbc348383
2019-09-18 08:12:41 -07:00
Tony Wickham 24fb1526e2 Merge "Allow scroll to clear all in 3 button+fallback mode" into ub-launcher3-qt-qpr1-dev 2019-09-18 14:54:20 +00:00
Tony Wickham 0638249b3e Allow scroll to clear all in 3 button+fallback mode
We weren't calling onSwipeUpToRecentsComplete(), which meant we kept the
disallowScrollToClearAll from prepareRecentsUi indefinitely.

Also don't update the icon scale if it is supposed to be scaled down, to
avoid it from scaling up and overlapping with the app window.

Fixes: 141184247
Change-Id: I49406764373e7121e289da7477dcbb58d0b98fd5
2019-09-17 15:10:33 -07:00
Sunny Goyal ed83cf6df0 Adding recents test for 3P Launcher
Bug: 140749967
Change-Id: I3644822accfd229d1e46ca5e43ad827aef776787
2019-09-17 13:41:10 -07:00
Jonathan Miranda 903abfc48f Merge "Support defining X column layout for all apps as a display option." into ub-launcher3-qt-future-dev
am: 315732e524

Change-Id: I1c47d689fbec052859d5fdbfcf8d10b07ddd0202
2019-09-17 11:25:21 -07:00
Tony Wickham 4aa0a6ca7c Merge "Replace OnGlobalLayoutListener with StateListener to update predictions" into ub-launcher3-qt-qpr1-dev am: fc520edbc6
am: 3ff1000632

Change-Id: I34b83f2038a6cb20e39c95aeba310e201060b564
2019-09-16 17:37:58 -07:00
Sunny Goyal 34ca0d3c62 Merge "Adding support for building a "spring like animation" with precomputed values" into ub-launcher3-qt-qpr1-dev am: 791dd73217
am: 30d998c625

Change-Id: Icd3d2bd914ba30bed3257de33af00ae201ecf17b
2019-09-16 17:37:24 -07:00
Hyunyoung Song fe2e430a71 Merge "resolve merge conflicts of 057059665e to ub-launcher3-master" into ub-launcher3-master 2019-09-17 00:15:15 +00:00
Jon Miranda 6f7e9702e3 Support defining X column layout for all apps as a display option.
Bug: 124967099
Change-Id: I7bf576759b3fa4f6ca617fbbd660541c12fd09ac
2019-09-16 16:24:59 -07:00
Hyunyoung Song 338e4ea7df resolve merge conflicts of 057059665e to ub-launcher3-master
Test: I solemnly swear I tested this conflict resolution.
Bug: None
Change-Id: I8a92d1389acbefc5bf33ef9760373bfbf54d682b
2019-09-16 15:29:37 -07:00
Tracy Zhou 6b272369e7 Make sure that live tile overlay is added only once.
Users report seeing empty launcher. After adding some logging, live tile
overlay can be added twice and removed only once. I added some logic to
make sure that it can only be added once.

Test: manual
Fixes: 135864059
Change-Id: I9d3325c56e76654f1397cc65979b97a6c0a80aee
(cherry picked from commit d3ef57b4dd)
(cherry picked from commit 4fa6f63ffd)
2019-09-16 20:52:35 +00:00
Shashwat Razdan ae084dafd9 Added AppLaunchEventsPlugin which relays app launch/dismiss events to
all connected plugins.
Listener for this plugin is added in PredictionAppTracker which receives
all app events.

Change-Id: Iec53d20272f6a587f78e3d84666efa4f02cf6962
2019-09-16 13:27:13 -07:00
Hyunyoung Song 82173698eb Merging ub-launcher3-qt-qpr1-dev, build 5872416 am: a7a1b57bc8
am: 1d43b107b3

Change-Id: Ied41d63d50033cb01b647abbf0f8f62139c3a901
2019-09-13 16:01:28 -07:00
Tony Wickham 3ff1000632 Merge "Replace OnGlobalLayoutListener with StateListener to update predictions" into ub-launcher3-qt-qpr1-dev
am: fc520edbc6

Change-Id: I8e5b43a582bd243e21f02b5a83b931f4f277eb95
2019-09-13 14:29:31 -07:00
Hyunyoung Song a7a1b57bc8 Merging ub-launcher3-qt-qpr1-dev, build 5872416
Test: Manual

Bug:121280703 P2 Finish implementation of PortraitLandscape annotation for tests
Bug:135633159 P3 [QPR] Promise icons on home screen
Bug:135638690 P1 [QPR] On-device app search
Bug:137106918 P2 UX: Accidental NGA triggering when hitting Undo actions in apps
Bug:137200188 P3 Home screen app title disappears during animation
Bug:138195597 P2 Wrong icon animated on return to home screen
Bug:138396187 P1 Swipe and hold from an app no longer uses spring to animate adjacent task
Bug:138729157 P1 [Flaky test] java.lang.AssertionError: http://go/tapl : want to fling backwards in widgets, flung back, but the current state is not WIDGETS; Unexpected launcher object visible: workspace
Bug:138729456 P1 [Flaky test] java.lang.AssertionError: http://go/tapl : Can't find an object with selector: BySelector [CLASS='\Qandroid.widget.TextView\E', PKG='\Qcom.google.android.apps.nexuslauncher\E', TEXT='\QShortcut 3\E'] (visible state: Workspace)
Bug:138964490 P1 Support DeviceConfig to drive ToggleableFlags
Bug:139021165 P2 [TEST TRACKER] [QPR] Promise icons on home screen
Bug:139137636 P2 Create memory tests for Launcher
Bug:139551306 P4 [Polish] Reduce shelf paddings in Overview
Bug:139885365 P3 App open animation different between launcher suggested apps and launcher home screen/drawer
Bug:139918680 P2 [a11y] Talkback shouldn't keep focusing on the background item and speak the description of the background item again after entering Widget list.
Bug:140076379 P1 Launcher ub-launcher3-qt-qpr1-dev Branch Build Keeps Crashing due to Exception
Bug:140252951 P2 Add widget launch test.
Bug:140308849 P2 Jank during swipe up to home, especially noticeable after pausing first
Bug:140311911 P2 Flake in Launcher tests: java.lang.AssertionError: Stable state != state: OverviewState, LauncherState
Bug:140405990 P2 [a11y] Unable to add shortcut to Home screen by Voice access or Switch access.
Bug:140819614 P1 If an install session is abandoned for an already installed app, the corresponding icon is removed
Bug:140823188 P1 AppPredictionsUITests failing
Bug:140837771 P1 Failing test: AddConfigWidgetTests and AddWidgetTests are failing
Change-Id: I1efae6216c53b1fee3e105c9356ed43c4bf46c6e
2019-09-12 15:22:35 -07:00
Sreyas 04850948f2 Refactoring RecentsView to handle non-TaskViews
am: 78010c1958

Change-Id: Ibcc968518e53f805c2b8985f6e305503e7edf698
2019-09-12 15:11:52 -07:00
Sunny Goyal 30d998c625 Merge "Adding support for building a "spring like animation" with precomputed values" into ub-launcher3-qt-qpr1-dev
am: 791dd73217

Change-Id: I1ecde4721df9895b0fb215f36a43d8cb85a392ef
2019-09-12 15:05:48 -07:00
Hyunyoung Song 057059665e When DeviceConfig/FeatureFlag value is different than the previous value, refresh icon cache
am: e17a699618

Change-Id: I5c2e54c069fc03172f471f9655cd8b09b5ac6dce
2019-09-12 15:05:19 -07:00
Sunny Goyal 3e3d759db2 Removing flag overrides. All flags should be defined as togglable flags instead.
Change-Id: Ia7b9ff84413096cd5b0c4a9a81a232019f2522d2
2019-09-12 10:17:14 -07:00
Tony Wickham fc520edbc6 Merge "Replace OnGlobalLayoutListener with StateListener to update predictions" into ub-launcher3-qt-qpr1-dev 2019-09-11 23:42:23 +00:00
Tony Wickham 51f2919815 Replace OnGlobalLayoutListener with StateListener to update predictions
Previously we were using OnGlobalLayoutListener, which is only called
when AllAppsContainerView or a child is re-laid out or visibility
changes to or from GONE. Since we no longer relayout when already
scrolled to the top, we need a better hook to check whether all apps has
changed visibility for the purpose of updating predictions.

Bug: 140823188
Change-Id: I7c4a0d94c529eb86b55729c75843c8b0bd673d8c
2019-09-11 14:41:52 -07:00
Sreyas 78010c1958 Refactoring RecentsView to handle non-TaskViews
Change-Id: I0bc28ef670a1dad9a3912ca5360c9bab18afd4b2
2019-09-11 14:07:26 -07:00
TreeHugger Robot 791dd73217 Merge "Adding support for building a "spring like animation" with precomputed values" into ub-launcher3-qt-qpr1-dev 2019-09-11 20:16:19 +00:00
Hyunyoung Song e17a699618 When DeviceConfig/FeatureFlag value is different than the previous
value, refresh icon cache

Bug: 135638690
Bug: 138964490

Test: manually toggled feature flag UI on/off
$ adb shell device_config put launcher APP_SEARCH_IMPROVEMENTS [true|false]
when launcher is in foreground and also when it is in the background

Afterwards, saw if "bank" would show BofA app or not

Change-Id: I98b62bd07b14a225168217d7eb9bfdfc7f74435d
2019-09-11 10:38:14 -07:00
Hyunyoung Song e1c1b76884 Merging from ub-launcher3-qt-qpr1-dev @ build 5834630 am: 151970d535
am: b6d7a85a2b

Change-Id: If79242dd021c9a2c3fa6e1a87a5c8d792e45dc1a
2019-09-10 11:26:04 -07:00
Sunny Goyal b1d7de25f8 Adding support for overlay and corresponding plugin to Launcher
Updating various task callbacks to handle overlays

Change-Id: I80077508ad35c31269c873f51f0105302a9e6a5d
2019-09-10 08:08:28 -07:00
Sunny Goyal 3600fb7777 Adding support for building a "spring like animation" with precomputed values
Bug: 138396187
Change-Id: Idba323090ecd9aca43c01414a32ab3b2e292e73e
2019-09-09 17:21:53 -07:00
Winson Chung 478414a7c3 Merge changes I4532e429,I532645de into ub-launcher3-qt-future-dev
* changes:
  Defer listening on widget host until after the state transition ends
  Migrate to using DefaultDisplay
2019-09-09 21:39:18 +00:00
Miranda Kephart fad2f3734d Merge "Add distance threshold for assistant gesture fling" into ub-launcher3-qt-qpr1-dev
am: 329cc8c53f

Change-Id: Ib1e4040010cf3919163e24971d2a368664bec1db
2019-09-09 14:22:47 -07:00
Tony Wickham 0d37f05a12 Merge "Properly prevent All Apps relayouts by avoiding scrollToPosition" into ub-launcher3-qt-qpr1-dev
am: d785fc289c

Change-Id: I69738f5d9c1f77195f2f82f963958d3cc741e9af
2019-09-09 14:17:33 -07:00