Commit Graph

20478 Commits

Author SHA1 Message Date
TreeHugger Robot 8a3be8cb53 Merge "Don't defer finish, only defer disableInputProxy" into ub-launcher3-rvc-dev 2020-05-30 00:41:06 +00:00
Tony Wickham cc558e86fb Don't defer finish, only defer disableInputProxy
We should always finish the controller when requested, to ensure
everything is cleaned up immediately. But if touch is in progress,
we should keep input proxy enabled until touch up/cancel.

Test: swipe up to launcher and interact with it during the transition
- Swipe to recents and scroll it or dismiss the current task
- Swipe to home and open another app or swipe again on the nav bar

Bug: 157771305
Change-Id: Ida53289e4ecbd5e5d16933fcc79bbebdf1f8d898
2020-05-29 19:04:48 -05:00
Hyunyoung Song b117a9221c Migrate launcher home settings button tap/longpress logging to WW
Bug: 157777128
Change-Id: Ic88811efc9aef8f38a0e7e5ae79e3b35236c6663
2020-05-29 17:03:22 -07:00
Sunny Goyal 142dcd8489 Fixing exception when applying transaction while the surface is released
> Check surface before applying transaction
> Keeping the release check around even if it release true the first time, as some other check may defer release
> Waiting on animation complete before releasing a surface

Bug: 148885018
Bug: 148194313
Change-Id: Ieb2b98492ff7df165e6b28a108b5f2cbc7ded32d
2020-05-29 16:08:28 -07:00
Evan Rosky 4510d13ff3 Move static-crops to 0,0 in animations
Otherwise, its trying to apply screen-space crops to
non screen-space surfaces which causes pieces to be missing.

Bug: 157594638
Test: In split, open and close apps in the secondary and observe
      launcher not being cropped.
Change-Id: Ia6f799c7f9ae7c824644a08e8dfd8da036b1a3eb
2020-05-29 16:00:55 -07:00
Samuel Fufa be40b29097 Allow hotseat edu in landscape mode
Screenshot: https://screenshot.googleplex.com/bTXH04qQRog
Bug: 152362405
Test: Manual
Change-Id: I8a9926e82794b11ab1b0fbce742f6b075e220c85
2020-05-29 15:48:31 -07:00
Jonathan Miranda c108b640ef Merge "Fix depth jumping around during transitions." into ub-launcher3-rvc-dev am: 02f0f82883
Change-Id: I91f98b4e689999046356346af7d414d43c139c2f
2020-05-29 22:44:12 +00:00
Jonathan Miranda 02f0f82883 Merge "Fix depth jumping around during transitions." into ub-launcher3-rvc-dev 2020-05-29 22:31:54 +00:00
TreeHugger Robot f136227925 Merge "[Overview actions] Remove unused duration variable." into ub-launcher3-rvc-dev am: 0e3572b953
Change-Id: Ie4d36e41cfb4e2569942e5066bc364cef8ef17fe
2020-05-29 22:05:47 +00:00
TreeHugger Robot 10e7a2bd4e Merge "Animates a fake TaskView in Home gesture tutorial." into ub-launcher3-rvc-dev am: 7fab619676
Change-Id: I39d6c9a66e4019427b17cfb8b9c0128f61263da9
2020-05-29 22:05:35 +00:00
TreeHugger Robot 0e3572b953 Merge "[Overview actions] Remove unused duration variable." into ub-launcher3-rvc-dev 2020-05-29 22:00:42 +00:00
TreeHugger Robot 7fab619676 Merge "Animates a fake TaskView in Home gesture tutorial." into ub-launcher3-rvc-dev 2020-05-29 21:50:43 +00:00
TreeHugger Robot 31e64fc22c Merge "Fix all apps alpha applying twice" into ub-launcher3-rvc-dev am: bc374cf7f2
Change-Id: Ie30912b32461dadb20891921faef4e9f50afaaa5
2020-05-29 21:39:13 +00:00
TreeHugger Robot bc374cf7f2 Merge "Fix all apps alpha applying twice" into ub-launcher3-rvc-dev 2020-05-29 21:25:54 +00:00
Zak Cohen 0c8e20eea7 [Overview actions] Remove unused duration variable.
Test: local build
Change-Id: I2f18e77273753f491c6d802aa3b4406fefce6ad7
2020-05-29 14:15:09 -07:00
Andy Wickham f8a8117676 Animates a fake TaskView in Home gesture tutorial.
The "TaskView" morphs as you drag up from the
nav bar, and transforms into a "home icon" or
final "TaskView" when you release your finger.

If you cancel the gesture (e.g. drag back down),
the view simply fades out and provides a hint
to swipe straight up.

Demo: https://drive.google.com/open?id=1NXlO1W6IhLoX0k2K6b-QZ5IXp0o7OYqO

Bug: 148542211
Change-Id: I3d5e9a45fcadc6a498941ea17813b9487720a504
2020-05-29 14:06:36 -07:00
Andy Wickham 7e78e63d50 Removes unused constant
Change-Id: Ic3d96ae3791ba75c5ce6c1c00203bf9d21469fe5
2020-05-29 13:49:09 -07:00
Jon Miranda 84f6e0182e Fix depth jumping around during transitions.
This is caused because we use mDepth for depth comparisons, but there are
cases where we set mDepth but we do not pass that value to WallpaperManager
(ie. surface is null or not valid) and that leads us into
inconsistent states.

Bug: 155780358
Change-Id: I3faf14416d5783ad472892425eb0bd37dd469a46
2020-05-29 13:06:55 -07:00
TreeHugger Robot 1a20acaeaf Merge "Fixing incorrect taskView size in multiwindow-landscape" into ub-launcher3-rvc-dev am: aaac3f1519
Change-Id: I7473bf4cc77001dcd8939d9bedd47bea54b6c827
2020-05-29 20:02:27 +00:00
TreeHugger Robot aaac3f1519 Merge "Fixing incorrect taskView size in multiwindow-landscape" into ub-launcher3-rvc-dev 2020-05-29 20:00:31 +00:00
Samuel Fufa 8c323b1178 Merge "Remove dependency on Launcher notification for hotseat edu" into ub-launcher3-rvc-dev am: dbb212e939
Change-Id: Ibf409d87cdb8f55526fc3095bfbbfc03bef9f42b
2020-05-29 19:55:29 +00:00
Samuel Fufa dbb212e939 Merge "Remove dependency on Launcher notification for hotseat edu" into ub-launcher3-rvc-dev 2020-05-29 19:39:28 +00:00
Tracy Zhou 6ae611a8eb Merging from ub-launcher3-rvc-dev @ build 6541617
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6541617.html

Change-Id: I23f7656c1cc1fcc922aab4f533bcb25509bc882f
2020-05-29 12:03:25 -07:00
Tracy Zhou 05cbf4aa18 Merge "Support predicted icons in preview" into ub-launcher3-rvc-dev am: c577bb8425
Change-Id: Id38a7070542226278110d6990dd8c102ecc43f57
2020-05-29 18:19:38 +00:00
Tracy Zhou c577bb8425 Merge "Support predicted icons in preview" into ub-launcher3-rvc-dev 2020-05-29 18:06:23 +00:00
Tracy Zhou bc305fc7fe Support predicted icons in preview
Fixes: 152789575
Test: https://screenshot.googleplex.com/r3AtHp3TAh0
Change-Id: I22f7ee2a69f2df12ade16f50bf455651dbfce597
2020-05-29 09:58:01 -07:00
Tony Wickham 244e173a68 Fix all apps alpha applying twice
Test: quick switch from home, ensure QSB fades out at the same
rate as the workspace/hotsea

Change-Id: I59ecd0c65a6abf3e24ea1c2bfba3c84f6a88e653
2020-05-29 11:10:10 -05:00
Tony Huang 7d375e31fe Enable one-handed mode gestural in QuickStep
Handling swipe-down/swipe-up gestural in device bottom area
for one-handed mode

1) The regsion is larger than gesture navigationbar view
2) One handed gestural in quickstep only active on NO_BUTTON, TWO_BUTTONS mode
3) One handed gestural only support on portrait mode

Bug: 150747547
Bug: 154189137
Bug: 156988988

Test: make and install
Test: manual enable one handed mode and swipe down to trigger
Test: manual start one handed and rotate device

Change-Id: I7b2447bfb2fe4082c95176b62934b98077b84920
2020-05-29 19:40:15 +08:00
TreeHugger Robot 1ea847ff42 Merge "Fix actions view showing up when it shouldn't in a couple spots" into ub-launcher3-rvc-dev am: 172ea18639
Change-Id: Icc849de108154f66613d957f962556a0daf730af
2020-05-29 01:28:04 +00:00
TreeHugger Robot 172ea18639 Merge "Fix actions view showing up when it shouldn't in a couple spots" into ub-launcher3-rvc-dev 2020-05-29 01:16:31 +00:00
TreeHugger Robot b14c703579 Merge "Remove overview share to match spec" into ub-launcher3-rvc-dev am: 06fcfe1f5f
Change-Id: I53c28941881b083d7a7312377a280bc4ea1f8d55
2020-05-29 00:56:33 +00:00
Tracy Zhou d67be77066 Merging from ub-launcher3-rvc-dev @ build 6538292
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6538292.html

Change-Id: I53b084ca2dc94d94f87d696bbfd7666b55d712ad
2020-05-28 17:45:04 -07:00
Tony Wickham 1fbf3c76f6 Fix actions view showing up when it shouldn't in a couple spots
- Replace HIDDEN_FULLSCREEN_PROGRESS with INDEX_FULLSCREEN_ALPHA
- When animating actions in after swiping to overview from an app,
  start at alpha 0 (since we setState(OVERVIEW) without animation
  when we settle, meaning alpha would already be 1).
- Fade in actions at the same duration as the icon scale when
  entering overview from an app
- Hide actions during quick switch from home

Tests:
- Start quick switch from home and swipe up back to home
- Start quick switch from home and swipe up to overview
- Go to overview from home
- Go to overview from an app
Verify actions don't appear on the first, and fade in
for the rest.

Bug: 157597385
Change-Id: I43a0be702066f91e13ce2a720278aae27160c557
2020-05-28 19:10:38 -05:00
Sreyas ae23746fa0 Remove overview share to match spec
Bug: 157174391
Change-Id: Iabfeb34b77abcb885b1518d348cac45e71dc92a9
2020-05-28 17:04:42 -07:00
Samuel Fufa f0dc0b6ae0 Remove dependency on Launcher notification for hotseat edu
Doc: go/hybrid-hotseat-tips

Allow launcher to show hotseat education with intent action "launcher.show_hotseat_edu"

Bug: 157683315
Test: Manual
Change-Id: I62c79b821b79cf1adb831e2f79f6f0f02166ca42
2020-05-28 16:40:46 -07:00
TreeHugger Robot 3092dfac9a Merge "Fix QSB animating separately from workspace during stagger anim" into ub-launcher3-rvc-dev am: f8273b949f
Change-Id: I31459de71e79e29c6cf4c2b7ecc80dbf395ab124
2020-05-28 23:35:52 +00:00
TreeHugger Robot f8273b949f Merge "Fix QSB animating separately from workspace during stagger anim" into ub-launcher3-rvc-dev 2020-05-28 22:43:50 +00:00
Tony Wickham 5d4e8541d0 Fix QSB animating separately from workspace during stagger anim
- Don't play any state animation if animComponents == 0
- StaggeredWorkspaceAnim handles depth controller

Bug: 157596833
Change-Id: I6ae4c5da2e837c61b57349e708b7499af8e14aaa
2020-05-28 16:42:45 -05:00
TreeHugger Robot d1d4c78b12 Merge "Putting Overview Share button behind flag" into ub-launcher3-rvc-dev am: 065c84cbeb
Change-Id: If8d51e1077e61a2c22644f289ef15d3cd6c910cb
2020-05-28 20:58:18 +00:00
TreeHugger Robot 065c84cbeb Merge "Putting Overview Share button behind flag" into ub-launcher3-rvc-dev 2020-05-28 20:38:46 +00:00
Sreyas dbedb91ad8 Putting Overview Share button behind flag
https://drive.google.com/file/d/1Io5N-LyXoRa9LHQjJNd1BAgBkVuBvnhr/view?usp=sharing
https://drive.google.com/file/d/15HhNvNoUn5qX1GhkjDaifA3G05PLoIwO/view?usp=sharing
Bug: 157174391

Change-Id: I8314d5aa309fe020a4121753d4e76ca10370c626
2020-05-28 12:03:12 -07:00
Sunny Goyal b46703d538 Fixing incorrect taskView size in multiwindow-landscape
RecentsView uses deviceProfile to calculate the padding.
Device profile had incorrect sizes in multiwindow mode as it
was not considering the insets.

Bug: 155816922
Change-Id: Iaa5b939624b4128ed634e6de1abf8453e2ae852b
2020-05-28 11:49:31 -07:00
Tony Wickham 39046f245b Merge "Don't run finish callback until we actually finish" into ub-launcher3-rvc-dev am: b4d75d2931
Change-Id: I0fbb4b375ba2d19d9b3de20f3a5c6e02768cdd82
2020-05-28 18:00:28 +00:00
TreeHugger Robot 11792138b0 Merge "Logging to debug Overview Actions not working." into ub-launcher3-rvc-dev am: ef7184c8a7
Change-Id: I3d16302afe4f27fd409658beef964437b6c1b063
2020-05-28 18:00:19 +00:00
TreeHugger Robot 6e3fe7207f Merge "Move content resolver call to constructor and cache" into ub-launcher3-rvc-dev am: 938fccd3da
Change-Id: I97bf0bab86cf927a92d219a33aae7b9e47aaf8d1
2020-05-28 17:59:24 +00:00
Tony Wickham b4d75d2931 Merge "Don't run finish callback until we actually finish" into ub-launcher3-rvc-dev 2020-05-28 17:18:09 +00:00
TreeHugger Robot ef7184c8a7 Merge "Logging to debug Overview Actions not working." into ub-launcher3-rvc-dev 2020-05-28 17:02:15 +00:00
TreeHugger Robot 938fccd3da Merge "Move content resolver call to constructor and cache" into ub-launcher3-rvc-dev 2020-05-28 05:55:42 +00:00
thiruram 957de6165d Fixes missing WW logs for drag and drop events. am: c85095b0e9
Change-Id: I2ade9346c63cf0373db15b3685f6b96a24d67550
2020-05-28 00:31:16 +00:00
Tony Wickham 5cf9edc1f2 Don't run finish callback until we actually finish
This fixes the issue where the app re-appears on top if you touch
the nav bar during the animation to home.

The sequence of events leading to this behavior is pretty long,
but actually always should have happened, it was just masked
until the ag/11172732 fix went in.

Here's an abbreviated version of what was happening
on the touch down during the animation to home:
1 Set mRecentsAnimationController#mTouchInProgress = true
2 Cancel the running animation to home
3 onSettledOnEndTarget(HOME) (this is what was missing before)
4 finishCurrentTransitionToHome(), which, due to #1, doesn't
  actually finish the controller, but does run the callback
5 Invalidate the handler due to #4, leading to TIS#reset()
6 Create a new handler (still from the original touch down),
  which is mResetGestureInputConsumer
7 mResetGestureInputConsumer handles touch down to finish
  the controller the app

This change addresses #4. Instead of calling the callback
immediately, we defer it to when we actually finish the
controller, which ensures there's no longer premature
cleanup that leads to the rest of the sequence.

Bug: 157407284
Change-Id: I0b2ff57bfa77a25c2bf1aece4b0ae7f943637ce6
2020-05-27 19:26:16 -05:00