Commit Graph

20478 Commits

Author SHA1 Message Date
Uwais Ashraf 5580144d6b Animate RecentsView when rotating in fake orientations
Test: Manual - animations
Bug: 336704871
Flag: EXEMPT bugfix
Change-Id: I80629128a0730ca85d0313d15af806ddf840e82b
2024-06-04 17:27:59 +00:00
Jagrut Desai e263730c1e Merge "Make Taskbar Divider PopUp Menu Width Dynamic" into main 2024-06-04 17:13:36 +00:00
Alina Zaidi c40cf8674b Merge "Add transition source for DesktopMode enter transition event originating from AppIcon press in overview" into main 2024-06-04 17:09:01 +00:00
Jordan Silva a3b66f59c2 Fix split snapshot broken after rotating in fake orientation
This CL replaces the live tile with the snapshot after rotating in fake orientation. The animateRotation function was created to extract the rotation logic to guarantee that switchToScreenshot call will only happen when there is a running task.

Fix: 326410493
Flag: EXEMPT bug fix
Test: Manual. Instructions in the bug description.
Change-Id: I9d5e1b5ca803f8f8072702b37206a73b8d8a10ed
2024-06-04 17:48:07 +01:00
Alina Zaidi f895a7b0bd Add transition source for DesktopMode enter transition event originating
from AppIcon press in overview

Test: Updated unit tests
Flag: EXEMPT not a major feature/ user visible change
Bug: b/326231756

Change-Id: I9e53cd3ec41dd2475ba90ea8fab2fb7a90f5e158
2024-06-04 13:12:04 +00:00
Jordan Silva bf5e19fcb1 Merge "Adding logs to monitor OverviewCommandHelper" into main 2024-06-04 12:49:12 +00:00
Jordan Silva 11afae1bc9 Adding logs to monitor OverviewCommandHelper
This CL adds some logs to help analyzing why recents button with 3 button navigation sometimes don't open Overview.

Bug: 337954957
Test: NONE
Flag: EXEMPT Adding logs to debug issue
Change-Id: I44a799319eca667b04d4e78a38ade796fc3b69fb
2024-06-04 11:16:01 +01:00
Fengjiang Li 018074351c Animate -1 to recents
Fix: 343770316
Test: manual - record a video
Flag: com.android.launcher3.use_activity_overlay
Change-Id: I74346f060ea93dbc8fc0a1c3290d4996d89ec062
2024-06-03 12:59:48 -07:00
Liran Binyamin ba732a77a1 Merge "Fix bubble bar and handle visibility on first bubble" into main 2024-06-03 19:49:26 +00:00
Ats Jenk 1507a2c59e Merge "Fix bubble position when dragged to dismiss view" into main 2024-06-03 18:30:59 +00:00
Liran Binyamin 273f9ec487 Fix bubble bar and handle visibility on first bubble
When the animation of the first bubble is suppressed, immediately
stash or show the bubble bar to make sure it has been initialized
correctly.

Also we no longer automatically update the bubble bar visibility
based on its alpha value, since we're managing alpha and visibility
ourselves.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 343505267
Fixes: 343502240
Test: manually verified state for the following scenarios for the first bubble
       - in app when keyboard is open
       - in app -> open shade
       - in app -> lock device
       - on home -> open shade
       - on home -> lock device
       - in overview -> open shade
Test: manually sanity tested to make sure animations for more bubbles still work
Test: manual
       - Open test bubble app
       - Open keyboard and send a bubble
       - The bubble should animate using a HUN since the keyboard is open
       - Swipe back to hide the keyboard
       - Observe that the bubble bar no longer shows to stash into the handle
Change-Id: I754a5a9c8e961af0cdd5ccadf83d3081d4414c7e
2024-06-03 13:27:48 -04:00
Jagrut Desai 38478e74f9 Make Taskbar Divider PopUp Menu Width Dynamic
Test: Manual
Bug: 327647761
Flag: com.android.launcher3.enable_taskbar_pinning
Change-Id: Ib5c13324afee46b45b2c71e3af86c15a6384a278
2024-06-03 10:26:41 -07:00
Alex Chau 5e102e4994 Handle uiMode changes in QuickstepLauncher
- Added uiMode in handled configChanges for QuickstepLauncher, NexusLauncherActivity and RecentsActivity
- This avoids Launcher from being recreated when swithching from an app in driving mode (e.g. Maps), which causes massive jank
- Launcher layout is affected when driving mode changes, so a recreation is ujnnecessary
- Light/dark mode changes still causes Launcher to create as expected

Fix: 339747262
Test: Swtich from driving mode app to another or home in 1p and 3p laucnher
Test: Switch light/dark mode and Launcher is updated correctly
Flag: EXEMPT bugfix
Change-Id: I3d52f0625b580a5b5a1ddbbb487c271a4bb0152b
2024-06-03 12:24:30 +01:00
Riddle Hsu 684ee34fe7 Send source rect hint to Shell via stopSwipePipToHome
Launcher has calculated it, so shell side can use it directly to
avoid inconsistency.

Bug: 331315278
Test: Assume the target app support auto-pip and it doesn't draw
      under display cutout.
      E.g. LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
      Enter PiP from 90 degrees to home with 0 degrees.
      The left side of pip should not flicker.
Change-Id: Id09efc8a30eeef14a031d9db2ab1e00b6f3034bc
2024-06-03 11:04:51 +08:00
Hongwei Wang 282cdebd0c Crop the center when no source rect hint
When there is no source rect hint, forge a crop that matches the given
aspect ratio and centered, therefore we can use a consolidated animation
path and fix the issue with the round corner, which was inproperly
scaled in the past.

Flag: NONE bug fix
Bug: 298409662
Test: Test the overlay in both gesture and button navigation mode,\
      with both YouTube and Google Maps,\
      in both folded and unfolded mode.
Change-Id: I8ae48b999159a51eda2ff41c49cdb3c4e1541176
2024-06-02 19:36:38 -07:00
Jeremy Sim 9715761427 Merge "Add logging for actions view" into main 2024-06-01 00:40:22 +00:00
Jeremy Sim bcaceda41a Merge "Save app pair with 50-50 snap target if snap position is SNAP_TO_NONE" into main 2024-06-01 00:39:00 +00:00
Jeremy Sim 2d107d8d4d Add logging for actions view
Bug: 340935208
Test: N/A
Flag: EXEMPT bugfix
Change-Id: Idb1ed848f01fc8378ae54f89ecf37cd14300ed79
2024-05-31 23:03:43 +00:00
Isak Lilja 29322e82fe Save app pair with 50-50 snap target if snap position is SNAP_TO_NONE
It was not possible to save an app pair if free snap mode was enabled
and the snap position was SNAP_TO_NONE. Just default to 50-50 split if
the current divider snap position is SNAP_TO_NONE.

Cherrypicked from isak.lilja@sony.com's CL at https://partner-android-review.git.corp.google.com/c/platform/packages/apps/Launcher3/+/2835425.

Bug: 343219704
Test: N/A
Flag: EXEMPT bugfix
Change-Id: I62347ac13440f714a493366ac66e893578a2d8d9
2024-05-31 21:52:15 +00:00
Ats Jenk af5a393f88 Fix bubble position when dragged to dismiss view
When moving a bubble to dismiss view, use the drag translation x methods
to set the translation x values.
When bubble is moved to the dismiss view, the container will animate
back to the initial position. And we need to account for this while
bubble is in the dismiss view.

Bug: 339659499
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, drag bubble to other side and then to dismiss view,
  observe that bar moves back to original side and bubble is at the
  center of the dismiss view
Change-Id: I4c6e1be2dcd1180d985ceafccfc0f18466549347
2024-05-31 14:21:40 -07:00
Brian Isganitis 8aad11912d Merge "Only stash for IME when in-app and in overview." into main 2024-05-31 19:25:31 +00:00
Ats Jenk 348ac13cfe Merge "Notify pin controller about stuck to dismiss" into main 2024-05-31 16:46:54 +00:00
Jordan Silva a74d1e419b Merge "Add Accessibility Menu support for multiple DWB banners" into main 2024-05-31 11:15:00 +00:00
Jagrut Desai 4c6913395c Merge "Accessibility Annoucement for the always show taskbar switch" into main 2024-05-31 05:33:15 +00:00
Jagrut Desai 7570f36e28 Accessibility Annoucement for the always show taskbar switch
Test: Manual
Bug: 326012899
Flag: com.android.launcher3.enable_taskbar_pinning

Change-Id: Idad1c6349d14153468e0c660703f5ff1808ab8e5
2024-05-30 14:50:53 -07:00
Brian Isganitis d4d6388c8a Only stash for IME when in-app and in overview.
Making it a force stashed flag does not work because we do not stashing
to occur in Launcher non-overview states.

Flag: EXEMPT bugfix
Fix: 343756969
Test: Manual
Change-Id: Ib9c9e6fd1213777e66e8b48a20a2bbeb210ded8a
2024-05-30 16:02:06 -04:00
Priyanka Advani 34459f0210 Merge "Revert "Always report mandatory insets for button nav"" into 24D1-dev am: 8ec05c628b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27593486

Change-Id: I6242e741fba0b4b95be4b7e47a44ad515faf64b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 18:57:33 +00:00
Priyanka Advani 8ec05c628b Merge "Revert "Always report mandatory insets for button nav"" into 24D1-dev 2024-05-30 18:50:44 +00:00
Tracy Zhou 55308cadcf Merge "Support trackpad tapl tests in 3-button mode" into main 2024-05-30 17:59:13 +00:00
Jordan Silva 1b487619a0 Add Accessibility Menu support for multiple DWB banners
Fix: 341672022
Flag: EXEMPT Bug fix
Test: Manual. With Talkback on, open two apps in split screen and both with DWB enabled, go to Overview, access the Accessibility Menu > Actions.
Change-Id: Iff6adf8d549aa00ea42598cbfbdaf8c7a4164b29
2024-05-30 18:22:38 +01:00
Jordan Silva 8181dfdf92 Fix Talkback wrong label announced going from App to Overview
To fix the incorrect title information being spoken after a transition state ends, a new function named getTitle is introduced in the LauncherState. This function provides the correct title for the transition state. The default accessibility label is set to R.string.home_screen. All Apps and Overview states override the getTitle function to ensure the correct accessibility label for their respective states.

Fix: 265892510
Flag: EXEMPT bugfix
Test: Manual with Talkback. With Talkback enabled, navigate from App to Overview.
Change-Id: I96b820f310f8b778a149709bca687a5912386246
2024-05-30 14:01:32 +00:00
Chaitanya Cheemala 1773b06050 Revert "Always report mandatory insets for button nav"
This reverts commit 4304a14206.

Reason for revert: Likely culprit for b/343564388  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ibc6fae27f31bcb54406da013babc76b2d5fc7f10
2024-05-30 11:44:57 +00:00
Treehugger Robot 1d9f23b1ad Merge "Fix DWB banner not showing up for split tasks" into main 2024-05-30 11:04:37 +00:00
Tracy Zhou acb4a3d1e8 Support trackpad tapl tests in 3-button mode
Currently we have logic to only enable input monitor when a trackpad is connected. Tapl tests need to have infrastructure to override that logic

Bug: 335146977
Test: presubmit
Change-Id: Ib7f80c828760f8b5abd7ed2788b246e47fca6e34
2024-05-29 21:58:20 -07:00
Tracy Zhou a27409e8b2 Merge "Register input monitor for trackpad only when trackpad is attached" into main 2024-05-30 04:12:27 +00:00
Winson Chung 50a37b33a9 Merge "Always report mandatory insets for button nav" into 24D1-dev am: 6de4b5286a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27569834

Change-Id: I2fa88ec94e77fc7ecf4086b8de28c9602a9a85cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 23:01:24 +00:00
Winson Chung 6de4b5286a Merge "Always report mandatory insets for button nav" into 24D1-dev 2024-05-29 22:56:05 +00:00
Jeremy Sim 1abc4761cc Address jank and memory issues with OverviewActionsView
Attempt to improve jank and memory regressions by simplifying the view layout of OverviewActionsView.

Bug: 339688091
Bug: 339853741
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair()
Flag: EXEMPT bugfix
Change-Id: Ib4a7c5a813b221c0a083144e7fb1e1c5f3fedb1c
2024-05-29 18:15:32 +00:00
Alex Chau e081914fb1 Fix DWB banner not showing up for split tasks
- Remove DWB banner and thumbnailView from TaskView when being recycled to avoid multiple banners from staying
- Extracted DWB toastg splitbounds update to not be called whenever task icon is loaded
- Refactor DWB toast to remove unused variable, and extract mSplitBannerConfig to be a getter

Fix: 343212887
Test: OverviewImageTest.digitalWellbeingToast
Flag: EXEMPT bugfix
Change-Id: I2dbdc483a7b99de009c9e2a946e1b026c5e4817f
2024-05-29 16:44:48 +01:00
Uwais Ashraf 3661e3f655 Merge "Add snapshot state to TaskThumbnailView and ViewModel" into main 2024-05-29 14:21:28 +00:00
Uwais Ashraf bad2e24f72 Add snapshot state to TaskThumbnailView and ViewModel
Bug: 334825222
Test: TaskThumbnailViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I829c346861a6f437b2c53dadb3a7f98084d3c962
2024-05-29 10:47:05 +00:00
Alex Chau 09ae3694e3 Merge "Address jank and memory issues with OverviewActionsView" into main 2024-05-29 09:36:37 +00:00
Winson Chung 4304a14206 Always report mandatory insets for button nav
Fixes: 340134342
Test: atest android.systemui.cts.WindowInsetsBehaviorTests
Change-Id: Iee9d5ca9f12ff63f856e7aa94227e5b8273e02a4
2024-05-29 06:39:57 +00:00
Ats Jenk 2b0efdb621 Notify pin controller about stuck to dismiss
Based on changes to the base controller we now only need to notify when
a dragged item is stuck to the dismiss view.

Bug: 339659499
Test: manual
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I82c5c4946b955b06cfba91179931e690d0591107
2024-05-28 16:37:06 -07:00
Vinit Nayak b34cc291d0 Merge "Return false for isSplitSelectionActive() if controller not initialized" into 24D1-dev 2024-05-28 20:39:58 +00:00
Vinit Nayak 364d784242 Merge "Disable gestures when split apps are animating in from shell" into 24D1-dev 2024-05-28 20:21:53 +00:00
Vinit Nayak f9b81f24a4 Return false for isSplitSelectionActive() if controller not initialized
Test: unable to repro
Fixes: 342716244
Flag: EXEMPT bugfix
Change-Id: I9d7d54d5f7571286778c0e82ef4082f9b5843c1d
(cherry picked from commit b449116345)
Merged-In: I9d7d54d5f7571286778c0e82ef4082f9b5843c1d
2024-05-28 20:19:46 +00:00
Vinit Nayak e3f3118bfa Merge "Return false for isSplitSelectionActive() if controller not initialized" into main 2024-05-28 20:19:26 +00:00
Jeremy Sim 1ab32a7942 Address jank and memory issues with OverviewActionsView
Attempt to improve jank and memory regressions by simplifying the view layout of OverviewActionsView.

Bug: 339688091
Bug: 339853741
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair()
Flag: EXEMPT bugfix
Change-Id: Ib4a7c5a813b221c0a083144e7fb1e1c5f3fedb1c
2024-05-28 13:16:52 -07:00
Andy Wickham 28cc86ee38 Merge "Revert "[omni] Handle touch slop for LPAA."" into main 2024-05-28 18:54:08 +00:00