Commit Graph

20478 Commits

Author SHA1 Message Date
Jon Miranda ba9e336349 Merge "Fix spring not springing when unstashing." into tm-qpr-dev am: cbe578b269 am: 0f43611645 am: 45a3ad23ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22202345

Change-Id: I6eb0db45419cd91b841924839d4db157377fdf82
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 18:52:10 +00:00
Jagrut Desai ef1a9b798d Make clear announcment for taskbar education.
Test: Manual
Bug: 273393698
Bug: 273408584
Flag: not needed
Change-Id: I6c6eb1e1e1047a2e702592290bf5735e8bfa6ce2
2023-03-23 11:26:09 -07:00
Jon Miranda 00e55a078a Merge "Update nav bar buttons to spec." into tm-qpr-dev am: fc8606dadc am: 3d8a020ab5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22211900

Change-Id: I73bb947b384f251adf6934d31c0f29eb2b1a4a83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 18:23:23 +00:00
Jon Miranda 45a3ad23ea Merge "Fix spring not springing when unstashing." into tm-qpr-dev am: cbe578b269 am: 0f43611645
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22202345

Change-Id: Ie8eacb26ccf2234b52ac36cbf81e048e65fa5a49
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 18:22:23 +00:00
Jon Miranda 3d8a020ab5 Merge "Update nav bar buttons to spec." into tm-qpr-dev am: fc8606dadc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22211900

Change-Id: I420f528cb0558fb3b7716df9f0b26344c392c9e6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 18:20:13 +00:00
Jon Miranda 0f43611645 Merge "Fix spring not springing when unstashing." into tm-qpr-dev am: cbe578b269
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22202345

Change-Id: I25e8204b0e93dd986a88329d53fef8e0507b7832
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 18:18:42 +00:00
Bill Yi 70727e87eb Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-03-23 18:03:14 +00:00
Jon Miranda fc8606dadc Merge "Update nav bar buttons to spec." into tm-qpr-dev 2023-03-23 17:37:53 +00:00
Jon Miranda cbe578b269 Merge "Fix spring not springing when unstashing." into tm-qpr-dev 2023-03-23 17:37:35 +00:00
Charlie Anderson 04c6def895 reorder System shortcuts for taskbar and secondary display
Bug: 269343928
Bug: 272418357
Test: locally on device
Change-Id: Iec7f9ad702214c7ab7f49758dbf2463fe63b0324
2023-03-23 15:27:12 +00:00
Tony Wickham c73db73a79 Handle swipe down on taskbar to stash
- Moved all touch-to-stash logic to new TaskbarStashViaTouchController
  (handles both tap outside to stash instantly as well as swipe down
  inside to stash after letting go)
- This is a TouchController on TaskbarDragLayer, so it intercepts
  touches from TaskbarView before icons can be dragged during swipe down

Test: swipe up to invoke transient taskbar in an app, swipe down or
touch outside to stash
Flag: ENABLE_TRANSIENT_TASKBAR=true
Fixes: 246631710

Change-Id: I5cf64848bba34ad32fcc80a93fb4f79ebd2c10a7
2023-03-23 15:13:52 +00:00
Mike Schneider 86dee11c19 Ensure FLAG_IN_APP is correctly set after launcher-restart. am: 43700f61f7 am: 94a6313bbf am: 6b138d009a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22195243

Change-Id: Ib7e00c033e96ed8fafc4dec8a8ad91f3ffa2a155
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 12:52:46 +00:00
Mike Schneider 2192e5a85a Ensure FLAG_IN_APP is correctly set after launcher-restart. am: 43700f61f7 am: 94a6313bbf am: 6b138d009a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22195243

Change-Id: If5479da739d325f457c94c66475be4b0ef3fa8ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 12:52:45 +00:00
Mike Schneider 6b138d009a Ensure FLAG_IN_APP is correctly set after launcher-restart. am: 43700f61f7 am: 94a6313bbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22195243

Change-Id: I55dcc38c9633199093f5cafca669f8c059a47d3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 12:13:50 +00:00
Mike Schneider 94a6313bbf Ensure FLAG_IN_APP is correctly set after launcher-restart. am: 43700f61f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22195243

Change-Id: I71e90d16b58de5f99db0838219e9624b06d77645
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 11:33:21 +00:00
Johannes Gallmann c2e5bfca50 Fix taskbar linger above notification shade
Remarks:
1. I think the correct fix for this would be to have the Taskbar z-ordered below the notification shade. That however seems to be difficult because there are cases when the taskbar window must be above the notification shade.
2. This CL improves the behaviour by starting the taskbar disappear animation when the notification panel is half expanded instead of waiting for the full expansion. This improves the UX when expanding the shade slowly. When expanding the shade quickly, this CL does unfortunately not significantly improve the UX.
3. I believe that the `SYSUI_STATE_NOTIFICATION_PANEL_EXPANDED` and `SYSUI_STATE_QUICK_SETTINGS_EXPANDED` flags can be replaced by the newly introduced one. But since this would pose the risk of introducing new bugs, I did not do that in this CL. It is my intention to create a CL with that replacement in udc.

Bug: 272621219
Test: Manual, i.e. observe Taskbar behaviour when pulling down notification shade and expanding quick settings
Change-Id: Ic79d3f41ed224cb1abdbac9011c6d27e0f458ec2
2023-03-23 10:31:25 +01:00
Jerry Chang 58dfb18f04 Merge "Consolidate split divider show/hide behavior" into tm-qpr-dev am: 064d88d8b8 am: 8ab17926ac am: 1dcf99f961
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22099682

Change-Id: I7865f45a9f3db1867780e0277ed83905dceb1309
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 08:26:09 +00:00
Jerry Chang 061608f6bf Merge "Consolidate split divider show/hide behavior" into tm-qpr-dev am: 064d88d8b8 am: 8ab17926ac am: 1dcf99f961
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22099682

Change-Id: I9712c5080a522ecd849a4911662753fefd22a4f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 08:25:40 +00:00
Mike Schneider 43700f61f7 Ensure FLAG_IN_APP is correctly set after launcher-restart.
This is a follow-up to ag/21699905, which caused the nav-bar to be visible after a device-restart alongside the hotseat, until an app was launched.

Currently, when restarting launcher (for example a device restart), there is no guarantee when the SysUI flags are received for the first time. The current init-codepath  expects the launcher to be fully initialized at the time. From there, only deltas are processed:
- during the initial resume, launcher is not considered active because the screen is still off
- the SCREEN_ON event itself is not processed to update the FLAG_IN_APP

Before: http://shortn/_MGQjGFRIaB
After: http://shortn/_awiv2CxFn9

Bug: 261418621
Test: manual (http://shortn/_ty9EDuLM97), tapl
Change-Id: Ie3b3ba1ebe249efe8fc43850052bc9956cafcd24
2023-03-23 08:54:01 +01:00
Jerry Chang 1dcf99f961 Merge "Consolidate split divider show/hide behavior" into tm-qpr-dev am: 064d88d8b8 am: 8ab17926ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22099682

Change-Id: I66e1a08ccfbfac1eb314d0a30fc1d9b8d3ffa73c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 07:45:53 +00:00
Jerry Chang 8ab17926ac Merge "Consolidate split divider show/hide behavior" into tm-qpr-dev am: 064d88d8b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22099682

Change-Id: I4c5ee30a5256ff07afb805b7f2f98793976b6e43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 07:07:51 +00:00
Jerry Chang 064d88d8b8 Merge "Consolidate split divider show/hide behavior" into tm-qpr-dev 2023-03-23 06:25:43 +00:00
TreeHugger Robot 980f4deb93 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-03-23 05:42:07 +00:00
TreeHugger Robot 2c95b5e452 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev 2023-03-23 05:23:18 +00:00
Jon Miranda 071a196a77 Update nav bar buttons to spec.
Bug: 259712417
Test: manual
Change-Id: I9ec51dc99392e371c15e3918af239a0970809ec2
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-22 18:00:38 -07:00
Tracy Zhou 897e665852 Update home screen trackpad gesture behaviors
- 3-finger swipe up to go to overview
- 2-finger swipe down to pull down notifications
- 2-finger swipe up to open all apps

Fixes: 273972106
Test: manual
Change-Id: I61bd0ad98b21abeb5f9b00786fe358c03a49f539
2023-03-22 23:00:07 +00:00
Tony Wickham 41b3bc0b83 Merge "Set PredictedAppIcon ring disabled when icon is disabled" into tm-qpr-dev am: f93aa98e3a am: b04aeba66b am: 89501aede7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22125079

Change-Id: I2ecc9a6dcc72878e4381a91d7933e61f68241890
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 21:30:44 +00:00
Jon Miranda a4922b9aaf Merge "Update start radius for reveal animation to match spec." into tm-qpr-dev am: 0a6356a5ea am: dc3e4c972d am: 4e8730f8e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22188102

Change-Id: Ib139754609298a71ec5a2b6602e79af23d77c8a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 20:04:53 +00:00
Tony Wickham 89501aede7 Merge "Set PredictedAppIcon ring disabled when icon is disabled" into tm-qpr-dev am: f93aa98e3a am: b04aeba66b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22125079

Change-Id: Id47004d671ec6f4493217a9e50007b25296e1474
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 19:58:53 +00:00
Tony Wickham b04aeba66b Merge "Set PredictedAppIcon ring disabled when icon is disabled" into tm-qpr-dev am: f93aa98e3a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22125079

Change-Id: I245d2ad27841078ceb09476f4c20608d06047753
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 19:20:31 +00:00
Tony Wickham 86ca5c1314 Merge "Restore proper nav buttons translation when taskbar is recreated" into tm-qpr-dev am: 3292947a73 am: 75a0c72d00 am: 38e185ddcb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22090087

Change-Id: I3ef0cb12997a791da9099ec237df1b9d0d80fdd9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 18:54:49 +00:00
Jon Miranda 5945226515 Fix spring not springing when unstashing.
The spring animation was getting cancelled by the reset
animation.

Added a check to avoid creating a new reset animation if we
are already animating to the final value.

Bug: 273961611
Change-Id: I3afb62b89b5f6fbe920906499db2497ef8e94069
Flag: ENABLE_TRANSIENT_TASKBAR
Test: stash transient taskbar
2023-03-22 11:53:58 -07:00
Tony Wickham f93aa98e3a Merge "Set PredictedAppIcon ring disabled when icon is disabled" into tm-qpr-dev 2023-03-22 18:46:56 +00:00
Jon Miranda 4e8730f8e9 Merge "Update start radius for reveal animation to match spec." into tm-qpr-dev am: 0a6356a5ea am: dc3e4c972d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22188102

Change-Id: I1ee7430d3eff46b1c8d1331e6457e680f41593d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 18:40:59 +00:00
Mike Schneider 32087f0116 Do not play unstash animation when unlocking the device am: 94f46e14f4 am: 14db451c21 am: 2736f2ed5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22119728

Change-Id: Iedcc0324e385f10a5505f98b8a1401dbc2d2a2ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 18:05:56 +00:00
Jon Miranda dc3e4c972d Merge "Update start radius for reveal animation to match spec." into tm-qpr-dev am: 0a6356a5ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22188102

Change-Id: I052941fca6d5def9bd9a7a37a0b0d0a8c287af69
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 17:44:18 +00:00
Tony Wickham 1e29b04f19 Set PredictedAppIcon ring disabled when icon is disabled
Test: drag a predicted app from taskbar, ensure both ring and icon are
set to grayscale
Fixes: 268759548

Change-Id: I764ebcd486c09eceaf30c5bd5153a1dd2ff5be72
2023-03-22 16:53:10 +00:00
Jon Miranda 0a6356a5ea Merge "Update start radius for reveal animation to match spec." into tm-qpr-dev 2023-03-22 16:51:27 +00:00
Bill Yi bcd33a7a6d Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Icde4e9d17d7691f594cc8379138c8ec4aa26223d
2023-03-22 09:47:19 -07:00
Tony Wickham 38e185ddcb Merge "Restore proper nav buttons translation when taskbar is recreated" into tm-qpr-dev am: 3292947a73 am: 75a0c72d00
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22090087

Change-Id: I7e4613202ceaa9e66e4592438668fadb057fc993
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 16:26:40 +00:00
Mike Schneider 2736f2ed5b Do not play unstash animation when unlocking the device am: 94f46e14f4 am: 14db451c21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22119728

Change-Id: I201404e1642a22dabae740e01d4b8bd06d36ca3b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 16:18:10 +00:00
Tony Wickham 75a0c72d00 Merge "Restore proper nav buttons translation when taskbar is recreated" into tm-qpr-dev am: 3292947a73
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22090087

Change-Id: Ic3fd82b74858b62456f40ed7426ad98a9eac825b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 15:35:51 +00:00
Mike Schneider 14db451c21 Do not play unstash animation when unlocking the device am: 94f46e14f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22119728

Change-Id: I03a41c526338a77c53c2bffec5a964fbb5206aa3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 15:35:04 +00:00
Tony Wickham 3292947a73 Merge "Restore proper nav buttons translation when taskbar is recreated" into tm-qpr-dev 2023-03-22 15:27:00 +00:00
Riddle Hsu 01a41a2bef Remove workaround of delaying remove task
The timing doesn't work on the latest code base. The onStop
of activity still almost has no chance to be called after
swiping the task to kill process.

And the friendly activity lifecycle will be controlled by
removeTask since Id69a8ba77da16a13f7a3413bb004fc2206f4b4e8.

Bug: 184899234
Bug: 213583589
Test: No behavior change after swiping task out from recents
Change-Id: If4110069834964571df7128b119fc6c782a03b34
2023-03-22 22:26:16 +08:00
Bill Yi 9988e9e1fd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id8fbed7faf52450df74992bffd44a7a26129ba3a
2023-03-22 06:27:22 -07:00
Bill Yi 7f54820ce6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I41875ec4d733b6fa8c98404797cb67114d2e5650
2023-03-22 06:26:50 -07:00
Mike Schneider 4374b4ffde Merge "Do not perform invisible transitions while the screen is off." into tm-qpr-dev am: 42a8fe91db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21699905

Change-Id: Idc2d27107db630a617102b83f819b5381242f8c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 08:43:55 +00:00
Mike Schneider 94f46e14f4 Do not play unstash animation when unlocking the device
The unstash is ignored by TaskbarStashController, while the TaskbarLauncherStateController positions the hotseat on the launcher correctly without animation.

Since the TaskbarStashController is used even with 3p launchers, both of these actors keep track of whether the device is locked independently, based on the SysUI flags.

Bug: 270139677, 266890635, 274084408
Test: manually, Tapl
Change-Id: Iae94522b5d57cc89c9a4d219ad1254b150a3400d
2023-03-22 09:10:03 +01:00
Mike Schneider 42a8fe91db Merge "Do not perform invisible transitions while the screen is off." into tm-qpr-dev 2023-03-22 08:04:09 +00:00