Commit Graph

1508 Commits

Author SHA1 Message Date
Liran Binyamin 9720472a8a Merge "Revert^2 "Synchronize bar expansion with WM Shell"" into main 2024-08-26 11:29:31 +00:00
Luca Zuccarini 6bf20cd965 Merge "2/3 Move some Shell utils to the Shared package." into main 2024-08-26 10:07:55 +00:00
Tony Wickham 39d0107ef2 Merge "Animate away Recent Apps section when going to home" into main 2024-08-22 18:45:08 +00:00
Uwais Ashraf 37752f5e19 Merge changes I31d9a51e,I1bc14be7 into main
* changes:
  Prevent requestLayout() when updating drawables that don't change size
  Fix splash icon size to 52dp
2024-08-22 09:13:41 +00:00
Tony Wickham 79f3cefae2 Animate away Recent Apps section when going to home
Also fix calculation for divider position during this transition
when there are recent apps. Added tests as well.

Flag: com.android.launcher3.enable_recents_in_taskbar
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Test: TaskbarViewControllerTest
Bug: 343522351

Change-Id: Ifffd620c1d4c156b37561584d6e3278b39804439
2024-08-21 22:48:06 +00:00
Luca Zuccarini c1f0506da0 2/3 Move some Shell utils to the Shared package.
Bug: 322791067
Flag: EXEMPT move only
Test: NA
Change-Id: I076d41404f23bd44fa6157a5dc39a60e467c79c3
2024-08-21 19:47:12 +00:00
Uwais Ashraf f1c14902ca Fix splash icon size to 52dp
Fix: 360804090
Test: presubmits passing, manual
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I1bc14be7d2d25a985d26709eb59b8aa4887d4764
2024-08-21 15:44:03 +00:00
Mady Mellor c15fe691e7 Merge changes I964d213d,I95085fd1 into main
* changes:
  Make an input consumer for bubble bar
  Include bubbles in the dragged items of taskbar UI controller
2024-08-20 21:34:54 +00:00
Jeremy Sim bfb29a2e3f Merge "Add a contentDescription to splitscreen's first staged task" into main 2024-08-20 05:05:50 +00:00
Jeremy Sim 2e59268f3b Add a contentDescription to splitscreen's first staged task
Currently, when we stage the first app in a split, the floatingTaskView has no contentDescription and is announced by screen readers as "unlabeled".

This CL allows FloatingTaskView to copy a contentDescription from the underlying task or ItemInfo when it is created.

Also changes SplitConfigurationOptions#itemInfo to a private field with a public getter for mockito compatibility.

Fixes: 319783133
Test: Confirmed with TalkBack on Overview, contextual and Intent splits
Flag: EXEMPT bugfix
Change-Id: Ia5a95e403bfe8623e17d2ceac9073ef15c7bb476
2024-08-20 03:19:58 +00:00
Federico Baron 89306a057d Merge "Add screenrecording for testOverview" into main 2024-08-19 23:14:53 +00:00
Mady Mellor 788a6ebb74 Make an input consumer for bubble bar
Instead of unstashing bubble bar in TaskbarUnstashInputConsumer
handle it in its own input consumer instead. This is a nicer
separation of concerns and simplifies the logic in both places.

Additionally, this fixes issues where swiping up the bubble bar
handle might initiate / be handled by gesture nav (or all apps) when
really any events originating on bubble UI should be managed by
bubbles instead.

Adds some mostly mock'd tests to check that the static method used
to indicate if bubbles should take the event or not works correctly.

Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - test swipe up on bubble bar handle in an app
             - test swipe up on bubble bar on home - it should
               open & all apps / launcher transition shouldn't happen
             - longpress to drag bubbles around on home and overview,
               try the collapsed bar & individual bubbles in the
               expanded bar
             - test dragging on the bubble bar after it's revealed
               in an app
Test: atest BubbleBarInputConsumerTest
Bug: 345488529
Change-Id: I964d213d71de15e4350cff5202dfb9343de1af14
2024-08-19 15:26:37 -07:00
Liran Binyamin bdd23572a7 Merge "Deflake BubbleViewScreenshotTest" into main 2024-08-19 19:19:03 +00:00
fbaron 01fc975288 Add screenrecording for testOverview
Flag: EXEMPT TEST_ONLY
Bug: 355042336
Test: FallBackRecentsTest#testOverview
Change-Id: Ic512e3a1ce887f8d4e8158f6650d99dfb8121650
2024-08-19 09:47:07 -07:00
Liran Binyamin 63ef8cf1e7 Deflake BubbleViewScreenshotTest
Hiding the dot runs an animation which is flaky.
Instead the bubble is created with the suppress notification flag.

Flake: https://android-build.corp.google.com/abtd/run/L87700030005824088

ABTD 50x: https://android-build.corp.google.com/abtd/run/L03700030005851578

Flag: EXEMPT test only
Bug: 355454021
Test: atest BubbleViewScreenshotTest
Change-Id: I635eafb44a3e0ffb9b38fd83c8cc7b36822cce75
2024-08-18 08:39:30 -04:00
Mykola Podolian 3bae9ff981 Merge "Fixed issue when hotseat icons are not touchable" into main 2024-08-16 22:26:56 +00:00
mpodolian 9367722dbc Fixed issue when hotseat icons are not touchable
The issue existed because of taskbar insets where set to the full height
of bubble and task bars. Added check that only adds bars touch area if
the user is currently not on the launcher home screen. Commented failing
tests.

Bug: 358301278
Bug: 359277238
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual.
http://recall/-/gx8ASgewUeUS3QYohfrd1J/hcgYuHUJwfbhlvPRsvdWYf
The touch area is within the red rectangle.

Change-Id: I3c2ad3633a049972b93fe5c5e45efd557c220e1f
2024-08-16 13:00:03 -07:00
Luca Zuccarini 0ad76ac07d Merge "Move some Shell utils to the Shared package." into main 2024-08-16 16:32:37 +00:00
Pat Manning b488c88fa3 Show and hide taskbar tooltips immediately.
Fix: 356352494
Test: TaskbarHoverToolTipControllerTest
Flag: EXEMPT bugfix
Change-Id: Ie7dc1f341cf059bb38f61fa185152cb2555e36b1
2024-08-15 17:59:59 +01:00
Liran Binyamin 02fdb75687 Revert^2 "Synchronize bar expansion with WM Shell"
799802cb7e

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 339683389
Test: atest BubbleBarViewAnimatorTest
Change-Id: Icd853eb76b20ee5ca035bd20c9360f5b60ecc00d
2024-08-15 10:35:36 +00:00
Liana Kazanova (xWF) 4b4a045474 Merge "Revert "Synchronize bar expansion with WM Shell"" into main 2024-08-14 19:08:26 +00:00
Liana Kazanova (xWF) 799802cb7e Revert "Synchronize bar expansion with WM Shell"
Revert submission 28703070-bubbles-defer-expand

Reason for revert: DroidMonitor. Potential culprit for b/359765550 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:28703070-bubbles-defer-expand

Change-Id: I5651cc8f740b1f0718abcfa8065e18c174657224
2024-08-14 16:58:12 +00:00
Liran Binyamin f544f7f164 Merge "Synchronize bar expansion with WM Shell" into main 2024-08-14 06:37:38 +00:00
Treehugger Robot 1a7bd33654 Merge "Add screen recording to TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet" into main 2024-08-13 21:42:22 +00:00
Treehugger Robot 0151027662 Merge "Revert "Mark TaplTestsOverviewDesktop.enterDesktopViaOverviewMenu as postsubmit only"" into main 2024-08-13 18:35:25 +00:00
Schneider Victor-tulias 600c508569 Add screen recording to TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet
Flag: EXEMPT debug cl
Bug: 358607191
Test: TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet
Change-Id: I06e82c3f9c4ecf48b1c627862125e0ff10a732fd
2024-08-13 11:14:27 -04:00
Helen Cheuk 801f86ecac Merge "[Contextual Edu] Enable updating Edu data in Launcher" into main 2024-08-13 12:52:02 +00:00
Alex Chau 041de0ba78 Revert "Mark TaplTestsOverviewDesktop.enterDesktopViaOverviewMenu as postsubmit only"
This reverts commit 194768420d.

Reason for revert: Memory leak has now been fixed
Fix: 358364342

Change-Id: I39e80d56a2c99ccb69d8de5170fd3e515bdef25b
2024-08-13 11:12:41 +00:00
Uwais Ashraf d39bc803c7 Merge "Improve performance of thumbnail retrieval - hot taskData flow" into main 2024-08-13 10:59:32 +00:00
Uwais Ashraf 60b62d734d Improve performance of thumbnail retrieval - hot taskData flow
Bug: 357542209
Test: TasksRepositoryTest, manual with reduced speed video
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ie94daf61d8e41c4b9c12d67f5f45166104879325
2024-08-12 16:49:24 +00:00
Liran Binyamin 9b559c48a3 Synchronize bar expansion with WM Shell
When a bubble is added and requested to be expanded, notify WM Shell
to show the expanded view when expansion actually starts on the
launcher side.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/cPZuf3STUqX9uFZ4zneRO2

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 339683389
Test: atest BubbleBarViewAnimatorTest
Change-Id: I0ba27acf8bae560a10b754241f8f2d8e3281cef9
2024-08-11 04:36:14 -04:00
Liran Binyamin de9b1df642 Merge "Remove BubbleBarView.mIsAnimatingNewBubble" into main 2024-08-11 08:25:29 +00:00
helencheuk 39a6093369 [Contextual Edu] Enable updating Edu data in Launcher
- Added ContextualEduStatsManager (in Launcher3) and SystemContextualEduStatsManager(in Quickstep) to enable classes in Launcher3 and quickstep to update contextual edu data
- Implemented new updateContextualEduData method in SystemUiProxy file, so the EduStatsManager could use it for update
- AbsSwipeUpHandler handles the logic to go home/overview when in app. Added code to update contextual edu data when these action is triggered.

Test: LauncherSwipeHandlerV2Test
Bug: 357542123
Flag: com.android.systemui.keyboard_touchpad_contextual_education
Change-Id: I6fc5a285ba1a1d770c54cc7af444ff8b3051bd00
2024-08-09 13:38:21 +01:00
Alex Chau ecb9ecd770 Merge "Mark TaplTestsOverviewDesktop.enterDesktopViaOverviewMenu as postsubmit only" into main 2024-08-09 10:39:13 +00:00
Alex Chau 194768420d Mark TaplTestsOverviewDesktop.enterDesktopViaOverviewMenu as postsubmit only
Fix: 358364342
Bug: 320313527
Test: TaplTestsOverviewDesktop
Flag: EXEMPT TEST_ONLY
Change-Id: I52f2db342ca75f66d5159a669cb8493caea0e88a
2024-08-09 10:39:03 +00:00
Jagrut Desai 6edc79057e Merge "Only run Taskbar related tests on foldables and tablets" into main 2024-08-08 23:59:56 +00:00
Jagrut Desai 1926d46784 Only run Taskbar related tests on foldables and tablets
Test: presubmit
Bug: 356409843
Flag: TEST_ONLY
Change-Id: I18d8f6e6c2c4ec7ec876c84a27466c883b1c0f71
2024-08-08 13:30:48 -07:00
Liran Binyamin 5eeff8d1e3 Merge "Support expanding the bar while animating" into main 2024-08-08 12:44:42 +00:00
Liran Binyamin 09c2ad248b Remove BubbleBarView.mIsAnimatingNewBubble
We now use BubbleBarViewAnimator directly to check if there's a new
bubble animation.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 339683389
Test: presubmit
Change-Id: I5f884095125e6226338aee14d9d08e46b87ff2ec
2024-08-08 07:49:04 -04:00
Treehugger Robot 3307f87b82 Merge "Implement e2e test for desktop windowing" into main 2024-08-08 11:32:10 +00:00
Alex Chau 1ceac5ddfe Implement e2e test for desktop windowing
Code changes:
- TaskView, GroupedTaskView and DesktopTaskView now uses different resId, so it can be differentiated by TAPL
- Extracted result handling of icon loading, so we can override in DesktopTaskView
- DesktopTaskView now load icons, so titleDescription can be loaded. When icons are loaded, contentDescription are applied to respective snapshotViews; icon unloading is ignored
- Track launchDesktopFromRecents and composeRecentsLaunchAnimator in TAPL events so we can test if the TaskView launch path is correct

Test changes:
- Added TaplTestsOverviewDesktop that move 2 TestActivities into Desktop, and launch the DesktopTaskView as static and live tile
- TaplTestsOverviewDesktop is limited to Tangor/cf_tablet only, and added LimitDeviceRule to AbstractLauncherUiTest to enable @AllowedDevices and @IgnoreLimit

TAPL changes (2 APIs added/modified):
- Changed TaskView matcher to use id/task_view_* to match all TaskView types
- When Overview is launcehd from Background, mark the currentTask after the launch as liveTile. When an OverviewTask has the same accessibility node as the liveTile, it'll expect different event when launching.
- [API change] BaseOverview.getTestActivityTask can now matches mutiple test activiites, useful for matching GroupedTaskView and DesktopTaskView; Fix a bug that getTestActivityTask wrongly use `getParent()` which is RecentsView to match activityName.
- In OverviewTask.open, we'll expect different events based on TaskView types and whether it's a live tile. Launching DesktopTaskView will in additional verify Desktop header is present on screen.
- [API change] In OverviewTaskMenu, support tapping Desktop menu and verify Desktop header is present on screen.
- Removed unused OverviewTaskMenuItem

Fix: 320313527
Test: TaplTestsOverviewDesktop
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I89261c787364901320f3acb18f01ddad5f62d17c
2024-08-08 10:37:40 +01:00
Liran Binyamin 46111b109e Support expanding the bar while animating
Update the BubbleBarAnimator to handle auto expanding bubbles as
well as expand signals that are received while animating the bubble
bar.

The expansion starts after the bar reaches its peak height. If the
hide animation starts before the expansion signal is received, we
ignore it.

Next step is to delay showing the expanded view until the bubble bar
starts expanding.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 353644484
Fixes: 356415377
Bug: 339683389
Test: atest BubbleBarViewAnimatorTest
Change-Id: I79a63f0b8728abc1ab3345f0116cbfcba2918643
2024-08-08 03:46:07 -04:00
Jagrut Desai 01d04c40dc Merge "Enable TaskbarEduTooltipControllerTests with rule ordering" into main 2024-08-07 17:55:02 +00:00
Treehugger Robot be48abdacf Merge "Separate TaplStartLauncherViaGestureTests test cases to prevent timeouts" into main 2024-08-07 17:49:51 +00:00
Schneider Victor-tulias aa01b2e755 Separate TaplStartLauncherViaGestureTests test cases to prevent timeouts
Flag: EXEMPT test fix
Fixes: 348476703
Test: TaplStartLauncherViaGestureTests
Change-Id: I083bbf67b3079fce8fed3a3d6b4ea477e4fef300
2024-08-07 12:01:55 -04:00
Sam Cackett acf4cd1163 Merge "Add hover states to IconView and TaskThumbnailView in Overview" into main 2024-08-07 11:18:51 +00:00
Sam Cackett 5c2d50d901 Add hover states to IconView and TaskThumbnailView in Overview
- Hover over IconView passes to FastBitmapDrawable
- Hover over TaskThumbnailView bounds highlights the border
- Hover over TaskView outside of IconView or Thumbnail does nothing
(previously highlighted a border incorrectly)

Bug: 342594235
Test: OverviewTaskViewHoverImageTest, OverviewDesktopTaskImageTest
Flag: com.android.launcher3.enable_hover_of_child_elements_in_taskview
Change-Id: I5b0753bdec609a4a6658a35422e2823c4ed109fc
2024-08-07 08:22:44 +00:00
Jagrut Desai 6b39f2d40e Merge "Ignoring TaskbarEduTooltipControllerTests" into main 2024-08-06 23:15:06 +00:00
Jagrut Desai 5643f48bb8 Enable TaskbarEduTooltipControllerTests with rule ordering
Test: Presubmit
Bug: 356155191
Flag: TEST_ONLY
Change-Id: If4a03033424c07e37f2cb3f792e75a64a55fb67b
2024-08-06 14:11:38 -07:00
Jagrut Desai 3baa8a7f70 Ignoring TaskbarEduTooltipControllerTests
Test: Presubmit
Bug: 356155191
Flag: TEST_ONLY

Change-Id: I2aa0c0822ea4458484d7a04e38004ddc60f7c982
2024-08-06 13:04:47 -07:00