Commit Graph

2291 Commits

Author SHA1 Message Date
Sukesh Ram aad306396e Increase IME switcher Left Margins to meet spec
Increase IME switcher Left Margins to meet specifications for taskbar. Result: https://screenshot.googleplex.com/5Ab33jnZiDY5tqm

Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 324269623
Change-Id: Ife3714c4d22d96851618a88ed217009c4f9c3929
2024-03-21 01:04:28 +00:00
Bill Yi 6e5f97b5e5 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-15 20:30:19 +00:00
Shamali Patwa a835a2dc92 Merge "Rename the color attr for paging dot indicator used in launcher." into main 2024-03-15 13:33:40 +00:00
Bill Yi 6cb64e97dd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I80374e1c3d831e5afc0436c95cd6aba8fced52ea
2024-03-14 22:09:01 -07:00
Shamali P 34d1db731b Rename the color attr for paging dot indicator used in launcher.
Additionally, make the widgetPickerActivity theme support dark mode.

http://screencast/cast/NDY5OTUzNTA0ODcwNDAwMHxmZWU3ZDBjZS04ZQ

Bug: 326092660
Test: Manual
Flag: N/A
Change-Id: Ic2816853bd25bd04e07d661682d720d1940c268c
2024-03-14 19:38:37 +00:00
Schneider Victor-tulias dba7cbae1a Update KQS task view layouts to new specs
The small size of the screenshots and make text look odd. Implementing new UI specs to improve this.

- Updated icon position and size
- Added some blur to the thumbnail

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328259439
Fixes: 328692456
Test: opened KQS in dark and light mode
Change-Id: I2b20100ddeb562291edf5f0bacbce916002eee45
2024-03-13 15:03:45 -04:00
Bill Yi 4266c83ed6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I862c3d90608b8b67f3b5d10ec8cc2152c38a39fd
2024-03-07 22:06:56 -08:00
Ats Jenk 60101ae7fc Merge changes from topic "bubble-bar-drag" into main
* changes:
  Fix bubble bar arrow visibility during animation
  Animate bubble bar location changes
  Introduce bubble bar location that is driven by shell
2024-03-07 19:42:17 +00:00
Ats Jenk 4186cf1b96 Fix bubble bar arrow visibility during animation
Bubble bar pointer arrow was being drawn outside of BubbleBarView
bounds.
This caused issues when alpha was applied to the BubbleBarView. With
alpha, BubbleBarView draw was clipped to its bounds and arrow was no
longer visible. This led to the arrow flickering during move animations.
Move animation updates alpha.
Move the pointer arrow inside the bounds of the bar view. Update the bar
height to include the arrow.
Update callers who rely on bubble bar content height to take into
account extra height for the arrow.

Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: move bubble bar left and right, observe arrow is visible
Change-Id: I05866b5c944361b2f10437c3641527ed3c594047
2024-03-06 15:06:05 -08:00
Ats Jenk cd0f35383f Introduce bubble bar location that is driven by shell
Adds bubble bar location to the update object that is sent by shell.
Allows repositioning the bubble bar if the location changes.

Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT

Test: manually sending the update to reposition, dragging coming soon
Change-Id: Id430a98116d860a7badcf607edc166c751e12cf8
2024-03-06 10:17:11 -08:00
Vinit Nayak 91b06fb4ac Revert "Revert "Implements the "Save App Pair" button in Overvie..."
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Reason for revert: Test failure in question wasn't related to this topic b/328016248

Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
2024-03-04 12:26:23 -08:00
Treehugger Robot 2be60d98a8 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-04 17:25:25 +00:00
Jeremy Sim 742f710168 Merge "Fix bug with TalkBack not reading out SplitInstructionsView" into main 2024-03-03 00:18:47 +00:00
Bill Yi 2320d553c7 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1e8590b55cd77be368a46668cc8764463a264ebf
2024-03-01 19:32:34 -08:00
PODISHETTY KUMAR b588e4618b Merge "Revert "Implements the "Save App Pair" button in Overview Actions"" into main 2024-03-01 09:27:08 +00:00
Jeremy Sim d2c28c7ee3 Fix bug with TalkBack not reading out SplitInstructionsView
This CL sets an accessibility title so that TalkBack and other tools will properly read out the instructions on SplitInstructionsView.

Fixes: 323461342
Flag: ACONFIG com.android.wm.shell.enable_split_contextual TRUNKFOOD
Test: TalkBack announces the instructions immediately when the view appears, and is not interrupted.
Change-Id: I1666f0c374d40b31d732d3cca529f03a7f2f7f28
2024-02-29 21:35:20 -08:00
Vinit Nayak 5c8978c4db Revert "Implements the "Save App Pair" button in Overview Actions"
Revert submission 26391074-save-app-pair-button

Reason for revert: breaks image comparison tests b/327665771
Reverted changes: /q/submissionid:26391074-save-app-pair-button

Change-Id: Ic4580fc39d8394771551f100932157e6ef35c4b7
2024-03-01 01:02:35 +00:00
Bill Yi 08fe4d0135 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-29 23:12:58 +00:00
Bill Yi 70799d4540 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If0d3c974835120248fb17d97fd678ef5921a46a8
2024-02-28 21:55:23 -08:00
Jeremy Sim 41d8ae8a7a Implements the "Save App Pair" button in Overview Actions
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!

This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.

Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
2024-02-28 19:39:04 -08:00
Sam Cackett fe2ff288de Merge "Set max height on TaskMenuView and scroll if too many elements" into main 2024-02-27 17:02:51 +00:00
samcackett 6c93e88faf Set max height on TaskMenuView and scroll if too many elements
Video of functionality: http://shortn/_pz6qhz5yxM

Fixes: 210466650
Test: Manual
Flag: NONE
Change-Id: I8b7873cf03857ee3be047ab30388e679f7a95bfd
2024-02-27 12:45:53 +00:00
Helen Cheuk 96fd73ed84 Merge "Stash taskbar when software keyboard is docked" into main 2024-02-27 10:40:07 +00:00
Bill Yi 697cb554a6 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-23 00:10:50 +00:00
Saumya Prakash 502f7b94f0 Merge "Increase taskbar edu Done button size to meet accessibility requirements." into main 2024-02-22 18:40:35 +00:00
Bill Yi def24aa88d Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I543d305f3f7587d6459fb1a926872bea5cf6ab1d
2024-02-21 16:45:43 -08:00
helencheuk 00ddb5e3a9 Stash taskbar when software keyboard is docked
Stash taskbar when
1) Software keybaord is docked
2) Input toolbar is placed at the taskbar area (stash so toolbar and taskbar would not overlap)

Testing result:
https://drive.google.com/file/d/1NMDexHl0FgyHFaOUh_GSEEUU2k08STJH/view?usp=sharing

Bug: 317251202
Test: TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet
Flag: N/A

Change-Id: I90662bc6e68f644e919f5c702059476b02519ed6
2024-02-21 23:03:03 +00:00
Saumya Prakash 0e126d5550 Increase taskbar edu Done button size to meet accessibility requirements.
Touch targets have to meet a minimum of 48 dp to meet accessibility
requirements. The Done button in taskbar education was previously too short.

Fixes: 320600718
Test: Manual
Flag: N/A
Change-Id: I5fae302b82585e9793d7ede42dbcc6e6395254da
2024-02-21 22:21:49 +00:00
Alex Chau 60ad90e519 Always run animateClose when closing TaskMenuView
- This avoid diverging code path when animation is off
- Also made sure menuTranslationX and Y always reset when not needed
- Also remove AnimatedVectorDrawable in favour of scale animation in code, as AnimatedVectorDrawable doesn't work well when animation is off

Bug: 319086207
Test: OverviewMenuImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I4a18cf4aac3237031095c2600c777b6c4c3e518f
2024-02-16 14:58:14 +00:00
Bill Yi 6ea90c84cc Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-15 18:10:21 +00:00
Andy Wickham 1abc0a7f66 Merge "Extract TaskbarViewCallbacks to a separate class + factory." into main 2024-02-14 23:15:55 +00:00
Bill Yi dd1e2b4ca8 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I700a0f73ccd8360cb672bfc936b48b8e9e01b79f
2024-02-14 13:03:49 -08:00
Andy Wickham 0ae51bcdb9 Extract TaskbarViewCallbacks to a separate class + factory.
Also log long presses on the taskbar all apps button.

Test: Manual
Flag: NA
Change-Id: Id2bf194f09007bfccff9f83162e4bcfb6562580f
2024-02-13 18:51:48 -08:00
Schneider Victor-tulias 322410712a Update the KQS overflow icon
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 324886878
Test: opened KQS with 0 and 7+ recent apps
Change-Id: I2496841c6d8bb24d1c90d58eecc18726827ae993
2024-02-13 23:49:25 +00:00
Schneider Victor-tulias 4a9ffb021f Merge "Update KQS empty message text/icon colors" into main 2024-02-13 23:46:31 +00:00
Saumya Prakash e1c6312800 Merge "Update back gesture tutorial strings to align with UX" into main 2024-02-13 22:48:17 +00:00
Schneider Victor-tulias 7bfd3ef9a0 Update KQS empty message text/icon colors
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 324902935
Test: opened KQS with 0 recent apps
Change-Id: I1aed3293d76c0f3abbf6e5e0d646531739eac3f8
2024-02-13 10:40:16 -05:00
Saumya Prakash 96ce6873dd Update back gesture tutorial strings to align with UX
This change updates the feedback shown to users to align with the
strings in figma for the back gesture tutorial.

Fix: 300919987
Test: Went through both the redesigned and previous gesture tutorial and
ensured the updated strings show up in the redesigned tutorial.
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED

Change-Id: I057af6e8631b86ffaec8093ffbfbeae01c9d917c
2024-02-13 00:35:37 +00:00
Alex Chau beb3053f3b Use bigger task size in app to overview carousel
- Introduced carouselTaskSize that represent size of TaskView in app to overview carousel, that is bigger than size of TaskView in Overview state
- Use nonGridScale and translation to scale TaskView to the desired carousel size
- For current task, inroduced carouselScale and translation to apply similar transformation at the carousel. They will be reset in `onPrepareGestureEndAnimation` after gesture is released and form the grid. Carousel translation can be invalidated and aniamte to 0.
- Fixed current task left/right wiggle that is caused by task shrinks and translate in different direction. Pivot is now moved to top right (or top left for RTL), to align with movement of current task.
- To compensate for the pivot change, current task is translated back to the carousel position by taskTranslation, and again translated by carouselTranslation for carousel -> fullScreen scaling. A complex interpolator is introduced to make current task moves in a vertical straight line rather than a curve.
- Fixed a bug in AnimatorControllerWithResistance when scaleStartResist==scaleMaxResist that causes division by 0. For grid overview, resistance kicks in after reaching carousel size, and current task size won't reduce further
- Added PendingAnimation#addAnimatedFloat that uses animator provided by AnimatedFloat, so the animator can be canceled and reaniamte from AnimatedFloat side; AnimatedFloat now clears the property values during cancel so the canceled animator still referenced by PendingAnimation can no longer change the values

Fix: 318352235
Fix: 308643507
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: presubmit
Change-Id: I2872d8b2204798fe5e05c10d08480a81e60bb498
2024-02-12 12:06:05 +00:00
Uwais Ashraf c2f73d9091 Merge "App chip refactor" into main 2024-02-09 13:43:03 +00:00
Uwais Ashraf 99fdf7a75e App chip refactor
- Adds background outline replacing 2 circles + rect approach. This
enables easier shadow drawing code.
- Simplify structure of AppChipView.
- Adds an anchor View to simplify laying out of menu around app chip

Bug: 313644427
Bug: 317007147
Fix: 322760765
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest
Change-Id: I56c2644779863c083ae475a740a84321b1d0c396
2024-02-09 12:09:42 +00:00
Bill Yi 768e23cfae Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I648c9803a9d4f7f8c65fd48287133f0301418539
2024-02-08 04:45:45 -08:00
Saumya Prakash 548add276e Merge "Increase the character limit for translations in taskbar pinning edu" into main 2024-02-05 23:44:58 +00:00
Jordan Silva d5df5b3e11 Merge "Refactoring TAPL functions for OverviewTask" into main 2024-02-05 23:03:49 +00:00
Saumya Prakash 1613fe6b13 Increase the character limit for translations in taskbar pinning edu
The current character limit for the taskbar pinning edu subtitle does
not fit many translations. We are increasing the character limit to
enable proper translations.

Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Fix: 323943380
Test: N/A
Change-Id: I56225711c475e617451e5db0b1c226e3603e5c02
2024-02-05 21:40:38 +00:00
Jordan Silva ebd71c6cc9 Refactoring TAPL functions for OverviewTask
This CL refactors some methods in OverviewTask to rely on OverviewSplitTask. It also changes the BaseOverview getTasks function to retrieve the parent task and support cases where only the bottomright_snapshot is available in the recent tasks.

Bug: 320633351
Test: TaplTestsSplitscreen
Flag: N/A
Change-Id: I226f895810ce3b46cc107f76cd85e2918abf7088
2024-02-05 13:50:23 +00:00
Jagrut Desai 4d24ad9cbf Change Persistent/Pinned Taskbar App Icon Size to 40dp
Test: Manual, Presubmit
Bug: 322315240
Flag: NONE
Change-Id: Ibef82e18bbe33af51b27310ccd8052a02a35522c
2024-01-31 13:53:12 -08:00
Bill Yi 2ee336096c Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-01-28 20:57:58 +00:00
Vinit Nayak 53eb01bcb5 Merge "Update split instructions text for contextual" into main 2024-01-25 23:25:58 +00:00
Vinit Nayak d441d7d22e Update split instructions text for contextual
Test: Visually saw different string for contextual
Bug: 322117067
Flag: aconfig com.android.wm.shell.enable_split_contextual
Change-Id: I92b09bc47d29ba5dd83d09f78aaf8d67e855dd36
2024-01-25 13:28:06 -08:00