Commit Graph

9168 Commits

Author SHA1 Message Date
Andreas Agvard eea784aea8 Adds an flag guarded extension point for long press nav handle behavior
Bug: 282993230
Flag: ENABLE_LONG_PRESS_NAV_HANDLE disabled
Test: Manual

Change-Id: I541886cc13af1db46bc38d4e18556be99bef7713
2023-05-24 16:24:42 +02:00
Luca Zuccarini 5a5b110030 Merge "Remove redundant instances of depth controller." into udc-dev am: f898ee474c am: 100ea1d75a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23390637

Change-Id: I8633d53d08a053bf552b307ad546efc9a999a28e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-24 13:02:12 +00:00
Luca Zuccarini f898ee474c Merge "Remove redundant instances of depth controller." into udc-dev 2023-05-24 11:35:21 +00:00
Luca Zuccarini a96dcb0cc7 Remove redundant instances of depth controller.
During each app launch, a new `MyDepthController` is instantiated, which
registers two of its methods as listeners for cross window blur and
opaqueness. This controller's usefulness spans that specific animation
only, but the listeners are never unregistered. This creates conflicts
when an opaqueness signal happens, which cause the background to flicker
(see videos).

Bug: 283335820
Test: manual, see videos in the bug
Flag: not needed, bug fix
Change-Id: I3dcb0b8ff0aa77bf3183a926889d0131b17bcaa4
2023-05-23 15:33:17 +00:00
Tony Huang 7bae2b82ef Merge "Hide divider immediately if going to launcher" into udc-dev am: 2d586455dc am: 645158f067
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23368297

Change-Id: I89962cb8501423c7d365e9d145ed97c8ad003ae3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-23 04:15:09 +00:00
Yunfan Chen 0135f1748b Merge "Migrate the insetsRoundedCornerFrame to InsetsFrameProvider" into udc-qpr-dev 2023-05-23 04:01:39 +00:00
Tony Huang 2d586455dc Merge "Hide divider immediately if going to launcher" into udc-dev 2023-05-23 03:04:18 +00:00
Treehugger Robot 3550f03c8d Merge "Adding debug tracing for b/262282528" into udc-dev am: 25e94ccb1b am: 8f9cc84297
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23359117

Change-Id: I187c7b00e47d3a67f748e2d9c250e6ee77d44e53
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-23 00:17:29 +00:00
Treehugger Robot 25e94ccb1b Merge "Adding debug tracing for b/262282528" into udc-dev 2023-05-22 22:48:47 +00:00
Schneider Victor-tulias 1ba474a657 Merge "Update BorderAnimator to work with layout updates" into udc-dev am: b323851e01 am: 56ae9055d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23320817

Change-Id: I6fd06cab51198d0ba440eea5cb235ecebb6ee1b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 21:52:13 +00:00
Schneider Victor-tulias 28821554ac Merge "Fix redesigned gesture nav jank" into udc-dev am: bd0188abd1 am: 3a32a4d20b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23267694

Change-Id: I19b409a952d0e88f19846ed87951921fa50c117a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 20:23:56 +00:00
Schneider Victor-tulias b323851e01 Merge "Update BorderAnimator to work with layout updates" into udc-dev 2023-05-22 20:17:35 +00:00
Schneider Victor-tulias bd0188abd1 Merge "Fix redesigned gesture nav jank" into udc-dev 2023-05-22 19:01:35 +00:00
Jagrut Desai dbd4079ec1 Merge "Fix Taskbar Education Tooltip Bottom Margin" into udc-dev am: 6acf350107 am: a6b655ade5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23269396

Change-Id: I5d38212bba1fe03243364f3e14490344553c68e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 18:38:46 +00:00
Schneider Victor-tulias 7dee27f470 Update BorderAnimator to work with layout updates
1. if a 'ViewScaleTargetProvider' is being used, this can cause a crash
2. otherwise, the old border bounds are reapplied, which is likely no longer correct

Updated BorderAnimator to use 'BorderAnimationParams' rather than 'ViewScaleTargetProvider'. This removes some unnecessary null checks while making the util class simpler to use. It also allows us to listen for specific view events for the border animation.

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 283272516
Test: opened the keyboard quick switch view and highlighted a view in recents view, then rotated the screen several times
Change-Id: I7959d6cd892ebcdd2c68163dd56c358815494af6
2023-05-22 11:33:57 -07:00
Tracy Zhou faa2fa0285 Merge "[Trackpad] Gesture navigation in 3-button mode" into udc-qpr-dev 2023-05-22 17:52:04 +00:00
Jagrut Desai 6acf350107 Merge "Fix Taskbar Education Tooltip Bottom Margin" into udc-dev 2023-05-22 17:04:25 +00:00
Treehugger Robot 7eeaae488e Merge "Add developer option to tweak All Apps from Overview threshold." into udc-qpr-dev 2023-05-22 16:06:42 +00:00
Tony Huang 2083c5450d Hide divider immediately if going to launcher
Divider should hide immediately when going to launcher, this fix
the divider hidden delay in 3-btn-nav mode.

Fix: 283058496
Test: manual
Test: pass existing tests
Change-Id: Ia4eaba8020c564cc95b8652fe0f7066b653b9df4
2023-05-22 16:38:14 +08:00
Tracy Zhou 6a71c2a6f5 [Trackpad] Gesture navigation in 3-button mode
Back gesture will be in a separate change

Bug: 279948218
Test: https://recall.googleplex.com/projects/3388b17c-d22f-46f8-b140-a102690377b4/sessions/0b8e838a-89b0-4451-ad44-df2916db877d
Change-Id: I1f14ca873efa33684e36ac1f0f72d766815752ae
2023-05-21 22:45:37 -07:00
Jon Miranda d88ce20005 Merge "Fix SUW unstash animation." into udc-dev am: 9e0eee3729 am: bdb4531729
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23352149

Change-Id: I38e1d23e36c9e67d5bdd3cd273b6e6573d145945
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-20 21:00:10 +00:00
Jon Miranda 9e0eee3729 Merge "Fix SUW unstash animation." into udc-dev 2023-05-20 20:16:17 +00:00
Jon Miranda 0aef6981ac Fix SUW unstash animation.
- Defer any UI updates to taskbar after the SUW unstash animation is created.
- Predicted app icons take longer to load, so it's possible that they are
  added after the animation is created.
- This avoids the case where icons are seemingly in the taskbar but
  do not get animated like the rest of the icons.

- We also need to call onAnimationStart for the reveal animation immediately,
  otherwise the clipToOutline params never get set.

Bug: 277712185
Test: flash device, very quickly go through SUW
Change-Id: I4c3089da0d20bf91672e2305655c4c37b1f367aa
2023-05-19 17:24:50 -07:00
vadimt 144a9508be Adding debug tracing for b/262282528
We see two long-clicks on the taskbar instead of expected one.

Bug: 262282528
Test: presubmit
Change-Id: I231d54ac08cf53ac7b0b6177da6b671314998021
2023-05-19 17:04:04 -07:00
Jagrut Desai 709242e89e Fix Taskbar Education Tooltip Bottom Margin
Test: Manual
Bug: 282990924
Flag: Not needed
Change-Id: I977e7fc84382b1c43612516c8d6f27610ad25a3f
2023-05-19 15:45:41 -07:00
Andy Wickham af5bb30141 Add developer option to tweak All Apps from Overview threshold.
Ability to move threshold from shift 1.05 to 5.0. Saved as an int
from 105 to 500. Shift 1.0 is where Overview rests; using this
value exactly causes a slight glitch while settling.

Demo (slightly outdated min value and flavor text):
https://drive.google.com/file/d/1PaS4MjFM1P9ZHQ-400tXUbDz_-z8qYtC/view?usp=drive_link&resourcekey=0-ZX-ofW4AzN0-Qjqo4OmU-g

Bug: 281717218
Test: Manual
Flag: ENABLE_ALL_APPS_FROM_OVERVIEW
Change-Id: I5acfb46f9df16e9d3091a7822c449301bc6067f9
2023-05-19 21:26:35 +00:00
Vinit Nayak c83f94cde3 Merge "Separate code paths to launch split from existing pair vs new pair" into udc-dev am: 258019fe8e am: 1f27273c06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23320818

Change-Id: I11104b119109468f3b0984fb670b6196c418b97d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-19 18:43:42 +00:00
Vinit Nayak 258019fe8e Merge "Separate code paths to launch split from existing pair vs new pair" into udc-dev 2023-05-19 17:51:23 +00:00
Hongwei Wang ba46fe8f94 Merge "Notify WMShell on aborting auto-enter-pip" into udc-dev am: 0c66b151e3 am: 2ef78aa7d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23321279

Change-Id: I65f500cbd7280ec09b7feeef096c74b7372c7454
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-19 01:03:33 +00:00
Saumya Prakash ae2aab9217 Merge changes If2c82082,I03532b80 into udc-dev am: 66e7ec721b am: 1b12262d07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23159151

Change-Id: I31b599f7b1e3cd4a3ed6dc659ba9b3f5b258334b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 23:13:58 +00:00
Hongwei Wang 0c66b151e3 Merge "Notify WMShell on aborting auto-enter-pip" into udc-dev 2023-05-18 23:00:03 +00:00
Ats Jenk 7377639653 Merge "Show a persistent toast when selecting desktop apps on home screen" into udc-qpr-dev 2023-05-18 22:24:26 +00:00
Saumya Prakash 66e7ec721b Merge changes If2c82082,I03532b80 into udc-dev
* changes:
  Update Lottie animations for gesture navigation tutorial to enable custom colors
  Update gesture tutorial colors
2023-05-18 22:01:49 +00:00
Schneider Victor-tulias 9caa0f9559 Fix redesigned gesture nav jank
- Removed the fake animated taskbar view from the redesigned tutorial flow
- Fixed the hotseat and home icon colors from the overview step

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Fixes: 281121701
Fixes: 283310758
Test: swiped up from home/overview step
Change-Id: Ie659495994f0c935c5b6c6bf1ae534ec51521726
2023-05-18 14:36:28 -07:00
Treehugger Robot 1967be3a1f Merge "Fix widget clipping in widget back animation" into udc-dev am: 80e9a3b64e am: 43f6b63317
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23267682

Change-Id: I234f78049ce344eb46c72cc978504a1395918eb0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 21:12:50 +00:00
Hongwei Wang 45b8d39ab8 Notify WMShell on aborting auto-enter-pip
Note that this change does not fix the bug listed here. This is to
callback WMShell when the transition is aborted and WMShell can choose
how to handle this.

Bug: 283177443
Test: adb shell dumpsys activity service SystemUIService WMShell
Test: go/winscope and check the SF/WM dump
Change-Id: I8abfc2db47d1f0bfc3d400066936bed354743420
2023-05-18 13:15:57 -07:00
Jagrut Desai 8c78798b26 Merge "Fixing spacing between folder icon and folder itself" into udc-dev am: b9a88db27c am: 59802b88ae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23269297

Change-Id: I37848a59e92af89b9c1732c28f6e2966523a9531
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 20:02:16 +00:00
Treehugger Robot 80e9a3b64e Merge "Fix widget clipping in widget back animation" into udc-dev 2023-05-18 19:59:21 +00:00
Saumya Prakash 0a6fb2c9e1 Update Lottie animations for gesture navigation tutorial to enable custom colors
This change introduces tokens for all the lottie animations in the
gesture navigation tutorial so that the colors can be changed to match
with the current design spec at http://shortn/_aig7n8W7rF

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Bug: 281764891
Test: Tried changing colors and verified that lottie animations changed
appropriately.

Change-Id: If2c820826603fb1cf424f5f0c97d83b195d26606
2023-05-18 10:47:44 -07:00
Schneider Victor-tulias 474f3c4e90 Update gesture tutorial colors
- Updated all redesigned gesture nav menu and tutorial colors to dynamic color spec

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 281764891
Bug: 279823249
Test: launched tutorial menu and tutorial steps
Change-Id: I03532b80c6e14867c1374bbdf9f984c1cece9809
2023-05-18 10:47:33 -07:00
Vinit Nayak 6ab2786d16 Separate code paths to launch split from existing pair vs new pair
* Launching existing pair doesn't rely on any existing
data/state in SplitSelectStateController or SplitSelectDataHolder
* Consolidate launchTask*() methods in GroupedTaskView

Test: TaskThumbnailViews measured correctly, animation
correct on small+large screen, initiating split
still working
Fixes: 274540670
Flag: none needed

Change-Id: Id359f53ac5f2bba19948d4ae3231092fb90cc7c5
2023-05-18 10:43:17 -07:00
Jagrut Desai b9a88db27c Merge "Fixing spacing between folder icon and folder itself" into udc-dev 2023-05-18 17:21:33 +00:00
Ats Jenk 9f11519936 Show a persistent toast when selecting desktop apps on home screen
When desktop stashed state changes, show a persistent popup on home
screen to select an app that will be launched on desktop.

Flag: persist.wm.debug.desktop_mode_2
Bug: 261234402
Test: launch an app on desktop, swipe home, observe the popup, launch an
  app, observe app is launched on desktop and popup is hidden
Test: stash desktop apps by going home while on desktop, press on the
  "exit desktop" button in the popup, observe popup is hidden, launch an
  app, observe it is launched in fullscreen

Change-Id: I66fe0ab977fa7b2059f149d7d0ab0cf92192c967
2023-05-18 09:31:27 -07:00
Tracy Zhou d7c00cb8b4 Disallow two finger gesture nav behaviors when the cursor is in the zones
- This change addresses swipe up and quick switch from the nav bar area using two fingers
- Separate changes will be implemented in SysUI to disable two finger swipe down from the status bar area and two finger swipe edge swipe for back

Bug: 283112069
Test: manual
Change-Id: I67c7ba31e759d5693d89112fd8f37f3d2a9eaa41
2023-05-18 00:33:04 +00:00
Sihua Ma f8acb23e1f Fix widget clipping in widget back animation
Test: Manual
Fix: 280261814
Change-Id: I4db24ca624d50b1d860df428fdab9d591f35ac5e
2023-05-17 13:32:20 -07:00
TreeHugger Robot e607fdb2a2 Merge "Removing support for lagacy shortcuts" into udc-qpr-dev 2023-05-17 19:25:45 +00:00
Saumya Prakash 7d7a07590a Merge "Display app icons in quick switch task view when there are no updates." into udc-dev am: e212779ffd am: 289de879b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23270250

Change-Id: I1aec6d672a6d2a9e967796256dd99b7b4dff0854
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-17 19:02:27 +00:00
Saumya Prakash e212779ffd Merge "Display app icons in quick switch task view when there are no updates." into udc-dev 2023-05-17 17:11:49 +00:00
Sunny Goyal e274d97fe5 Removing support for lagacy shortcuts
> Addition/removal of  shortcus is already removed. This just
  cleans up the unused code path

Bug: 275875209
Test: Updated tests
Flag: N/A
Change-Id: I8ab7f57b693f996920e50e8beecafcffab5167e9
2023-05-17 09:20:45 -07:00
Alex Chau 7af659da9e DisplayController should deep compare mPerDisplayBounds
- In CHANGE_SUPPORTED_BOUNDS check, it uses Map.equals, but as the value is a primitive array WindowBounds[], equals check does not deep compare the arrays and may result in false negative
- One example is when fontScale changes, DisplayController re-create bounds from WindowManagerProxy, result in new WindowBounds[] created, and the shallow compare results in unexpected CHANGE_SUPPORTED_BOUNDS

Fix: 282736623
Test: DisplayControllerTest
Change-Id: I3897595c58559192b951ecfee7c9f62a07dafe1f
2023-05-17 09:40:46 +00:00