Commit Graph

6810 Commits

Author SHA1 Message Date
Alex Chau ac61bed9a8 Merge "TaskbarViewController should only translate on rotation if icon is aligned with hotseat" into tm-qpr-dev am: 2f581b799b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20748309

Change-Id: Iffd7b5a38263fbbb019b1ddd15ebc500425ee94f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 19:20:51 +00:00
Jeremy Sim c3fabd892a Merge "Fix bug with Taskbar second-app-selection animation" into tm-qpr-dev am: e8eb4a3c48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20704401

Change-Id: I5b69d3a32c6a0ba95dce3f64f8e314af9e292164
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 19:19:24 +00:00
Alex Chau 2f581b799b Merge "TaskbarViewController should only translate on rotation if icon is aligned with hotseat" into tm-qpr-dev 2022-12-16 19:06:25 +00:00
Jeremy Sim e8eb4a3c48 Merge "Fix bug with Taskbar second-app-selection animation" into tm-qpr-dev 2022-12-16 18:30:38 +00:00
Alex Chau a1608fb21a Merge "Set iconsSizePx of Taskbar's DeviceProfile directly" into tm-qpr-dev am: 98d33cdff9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747426

Change-Id: Iabd35264bf880d76d6a669b29f614a8d86334adc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 17:25:04 +00:00
Alex Chau 98d33cdff9 Merge "Set iconsSizePx of Taskbar's DeviceProfile directly" into tm-qpr-dev 2022-12-16 16:45:21 +00:00
Alex Chau adbbc2f7fa TaskbarViewController should only translate on rotation if icon is aligned with hotseat
Fix: 254191175
Test: With 3 button, rotate at home and overview, nav button are at expected position. Repeat with TASKBAR_IN_OVERVIEW flag off.
Change-Id: I1e629e6be92c4793d3dfdb0dac60c3bfce886e7a
2022-12-15 22:04:16 +00:00
Sunny Goyal 37dd2e6691 Merge "Unifying multiple all-apps implementations" into tm-qpr-dev am: 09fab7ee7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713205

Change-Id: I1bd905e44924ec55f8f7cb254d66f9f751357590
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 17:28:53 +00:00
Alex Chau a68164d89e Set iconsSizePx of Taskbar's DeviceProfile directly
- After ag/20691430, iconScale no longer scale app icons (I should rename it later, after QPR2), so we'll need to set the desired iconSize directly for Taskbar's DeviceProfile
- Extracted setting iconSizePx and testSizePx out of updateIconSize, as they are no longer affected by scaling. This allows TaskbarActivityContext to set desired iconsize and then call updateIconSize

Bug: 256976071
Test: Test Taskbar icon size in different density
Change-Id: I741c178b59e0d8ecb4c63689e68767622329379c
2022-12-15 17:05:12 +00:00
Sunny Goyal 09fab7ee7d Merge "Unifying multiple all-apps implementations" into tm-qpr-dev 2022-12-15 17:03:05 +00:00
Schneider Victor-tulias fa854bd707 [DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds. am: 80b25c756a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20652594

Change-Id: I546f4a2c97c5dd18f55993cfb528fe2e76aef095
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 10:29:01 +00:00
Schneider Victor-tulias 85127b4f47 Merge "[DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds." into tm-qpr-dev 2022-12-15 09:42:15 +00:00
Jeremy Sim 768e9ec8c0 Fix bug with Taskbar second-app-selection animation
This patch makes it so that the correct animation will play when the user selects a second app from the Taskbar.

Previously, when the user selected a second app from the Taskbar, an animation would play showing the expansion of the app -- but it would come from the wrong place. The error occurred because when we calculate the animation start position, we assume that the starting view is located in the DragLayer, which fills the whole screen. But in cases where the starting view is located in the Taskbar, the root view is actually the TaskbarDragLayer, which only fills an area on the bottom part of the screen.

Fixed by adding a check to see if the starting view is part of the TaskbarActivityContext, and if so, adding an offset to calculate the correct DragLayer coordinates.

Fixes: 258692761
Test: Manual
Change-Id: I4026676fefe1e4c5cdf9d9a47d95c0d6e64672e8
2022-12-14 17:48:14 -08:00
Brian Isganitis 4aa2644629 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev am: f5c099b528
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20726289

Change-Id: I0184935622d8892842af29629ed96eff65e9507b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 20:50:23 +00:00
Brian Isganitis f5c099b528 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev 2022-12-14 20:25:21 +00:00
Jon Miranda 80f6ece5ad Merge "Taskbar All Apps button visual updates" into tm-qpr-dev am: a0743cf62c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20724415

Change-Id: Ib3ff9ebcfd645a6f929e17e17aec4f14b070b7ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 19:33:23 +00:00
Brian Isganitis 71f9faded9 Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev am: 8216a26bfe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713695

Change-Id: Ic5f32fca6c7f56c9e17cdc68bc0416c0881e2fd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 19:32:50 +00:00
Sunny Goyal adb364a104 Unifying multiple all-apps implementations
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher

Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
2022-12-14 11:27:12 -08:00
Jon Miranda a0743cf62c Merge "Taskbar All Apps button visual updates" into tm-qpr-dev 2022-12-14 19:00:18 +00:00
Brian Isganitis 8216a26bfe Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev 2022-12-14 18:54:42 +00:00
Jon Miranda e7417ce2ae Taskbar All Apps button visual updates
- Moved to new position
- Using 3x3 icon
- New Colors

Checked with visd that this half is good to go,
will follow up with positioning of the 3x3 icon within
its container.

Bug: 259712417
Test: manual, LTR/RTL modes, transient/persisent models

Change-Id: I298b6dbca004cdb8920e6533fffc8ca83e0197f9
2022-12-13 15:16:01 -08:00
Brian Isganitis 47da4167ea Assign taskbar EDU same interpolator as all apps.
This polishes closing both at the same time when they are on top of each
other.

Test: Manual
Bug: 217261955
Change-Id: Iecb8658b98debb0225d3b59da99ecb34d008971a
2022-12-13 16:43:36 -05:00
Brian Isganitis 2a2f1b6cd3 Polish all apps taskbar unstash behavior for transient and persistent.
- During gestures from taskbar all apps, unstash immediately in
  transient.
- Overlay closes sooner if all apps is open (still done later for EDU).
- Taskbar stashes in overview when All Apps is opened.
- Transient app-window threshold is ignored if All Apps is opened.

Test: Manual
Fix: 262076812
Change-Id: I46b2dcdc75ee0cc15c1b47da2139ff8c20cf618a
2022-12-13 16:24:35 -05:00
Pat Manning 2eca15a02f Merge "Include taskbar cropped insets in thumbnail aspect ratio difference calculation." into tm-qpr-dev am: 59c4fff67c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20643015

Change-Id: Id044d04b165d334931afb3cfc3754c5b4e0f4abf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-13 18:59:11 +00:00
Jeremy Sim 8ccaa6a33d Merge "Use already-running app instances when splitting" into tm-qpr-dev am: 538281db37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20625907

Change-Id: If7edcfa37908409a48c6a4db9031fab0fe2414a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-13 18:57:59 +00:00
Pat Manning 59c4fff67c Merge "Include taskbar cropped insets in thumbnail aspect ratio difference calculation." into tm-qpr-dev 2022-12-13 18:29:27 +00:00
Jeremy Sim 538281db37 Merge "Use already-running app instances when splitting" into tm-qpr-dev 2022-12-13 18:21:12 +00:00
Pat Manning 0333ec1d21 Include taskbar cropped insets in thumbnail aspect ratio difference calculation.
Bug: 260861673
Test: manual.
Change-Id: I3abed4dfab5dccf99ae81e0f2d0ae840a3aabed5
2022-12-13 11:45:05 +00:00
Andy Wickham a89df1e47f Merge "Adds header protection on tablet all apps panel." into tm-qpr-dev am: 29b95b58ba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20546292

Change-Id: I09030c24485b7b25a2eb72d90e4515d6e9ea3960
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-12 19:29:48 +00:00
Andy Wickham 29b95b58ba Merge "Adds header protection on tablet all apps panel." into tm-qpr-dev 2022-12-12 19:08:37 +00:00
Jon Miranda e34202df54 Merge "Better support transient and persistent taskbar in taskbar's overlays." into tm-qpr-dev am: a76222d209
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20693438

Change-Id: I54a1a4198047d658def291ec70fc8530b42ad6b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-10 02:03:49 +00:00
Brian Isganitis 3030ccf26b Merge "Add logging to investigate updateOverviewTargets state." into tm-qpr-dev am: 570c5146d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680311

Change-Id: If5371ef5eaf0b1c37ee506dae619e311977490b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-10 02:02:59 +00:00
Jon Miranda a76222d209 Merge "Better support transient and persistent taskbar in taskbar's overlays." into tm-qpr-dev 2022-12-10 02:02:54 +00:00
Brian Isganitis 570c5146d3 Merge "Add logging to investigate updateOverviewTargets state." into tm-qpr-dev 2022-12-10 01:22:13 +00:00
Federico Baron 2263b57d8d Merge "Move AnimatedFloat from quickstep to launcher" into tm-qpr-dev am: 9a6a2c8a2d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20683305

Change-Id: Ib0f4ad639670fce70e9431f8c8cb9f2663722c77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 23:56:31 +00:00
Federico Baron 9a6a2c8a2d Merge "Move AnimatedFloat from quickstep to launcher" into tm-qpr-dev 2022-12-09 23:33:17 +00:00
Brian Isganitis 85ccf120f2 Better support transient and persistent taskbar in taskbar's overlays.
- Transient taskbar nav threshold now works in overlays.
- Delay closing overlay to transient app-window threshold if necessary.
- Persistent taskbar no longer stashes for EDU overlay.
- EDU overlay provides enough bottom padding for transient and
  persistent taskbar.

Test: Manual
Bug: 217261955
Change-Id: I2ae5612ef70a6d09e22f83f8117cdbf2a0a053b8
Fix: 260769010
2022-12-09 11:24:27 -08:00
Sunny Goyal deffe8f8df Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev am: d31c8baef1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20676568

Change-Id: Ie215c1933dce65d87204e5969c470548452a7998
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 15:47:35 +00:00
Sunny Goyal d31c8baef1 Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev 2022-12-09 15:35:59 +00:00
Ats Jenk 7868989e50 Merge "Check for both proto flags for common logic" into tm-qpr-dev am: e8c57e94e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20653403

Change-Id: I155bba8ce3621fcb235d3b5cc245e381f3c22947
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 00:54:23 +00:00
Ats Jenk e8c57e94e7 Merge "Check for both proto flags for common logic" into tm-qpr-dev 2022-12-09 00:43:04 +00:00
Brian Isganitis 2b5ba5eb5f Merge "Add EDU lottie animations for persistent and transient." into tm-qpr-dev am: ddc7ef2eb1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20672612

Change-Id: Ie302f00d1ba369210caf9910422a1df305a8a4ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 00:02:31 +00:00
Brian Isganitis ddc7ef2eb1 Merge "Add EDU lottie animations for persistent and transient." into tm-qpr-dev 2022-12-08 23:11:27 +00:00
Federico Baron 47d81686e6 Move AnimatedFloat from quickstep to launcher
We are moving AnimatedFloat to launcher to be able to use this in class in launcher. Having it in launcher will allow us to do restore icon treatment animations to do with scaling the icon size

Bug: 254858049
Test: verified that the device still works
Change-Id: I1c4c47ab436c389a94abf7c910c1a44724efc955
2022-12-08 13:58:07 -08:00
Jeremy Sim 2cbd7bbfdf Use already-running app instances when splitting
This patch makes it so that when the user initiates a split from Home, a running app instance is used instead of always attempting to spawn a new Intent. If no matching app instance is found, behavior is unchanged.

Previously, splitting from Home always resulted in a new Intent being staged, which ignored the fact that an app of the same type could already be running. This resulted in undesirable situations like being able to attempt splitting an app with itself in Overview.

Fixed by querying the RecentsModel when a split of this type is initiated, checking to see if there is a running task of the desired type, and using that to perform the split operation if one is found. When Overview is loaded, applyLoadPlan() will now check to see if there is a staged task, and remove the associated tile as needed. If the removed task is part of a pair, this involves creating a temporary TaskView to hold the other task.

Also fixes a bug where using the Taskbar to select one's second app would incorrectly choose the oldest instance of a multi-instance app rather than the newest.

Fixes: 257513447
Fixes: 259936298
Test: Manual
Change-Id: I97a62f34c03aa4980f9cd743e35e9fc6ef4c092d
2022-12-08 13:24:43 -08:00
Brian Isganitis b962950ae9 Add logging to investigate updateOverviewTargets state.
Test: Manual (logcat)
Bug: 258022658
Change-Id: I50640124f1e8fd5ae4aaf6240c044ded108849b5
2022-12-08 18:26:22 +00:00
Sunny Goyal 54fa110bba Removing some unnecessary interfaces and merging them to ActivityContext
Bug: 259733681
Test: Everything compiles
Change-Id: If6b530f6e589a851cf8554f5de0849843bd66dd4
2022-12-08 10:15:55 -08:00
Schneider Victor-tulias 80b25c756a [DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds.
Bug: 259021562
Test: performed gestures and checked logs
Change-Id: If0dec4ef74c2ef2d1617d8c37f10f3ef9d96b2f5
2022-12-08 17:42:53 +00:00
Schneider Victor-tulias d132ad4393 Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev am: ad48decd4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20664263

Change-Id: Icfdd29ce44e4ff73bfb79b3150addca41b7517cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-08 15:25:37 +00:00
Schneider Victor-tulias ad48decd4f Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev 2022-12-08 14:55:15 +00:00