Commit Graph

18671 Commits

Author SHA1 Message Date
Treehugger Robot eda0a92d52 Merge "Read task size info from RecentsView directly" into main 2024-08-20 11:46:03 +00:00
Alex Chau 6d00b4b014 Read task size info from RecentsView directly
- Automatically determine the Overivew component to use the correct RecentsViewContainer
- Also added log on both pre-computed taskSize and newly calculated task size

Bug: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ic0adfba35af513e731007241416fc85760135f07
2024-08-20 10:56:52 +01:00
Jeremy Sim bfb29a2e3f Merge "Add a contentDescription to splitscreen's first staged task" into main 2024-08-20 05:05:50 +00:00
Jeremy Sim 2e59268f3b Add a contentDescription to splitscreen's first staged task
Currently, when we stage the first app in a split, the floatingTaskView has no contentDescription and is announced by screen readers as "unlabeled".

This CL allows FloatingTaskView to copy a contentDescription from the underlying task or ItemInfo when it is created.

Also changes SplitConfigurationOptions#itemInfo to a private field with a public getter for mockito compatibility.

Fixes: 319783133
Test: Confirmed with TalkBack on Overview, contextual and Intent splits
Flag: EXEMPT bugfix
Change-Id: Ia5a95e403bfe8623e17d2ceac9073ef15c7bb476
2024-08-20 03:19:58 +00:00
Shamali Patwa accd0f68c8 Merge "Update the scale on corner radii on scaled image drawable." into main 2024-08-16 20:37:57 +00:00
Pat Manning 0c6e17020d Merge "Show and hide taskbar tooltips immediately." into main 2024-08-16 14:45:10 +00:00
Helen Cheuk 76b2dad620 Merge "Fix stuck focus outline after returning to home" into main 2024-08-16 10:51:56 +00:00
Brandon Dayauon 109f516e3e Merge "Add logs for when sectionInfo is computed or added for bugreport." into main 2024-08-15 23:10:18 +00:00
Brandon Dayauon 71fff87e2d Add logs for when sectionInfo is computed or added for bugreport.
bug: 336947811
Test: manually/presubmit: https://screenshot.googleplex.com/A2st8q57pajFBcG
dump: https://screenshot.googleplex.com/8JGoqz2ixodHH94
Flag: NONE adding logs

Change-Id: I3edc953fa8ec58a3677cc65f858b50d95184592c
2024-08-15 11:40:31 -07:00
Pat Manning b488c88fa3 Show and hide taskbar tooltips immediately.
Fix: 356352494
Test: TaskbarHoverToolTipControllerTest
Flag: EXEMPT bugfix
Change-Id: Ie7dc1f341cf059bb38f61fa185152cb2555e36b1
2024-08-15 17:59:59 +01:00
helencheuk 80896721ae Fix stuck focus outline after returning to home
Sometimes SmartspaceViewContainer is not the LastFocusedItem in ItemFocusIndicatorHelper when triggering changeFocus, it would skip the hiding outline animation which causes the stuck focus outline.
So the solution is to add a checking in "changeFocus" that if the LastFocusedItem is not the view calling changeFocus and it does not have focus now, it means no need to add or remove outline and could just return.

Bug: 349019294
Test: after going to notification panel, touch/click could make the outline disappears. https://drive.google.com/file/d/1aXQ38CEqvzJVj7gBM-KNTCJSpzfwYZsn/view?usp=sharing
Test: after going home from app in overview, touch/click make the outline disappears. https://drive.google.com/file/d/1DgYzAgIJqAHJ_DuYjswlCUBOiohprJze/view?usp=sharing
Flag: EXEMPT bugfix
Change-Id: I4613ba2fe92ec609055e48dc0b5ff53c2037a158
2024-08-15 16:41:18 +01:00
Tracy Zhou 9944b989d6 Merge "Use isGestureNav signal from TaskbarActivityContext for getTaskbarPhoneDimensions" into main 2024-08-15 04:56:41 +00:00
Shamali P c7e1b5c975 Update the scale on corner radii on scaled image drawable.
The RoundedDrawableWrapper applies rounded corners on each draw, so,
on scaling, the corners look odd for small widgets.

This change, applies the same scale to corner radius as well.
There are some widgets whose preview images have embedded transparency,
but we don't do much for such previews.

Bug: 359860747
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I5e58e29765503454f286d99050b13b497531d306
2024-08-15 02:54:17 +00:00
Tracy Zhou a51ee6a4dc Use isGestureNav signal from TaskbarActivityContext for getTaskbarPhoneDimensions
Somehow deviceProfile.isGestureMode doesn't have the right signal for tests.

We need to look into why dp doesn't have the right signal for isGestureMode in tests. Temporary fix here to unblock pushing the flag to staging

Bug: 359196354
Test: https://android-build.corp.google.com/builds/abtd/run/L05600030005823769
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Ie6451812cf4b0c3f034cabdfd4cec726322af0bc
2024-08-15 01:49:40 +00:00
Treehugger Robot 28cbc13413 Merge "Ensure that inactive archived icons in the folder preview are not shown as grey pending icons" into main 2024-08-13 22:19:44 +00:00
Charlie Anderson 08a0a65fca Ensure that inactive archived icons in the folder preview are not shown as grey pending icons
Bug: 350758155
Test: manually verified + PreviewItemManagerTest
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: Ic378c4f840ce05ecbcbbc3f4f57087c9acd7c1f5
2024-08-13 13:01:18 -04:00
Helen Cheuk 801f86ecac Merge "[Contextual Edu] Enable updating Edu data in Launcher" into main 2024-08-13 12:52:02 +00:00
Uwais Ashraf d39bc803c7 Merge "Improve performance of thumbnail retrieval - hot taskData flow" into main 2024-08-13 10:59:32 +00:00
Fengjiang Li 24184fa7cd [NPE] Skip all apps icon preinflatioino on bg thread if layout manager is set to null
Fix: 355192472
Test: presubmit
Flag: NONE - bug fix
Change-Id: Icdac63c58983cd7bada5d75f0e257d45d48a8d2e
2024-08-12 11:49:19 -07:00
Uwais Ashraf 60b62d734d Improve performance of thumbnail retrieval - hot taskData flow
Bug: 357542209
Test: TasksRepositoryTest, manual with reduced speed video
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ie94daf61d8e41c4b9c12d67f5f45166104879325
2024-08-12 16:49:24 +00:00
Treehugger Robot 50051adcc1 Merge "Revert AllAppsRecyclerViewPoolTest.kt" into main 2024-08-09 23:01:49 +00:00
Fengjiang Li 6554ab99e3 Revert AllAppsRecyclerViewPoolTest.kt
Manual revert of ag/28323761, will add it back after confirming preformance test regression has been resolved.

Fix: 354560500
Test: Revert of test
Flag: NONE
Change-Id: Ibc9ec7a641c7df80ac5a7f08933dadfdf0b8d1e6
2024-08-09 13:06:52 -07:00
Mady Mellor de28dc32eb Merge "Add a bubble option to launcher long press menus" into main 2024-08-09 17:25:02 +00:00
helencheuk 39a6093369 [Contextual Edu] Enable updating Edu data in Launcher
- Added ContextualEduStatsManager (in Launcher3) and SystemContextualEduStatsManager(in Quickstep) to enable classes in Launcher3 and quickstep to update contextual edu data
- Implemented new updateContextualEduData method in SystemUiProxy file, so the EduStatsManager could use it for update
- AbsSwipeUpHandler handles the logic to go home/overview when in app. Added code to update contextual edu data when these action is triggered.

Test: LauncherSwipeHandlerV2Test
Bug: 357542123
Flag: com.android.systemui.keyboard_touchpad_contextual_education
Change-Id: I6fc5a285ba1a1d770c54cc7af444ff8b3051bd00
2024-08-09 13:38:21 +01:00
Anushree Ganjam 3f6412e50d Merge "Remove debug logs" into main 2024-08-08 23:19:39 +00:00
Mady Mellor 1cc100844c Add a bubble option to launcher long press menus
- Add a launcher "system shortcut" to bubble deep shortcuts or apps
- For shortcuts, save the shortcut info to use to produce the bubble
- Add an interface so that the system shortcut can call through to
  sysui proxy

Flag: com.android.wm.shell.enable_bubble_anything
Test: manual - enable the flag and try to bubble a shortcut via the
               longpress menu on launcher
             - try bubbling an app on launcher
             - try bubbling an app from the taskbar
Bug: 342245211
Change-Id: I1ef49e1628ba0be9cea05073ecd9cd66bf67f88f
2024-08-08 21:23:13 +00:00
Anushree Ganjam 5c4ea5b0ca Remove debug logs
Bug: 339737008
Test: Manual
Flag: TEST_ONLY
Change-Id: I8177fc721f330267bc20abf6e7d587289e45477b
2024-08-07 14:08:10 -07:00
Charlie Anderson 99147f53e0 Use DoubleShadowIconDrawable to draw shadow behind archived cloud icon
- Refactor Launcher3 ShadowInfo out of DoubleShadowBubbleTextView

Bug: 350758155
Test: locally verified + screenshot test
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: I8e5e5936296fafbfbf3caf80a936ca1038c125e3
2024-08-07 11:56:33 -04:00
Riddle Hsu 9164534fb9 Merge "Use rotation hint to update layout" into main 2024-08-06 11:39:03 +00:00
Fengjiang Li 77be7410c3 Merge "Fix jank regression from AllAppsRecyclerViewPoolTest" into main 2024-08-05 23:17:22 +00:00
Fengjiang Li ce638d69b7 Fix jank regression from AllAppsRecyclerViewPoolTest
Unit test ag/28323761 delays the preInflationCount check after creating ActivityContext on main thread, thus causing jank regression. This CL is a forward fix.

Fix: 354560500
Flag: NONE - jank fix
Test: Presubmit
Change-Id: I0e91dd765f1805b98895ce90804ec187e50285b4
2024-08-05 09:39:05 -07:00
Charlie Anderson 544592dcd3 Merge "Adds new bugfix flag for using new app archiving icon" into main 2024-08-05 14:24:58 +00:00
Treehugger Robot f205266047 Merge "Fixes background color issue in private space" into main 2024-08-05 09:39:13 +00:00
Charlie Anderson 6b8e362247 Adds new bugfix flag for using new app archiving icon
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Bug: 350758155
Test: locally
Change-Id: I7bacbacd85a8216e7975665e6d3c1ab98ed23235
2024-08-05 00:37:28 -04:00
Charlie Anderson e5ace06d81 Merge "Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"" into main 2024-08-05 04:24:32 +00:00
Charlie Anderson fe23e711fd Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 00fb1adab4.
Also fixes test applyIconAndLabel_setsImageSpan_whenInactiveArchivedApp.

Bug: 350758155
Fixes: 356166053
Test: unit test
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I93f2ac47dc3a8fa81d59e0f089385d2b3fe93306
2024-08-02 17:26:02 +00:00
Marcelo Arteiro 17422a8c61 Fixes background color issue in private space
Bug: 355066712
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I3d53b7d82b577c05642aab9fc40f54d382578942
2024-08-02 14:54:38 +00:00
Riddle Hsu a3c17fc075 Use rotation hint to update layout
The info from DisplayController is the rotation of display.
While the rotation hint is from the current configuration of
the activity. Because system supports to display activities
with individual rotation at the same time, it is more accurate
to use the hint for layout.

Because there are 4 DeviceProfile instances for 4 rotations.
The instance will be used for corresponding rotation. So the seascape
attributes is a final state which no longer needs to be updated.

Bug: 356164050
Flag: EXEMPT bugfix
Test: Enable auto rotation. Enable home rotation.
      Launch a fixed portrait activity.
      Rotate device to 270 degree (seascape).
      Swipe navigation to return to home.
      Home should use 270 layout directly instead of 90
      and then change to 270 after animation is finished.

Change-Id: Iad0f6ada0ec1cb7f0b5281b508d58276332076fb
2024-08-02 16:40:24 +08:00
Fengjiang Li 7d7bd30491 Merge "Fix NPE of AllAppsRecyclerViewPool.kt" into main 2024-08-01 23:45:25 +00:00
Shamali Patwa b74b05336c Merge "Fix the getWidgetsByPackageItem method to return a copy" into main 2024-08-01 21:59:28 +00:00
Fengjiang Li 696a6c58d8 Fix NPE of AllAppsRecyclerViewPool.kt
Skip preinflating all apps icons if RecyclerView doesn't have layout manager yet. Also force crash in studio build to help find a repro case

Fix: 355192472
Flag: NONE - npe fix
Test: presubmit
Change-Id: I1e3e271eb6d5b732a7a71eb466bff402c172be0a
2024-08-01 14:39:02 -07:00
Sihua Ma 7eaf24840d Merge "Add unit test for LauncherAppWidgetHost" into main 2024-08-01 20:26:40 +00:00
Shamali P 74862f990b Fix the getWidgetsByPackageItem method to return a copy
Bug: 356545910
Fix: 356545910
Test: Unit test
Flag: EXEMPT BUGFIX
Change-Id: I90429983733eb5f2bb2d6df00799d2445eaeea31
2024-08-01 18:56:41 +00:00
Treehugger Robot a6e8616980 Merge "Revert "Add debug logs to TopTaskTracker"" into main 2024-08-01 16:07:57 +00:00
Sebastián Franco 7c434ddbde Merge "Adding logging for backup and restore" into main 2024-07-31 18:08:07 +00:00
Treehugger Robot 01a1169d57 Merge "Revert "Handles Bold Text setting for inline icon by providing bolded cloud icon"" into main 2024-07-31 16:47:15 +00:00
Charlie Anderson 00fb1adab4 Revert "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 114e84908f.

Reason for revert: b/356166053

Change-Id: I30dfbc5da1caecd89b4b23aafe4de8e9efede6a0
2024-07-31 14:08:16 +00:00
Sebastian Franco e356978869 Adding logging for backup and restore
Bug: 353505773
Test: compiles
Flag: EXEMPT bugfix
Change-Id: I4c1e56365332557fa95a11526498505bf2063e12
2024-07-30 18:47:37 -07:00
Treehugger Robot 779c79129b Merge "Fix grid migration item copy bug" into main 2024-07-30 20:19:19 +00:00
Brandon Dayauon dfb1722afc Merge "Make a dummy view at the bottom of all apps" into main 2024-07-30 20:15:26 +00:00