Commit Graph

9216 Commits

Author SHA1 Message Date
Helen Cheuk ed4c2acf58 Merge "Add hover state border line to overview task item by using the same approach used by keyboard focus state" into udc-qpr-dev 2023-06-01 15:45:01 +00:00
Nick Chameyev c1eafd92ab Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-qpr-dev 2023-06-01 12:55:27 +00:00
Jagrut Desai 9edf316ca3 Merge "Fixing Toast Hiding behind Taskbar - Part 2" into udc-dev am: e208e02aba am: 3d630fdddb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23455641

Change-Id: I4b47b8d6304830311eef6545ee08bfee51554269
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 21:26:47 +00:00
Jagrut Desai e208e02aba Merge "Fixing Toast Hiding behind Taskbar - Part 2" into udc-dev 2023-05-31 20:45:37 +00:00
Schneider Victor-tulias fc32303ebf Merge "Fix launcher activity leak in TouchInteractionService" into udc-dev am: 8f95307087 am: 9dd8eacd99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23375885

Change-Id: I7b6cfeb031aefc61441a030aac15d2674ef83b1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 19:20:54 +00:00
Schneider Victor-tulias 8f95307087 Merge "Fix launcher activity leak in TouchInteractionService" into udc-dev 2023-05-31 17:49:35 +00:00
Jagrut Desai 84e959a72a Fixing Toast Hiding behind Taskbar - Part 2
Test: Visual, Manual
Bug: 282964229
Flag: not needed
Change-Id: If2373d8f0bc44a555844c78d20877e9636a7e176
2023-05-31 10:41:16 -07:00
Nick Chameyev 6d756970e7 [Unfold animation] Do not preemptively start the animation if it has run already
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.

This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.

This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.

Bug: 285150685
Test: open an app on folded screen, unfold, go to home screen =>
  check that icons are not squished
Test: fold/unfold when launcher is open
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
2023-05-31 17:12:08 +00:00
Kateryna Ivanova 72fbdc7976 Merge "Migrate Interpolators from Launcher3 to the public animation library" into udc-qpr-dev 2023-05-31 15:25:40 +00:00
Vinit Nayak 9cea469bc9 Merge "Resize mRemoteTargetHandles when RecentsAnimationStarts" into udc-dev am: 52ac882e9b am: 7916ab1e26
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23267214

Change-Id: Ib0895dfd51575b5e43cb60c73c28a5c047eb9c51
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 23:39:52 +00:00
Vinit Nayak 52ac882e9b Merge "Resize mRemoteTargetHandles when RecentsAnimationStarts" into udc-dev 2023-05-30 22:10:28 +00:00
helencheuk 64975ae992 Add hover state border line to overview task item by using the same approach used by keyboard focus state
Reviewed TAPL DD: https://docs.google.com/document/d/1OmCLgTDw3gFOMXjEvH0W1XoAe0n2J5pPdyMcAHtflMA/edit?resourcekey=0-bXle-rOnQqOR_RJBffRybQ
Fix: 249859410
Test: OverviewTaskImageTest

Change-Id: Ic9ce4e9fe90f38a4bf4be6c7deed302a12a3192a
2023-05-30 21:30:14 +01:00
Brian Isganitis 1f2919d634 Merge "Fix how task stack listener closes overlays on task changes." into udc-qpr-dev 2023-05-30 19:21:15 +00:00
Stefan Andonian 4439bec7aa Merge "Use LockedUserState in TouchInteractionService." into udc-qpr-dev 2023-05-30 18:55:02 +00:00
Tracy Zhou 073a04f639 Merge "Simplify trackpad multi-finger gesture recognition logic for gesture nav" into udc-qpr-dev 2023-05-30 16:38:16 +00:00
Kateryna Ivanova 7120373bbc Migrate Interpolators from Launcher3 to the public animation library
Test: atest
Bug: 271850966
Change-Id: Iba999f2e753764a37d35e508e707df02388432e9
2023-05-30 07:20:38 +00:00
Tracy Zhou 48ac5a0f74 Simplify trackpad multi-finger gesture recognition logic for gesture nav
Now we can use AXIS_GESTURE_SWIPE_FINGER_COUNT per ag/23288416

Test: swipe up to overview / home; workspace scroll 2-finger only / quick switch/ pull down notifications works
Bug: 284463803
Change-Id: Ie1c7d13f4683d3b9c8de6e5ea2821df73b97ca29
2023-05-27 21:16:25 -07:00
Achim Thesmann 5644e3f1fd Merge "Allow BAL in Launcher" into udc-dev am: 2bcfbd3739 am: fc6ffba0bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23342819

Change-Id: I0773e3c7123af7066eec8e29c5bc9c8fc40c4c59
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-27 19:18:44 +00:00
Achim Thesmann 2bcfbd3739 Merge "Allow BAL in Launcher" into udc-dev 2023-05-27 17:48:16 +00:00
Ats Jenk 40f9151ff0 Merge "Support alt+tab for desktop tasks" into udc-qpr-dev 2023-05-27 05:52:46 +00:00
Vinit Nayak 23bded7f62 Merge "Handle fullscreen app launchs in split init flow for SplitSelectDataHolder" into udc-dev am: ed7b50efee am: 6641699a72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23379363

Change-Id: I3bc803af7929974bef8bba5c22831f8020adb173
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26 23:47:06 +00:00
Ats Jenk 3067874559 Support alt+tab for desktop tasks
Updates keyboard quickswitch logic handle quickswitching while on
desktop. When on desktop, alt+tab moves only between desktop tasks.
Fullscreen tasks are shown in the overflow tile and can be accessed by
going to overview.

TODO:
- when not in desktop and using quickswitch, show the desktop tile as a
  combined tile in the row, similar to what is shown in overview

Flag: persist.wm.debug.desktop_mode_2
Bug: 280468885
Test: open some apps on desktop and have some fullscreen apps opened in
  the background, when on desktop, observe that alt+tab only switches
  between desktop tasks
Test: same setup, but switch to a fullscreen app, observe that alt+tab
  only switches between fullscreen tasks and desktop is accessible from
  overview

Change-Id: Ib19f2eaa24363bbd0669c8c8c3d99ed9d9118a17
2023-05-26 15:38:58 -07:00
Schneider Victor-tulias f304ab8e2b Fix launcher activity leak in TouchInteractionService
TouchInteractionService cannot be garbage collected until it has been cleared from the sysui process. Switching to use a WeakReference to help with garbage collection.

Flag: not needed
Bug: 283490010
Test: ran launcher and performed gestures
Change-Id: I37aa5f858f2ae0ac78b46478ab4c5f24770bd64f
2023-05-26 14:39:14 -07:00
Brian Isganitis 34c6b871af Fix how task stack listener closes overlays on task changes.
Originally gated onTaskMovedToFront behind prototype because looked like
it was causing overlay to close when it shouldn't. However, it turns out
it was actually onTaskStackChanged that was doing this.

Additionally, changing onTaskMovedToFront to close with animation, because this will fire if swiping up from all apps (going to overview so Launcher is considered as the task moving to front). Also, registered onTaskCreated to be a bit more thorough.

Test: Manual (EDU, All Apps, and EDU + All Apps)
Fix: 283373523
Flag: none
Change-Id: I4cd3969f91a93bab190b764a656d9cfc03d1ce09
2023-05-26 21:04:19 +00:00
Vinit Nayak ed7b50efee Merge "Handle fullscreen app launchs in split init flow for SplitSelectDataHolder" into udc-dev 2023-05-26 20:19:19 +00:00
Schneider Victor-tulias 2f3ad0bc36 Merge "Update gesture nav edu motion and colors" into udc-dev am: b4e91b14bd am: 2256dfcec1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23389667

Change-Id: Ibd7edffcc8e3492497ca06008f4ce5e8bc94c183
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26 19:57:55 +00:00
Schneider Victor-tulias 1a72f089f8 Merge "Fix keyboard quick switch d-pad left/right traversal direction" into udc-dev am: 010a55d377 am: 2359172135
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23413644

Change-Id: I348efad29014e088e351368d7fb23934f70edbeb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26 19:57:43 +00:00
Stefan Andonian cf36a3f3a8 Use LockedUserState in TouchInteractionService.
This change was previously attempted, but failed because of a tricky issue where the LockedUserState singleton object was getting permanently set to a mock context in LockedUserStateTest, and then was failing TaplTests because isUserUnlocked was always false.

This fixes that by avoiding using the singleton LockedUserState instance in the unit tests.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly. Post-submit was tested and this CL passed all previously
failing tests: https://android-build.googleplex.com/builds/abtd/run/L12900000960898179

Change-Id: I045c9f2558a6bdacb4bfa029fbf6a07c3c190fe7
2023-05-26 17:06:09 +00:00
Schneider Victor-tulias b4e91b14bd Merge "Update gesture nav edu motion and colors" into udc-dev 2023-05-26 16:12:06 +00:00
Schneider Victor-tulias 010a55d377 Merge "Fix keyboard quick switch d-pad left/right traversal direction" into udc-dev 2023-05-26 16:11:51 +00:00
Winson Chung f1815885a4 Merge "Try to handle side-task launches even if not fully transitioned to overview" into udc-dev am: a5fb95df57 am: 61a6937e5a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23425161

Change-Id: I5c3cc7570cf7d1a7e043f8473361c93d44f183d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26 06:04:30 +00:00
Winson Chung a5fb95df57 Merge "Try to handle side-task launches even if not fully transitioned to overview" into udc-dev 2023-05-26 04:25:21 +00:00
Luca Zuccarini 5a5560e3d1 Merge "Add a view type check to ensure the right animation is used." into udc-dev am: 07c3491ec2 am: 1de059dbeb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22433062

Change-Id: I7cca0f7a47cd265137f0006b76fee37eedac861a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 16:48:28 +00:00
Luca Zuccarini 07c3491ec2 Merge "Add a view type check to ensure the right animation is used." into udc-dev 2023-05-25 15:42:51 +00:00
Winson Chung 98fbe25da9 Try to handle side-task launches even if not fully transitioned to overview
- The launcher state does not transition from Background -> Overview
  until the overview animation finishes, and if a side task is launched
  before that happens, then we receive onTaskAppeared() but
  isInLiveTileMode() is false, which results in a state where no
  animation of the side task surface is run, and the recents animation
  is not finished.  In these cases, if we've already calculated the
  end target is RECENTS, then we can still animate the side task
- Adding some more gesture logs to indicate side task launched (or didn't)

Bug: 279114961
Test: Go to overview and launch next task

Change-Id: I23eac8721da801f14cc95fc6781a0ef9f0355cc0
2023-05-25 06:14:53 +00:00
Jordan Silva 135adf3d90 Merge "Fix TaskView bind and orientation state called multiple times" into udc-qpr-dev 2023-05-24 23:28:39 +00:00
Vinit Nayak 57de6565a0 Resize mRemoteTargetHandles when RecentsAnimationStarts
* TopTaskTracker gets updated too late after we've exited
split screen so we can't use that to determine how many
RemoteTargetHandles to use
* We default to 2, and then scale it down to 1. Because we
modify the array holding the handles directly, it should
also get updated in AbsSwipeUpHandler
* Temporary solution to stop setting up RecentsView if we detect that
TopTaskTracker has incorrect data and re-setup when we get
onRecentsAnimationStart()

Test: Tested quickswitch in gestural and recents button
double tap in button nav.
Bug: 236226779
Flag: none

Change-Id: I1bae7aed1f8712ddd1bf496acfcb851c0e32a115
2023-05-24 16:26:33 -07:00
Tracy Zhou 24bbc6a577 Merge "Animate expansion of notification panel before ACTION_UP" into udc-qpr-dev 2023-05-24 20:29:18 +00:00
Jagrut Desai ab7ea8a07a Merge "Android U: GM3 Color Tokens for Taskbar and quickstep" into udc-dev am: 990aef6c00 am: 97ec1855a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23220591

Change-Id: I410846f848704b706afb6af4d1b5718cbf0062f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-24 19:05:03 +00:00
Schneider Victor-tulias 9a7de100f4 Update gesture nav edu motion and colors
- Updated gesture nav edu overview step post-success motion and colors
- Updated gesture nav edu menu done button color and legacy action button color
- Switching light/dark mode when a step is complete started the demonstration animation. fixed this jank

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281764891
Fixes: 283964958
Bug: 279823249
Test: ran full tutorial with ENABLE_NEW_GESTURE_NAV_TUTORIAL enabled and disabled
Change-Id: I9adc05947267ec038b6f374b2a29a5499468883b
2023-05-24 18:36:39 +00:00
Jagrut Desai 990aef6c00 Merge "Android U: GM3 Color Tokens for Taskbar and quickstep" into udc-dev 2023-05-24 17:28:33 +00:00
Schneider Victor-tulias 8f26e47736 Fix keyboard quick switch d-pad left/right traversal direction
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 284156698
Test: tried keyboard quick switching with d-pad left/right in rtl/ltr
Change-Id: Idb7466b316cb7cbd9f592c5949d2c95c3278d85f
2023-05-24 10:04:05 -07:00
Jordan Silva 8554f90ea6 Fix TaskView bind and orientation state called multiple times
DWB toast initialization is being called 3 times for every TaskView. Twice during the TaskView bind (setOrientationState and bind), and for every TaskView loaded in applyLoadPlan the bind and the setOrientationState are invoked. This CL removes the excessive calls in the TaskView bind and applyLoadPlan.
The DWB for the focused task view is still being called twice due to orientation update for the focused task.

Bug: 281980412
Flag: N/A
Test: atest DigitalWellBeingToastTest
Change-Id: Id301b53b9cb0dfc23a81debec67a6de9a35485b9
2023-05-24 16:29:54 +00:00
Andreas Agvard eea784aea8 Adds an flag guarded extension point for long press nav handle behavior
Bug: 282993230
Flag: ENABLE_LONG_PRESS_NAV_HANDLE disabled
Test: Manual

Change-Id: I541886cc13af1db46bc38d4e18556be99bef7713
2023-05-24 16:24:42 +02:00
Luca Zuccarini 5a5b110030 Merge "Remove redundant instances of depth controller." into udc-dev am: f898ee474c am: 100ea1d75a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23390637

Change-Id: I8633d53d08a053bf552b307ad546efc9a999a28e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-24 13:02:12 +00:00
Luca Zuccarini f898ee474c Merge "Remove redundant instances of depth controller." into udc-dev 2023-05-24 11:35:21 +00:00
Tracy Zhou 942a8b996f Animate expansion of notification panel before ACTION_UP
Fixes: 280335619
Test: Make sure that the notificaton shade can be pulled down before ACTION_UP
Change-Id: Ib29b17e4d8e42391e5ec46f230226debe0cc1186
2023-05-23 22:58:45 -07:00
Jagrut Desai 5b3161ef3e Android U: GM3 Color Tokens for Taskbar and quickstep
Test: Manual, Design Review
Bug: 268505871
Flag: not needed
Change-Id: I68e5092ccc69cf8a0d40aa4cc49fe9e8d82a68f4
2023-05-23 11:44:15 -07:00
Luca Zuccarini a96dcb0cc7 Remove redundant instances of depth controller.
During each app launch, a new `MyDepthController` is instantiated, which
registers two of its methods as listeners for cross window blur and
opaqueness. This controller's usefulness spans that specific animation
only, but the listeners are never unregistered. This creates conflicts
when an opaqueness signal happens, which cause the background to flicker
(see videos).

Bug: 283335820
Test: manual, see videos in the bug
Flag: not needed, bug fix
Change-Id: I3dcb0b8ff0aa77bf3183a926889d0131b17bcaa4
2023-05-23 15:33:17 +00:00
Tony Huang 7bae2b82ef Merge "Hide divider immediately if going to launcher" into udc-dev am: 2d586455dc am: 645158f067
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23368297

Change-Id: I89962cb8501423c7d365e9d145ed97c8ad003ae3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-23 04:15:09 +00:00