When bottom sheet is visible, such as in SUW or when app launcher pauses, the taskbar three buttons are translated upwards clashing with SUW UI.
Flag: EXEMPT bugfix
Bug: 358532768
Test: Manual
Change-Id: I0d18bda5cb7aeae894f5058df89cc413e34c00fc
Based on the bug, it seems that onHandleConfigChange was not called via the perfetto trace. Here is the call order:
1) Loader Task is created
2) Loader task runs
3) Preinflation happens from setApps() in bindAllApplications() via ModelCallbacks.kt
4) When show long app names toggle happens: it eventually triggers an onHandleConfigurationChanged() which is traceable in perfetto.
5) After configChange, preinflation happens again.
In step 4) there is an early return that happens and makes it so it doesn't call the reinflation of views that happens in the mModel.rebindCallbacks().
When the force configUpdate happens upon toggle, reset the variable after it is done.
bug: 370121944
Test: presubmit/manually/perfetto in bug
Flag: NONE trying to fix edge case
Change-Id: Id0ba591bfe583b300cc241fcfc37db6dd5a85363
* changes:
Add spannedDrawable for the divider in the letter fastScroller.
Only have private space drawable section for beginning of private space section and keep letters for everything else.
> Converting various if-else-if blocks to when
> Moving SessionMailureTask to its own class
> Moving install session callbacks to ModelCallbacks
Bug: 372553045
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I027b35f271b84f079fa3135b56dc15bb7375b2e0
> This will make it easier to migrate to dagger as it will
increase the number of constructor parameters significantly
Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger migration
Change-Id: Id06246ec74c678d7614f4c6a798c5644b40a0545
Splitting allows easily making a fake that doesn't have to override the implementation details of LauncherPrefs. The fake should not deal with SharedPreferences.
LauncherPrefs could be an interface, but then the companion object has more limitations. The solution there is to have a dedicated object class, e.g. `LauncherPrefItems`. I went with an abs class to make the refactor simpler.
Flag: EXEMPT refactor
Bug: 369641781
Test: go/testedequals
Change-Id: I97a2d495d3b5fa892fa53a11fb3f7a7dfb98515b
Remove extra screen & go to normal state only if widget
addition was complete. If a config activity was started, then
don't change to remove screen yet or go to normal state. Else,
QuickStepLauncher clears the existing activity open requests when
going to normal state. When animations are off, this led to config activity to never launch and hence, such widgets not being added.
Bug: 369422714
Test: Manual
Flag: EXEMPT BUGFIX
Change-Id: I4e7e29fd998a0cc5ca18a7a48b91a5b788a60a52
Moved out logic that computes the translation X for the hotseat icons.
Fixes: 368379159
Test: Manual. Have the hotseat adjusted. Open any application from the
hotseat bar. Go back to home.
Flag: EXEMPT refactoring
Change-Id: If9dfa70be537f87b075bd865e7f9c5cd1ae78f00
Updated logic that computest the hotseat shift.
Fixes: 372014534
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Put device into 3 buttons navigation mode, force RTL.
Hotseat is placed next to the navigation buttons bar.
Change-Id: Ie7b6be11a093ffa4006182bdc0b73018ba799246
Using same key for blob store and content provider based layouts
Using a single key for layout provider. This ensures that if one
test doesn't cleanup properly, any followup test which relies on
model initialization overrides the key appropriately
Bug: 370080120
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Idef0a89a5d1ec89e24aae8a4549fd122634dad2f
Receive color update messages with a list of color resource ids and a
corresponding list of color overrides, and adjust the preview
accordingly.
Flag: com.android.systemui.shared.new_customization_picker_ui
Test: manually verified that the selected colors are previewed
Bug: 350718581
Change-Id: Ibcde0575416df00b76627ac1004f21f5f9af1196
Alpha was applied to fill paint only. Add it to stroke paint as well.
Introduce a new method in Utilities to map range of ints and not only
floats.
Bug: 345687278
Test: compare bubble bar shadow and stroke before and after change
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I7c9e8d6337a857a661de0c945181cdd5ef2fd4ca
Mykola Podolian
Treehugger Robot
Graciela Putri
Sunny Goyal
Sukesh Ram
Andy Wickham
Sihua Ma
Brandon Dayauon
Brian Isganitis
Shamali P
Schneider Victor-Tulias
Fengjiang Li
Catherine Liang
Ats Jenk
Anushree Ganjam