Commit Graph

2070 Commits

Author SHA1 Message Date
vadimt 2d6cd80bc9 Launcher reports whe 0-button swipe-up gesture pause is detected.
This eliminates an unreliable timeout.

Also removing an unnecessary check for harness that is done by the
called method.

Change-Id: If954580060415cbb2952532c16ea0ae4dc7b9469
2019-05-24 19:28:40 -07:00
Sunny Goyal 55d1e44c47 Fixing user getting stuck in quick-switch state
If we are cancelled after the animation has completed, but before the deferred frame
was captured, we set the state as cancelled, and start the new consumer with the
existing recents controller.
But after the deferred frame, we finish the controller (and since the state was set to
cancelled, do not launch the new task)

Bug: 132756514
Change-Id: If30af713c76b6d895d0b01b93d31c0e1403b7214
2019-05-24 17:20:10 -07:00
TreeHugger Robot 3831fc99dc Merge "Making some fields accessible to subclasses" into ub-launcher3-qt-dev 2019-05-24 22:28:34 +00:00
Sunny Goyal c62699fd63 Merge "Removing prediciton loading state" into ub-launcher3-qt-dev 2019-05-24 22:01:09 +00:00
TreeHugger Robot 1625bf74dd Merge "Adding myself as an owner of test directories" into ub-launcher3-qt-dev 2019-05-24 18:06:28 +00:00
vadimt addaab60fa Adding myself as an owner of test directories
Change-Id: I3d6649a2b804715cebb80b8cac881ef227738088
2019-05-24 10:54:12 -07:00
TreeHugger Robot f54839bf35 Merge "Remove unnecessary dispatchInsets routing" into ub-launcher3-qt-dev 2019-05-24 00:31:18 +00:00
Sunny Goyal 4c96dd2cd0 Merge "Moving TestInformationProvider to Launcher3 so that it can be used for testing Launcher3 without quickstep" into ub-launcher3-qt-dev 2019-05-24 00:12:14 +00:00
Sunny Goyal 9820c05f2b Removing prediciton loading state
Also fixing test flakyness due to delayed prediction loading

Bug: 132993129
Bug: 131854153
Change-Id: I85f7afff0e3ee0ca9e40e92e91681f797a0bc2de
2019-05-23 17:01:19 -07:00
TreeHugger Robot a80180bfcb Merge "Set scroller to new max duration if snapping too slowly" into ub-launcher3-qt-dev 2019-05-23 21:53:06 +00:00
Tony Wickham 9b832295c3 Set scroller to new max duration if snapping too slowly
Change-Id: I87bfc8f767f7ae9cbe838c2a9ba229bec179f526
2019-05-23 14:42:24 -07:00
Sunny Goyal 68ff2d91cf Making some fields accessible to subclasses
Bug: 132975416
Change-Id: Icc7043d8299c88fcf505068f8cabd4705d19010d
2019-05-23 14:16:06 -07:00
Sunny Goyal ab3963ddcf Moving TestInformationProvider to Launcher3 so that it can be used for
testing Launcher3 without quickstep

Also keeping the provider as disabled until needed

Change-Id: Ib5f459e02ae551724b390f3b74f43d601568d749
2019-05-23 14:02:33 -07:00
TreeHugger Robot 571e51161c Merge "Quick patch for PredictionUiStateManager.applyState interrupting allapps" into ub-launcher3-qt-dev 2019-05-23 20:53:27 +00:00
vadimt 0c1ed7cb4c Quick patch for PredictionUiStateManager.applyState interrupting allapps
Constructor of PredictionUiStateManager posts an action in 5 sec, which
may interfere with the process of opening all apps.

Waiting until the posted action happens.

Hopefully this will fix massive flakes.

Bug: 131854153
Change-Id: I6544eae1a3b063c03e78185826c05a76add1f71b
2019-05-23 12:36:32 -07:00
TreeHugger Robot 1b9afd4f73 Merge "Reading navigation_bar_gesture_height for bottom swipe region" into ub-launcher3-qt-dev 2019-05-23 17:53:24 +00:00
Sunny Goyal f5d02b069a Reading navigation_bar_gesture_height for bottom swipe region
Bug: 132917885
Change-Id: I39d266fc34a69c3ba50246b5a66350942a85becb
2019-05-23 10:42:24 -07:00
Vadim Tryshev 789fe60dc4 Merge "Reducing test wait time from 60 sec to 10 sec" into ub-launcher3-qt-dev 2019-05-23 17:33:53 +00:00
vadimt 40bbfbed0f Reducing test wait time from 60 sec to 10 sec
Bug: 112282235
Bug: 121279417
Change-Id: Id88e782145b5fdae42354f6fce830aa05b78857a
2019-05-23 10:23:41 -07:00
Tony Wickham eb64fd3946 Merge "Capture screenshot when animating to home" into ub-launcher3-qt-dev 2019-05-23 01:56:08 +00:00
Jonathan Miranda 16dfcb9588 Merge "Use spring to update window/icon scale for swipe up animation." into ub-launcher3-qt-dev 2019-05-23 01:49:23 +00:00
TreeHugger Robot a338daa261 Merge "Adding a utility class to cache views at an activity level" into ub-launcher3-qt-dev 2019-05-22 23:35:03 +00:00
Tony Wickham aa8b2d86fc Capture screenshot when animating to home
This is to ensure the task thumbnail is captured in the correct
orientation, rather than waiting until after the task pauses
which might be after the device rotates to portrait.

Also update the state to wait until screenshot is captured
before finishing the transition to home.

Test: testStressPressHome
Test: Swipe up from a forced landscape app, enter overview;
      ensure task view thumbnail is shown correctly

Bug: 132687470
Change-Id: I5cd5f4b2a413628a8bdcb456e2d132c1c2da5258
2019-05-22 15:44:04 -07:00
Sunny Goyal 5686333117 Adding a utility class to cache views at an activity level
Bug: 122345781
Change-Id: I9a939e0b19c06c1089c1ceb515f8b97fb5dbb49e
2019-05-22 14:23:12 -07:00
vadimt 3ab80bb734 Enable debug tracing for a lab-only non-starting app from all apps
Bug: 132900132
Change-Id: I9c5bb51e49f865ea1e1d3d2209a8dfb149f66e87
2019-05-22 12:58:35 -07:00
Tony Wickham 9e26fccacc Merge "Fix some issues with shelf jumping/duration" into ub-launcher3-qt-dev 2019-05-22 19:21:37 +00:00
Adam Cohen 47f21e8a08 Merge "Fix issue where Assistant could be invoked at the same time as all apps" into ub-launcher3-qt-dev 2019-05-22 03:48:36 +00:00
Tony e246dff69f Fix some issues with shelf jumping/duration
Don't use OvershootParams for 0 button mode, since that interpolator
assumes the shelf is moving in conjunction with recents/app window.
Instead, use OVERSHOOT_1_2 like we do when not flinging.

Also bound the duration when entering recents, since scroller
duration could be 750ms if we are snapping to the current page.
Now we cap at MAX_SWIPE_DURATION (350ms). This case is most likely
to be hit when ending a slow swipe near the final recents scale,
since in that case duration is close to 0 and the scroller duration
is taken instead.

Test:
- Artificially always detect a pause, fling up in 0 button mode;
  ensure shelf doesn't jump
- Either with the above artifical change in 0 button, or 2 button
  mode, end a swipe to recents near its final scale with a slight
  scroll to the right; ensure duration is 350 instead of 750

Bug: 132283018
Bug: 127783075
Change-Id: I8d5fbd0b30af21b9587fba47d141ba90b3b6e778
2019-05-21 20:27:55 -07:00
TreeHugger Robot 0ef504aa71 Merge "Adding tracing for a lab-only flake" into ub-launcher3-qt-dev 2019-05-22 03:12:56 +00:00
vadimt e17d1feb79 Adding tracing for a lab-only flake
We had a resolved case in the past where an app's context menu didn't
open on a long click (thanks to app updates), now the menu opens, but
the drag gesture doesn't drag the icon.

Bug: 133009122
Change-Id: I45d104a92fab6556ecd937aef76f0a8147e67f56
2019-05-21 17:19:23 -07:00
Sunny Goyal 2524b82369 Remove unnecessary dispatchInsets routing
Insets are dispatched to all views. We never consume the insets and
let each view decide what to do with it.
Also fixing scrim in all-apps when in full-gesture navigation

Change-Id: Ib1c6bef5b32aac0c6ea03078b5138d2d0408c6d8
2019-05-21 15:58:44 -07:00
Adam Cohen 8f7d2b0dfd Fix issue where Assistant could be invoked at the same time as all apps
issue 132366412

-> First, we shouldn't accept flings when the delegate has intercepted. This prevents any situation
   where both are triggered.

-> Modified the slop to be the standard 8dp. This acts as a standalone fix because
   it means that there are no situations where we cross all apps slop before assistant slop.
   ie. in a purely vertical gesture from the corner, without this change, it's possible to trigger
   all apps instead of Assistant.

Change-Id: I39e3d8a525e165024399d9802d4cc1d7ae329ee6
2019-05-21 15:52:34 -07:00
Jon Miranda f535787571 Use spring to update window/icon scale for swipe up animation.
Bug: 123900446
Change-Id: I644dae6210ab3c8b72c777a556dfde4ae4cdce8f
2019-05-21 15:05:32 -07:00
Miranda Kephart 49e5d8227b Merge "Pass in fling velocity for gesture progress" into ub-launcher3-qt-dev 2019-05-21 21:05:00 +00:00
TreeHugger Robot 32ba3c1125 Merge "Using squared hypot to optimize some comparisions" into ub-launcher3-qt-dev 2019-05-21 19:48:37 +00:00
Sunny Goyal 878aa33567 Using squared hypot to optimize some comparisions
Change-Id: Ia5b99c2e60eedf02dea26857819f0e13127db4e2
2019-05-20 15:20:47 -07:00
Miranda Kephart b063775eb9 Pass in fling velocity for gesture progress
Calls SystemUIProxy.onGestureCompletion for a completed gesture
(either drag or fling) and passes in the velocity (0 for drags).

Bug: 132356358
Test: manual

Change-Id: I080adc401e19a6141627d1806b425056f7eefcbd
2019-05-20 18:07:44 -04:00
TreeHugger Robot 2445ca0777 Merge "Fix bug where FolderIcon stays visible during swipe up to home animation." into ub-launcher3-qt-dev 2019-05-20 20:16:47 +00:00
TreeHugger Robot dea6ee23c6 Merge "Fixing inset map in case of display cutouts" into ub-launcher3-qt-dev 2019-05-20 19:11:19 +00:00
Sunny Goyal c79bd21471 Fixing inset map in case of display cutouts
Change-Id: Ia2969688d9ae4c89a2da45eb6361f4476e1877ec
2019-05-20 12:00:17 -07:00
TreeHugger Robot 662a14f2de Merge "Using different resource size for touch region in landscape" into ub-launcher3-qt-dev 2019-05-20 18:57:00 +00:00
Zak Cohen 418b9bc5fc Adapt the task footer container to be a named container.
Bug: 126744445
Test: manual
Change-Id: Id00ffac4581bbbe5dfd73a63b05c4512394745c1
2019-05-20 10:44:20 -07:00
Sunny Goyal 1b40b731b2 Using different resource size for touch region in landscape
Bug: 132917885
Change-Id: Ib702fd17fecff980db2e1d00f05cd055bcc3185a
2019-05-20 10:09:26 -07:00
Jon Miranda e543818bb6 Fix bug where FolderIcon stays visible during swipe up to home animation.
This can happen when opening an app from a folder, and then immediately
swiping up back to home.

This happens because when we swipe up to go home, there's a race condition
where the folder close animation finishes and sets the FolderIcon to VISIBLE
right before FloatingIconView sets it to INVISIBLE.

To fix it, in OverviewState#onStateEnabled we call
AbstractFloatingView#closeAllOpenViews(animate=false). Then we added logic
to cancel any Folder closing animation (which there is,
from WindowTransformSwipeHandler#onLauncherStart) and to just close the
folder right then and there.

Bug: 132588097
Change-Id: I4379431815e7cbddede5ea0213fe9323f001484b
2019-05-20 10:01:15 -07:00
Vadim Tryshev ef80b4b491 Merge "Make every UI test generate screenshots for local test runs" into ub-launcher3-qt-dev 2019-05-18 01:40:38 +00:00
vadimt c328ac56cf Make every UI test generate screenshots for local test runs
Change-Id: Idb7962e62c0c95f8a50792e9342562c6d8b6ba42
2019-05-17 18:19:13 -07:00
TreeHugger Robot 7c278b62f9 Merge "Continue using window's sysui flags if task thumbnail unavailable" into ub-launcher3-qt-dev 2019-05-17 22:25:42 +00:00
TreeHugger Robot 24200e2757 Merge "Reapply recents attached state in createActivityController()" into ub-launcher3-qt-dev 2019-05-17 22:21:03 +00:00
TreeHugger Robot 95b81c3e55 Merge "Cancelling touch interaction on multi-touch event" into ub-launcher3-qt-dev 2019-05-17 22:21:01 +00:00
TreeHugger Robot 57ffdc4ec7 Merge "Fix issue with restored task display ids" into ub-launcher3-qt-dev 2019-05-17 22:10:02 +00:00