- Starts listening to local wallpaper colors as soon as folder
is positioned.
- The folder open animation already has a background color
animator.
- For simplicity, folder open animation always starts
first, and then we cancel its background color animator,
and start a new animator to the extracted color.
- setAutoCancel would be handy here, but it does not work, will
track in a separate bug.
- Since folders are reused, we clear our the color extractor on
folder close.
Bug: 175329686
Test: multiple folders on rainbow background
open each folder, ensure bg animates to proper color
Change-Id: Ie0f2c0632fa2361f7710ba247d74f882620dec16
The issue is caused by not updating the header container after widgets
recycler view items changed due to item click.
Test: Expand / collapse items in the full widgets picker. No UI
overlapping or void space is observed.
Bug: 186121915
Change-Id: I6a12bbdcca921d66c6d62601bb59cea66a33640b
Even though there is no change in fast scroller offset, the recycler view
scroll Y may still be updated. Let's also notify a scroll change if
the recycler view scroll has changed when updating the fast scroller thumb
offset.
Test: In the full widgets picker, scroll up and down with the fast
scroller. Then, scroll up and down in the recycler view. The top
section is scrolled together with the recycler view smoothly.
Bug: 183721076
Change-Id: I009fc7e27c8a20505a60502405ebbf695b5a37f2
Test: Go to contact bottom widgets picker. No collapse handle is
shown because the content isn't scrollable. Go to Google calendar
bottom widget picker. Collapse handle is hown because the content
is scrollable.
Bug: 185134663
Change-Id: Ic6109c055a072aa1cf3521f829833fd5f4cece0f
Before this change, the widgets recommendation table handles all the
touch events. The table doesn't distinguish a touch event from a scroll
event. This change forwards the motion event to the active recycler view.
If the recycler view doesn't handle the event, it will then forward the
event back to the view hierarchy.
Test: Open the full widgets picker, then start scrolling on the
recommended widgets UI. The full widgets picker scrolls perfectly.
Drag-n-drop a recommended widget
Bug: 186567644
Change-Id: I89d473179796c516d2394332dd75f8e9a1d8b388
* changes:
Move color extraction utils to extractor class so each instance can have its own set of temp variables.
Revert "Revert "Use color extraction for arrow popup.""
have its own set of temp variables.
- Pass in float[] param to not create new obj in each frame
for dragging widget case.
Bug: 175329686
Bug: 187019711
Test: manual, verify
Change-Id: I4350fb7e66a80c73def5659fb41abc14d357e667
This reverts commit 17fda29bf3.
Reason for revert: Fixing the memory leak
Leak was detected in caused launcher tapl tests to fail.
For instructions on how to debug leaks, see go/launcher-testing.
Using AS memory profiler, the color extractor class is holding
onto a reference to launcher that has already been destroyed.
The fix is to set the listener to null when view is closed.
Bug: 175329686
Test: run profiler in AS, open and close popups, and verify no leaks
Change-Id: I2d4a87f0481cbc88f3587dce91278e85ca113545
> Simulating the windo wmanager API to get available device
profiles until final API
> When a device has multiple internal displays, and with both
tablet and phone possibilities, it uses a split workspace layout
Bug: 186160341
Bug: 175782275
Test: Manual
Change-Id: Ieff2329acac7cdd6b9abe6f96cd459cd45bd0efe
This reverts commit 242c805f82.
Reason for revert: Introduces a leak. I haven't seen a bug for it yet, but this CL is the only in the culprit list; the leak can block multiple teams presubmits, and the leak is via ArrowPopup. Enough evidence.
https://fusion2.corp.google.com/invocations/4b50db71-d598-4e52-9076-e91d42b65014/targets
Change-Id: I1700a9eea8705983598aee43c0a63e67c1d9cf71
Bug: 187075409
- Updated logic to accept any view that is a a child of draglayer
(from being workspace dependent)
- Move color extraction logic from widget class to utility class.
- Initial CL, future CL will interpolate between colors
and expand color extraction to other abstract floating views.
Bug: 175329686
Test: long press on colorful wallpaper and test colors are extracted
test in multiwindow mode
Change-Id: I18a6bb5013de4eea7e9b45810401f5b9b3cd7302
Test: Open full widgets picker and observe the expected icon for
the conversations category.
Bug: 184878454
Change-Id: I580b0148d39c8dd004113c8f966135b22165a329
Reset the inset upon orientation change
Test: Open bottom widgets picker. Rotate the screen from portrait
to landscape and then back to portrait. Observe the correct
inset is set.
Bug: 183601302
Change-Id: I88432a49b2601df843fe33911fd7acdde66d06c4
Test: Enable talkback. When focusing on a collapsed item, it announces
Collapsed "App Name" "n widgets/shortcuts". Action available. Use
tap with 3 fingers to view. 3 fingers tap > Action > Expand.
Widgets are expanded.
When focusing on an expanded item, it announces
Expanded "App Name" "n widgets/shortcuts". Action available. Use
tap with 3 fingers to view. 3 fingers tap > Action > Collapse.
Widgets are collapsed.
Bug: 183120145
Change-Id: Ibbb6025b929c141aa9e2fd2c72dce314e8be837e
Provides a mechanism to temporarily block app widget updates to a
particular app widget for a limited time.
Bug: 169042867
Test: manual
Change-Id: I35bf9cb4bfe99b2f371ae8fc3db09e6fcc773752
Include the widget preview padding in the height calculation
Test: Run AddWidgetTest
Bug: 186138174
Change-Id: Iebb7ebb6ba1c6fc527ba94440bc16f84f63017b4
Test: In all widgets tray, switch to work profile. Expands an app.
Switch to personal tab and then switch back to work tab.
The previously expanded app is collapsed with correct arrow.
Bug: 184199207
Change-Id: Iac601a04412cb8c5f163483c5dd79da35f1fd05c
Test: Pin a conversation widget from a notification. RemoteViews are
rendered with the default size. Drag-n-drop from the pin widget
dialog works fine.
Bug: 185934141
Change-Id: Idb76cce2807e55e7b42e2e044712519857beb202
- Bind recommended widgets only when not in search mode. (b/183503774)
- Bind recommended widgets in onAttachedToWindow, Recommended widgets
are available in PopupDataProvider at this point. (b/185461866)
Bug: 183503774
Bug: 185461866
Test: tested manually
Change-Id: If24e5b2b3e69a695821b5f7d9f42ff4c89ae62fc
Test: Set grid to 2x2 and open the widgets picker in portrait. Able to
scroll the recycler view.
Bug: 185915917
Change-Id: I02bb11a999fb1816de6e2410810c4ae6c1da137f
Potential issues:
1. Widgets floating tips view is being shown
2. Header visible height is too small to be considered as a scroll
gesture
Test: Run AddConfigWidgetTest, AddWidgetTest, BindWidgetTest &
RequestPinItemTest
Bug: 185733371
Change-Id: Ic3e9188724dd920349ce8d8e8d98392b94b40642
TreeHugger Robot
Jon Miranda
Steven Ng
Samuel Fufa
Sunny Goyal
Vadim Tryshev
Alina Zaidi
Cyrus Boadway
Pierre Barbier de Reuille