Commit Graph

17288 Commits

Author SHA1 Message Date
Andreas Agvard d103d230a9 Merge "Enabled haptics during long press nav handle" into main 2023-11-06 08:40:58 +00:00
Andy Wickham 402ca3e3e5 Merge "Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag" into main 2023-11-04 19:57:39 +00:00
Andreas Agvard cb016243c7 Enabled haptics during long press nav handle
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Test: Manual
Bug: 303023676
Change-Id: Ia792fc6d00bf06320f51d56c43ed59c6dd23d456
2023-11-03 23:44:13 +01:00
Andreas Agvard 15ddc16b53 Merge "Tweak lpnh haptics based on UX input" into main 2023-11-03 22:41:02 +00:00
Priyanka Advani ebc9a3b5e1 Merge "Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."" into main 2023-11-03 22:10:27 +00:00
Priyanka Advani 9aed56096c Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Reason for revert: Likely culprit for b/309158105

Reverted changes: /q/submissionid:24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Change-Id: I8ee560f7e599bcfde09eff53f049309ba25ce77f
2023-11-03 21:31:45 +00:00
Pat Manning 89bd90927d Merge "Fix focus navigation of All Apps when using external keyboard." into main 2023-11-03 18:42:37 +00:00
Tony Wickham 075a67da15 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-11-03 18:35:54 +00:00
Kevin Lim ab242020a2 Merge "[Settings] Remove logic to restore highlight to 0th item in SettingsActivity." into main 2023-11-03 18:12:09 +00:00
Andreas Agvard 3221a9235f Tweak lpnh haptics based on UX input
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT DISABLED
Test: Manual
Bug: 303023676
Change-Id: I7c96ac82358059418665dfe569705e745da7b1d8
2023-11-03 14:11:41 +01:00
Michael Stokes f5a83e56e0 Merge "Revert "Fix the badge in badge (triple badging), by simply remov..."" into main 2023-11-03 12:36:10 +00:00
Uwais Ashraf b965427554 Revert "Fix the badge in badge (triple badging), by simply remov..."
Revert submission 24721954-cherrypick-removeBadgeInBadge-dia2ji7r7td

Reason for revert: Breaking tests

Reverted changes: /q/submissionid:24721954-cherrypick-removeBadgeInBadge-dia2ji7r7td

Change-Id: Ia78cbae76d52b52fdfdc258311712f44bd645f2e
2023-11-03 12:20:33 +00:00
Jagrut Desai 2d9f2c1cec Merge "Animate aways Notification Dots for Taskbar Pinning Annimation" into main 2023-11-03 02:02:49 +00:00
Jagrut Desai 61526a7413 Merge "Improvements to TaskbarDividerPopupView" into main 2023-11-03 02:02:28 +00:00
Jagrut Desai 47bf322e21 Animate aways Notification Dots for Taskbar Pinning Annimation
Test: Manual
Bug: 308460959
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: Ic16881c05c70ed717dc63131d94ece805c39f6fc
2023-11-02 17:39:37 -07:00
Jagrut Desai 9af2084a56 Improvements to TaskbarDividerPopupView
- Close Animation improvement for popup.
- Popup location changed to  16dp above the taskbar view.
- Support for disabled state when user is in 3-button mode. (design changes to come in separate cl)

Test: Manual
Bug: 265170176
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: I9c91e6eb2b29c85433ba1c3d34505f0519448a6f
2023-11-02 17:24:50 -07:00
Federico Baron 0282c107fa Merge "Fix page indicator bugs for foldable" into main 2023-11-02 17:34:18 +00:00
Brandon Dayauon 2424d48867 Merge "Fix the badge in badge (triple badging), by simply removing the user badge (FLAG_SKIP_USER_BADGE)." into main 2023-11-02 15:27:11 +00:00
Tony Wickham eccf070bae Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: Ib6e592a31a55a912a7ea991a421a9c60bca51c80
2023-11-01 23:16:10 +00:00
Kevin Lim a8ada5314c [Settings] Remove logic to restore highlight to 0th item in
SettingsActivity.

Bug: b/303787732
Flag: NONE
Test: Manual: http://recall/clips/9504ce89-ec62-4b32-b43e-0740300f872f
Change-Id: I47e55811637ff2d7fff996b19ad7af867a1307ba
2023-11-01 22:28:46 +00:00
Jagrut Desai 1e63858559 Merge "Turn on TASKBAR_PINNING for TEAMFOOD" into main 2023-11-01 22:06:31 +00:00
fbaron 95ed863d96 Fix page indicator bugs for foldable
There are bugs when unfolding the felix device where the page indicator will appear in the wrong place, and have to animate all the way back to where it should go. This was originally fixed with ag/24399441 but it seems that the issue is still happening when flag FOLDABLE_SINGLE_PAGE is off. Here we fix that issue..

Fix: 294231977
Fix: 291822492
Flag: NONE
Test: n/a
Change-Id: I6ae97ebbb034f5b520a4f5ace729b44b89ea73a0
2023-11-01 14:19:07 -07:00
Thales Lima 9623aaa470 Merge "Change AllApps padding to use a Rect" into main 2023-11-01 12:21:53 +00:00
Andy Wickham 24a50df135 Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag
Bug: 306400785
Bug: 308693847
Test: Manual
Flag: LEGACY ANIMATE_LPNH TEAMFOOD
Change-Id: I996c923e5a1949e6219f900da12e2b5091597750
2023-10-31 23:45:12 -07:00
Stefan Andonian 7117c55578 Merge "Robustly fixed issue where migration from different versions of DB data tables was causing crashes upon grid size switching." into main 2023-10-31 22:44:06 +00:00
Stefan Andonian e8b86db34d Robustly fixed issue where migration from different versions of DB data
tables was causing crashes upon grid size switching.

Bug: 304687723
Test: Verified behavior through unit test. Also manually tested that
factory resetting device -> adding shortcuts to the workspace ->
changing the grid size didn't cause any issues and resulted in normal
behavior.

Change-Id: I1945004d2c9a2d6f2b74d9597b39763ed4962e7b
2023-10-31 20:27:26 +00:00
Himanshu Gupta 510fa88571 Merge "Adding support for private/clone profile badge in Launcher3." into main 2023-10-31 16:28:40 +00:00
Thales Lima b433c9c312 Change AllApps padding to use a Rect
AllApps uses different values for left and right padding in some places (e.g. ActivityAllAppsContainerView uses workspacePadding.left/right), and this change is the first step into moving those values into DeviceProfile.

Bug: 269632571
Test: NexusLauncherTest
Flag: NONE
Change-Id: I14c4edf55ca74f256b1aaa336fff246a0c78e25d
2023-10-31 16:19:40 +00:00
Pat Manning b53d8d6360 Fix focus navigation of All Apps when using external keyboard.
- All apps icons do not show the focus rectangle when focused as mIconFocusListener is null in BaseAllAppsAdapter when onCreateViewHolder is called.
- All apps recyclerview does not scroll down when focus goes from top to bottom of list, as AllAppsToastUiDelegate calls hideKeyboard which clears focus.
- Focus goes behind AllApps into hotseat, so update hotseat setDescendantFocusability.

Flag: NONE
Fix: 296844600
Test: TaplKeyboardFocusTest
Change-Id: I65f6fbb6f4df0be4b4ff922dda267d27da16effe
2023-10-31 13:47:12 +00:00
Himanshu Gupta 6e030348dd Adding support for private/clone profile badge in Launcher3.
Bug: 289224457
Flag: None
Test: Flash on device and Presubmit
Change-Id: Icebb5b5129a2f0d909481f00d51e047431a23a15
2023-10-31 07:46:34 +00:00
Ats Jenk 866e77101c Merge "Use aconfig flag for desktop mode" into main 2023-10-31 05:07:02 +00:00
Sunny Goyal 24e738e872 Merge "Removing some dependencies on Activity" into main 2023-10-30 22:50:19 +00:00
Jagrut Desai 0dbc0d0285 Turn on TASKBAR_PINNING for TEAMFOOD
Test: Presubmit
Bug: 265437087
Flag: LEGACY ENABLE_TASKBAR_PINNING TEAMFOOD
Change-Id: I13e7e5b96323a3b10d930a053fbeca7023cbba5f
2023-10-30 12:24:50 -07:00
Sunny Goyal e82a20a44d Removing some dependencies on Activity
> Removing activtiy from overlay callbacks
> Removing usage on activtiyLifecycleCallbacks and managing the callbacks ourselves

Bug: 306225896
Test: Existing tests cover the lifecycle changes
Flag: N/A
Change-Id: I79941e364328eecdc8a72cac4d35b75d50a25319
2023-10-30 08:23:15 -07:00
Jon @ d2750e315c Merge "Migrate ENABLE_HOME_TRANSITION_LISTENER to launcher.aconfig" into main 2023-10-27 23:12:02 +00:00
Anushree Ganjam 2fada7dc9e Merge "Read LPNH touch slop percentage and timeout ms from DeviceConfig." into main 2023-10-27 21:03:50 +00:00
Stefan Andonian 42d6ed42b8 Merge "Do DbMigration if coming from a DB w/ version < 31" into main 2023-10-27 20:30:08 +00:00
Ats Jenk 5c25c3a19d Use aconfig flag for desktop mode
Refactors all flag access in Launcher to be from DesktopTaskView and using a method instead of a static field.
Also using static import for the method so if we need to move it, only imports needs to be updated.

Bug: 304778354
Flag: ACONFIG com.android.wm.shell.enable_desktop_windowing TEAMFOOD
Test: enable the aconfig flag, check that desktop windowing is available

Change-Id: Ia2bdfd865802a635878d72cfb5a90c21dad6ed08
2023-10-27 10:58:07 -07:00
Jon Miranda 60ae29ef08 Migrate ENABLE_HOME_TRANSITION_LISTENER to launcher.aconfig
Also set flag to TEAMFOOD.

Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TEAMFOOD
Bug: 306053414
Test: manual
Change-Id: Icf3947e61fa9f20f5b6e5ca2af96e693b55d3edc
2023-10-27 16:43:01 +00:00
Anushree Ganjam cb571daa0b Read LPNH touch slop percentage and timeout ms from DeviceConfig.
Make CUSTOM_LPNH_THRESHOLDS as a ReleaseFlag so this can be enabled from
server for experiments since touch slop percentage and timeout are
applied only when CUSTOM_LPNH_THRESHOLDS is enabled.

Add FeatureFlags for LPNH slop multiplier is "lpnh_slop_percentage" and LPNH timeout is "lpnh_timeout_ms"

Bug: 301680992
Flag: Legacy CUSTOM_LPNH_THRESHOLDS DISABLED
Test: Manual

Change-Id: Ifd066b8cb8521dceb7aa12d9e46f5b7cfce1ec7f
2023-10-26 19:03:40 -07:00
Jagrut Desai 24231d9994 Merge "Taskbar pinning animation with no recreate" into main 2023-10-26 21:33:41 +00:00
Stefan Andonian 634bb805bb Do DbMigration if coming from a DB w/ version < 31
This was the issue that is causing the launcher to crash when changing a
grid layout. The migration is not happening, causing there to be 21
columns in the database. When the grid size changes, and the db from
grid size X is migrated to a db of grid size Y, the column count isn't
matching.

Bug: 304687723
Test: Verified behavior through unit test.
Change-Id: I2ee1f2fe09db432715b22c41581a77f6b0ac8320
2023-10-26 20:29:22 +00:00
Jagrut Desai 631b284836 Taskbar pinning animation with no recreate
Test: Manual, Visual
Bug: 265436799
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED

Change-Id: I84a4d1efdb0bd4a0f856fa1f46b6489ef54a3841
2023-10-26 10:36:48 -07:00
Vinit Nayak 0fcd231173 Merge "Use aconfig flag enable_split_contextual" into main 2023-10-25 23:19:27 +00:00
Tracy Zhou 867f7f8360 Merge "Migrate ENABLE_TASKBAR_NO_RECREATION to launcher.aconfig" into main 2023-10-25 17:45:09 +00:00
Uwais Ashraf 6eb006ed90 Merge "Add margins to top and bottom when grid only overview enabled" into main 2023-10-25 13:53:24 +00:00
Thales Lima 7275322cf0 Merge changes from topic "handheld_landscape" into main
* changes:
  Remove app labels in isVerticalBar
  Decrease text size if it doesn't fit the cell
2023-10-25 10:13:58 +00:00
Tracy Zhou 00f9e52575 Migrate ENABLE_TASKBAR_NO_RECREATION to launcher.aconfig
Bug: 274517647
Test: manual
Change-Id: I29fe58691440ee757c9f391bd574ef80eefb5ae6
2023-10-24 18:42:15 -07:00
Vinit Nayak a1be4c1123 Use aconfig flag enable_split_contextual
Bug: 276361926
Test: Basic split contextual operations work
as expected

Change-Id: I7202654f8452a0c57e5e728c9baaadf85fa22a96
2023-10-25 01:37:17 +00:00
Jeremy Sim 001a0f1cc0 Merge "Prevent app pairs rank from resetting on Launcher model reload" into main 2023-10-25 00:12:20 +00:00