Commit Graph

9769 Commits

Author SHA1 Message Date
Holly Jiuyu Sun 564a0acda7 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev am: 6c3cd3c092
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24856663

Change-Id: If4a73bc64242feec4786705603c5c128fc2cecba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-27 17:49:29 +00:00
Holly Jiuyu Sun 6c3cd3c092 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev 2023-09-27 16:05:41 +00:00
Holly Sun e292642489 Log toggle status for LPNH and LPH in Settings.
Bug: 295039461
Test: manual
Flag: PRESS_HOLD_NAV_HANDLE_TO_SEARCH. LONG_PRESS_HOME_BUTTON_TO_SEARCH
Change-Id: I380dd6f62378098edf063f29d10305b8c404f38d
2023-09-26 00:36:44 +00:00
Andy Wickham c18764fce1 Merge "Add some gesture logs" into udc-qpr-dev am: 66072ca559
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755061

Change-Id: Iabb40a2aaf81ac23121ec356b55c012da92348a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 00:31:56 +00:00
Andy Wickham 66072ca559 Merge "Add some gesture logs" into udc-qpr-dev 2023-09-25 23:54:20 +00:00
Becky Qiu f545328f56 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP. am: 86b6a887d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24828699

Change-Id: Ifd35410d27765efc7896dac8e002ce3f1690a8c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-23 06:48:19 +00:00
Becky Qiu 86b6a887d1 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP.
Bug: 300101221
Test: manually tested dump, see the NL change for samples.
Flag: INVOKE_OMNI_LPH, DISABLED; ENABLE_LONG_PRESS_NAV_HANDLE, TEAMFOOD.
Change-Id: I1fb03779775cd0c9353abd4f796e9cc7c42f0f96
2023-09-23 02:29:54 +00:00
Felix Stern db1028ea85 Merge "Use stashedTaskbarHeight for IME insets override" into udc-qpr-dev am: 795dc83c72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24834321

Change-Id: Iec4d3327d606cf5d607b8b68d7c640e737199d72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 18:07:44 +00:00
Felix Stern 795dc83c72 Merge "Use stashedTaskbarHeight for IME insets override" into udc-qpr-dev 2023-09-22 17:04:19 +00:00
Brandon Dayauon f9a203c586 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev am: 28ae77df37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24724750

Change-Id: Ibbefedc8e85690aa7a389b0e106476d56d0d768b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 15:25:17 +00:00
Brandon Dayauon 28ae77df37 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev 2023-09-22 14:36:45 +00:00
Cosmin Băieș df2ceac06c Use stashedTaskbarHeight for IME insets override
Previously [1] we removed the explicit insetsSizeOverride from the
Taskbar for the IME window, as we now [2] enable hiding the IME nav bar.
This would now send the normal insets the taskbar reports. When running
on pre/postsubmit, with test harness setup, the non-transient taskbar
would show, which is bigger than the IME's navigation bar height.

Due to the current logic in InsetsSource#calculateInsets, this leads to
the IME window receiving top navigation bar insets instead of bottom.
As the IME nav bar is now treated as a (fixed on bottom) caption bar,
the two would no longer overlap, and thus lead to a double insets
dispatch, and also a (temporarily) bigger IME window, for IMEs that set
their decorView height to WRAP_CONTENT (e.g. MockIME used in testing).

This instead keeps the previous insetsSizeOverride for IME, and uses the
stashedTasbarHeight when in gesture nav, which should account for both
transient and normal taskbars.

 [1]: I86079cb6670a2ae3b6fa883694f8af81df212408
 [2]: I8793db69fb846046300d5a56b3b0060138ef4cd5

Bug: 297000797
Test: atest WindowInsetsControllerTests#testDispatchApplyWindowInsetsCount_ime
Change-Id: I102a8bc1f8869ebbce9f8f1fefa651d49a9538ec
2023-09-22 14:16:03 +00:00
randypfohl 1c76ccfd6c Setting recentsView orientation to match recents activity orientation am: 03d29305ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804147

Change-Id: I12f07376447009d58ee7519b9cd7433ac544191a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 16:51:04 +00:00
randypfohl 03d29305ca Setting recentsView orientation to match recents activity orientation
Test: can no longer repro incorrect orientation when launching apps from all apps
      added logs to verify recents activity -> view were the same while rotating
      turned off auto rotate and verified state matched

Bug: 288984663
Bug: 301024104

Change-Id: I7fc3b47bff0a99756aaf877bf634e2d162838d6f
2023-09-20 15:04:55 -07:00
Brandon Dayauon 47000ae6e6 Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW
- Create another icon, "all_apps_predicted_row_icon" that will be the mDisplay for the predicted app row
in AllAppsList

Bug:299171695
Test: video
Before: https://drive.google.com/file/d/1HxNW0015nQHCc7eQiySf-gwsHrLs_JjR/view?usp=sharing
after: https://drive.google.com/file/d/1HyEwKI-yumILTCjglKcqovhTlRVjNGxg/view?usp=sharing - making sure that QL is fine and dragging regular Toast results are normal
Flag: N/a
Change-Id: Ie002cacb168396dbea39f79679bd6a04b80e374b
2023-09-20 14:21:10 -07:00
Sunny Goyal a6aa1c9466 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread am: 5b86162853
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24795935

Change-Id: I9f4d5a9eb2590951fbe4091ff8050ad72f37bbd4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-19 18:36:04 +00:00
Sunny Goyal 5b86162853 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread
during onAttachToWindow

Bug: 294352799
Test: Verified on device
Flag: N/A
Change-Id: I3cce6900cd62a6e9a57c155b74c15c2340c6011b
2023-09-18 23:04:33 +00:00
Tony Wickham 8e735c8234 Add some gesture logs
- Log when a DelegateInputConsumer becomes active
- Add reason for NavHandleLongPressInputConsumer
- Fixed typo

Test: adb shell dumpsys activity service TouchInteractionService
locally and verify logs
Flag: ENABLE_LONG_PRESS_NAV_HANDLE
Bug: 300247322

Change-Id: Ie2cdc8f4bfc8a6c794536871e714ff913f36f46f
2023-09-18 16:34:20 +00:00
Tony Wickham e136b6a641 Finish recents animation synchronously on cancel event am: 2316dc4750
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755062

Change-Id: Ib8bd21048402db34caf681802599517b4a37cb94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-18 16:11:14 +00:00
Tony Wickham 2316dc4750 Finish recents animation synchronously on cancel event
Fixes: 300247322
Test: invoke omnient via long press nav handle
Flag: ENABLE_LONG_PRESS_NAV_HANDLE

Change-Id: I5d7cd1d0a2a50da26a881a6daa203806bf857909
2023-09-18 15:34:29 +00:00
Nicolò Mazzucato 6eb5e0892b Merge "Preload overview after unfold" into udc-qpr-dev am: 3c898a7550
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24771967

Change-Id: Ic4f1ca2b27cd408963ff33ad7972ec4d1fef5a66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-18 09:53:20 +00:00
Nicolò Mazzucato 3c898a7550 Merge "Preload overview after unfold" into udc-qpr-dev 2023-09-18 08:37:56 +00:00
Vinit Nayak a6f66eeba7 Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev am: 8ad9393213
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24761312

Change-Id: Ib31bfdd11c5f1c62b1ffcfe24bcdd81fd4903633
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 17:24:13 +00:00
Vinit Nayak 8ad9393213 Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev 2023-09-15 17:20:43 +00:00
Vinit Nayak 9b3598f154 Provide bgExecutor for RotationButtonController
Bug: 289341065
Test: Unfolded, checked perfetto trace, it
shows up not on UI thread

Change-Id: I9a080c9a5c3c57f38eb6719ed73952dde4f6bba1
2023-09-15 10:46:00 -04:00
Nicolo' Mazzucato f6264d2387 Preload overview after unfold
Before this change, the configChange was processed when launcher becomes visible. However, this happened during animations (e.g. swipe to home after unfold to app).

With this change, the onConfigChange received by TIS (so, it's received also if the activity is not visible), is used to preload overview, moving a ~100ms block to unfold instead of during the animation.

Bug: 294352799
Test: recorded a perfetto trace and checked jank decrease
Change-Id: I35a7036887cc9ea490f27d5ccd47fe423775350b
Merged-In: I35a7036887cc9ea490f27d5ccd47fe423775350b
(cherry picked from commit 11ce5f85c9)
2023-09-15 11:38:46 +00:00
Federico Baron f3a2082285 Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev am: 15b81093d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24749997

Change-Id: I06df48dda4c77024b9b35127a8eeda9b42080607
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 16:51:15 +00:00
Federico Baron 15b81093d7 Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev 2023-09-14 16:26:34 +00:00
Becky Qiu 09b354b232 Merge "Print out debug logging in bug report if not running test." into udc-qpr-dev am: d1d73e05ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24737823

Change-Id: I628cb28daa134c58b10a8db6f84f4004ed1ddbf4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 16:00:42 +00:00
Becky Qiu 28498d5f6f Print out debug logging in bug report if not running test.
Bug: 300101221
Test: local
Flag: not needed, logging only.
Change-Id: If016d6fe35a1c43e1a1f311d696b9f2ca0f36f6a
2023-09-13 17:24:51 -07:00
fbaron a101ac696f Ensure PauseUIUpdate always ends up getting set to false
when result was null but getTaskbarUIController() is not null, we don't setPauseUIUpdate to false. This CL ensure we always end up setting pauseUIUpdate to false so that the hotseat suggested apps show up.

Fix: 295892343
Flag: no flag
Test: verify hotseat icons don't disappear
Change-Id: Id872f3174df276cb7a4ed7f6672523d0851a11dd
2023-09-13 16:56:02 -07:00
Jagrut Desai a1e8f327ff Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev am: 733d440ac1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24709295

Change-Id: I0066e91a986878debb75663fa68d4f5408af8898
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-11 22:57:58 +00:00
Jagrut Desai 733d440ac1 Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev 2023-09-11 21:52:08 +00:00
Jagrut Desai 6472119d4b Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar
Test: Manual
Bug: 278078311
Flag: Not needed
Change-Id: Ia963e45b3b4e6d928b6292b80b73394e76fe2325
2023-09-11 09:39:23 -07:00
Schneider Victor-tulias ad147bbc0d Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev am: 9e6a845ca4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24622404

Change-Id: I543b44b24c93508776bcc4a7c24a8142a70d698c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-11 16:29:01 +00:00
Schneider Victor-tulias 9e6a845ca4 Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev 2023-09-11 15:30:05 +00:00
Andy Wickham 294a40b1be Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev am: 3289e4fa35
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24607784

Change-Id: I87cd79905c5febcd0391d75b9756522ad3d1ba34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-08 16:44:53 +00:00
Andy Wickham 3289e4fa35 Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev 2023-09-07 23:43:42 +00:00
Brian Isganitis a62d85752e Register OnAttachStateChangeListener before attaching to container. am: 503f04f86d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681979

Change-Id: Iae9abea705e1f379cb605ed286de6ee4e6df8168
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-07 22:54:25 +00:00
Brian Isganitis 503f04f86d Register OnAttachStateChangeListener before attaching to container.
If we do the reverse, there is a change onAttach will occur before the
callback is registered and invokable (e.g. overlay window already exists
for EDU).

Test: Manual
Fix: 299335210
Flag: None
Change-Id: Ic4befe900c9582e1b01c2bc4699b431f95efa617
2023-09-07 19:15:10 +00:00
Brandon Dayauon b33d906d87 Merge "Add nullable annotation" into udc-qpr-dev am: 31679166a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24544468

Change-Id: Ifd6ac159f610f6a9a3a0f409778a6084f411949f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-05 18:09:33 +00:00
Brandon Dayauon 31679166a7 Merge "Add nullable annotation" into udc-qpr-dev 2023-09-05 16:50:38 +00:00
Schneider Victor-tulias 785a7511b6 Add error handling to prevent IllegalArgumentException
ActivityLaunchAnimator.Controller.fromView requires an instance of LaunchableView, however findViewWithBackground had no checks to return one. updated the check to make the exception less likely.

Flag: not needed
Fixes: 297564681
Test: ran launcher and launched apps
Change-Id: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
Merged-In: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
2023-09-05 13:58:42 +00:00
Saumya Prakash a2c965726e Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev am: 15b0c9ea54
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24623620

Change-Id: I76dcb5ab590f458fdebb2b171e3faf58d7d919f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-02 00:48:43 +00:00
Sunny Goyal aee84be4b6 Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev am: a6f089c5fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24589979

Change-Id: I790f16e73181bd299e9e229401015784588bd245
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-02 00:48:15 +00:00
Saumya Prakash 15b0c9ea54 Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev 2023-09-01 23:49:30 +00:00
Sunny Goyal a6f089c5fc Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev 2023-09-01 23:46:02 +00:00
Tony Wickham 0eb2b24d68 Merge "Update TaskView corner radius dynamically" into udc-qpr-dev am: 2677e04510
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24627246

Change-Id: I59ba22e210e592dff73e0a1ac73b6fba4762e610
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-01 23:05:41 +00:00
Tony Wickham 2677e04510 Merge "Update TaskView corner radius dynamically" into udc-qpr-dev 2023-09-01 22:41:18 +00:00
Saumya Prakash 3ca10a1325 Ensure Gesture Nav Edu animation scales to fit different screen sizes
The lottie animation in the gesture nav tutorial wasn't scaling correctly for certain devices
leading to gaps around the animation. This change uses animation's scale transformation to ensure it fits the
dimensions of the device.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 295809541
Test: Went through the tutorial on different types of devices and ensure
the animation takes up the entire screen.

Change-Id: Iadee0d0389a11aa38c9e947b4b40466acd8f4422
2023-08-31 23:08:54 +00:00