Commit Graph

10614 Commits

Author SHA1 Message Date
Santiago Etchebehere e9f490374c Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d am: f52e543389
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I8e138883c1440327abb6e0e595a0b5e47e17d545
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:52:37 +00:00
Santiago Etchebehere f52e543389 Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I8745066261a7fa93870ba9b1860c39d112888420
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:27:38 +00:00
Sunny Goyal ba0a00eec9 Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca am: 77d7797f83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: Icaa4a4a6863e43f6b499d0c21be0614e11b4381c
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:19:48 +00:00
Santiago Etchebehere 8340cb6d7d Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev 2022-04-22 21:07:18 +00:00
Sunny Goyal 77d7797f83 Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: I19c237bf97f40a37f2f537ed165b802236a26b89
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:02:25 +00:00
Santiago Etchebehere b8ad6e08cf Revert "Use new onStartSplitLegacy when starting split from overview"
Revert submission 17779173-startSplitLegacy

Reason for revert: Broken build: b/230129218
Reverted Changes:
I01590e53c:Remove check for preventing re-parenting non-split...
I696749f76:Use new onStartSplitLegacy when starting split fro...

Change-Id: I6d81e0584bbfda3694772dcf293a4d064b2e8517
2022-04-22 21:02:22 +00:00
Sunny Goyal 84151d2bca Merge "Removing fade in logic during load." into tm-dev 2022-04-22 20:29:34 +00:00
Jeremy Sim d0b1258d27 Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399 am: 8f00e9bc55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: I95cf7e35b7f7424d30e978214135476e86da12ff
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:24:24 +00:00
TreeHugger Robot 936a3e1239 Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f am: 1a3002207b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: I9d130eb8e5d070dfd2f5f3fe6e94978eb0fbf8f3
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:23:43 +00:00
Tony Wickham ae15c42ce6 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95 am: 8426275608
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I90101494f32fa6b15b5085b75a78fb80bc8d3cfc
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:22:09 +00:00
Jeremy Sim 8f00e9bc55 Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: I74d9711a7e60d2ecfa61565e67060c6b9c9aa6b0
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:09:35 +00:00
TreeHugger Robot 1a3002207b Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: I6ed16e6d0a59e4804eaa30b1c7849150a6fcd6bb
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:09:17 +00:00
Jeremy Sim 602b46c399 Merge "Fix crash bug when splitting with animations disabled" into tm-dev 2022-04-22 20:05:09 +00:00
TreeHugger Robot 8aead5503f Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev 2022-04-22 20:03:36 +00:00
Tony Wickham 8426275608 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I37bc83970d5dd6b1c1d59cfd95079826d5c2400f
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:01:47 +00:00
Jeremy Sim 42276318b9 Fix crash bug when splitting with animations disabled
Fixes a bug where disabling animations (through Settings) would cause split staging to crash.

The crash occurs because when animations are disabled, StateManager advances to OVERVIEW_SPLIT_SELECT too quickly, and does not trigger the appropriate code block in RecentsViewStateController#handleSplitSelectionState(). This causes a crash.

Fixed by changing the conditional so that it always runs when OVERVIEW_SPLIT_SELECT is the target state, no matter the starting state.

Note: If more animations are added for this state in the future, the conditional may need to be tweaked further.

Fixes: 223598955
Test: Confirmed not crashing on 2 devices when splitting in a variety of ways.
Change-Id: I7f3def88f124fa1babe9a943adf72c10f58b7131
2022-04-22 19:58:40 +00:00
Tony Wickham 741e4aeb95 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev 2022-04-22 19:55:31 +00:00
TreeHugger Robot da0d7d3fcc Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec am: e03e7e1f5f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: I44be923da02284b6edf86e2b1f3d539ccd6a6c15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:20:07 +00:00
Alex Chau d5620750fc Update pull back animation for tablet AllApps am: e3b806366a am: 24771d2ef7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: If13ee7fdfaced3a40e45be7e817e03bbcc911413
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:18:37 +00:00
TreeHugger Robot e03e7e1f5f Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: I182643138fa930f634d313a426725a8603487360
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 17:52:52 +00:00
Alex Chau 24771d2ef7 Update pull back animation for tablet AllApps am: e3b806366a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: I82187136a89e794aff6719d2623926f2aa3f159a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 17:52:30 +00:00
TreeHugger Robot 37fa1392ec Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev 2022-04-22 17:33:06 +00:00
Sunny Goyal 7b8d63fcf8 Removing fade in logic during load.
Launcher already blocks the draw during load, which ensures
that system draws the loading screen. Additional fade animation
is not visible since the Launcher window is already getting fade in

Bug: 199120420
Bug: 199120420
Test: Verified on device

Change-Id: I7089cea4c5f97f6ef92eabcba56451de407c98b8
2022-04-22 16:35:40 +00:00
Alex Chau e3b806366a Update pull back animation for tablet AllApps
- This is a follow-up of http://ag/17636490
- Introduced animation property specifically for pullback translation and alpha, which will invoke getRecyclerViewContainer directly on tablet, and invoke aggregate setter of appsView on phones
- Delay reset of pullback animation to after dismiss animation to avoid jump in value during state transition animation
- Introduced property factory for addictive properties similar to MultiScalePropertyFactory

Fix: 220345008
Test: manual on small and large screen
Change-Id: I7b5c0019c1d4d36c3c7ca4ec79e38e4eb09c32ca
2022-04-22 16:27:25 +01:00
TreeHugger Robot 71a63918c6 Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-dev am: df436c364c am: dc06e3be5e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17891361

Change-Id: I49cffc67fb9b7ae6b2cbcd40840f0b4109614c01
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 04:15:13 +00:00
TreeHugger Robot dc06e3be5e Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-dev am: df436c364c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17891361

Change-Id: I1de502b9faaa12f98a2e1838216afe61295730d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 03:28:10 +00:00
Brian Isganitis e10ab8cdcd Snap to last task if swiping down at a greater Y than X velocity.
If you swipe down slightly diagonally, it will almost always be treated as a swipe to the next task rather than a return to the current task. If we are swiping down and the Y velocity is grater, we should snap to the current task instead.

Test: Manually in fully gestural mode.
Bug: 222117127
Change-Id: I0f591fa5117291a9c095c2b733280464d29103d9
2022-04-21 22:50:39 +00:00
Vinit Nayak dd7e132db5 Use new onStartSplitLegacy when starting split from overview
Bug: 223396876
Change-Id: I696749f7674a09b2a12c6ef2c2b7d19d0884049a
2022-04-21 11:51:24 -07:00
TreeHugger Robot 6a75aaee52 Merge "Fixing potential NullPointer exceptions when Launcher is created before TouchInteractionService is initialized" into tm-dev am: d880a4fa63 am: b12c1b938d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17805037

Change-Id: Ibd1567306b78855ce80602be657b623598048681
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 18:39:56 +00:00
TreeHugger Robot b12c1b938d Merge "Fixing potential NullPointer exceptions when Launcher is created before TouchInteractionService is initialized" into tm-dev am: d880a4fa63
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17805037

Change-Id: I5c57c00aa461387c0d031c9430ecdf7dcdbc314c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 18:23:30 +00:00
TreeHugger Robot c1cf8b0e95 Merge "Disallow long press below taskbar icons" into tm-dev am: 8e0177813a am: c922594e6b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17872520

Change-Id: I763257e603be7845bd63478505266651a4895bba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 17:59:32 +00:00
TreeHugger Robot d880a4fa63 Merge "Fixing potential NullPointer exceptions when Launcher is created before TouchInteractionService is initialized" into tm-dev 2022-04-21 17:54:03 +00:00
TreeHugger Robot c922594e6b Merge "Disallow long press below taskbar icons" into tm-dev am: 8e0177813a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17872520

Change-Id: I91f7d287952a2d187c7e1ac920910348b5d26fd8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 17:36:10 +00:00
TreeHugger Robot 8e0177813a Merge "Disallow long press below taskbar icons" into tm-dev 2022-04-21 17:16:42 +00:00
Tony Wickham a681cf6abe Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets
- This allows us to distinguish taskbar's ITYPE_EXTRA_NAVIGATION_BAR insets from its ITYPE_BOTTOM_TAPPABLE_ELEMENT insets
- Set nav bar insets as before (contentInsets)
- Set tappable elements insets the same, except when taskbar is stashed, in which case set to 0

Test: TaplTestsTaskbar; manually stash/unstash taskbar, open IME, open Calculator (which uses tappableElement() insets) and Contacts (which uses systemBars())
Fixes: 215411414
Change-Id: If00f7a590b0780715d5b8159f5135054364ce84e
2022-04-21 16:15:41 +00:00
Tony Huang ac409540bc Merge "Add jank instrument support for split screen" into tm-dev am: 8edc0dfcf1 am: b01dc823a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17818645

Change-Id: I680bba5206adfb81754b042b7b76748bf5a4d404
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 12:09:23 +00:00
Tony Huang b01dc823a0 Merge "Add jank instrument support for split screen" into tm-dev am: 8edc0dfcf1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17818645

Change-Id: Ic2f254e0fa7cf210a5c845b1d7598441dea9ddb1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 11:53:33 +00:00
Tony Huang 8edc0dfcf1 Merge "Add jank instrument support for split screen" into tm-dev 2022-04-21 11:31:22 +00:00
Tony Wickham 4ba1c141e0 Merge "Move taskbar insets logic to TaskbarInsetsController" into tm-dev am: 74641da5b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778391

Change-Id: Ie6f9bb9e6eab240e38660cb0705d34725eb9ee1b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 00:03:00 +00:00
Tony Wickham 74641da5b8 Merge "Move taskbar insets logic to TaskbarInsetsController" into tm-dev 2022-04-20 23:43:50 +00:00
Vinit Nayak 9d6dc317af Merge "Check for auto-rotation when initializing RecentsOrientedState" into tm-dev am: bf33e85cb7 am: 9085667ac0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17776932

Change-Id: Ie395738aa2a8554d021510fdcafb1e957dc6b4ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 21:37:23 +00:00
Vinit Nayak 9085667ac0 Merge "Check for auto-rotation when initializing RecentsOrientedState" into tm-dev am: bf33e85cb7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17776932

Change-Id: I374d1d66a580dc8b2c8925ff66de93c382eac3c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 21:18:34 +00:00
Tony Wickham 81bff9becd Disallow long press below taskbar icons
Test: long press below icons, doesn't stash; can still swipe up
Fixes: 201239461
Change-Id: Ifdf355138d7958c0442814d968f0722f54e12ae1
2022-04-20 13:58:53 -07:00
Vinit Nayak bf33e85cb7 Merge "Check for auto-rotation when initializing RecentsOrientedState" into tm-dev 2022-04-20 20:58:30 +00:00
Tony Wickham 36c9d888d8 Move taskbar insets logic to TaskbarInsetsController
Test: TaplTestsTaskbar; manually stash/unstash taskbar, open IME
Bug: 215411414
Change-Id: I73622dc020c4f8c8b3d317fcb1dd072bcfc3d274
Merged-In: I73622dc020c4f8c8b3d317fcb1dd072bcfc3d274
2022-04-20 19:27:48 +00:00
Tony Wickham 2965948ae1 Merge "Move taskbar insets logic to TaskbarInsetsController" 2022-04-20 19:27:29 +00:00
Brian Isganitis 416f0be9f3 Merge "Decrease overview degree threshold from 45 to 15 degrees." into tm-dev am: 7bd3e02e2f am: 1947eda74c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17838566

Change-Id: I82c0745814d889c48ad12dad59e9bd73bca91e1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 18:46:22 +00:00
Brian Isganitis 6e8f550b37 Merge "Log taskbar all apps entrypoint, launches, and drags" into tm-dev am: 6d780af405 am: e6588aa656
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17694348

Change-Id: Ic5c91ff514f2826ba4ddff354ed8e08d5a294b0b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 18:46:15 +00:00
Vadim Tryshev 6e9d62a42d Merge "Sampling too long Launcher tests" into tm-dev am: 70dffbe896 am: b653f3b436
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17838280

Change-Id: I9e59f0f4e211285bfd40a4c38c57e4c50afa2ab4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 18:46:07 +00:00
Brian Isganitis 1947eda74c Merge "Decrease overview degree threshold from 45 to 15 degrees." into tm-dev am: 7bd3e02e2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17838566

Change-Id: Ia074079ed9062818145c340dbc0695d41581dbcf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 17:44:27 +00:00