Commit Graph

3392 Commits

Author SHA1 Message Date
Tracy Zhou e9e5e51d73 [Live Tile] App surface is above launcher even after reaching Overview
Currently we place app surface below launcher and punch a hole through task view to display live tile in overview. In this change the order will be flipped, with a few benefits not limited to the following. For example, we have a surface view lifecycle bug where the surface view in a live tile app can go blank during app launch transition. This change will significantly mitigate the issue visually as the background wallpaper will not be revealed.

In order to make sure visually everything still looks the same, we will need to finish the recents animation when the user taps on the task view icon, since the menu overlaps with the task snapshort view.

This change also addresses fading out the task view when it's getting dismissed.

Test: manual
Fixes: 186531762
Fixes: 189265196

Change-Id: Ieae67fb89b60136fd81ceb8abde1a0cab8718b27
2021-06-30 17:34:13 +00:00
Vinit Nayak 0a740a074a Merge "Take margin insets into account when setting position" into sc-dev am: 0f3053ceae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15152173

Change-Id: Ib3639aeb91dabbb4283d21e3e6cb6da69af08d23
2021-06-30 17:34:03 +00:00
Vinit Nayak 0f3053ceae Merge "Take margin insets into account when setting position" into sc-dev 2021-06-30 17:29:44 +00:00
Yogisha Dixit 1e143f2c6b Merge "Log widget features to new features field." into sc-dev am: f91abaa6f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133002

Change-Id: Ib0e8d40b2b09d1b090f7968cce73fbafde5534c2
2021-06-30 17:28:34 +00:00
Yogisha Dixit f91abaa6f9 Merge "Log widget features to new features field." into sc-dev 2021-06-30 17:25:46 +00:00
Cyrus Boadway f5f23ba119 Merge "Defer onColorsChanged updates during widget-to-home animation" into sc-dev am: 1edaed8790
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147896

Change-Id: I93c3c42dc173182c7625dea719bbc540a544234a
2021-06-30 17:24:57 +00:00
Cyrus Boadway 1edaed8790 Merge "Defer onColorsChanged updates during widget-to-home animation" into sc-dev 2021-06-30 17:14:57 +00:00
Tony Wickham 597943985f Merge "Fully null check mRecentsAnimationController" into sc-dev am: d61f224570
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147296

Change-Id: I88d51d664b00ec21145281782612045fc6297663
2021-06-30 14:54:49 +00:00
Tony Wickham d61f224570 Merge "Fully null check mRecentsAnimationController" into sc-dev 2021-06-30 14:35:03 +00:00
Yogisha Dixit 4c3259a0eb Log widget features to new features field.
Bug: 185778648, 187734511
Test: manual
Change-Id: Ifa5d88602e4fccce153b207b2d57d10d13f33dc9
2021-06-30 14:14:55 +00:00
Cyrus Boadway 0d96baec13 Defer onColorsChanged updates during widget-to-home animation
Color change updates recreate the view, which can interfere with the
widget-to-home return animation, specifically the GhostView's use of the
AppWidgetHostView's render node.

Deferring the application of color changes until the end of the
animation allows the widget to settle and remove the GhostView before a
color change might recreate the widget's view.

Bug: 190818220
Test: manual
Change-Id: I6552e583ebb0e4810077d4e70fe9ecb07fd5d01a
2021-06-30 13:10:02 +00:00
Alex Chau f35a887446 Merge "Snap to relative position to snappd task when dismissing" into sc-v2-dev 2021-06-30 10:24:11 +00:00
Vinit Nayak 4ce773962e Take margin insets into account when setting position
Previously we computed insets for task menu position
whenever a Task was told that orientation had changed.
This missed a path for the TaskMenuView's onScrollChanged()
listener, which also calls set position and wasn't taking
the insets into account.

Moved the inset into setPosition() directly so it's caught
on all code paths.

Also noticed 2 bugs where
* We were calling updateChildTaskOrientation() twice, it
already happens in the call to updateOrientationHandler()
* We were directly modifying insets from the activity's
drag layer instead of copying those insets to another rect
and then modifying (this is no longer an issue since we
are not touching those insets at all anymore)

Bug: 192400086
Test: Rotated w/ task menu open for fake and real
landscape. Nothing seems broken.
Note real landscape hides the menu whereas fake one
shows it (which was behavior before this change)

Change-Id: I613dac9519220f49285655ef11a1f72e4a6d31bd
2021-06-30 06:23:38 +00:00
Sunny Goyal ae7ef2d5c1 Merge "AllSet page fixes" into sc-dev am: 50f43df36e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147340

Change-Id: I7a000e357abf704bceea0bedca3407439ca50206
2021-06-30 04:42:29 +00:00
Sunny Goyal 50f43df36e Merge "AllSet page fixes" into sc-dev 2021-06-30 04:31:34 +00:00
Lucas Dupin 3fb19d41b6 Merge "Decouple zooms and blurs on app launch" into sc-dev am: c2ef0363af
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15145970

Change-Id: Idadf9a85d4de92e584a524ff48856cca5c81d664
2021-06-30 00:25:43 +00:00
Tony Wickham 8ae56bd4e3 Fully null check mRecentsAnimationController
It's already null checked everywhere else it's used.

Test: none
Fixes: 187354606
Change-Id: I50913c38b2653fe292d84fabe111ff3a3e10736d
2021-06-29 17:18:33 -07:00
Sunny Goyal ce50b9ed83 AllSet page fixes
> Updating background color
> Updating activity theme to not be transparent
> Updating default accent color
> Adding an accessible target to exit

Bug: 190447132
Bug: 190136972
Bug: 190454597
Test: Manual
Change-Id: Ia8ef67ed429c062a8d1109d7f444343ec4ca09cf
2021-06-29 16:32:37 -07:00
Lucas Dupin 0f00c35268 Decouple zooms and blurs on app launch
We'd like to be able to disable blurs during app launch, but without
disabling zooms as well. The previous sysprop would set the depth of
BackgroundAppState to 0, when what we want is to conserve wallpaper
zoom.

Bug: 191969790
Test: adb shell setprop ro.launcher.blur.appLaunch false
Change-Id: Ie4b26096f6ac723c3981bba2829557e6cc6c733b
2021-06-29 13:02:12 -07:00
Alex Chau ba61b98fca Snap to relative position to snappd task when dismissing
- Calculate the diff to snapped page scroll and apply in onLayout, so tasks won't jump after dismiss when not in snapped position
- In grid, always keep the relateive snapped page unchanged to avoid jump

Bug: 188793333
Test: manual
Change-Id: Id11c2d700dc55440de39cc7409d06a712cedc9bc
2021-06-29 19:54:21 +01:00
Lucas Dupin 820b0987bd Merge "Reset DEPTH at the end of launch animations" into sc-dev am: 789f01af7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15130116

Change-Id: I5d4b3c70bf2201831ed25405083eaf6de1bdf92f
2021-06-28 22:28:34 +00:00
Lucas Dupin 789f01af7e Merge "Reset DEPTH at the end of launch animations" into sc-dev 2021-06-28 22:15:21 +00:00
Lucas Dupin 9d8580bd2a Reset DEPTH at the end of launch animations
This way the wallpaper won't be zoomed out if an app crashes.

Test: adb am crash <some test app>
Fixes: 191979512
Change-Id: I7576798f736d63c3e46bbac1b983b9d1a437647d
2021-06-28 11:45:14 -07:00
Alex Chau ed4db64369 Merge "Hide overview on fold/unfold when live tile is active." into sc-v2-dev 2021-06-28 10:38:15 +00:00
Tracy Zhou 10966ba3de Merge "Wallpaper and non-app targets are not necessary" into sc-dev am: 540723bd05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15085898

Change-Id: Iea021cdcc976f3ebf1b9160b833ba0bd3e4e8b5d
2021-06-26 15:10:09 +00:00
Vadim Tryshev e3f02c4de6 Merge "Postponing CUJ start by 1 frame" into sc-dev am: e70e6a3b0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15096971

Change-Id: Iaedc20bb98781ad97b8f72e064cb47e77e7f2975
2021-06-26 15:10:04 +00:00
Tracy Zhou 540723bd05 Merge "Wallpaper and non-app targets are not necessary" into sc-dev 2021-06-25 19:11:57 +00:00
Vadim Tryshev e70e6a3b0b Merge "Postponing CUJ start by 1 frame" into sc-dev 2021-06-25 17:56:34 +00:00
Tracy Zhou 936f06e02c Wallpaper and non-app targets are not necessary
Fixes: 191773356
Test: Swipe up to overview, launch another app, and make sure it works
Change-Id: I3f71d90687e18f38ddb17876bf7c56861bc61932
2021-06-25 10:17:50 -07:00
Winson Chung 95e819d572 Merge "Tweak live tile rotation handling" into sc-dev am: 694734f133
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023837

Change-Id: Iae13638ac9a4a5275f6bcba51da24ee550d1a424
2021-06-25 16:21:53 +00:00
TreeHugger Robot 81b70eaed2 Merge "Update gesture navigation intent tutorial steps handling" into sc-dev am: c20f6b52ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15082876

Change-Id: Ic171072979dd5865f63cd46d2221dba27bf51243
2021-06-25 16:21:01 +00:00
TreeHugger Robot 6a00bf853b Merge "Revert "Fix some touch issues during gesture nav transition"" into sc-dev am: c48d40475b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15092224

Change-Id: I5b2bb3dcb078d77bccaa1c328be81f5bfae7b565
2021-06-25 16:19:25 +00:00
Winson Chung 694734f133 Merge "Tweak live tile rotation handling" into sc-dev 2021-06-24 23:30:07 +00:00
TreeHugger Robot c20f6b52ab Merge "Update gesture navigation intent tutorial steps handling" into sc-dev 2021-06-24 23:06:40 +00:00
TreeHugger Robot c48d40475b Merge "Revert "Fix some touch issues during gesture nav transition"" into sc-dev 2021-06-24 21:53:47 +00:00
Schneider Victor-tulias f0c2158a5f Update gesture navigation intent tutorial steps handling
Updated gesture navigation to use either a comma-separated string or a string array for defining tutorial steps.

Fixes: 184002732
Test: manual
Change-Id: Ib2f8f78ccd57100d978db799b785fd9dffe9fb7f
2021-06-24 14:05:44 -07:00
Winson Chung 46319004c1 Tweak live tile rotation handling
- With ag/15023409, the system will screenshot and cancel the recents
  animation based on the hint provided by launcher when there is a
  global config change. As such, we can remove extra handling of the
  configuration change on the launcher side, and handle the cancel
  with the provided snapshot.

  To handle the snapshot, we need to hook into the gesture state
  recents animation callbacks (which actually are of the lifecycle of
  the animation and not just the gesture).

Bug: 189843542
Test: With live-tile enabled, swipe up to overview and rotate
Change-Id: If74f3fc5d47c327f9f5cca8f1f5d23b48cd3c954
2021-06-24 12:35:53 -07:00
vadimt ca383ffdf5 Postponing CUJ start by 1 frame
for CUJ_APP_LAUNCH_FROM_ICON, CUJ_APP_CLOSE_TO_HOME,
CUJ_APP_LAUNCH_FROM_WIDGET and CUJ_APP_LAUNCH_FROM_RECENTS

Test: Local perfetto run
Bug: 190858586
Change-Id: I7a26d91c44a0a4c767bde3230d39a096a26d7b75
2021-06-24 11:44:57 -07:00
Zak Cohen 95d23f9a4d Revert "Fix some touch issues during gesture nav transition"
This reverts commit 1351c2214d.

Reason for revert: Suspect causing test failures: https://b.corp.google.com/issues/191946109

Change-Id: Ib1b5545b3a612e89923ea06a890e4a07be9fa857
2021-06-24 18:11:36 +00:00
Pat Manning 99191fdf3f Hide overview on fold/unfold when live tile is active.
Test: manual
Fix: 184846394
Change-Id: I97ae328234bf0932712c7cf3ca97813cae7c46a7
2021-06-24 16:18:03 +00:00
Tony Wickham 9f7eae758f Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 8db306f3c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15081302

Change-Id: I95ef73ae3b9352e70d16ff3a97ae74abf0b69656
2021-06-24 01:18:10 +00:00
TreeHugger Robot bd80a07da1 Merge "Ensure InputConsumer is non-null in remaining cases" into sc-dev am: 862224f913
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15084524

Change-Id: If699c0ba7e4ef2e1bcb8026de6a16ed5fc599c6d
2021-06-24 01:18:03 +00:00
Tony Wickham 8db306f3c5 Merge "Fix some touch issues during gesture nav transition" into sc-dev 2021-06-24 01:08:43 +00:00
TreeHugger Robot 862224f913 Merge "Ensure InputConsumer is non-null in remaining cases" into sc-dev 2021-06-24 01:04:18 +00:00
Tony Wickham f64f9a14d8 Ensure InputConsumer is non-null in remaining cases
Anywhere that was using mResetGestureInputConsumer now uses getDefaultInputConsumer, which returns NO_OP if mResetGestureInputConsumer is null.

Test: none
Bug: 191684742
Change-Id: I1ae02b01a9629fa0830955dfe4d83c95a4759c14
2021-06-23 16:39:44 -07:00
Hilary Huo cb4475f7d8 Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev am: 08843d8e37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15068624

Change-Id: I58da46b9fc9fd83205c352996c78453885666397
2021-06-23 22:29:13 +00:00
Hilary Huo 08843d8e37 Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev 2021-06-23 22:18:00 +00:00
Tony Wickham 1351c2214d Fix some touch issues during gesture nav transition
- Don't recreate the laucher transition controller if we've already ended it, as it could clobber a touch interaction that started in the meantime
  - Test: swipe up from an app to overivew, swipe to dismiss it during the transition.
  - Previously, we were ending the controller twice (once on touch down as we started proxying, and again in setupLauncherUiAfterSwipeUpToRecentsAnimation()), and the second one could happen after starting the dismiss interaction.
- Don't recreateControllers() if orientation didn't change
  - Test: swipe up to go from an app to home, swipe up to all apps during the transition.
  - Previously, we were getting the following sequence:
    1. Touch down on home to start swiping to all apps - all current controllers get this down event to start determining whether to intercept
    2. Before reaching touch slop, we recreateControllers(), so all new controllers won't get the down event and thus won't intercept
  - Now, we avoid unnecessarily recreateControllers(), so the original controllers can still intercept.

Test: see above
Fixes: 189700453
Change-Id: Icfa5b6cdb32122adaf6ac8e8cb197b0c477dac60
2021-06-23 13:07:18 -07:00
Tracy Zhou 2f8342d791 Merge "Finish recents animation on task dismissal only if the task is a live tile task" into sc-dev 2021-06-23 19:40:15 +00:00
Lucas Dupin 8ee65b1d75 Merge "Disable blurs when dev setting or battery saver" into sc-dev am: 697e51cd8c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15069844

Change-Id: Ia7bcf27ad8aba1a9115481f5ba4f9d77bf56d3a8
2021-06-23 19:00:14 +00:00