Commit Graph

13675 Commits

Author SHA1 Message Date
Kholoud Mohamed e98a6d2fc8 Merge "Fix newAPI lint error" 2022-03-31 21:11:34 +00:00
TreeHugger Robot 697a168260 Merge "Add metrics for taskbar 3 button nav" 2022-03-31 19:19:24 +00:00
Jon Miranda 19a1fc932f Merge "Avoid closing PopUpContainer immediately after view is clicked." into tm-dev am: 39055bebc9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17477449

Change-Id: I724a4061df211b583dc18b90a93c5f441ba931f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-31 17:33:04 +00:00
Sebastián Franco 07d9073f3d Merge "Fix widget drop animation in 4x5 grid" into tm-dev am: 89804c42d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17491543

Change-Id: I50811d73b895dcf1dbd9835ae327a79a4d404602
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-31 17:31:23 +00:00
Jon Miranda 39055bebc9 Merge "Avoid closing PopUpContainer immediately after view is clicked." into tm-dev 2022-03-31 17:08:33 +00:00
Sebastián Franco 89804c42d4 Merge "Fix widget drop animation in 4x5 grid" into tm-dev 2022-03-31 17:05:16 +00:00
kholoud mohamed 71398ca1c0 Fix newAPI lint error
Fixes: 225612636
Test: m -j out/soong/.intermediates/packages/apps/Launcher3/Launcher3/android_common/lint/lint-report.txt
Change-Id: Ib7f7df0010702b0f26d99bbd7b27ee38a6ed5e17
(cherry picked from commit af6641414c)
Merged-In: Ib7f7df0010702b0f26d99bbd7b27ee38a6ed5e17
2022-03-31 15:00:22 +00:00
Alex Chau eb2f9d1d6c Merge "Using the WindowMetrics API instead of display.getRealSize" into tm-dev am: 5f8386cf26
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17326029

Change-Id: I573733c080c1e30ad1fc71641cf72f81079eba39
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-31 11:11:04 +00:00
Alex Chau 5f8386cf26 Merge "Using the WindowMetrics API instead of display.getRealSize" into tm-dev 2022-03-31 10:58:40 +00:00
Thales Lima be6eb48f49 Merge "Make inline qsb part of grid attrs" into tm-dev am: c1ea50a43d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17399991

Change-Id: Iae76139962f1d97f229d0f06de288f419e9afe1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-31 08:51:24 +00:00
Thales Lima c1ea50a43d Merge "Make inline qsb part of grid attrs" into tm-dev 2022-03-31 08:30:10 +00:00
Vinit Nayak cb2ebaf6a8 Merge "Fix translation for secondary split thumbnail in RTL" into tm-dev am: 254c77e279
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17489781

Change-Id: I64857ab83e08d079776208a3f820069b8d48253e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-31 04:25:13 +00:00
Jerry Chang df52cac56d Merge "Fix wrong split percentage after split layout been pushed up" into tm-dev am: 8eba01dca3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17505943

Change-Id: I2705c5a4bfaf205213dc49131e163c5c0e31edda
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-31 04:24:49 +00:00
Vinit Nayak 254c77e279 Merge "Fix translation for secondary split thumbnail in RTL" into tm-dev 2022-03-31 04:19:42 +00:00
Jerry Chang 8eba01dca3 Merge "Fix wrong split percentage after split layout been pushed up" into tm-dev 2022-03-31 04:07:15 +00:00
Vinit Nayak ddbf5374aa Add metrics for taskbar 3 button nav
Fixes: 221075063
Test: wwlogcat shows right events,
new events show up on aster dashboard

Change-Id: I3864ac02ea00f281d33ccb26b95a4916bd8b6be9
2022-03-31 01:38:39 +00:00
Sebastian Franco b6b4069aa4 Fix widget drop animation in 4x5 grid
For the 4x5 grid we add insets to the widget and the
 animation wasn't accounting for it.

I'm using this shell function to quickly change the
animation speed

```
function anim-speed() {
	adb shell settings put global window_animation_scale $1
	adb shell settings put global transition_animation_scale $1
	adb shell settings put global animator_duration_scale $1
}
```

anim-speed 1 # for regular speed
anim-speed 10 # for really slow speed

Fix: 194227752
Test: Put down a widget in 4x5 and the animation should match,
sometimes is to fast but you can slow the animations with adb and see
the difference

Change-Id: I182729de39c0d0b12231d07e337dddca6fccf5c0
2022-03-30 21:18:18 +00:00
Sunny Goyal 36c0f76e21 Using the WindowMetrics API instead of display.getRealSize
Bug: 221961069
Bug: 195408476
Bug: 198965093
Test: Verified locally and presubmit
Change-Id: I4dac9c19df4c43e6a38ba5c05f27d25f4cfcb071
2022-03-30 21:07:23 +00:00
Thales Lima 12d0eff037 Make inline qsb part of grid attrs
This should make it more configurable, and be independent of the screen size set by the user.

Fix: 223726518
Test: atest Launcher3Tests:HotseatSizeTest
Test: atest Launcher3Tests:InlineQsbTest
Change-Id: If04f3fb0f556103f60b580c757a9fc06da561516
2022-03-30 20:57:57 +01:00
Vinit Nayak 1322fc3710 Fix translation for secondary split thumbnail in RTL
Fix: 225157531
Test: Swipe up in RTL shows both thumbnails
were expected.

Change-Id: I87d286b6ce6542c7cffadf86e3d4d99a3618f984
2022-03-30 10:32:51 -07:00
András Klöczl 2a1a9043de Merge "Separate workspace item finding logic" into tm-dev am: aa35c39167
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16968685

Change-Id: I04b5a69808a06941726e1ea703538c91fd0cc713
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-30 17:01:39 +00:00
Thales Lima ad8365a86b Merge "Add border space to all apps cells" into tm-dev am: ececa893b7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17399999

Change-Id: I4e26c736241e10654e711aeabe2c2265461bba09
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-30 17:01:23 +00:00
András Klöczl aa35c39167 Merge "Separate workspace item finding logic" into tm-dev 2022-03-30 16:43:32 +00:00
Thales Lima ececa893b7 Merge "Add border space to all apps cells" into tm-dev 2022-03-30 16:42:46 +00:00
Jerry Chang f5d90b9ec2 Fix wrong split percentage after split layout been pushed up
The task thumbnails of splitting task might not start with (0, 0), like
the case when IME panel pushing up split layout. Updated to consider
different start position while calculating split percentage.

Fix: 218704243
Test: enter split in portrait, toggle on IME panel, observed task
      thumbnails been placed properly after swiped up to overview.
Change-Id: I5b0d9710b56e9d77b86369c7fff4bc3ca75d9c7e
2022-03-30 14:03:55 +00:00
Luca Zuccarini 9fbdd87ad3 Merge "Refactor the floating header's positioning." into tm-dev am: 4e813d37c0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17252654

Change-Id: I42e50839becf295b9f05a2368e68e641eee94e12
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-30 13:29:23 +00:00
Luca Zuccarini 4e813d37c0 Merge "Refactor the floating header's positioning." into tm-dev 2022-03-30 13:03:48 +00:00
Thales Lima 080d890383 Add border space to all apps cells
Also remove tablet condition, phones should also follow the workspace size.

Fix: 218638090
Test: visual and HSV
Change-Id: Ib201011391c28c0f1dcd0ce8645c3191655a7227
2022-03-30 11:56:27 +01:00
Jon Miranda 10b5d68045 Avoid closing PopUpContainer immediately after view is clicked.
When an item is clicked, we start an app launch animation
from the icon in the container to the full app. The issue is that
we close the container too early, which causes a janky experience.

Tested that we already handle closing the container in all click
instances (ie. when launcher is in background).

Bug: 185510490
Test: click on all the different view types within PopupContainer
      ensure that the container does get closed via logs

Change-Id: I4fef24b911137d0abd24746fa49f466f5183176c
2022-03-29 11:12:48 -07:00
Tony Wickham 2abae73d7e Merge "Fix problems with taskbar floating views on rotation" into tm-dev am: b2aa48cad6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17454588

Change-Id: I7e13f8465af418d799a37d21626bad731150e213
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-29 16:47:42 +00:00
Stefan Andonian 3f2b1aed7c Update monochrome theme icon notification dot color am: 1d57706125
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17228731

Change-Id: I79893016c6ed2f41a41db205f93ed05045acd362
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-29 16:46:54 +00:00
Tony Wickham b2aa48cad6 Merge "Fix problems with taskbar floating views on rotation" into tm-dev 2022-03-29 16:36:16 +00:00
Stefan Andonian 1d57706125 Update monochrome theme icon notification dot color
Bug: 189498337
Test: Hard-coded the notification dots to be visible, and verified they were the correct color.
Screenshot: https://screenshot.googleplex.com/AVbbW6P2bm6jYNS
Change-Id: I38a78cda056273eb300d458e663f79ccdd28f36a
2022-03-29 16:21:32 +00:00
Andras Kloczl 68e1af2bc2 Separate workspace item finding logic
Extract the item finding logic from AddWorkspaceItemsTask
to a separate class and write tests.

Test: AddWorkspaceItemsTaskTest.kt , WorkspaceItemSpaceFinderTest.kt
Bug: 199160559
Change-Id: Ie1bc4fcd4f94cd7cb0601c21bbdf273452b9dd1f
2022-03-29 13:31:31 +01:00
Kholoud Mohamed 964bc9a0c7 Merge "RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3" 2022-03-29 11:01:19 +00:00
Luca Zuccarini 0c3961c367 Refactor the floating header's positioning.
Maintains the existing behavior while simplifying the overall layout.

See go/all-apps-qsb-positioning for details.

Bug: 221418522
Test: manual
Change-Id: I25a737cdfa431e8eb3a00b639984caed70819252
2022-03-29 10:18:33 +00:00
Sebastián Franco 9d5eef80cd Merge "Brighten theme-icons when in Dark mode and add dark color for taskbar" into tm-dev 2022-03-29 00:00:33 +00:00
Sebastián Franco 50d5e9a145 Merge changes from topic "cherrypick-217247494-b0lshr6mfa"
* changes:
  [automerge] Brighten theme-icons when in Dark mode and add dark color for taskbar 2p: 5282efddc9 2p: e3a8e17984
  [automerge] Brighten theme-icons when in Dark mode and add dark color for taskbar 2p: 5282efddc9
  Brighten theme-icons when in Dark mode and add dark color for taskbar
2022-03-29 00:00:33 +00:00
Tony Wickham 538c9a0b52 Fix problems with taskbar floating views on rotation
- Close all views except TYPE_REBIND_SAFE
- Make All Apps TYPE_REBIND_SAFE again
- Reapply fullscreen to ensure any remaining floating views such as taskbr edu are laid out correctly upon rotation

Test: Rotating with folder and/or popup closes them; rotating with all apps stays open; rotating with all apps + popup closes popup but not all apps; rotating taskbar edu lays out correctly; opening shortcut or notification from all apps popup still closes all apps
Fixes: 220074790
Fixes: 219981733
Change-Id: I1dfea4ed0a636ab84bcc4e33304c80a689da01cd
2022-03-28 14:48:20 -07:00
Jeremy Sim db92b5d73f Merge "Fix issue with camera overlapping split staging UI" into tm-dev 2022-03-26 19:41:48 +00:00
Presubmit Automerger Backend 82a04f427b [automerge] Fix issue with camera overlapping split staging UI 2p: b8eeb41ee0 2p: 8846338a7c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17311863

Change-Id: I4dcb66f8b2f8b1e138623007fdf702144afc3c8c
2022-03-26 00:39:44 +00:00
Presubmit Automerger Backend 8846338a7c [automerge] Fix issue with camera overlapping split staging UI 2p: b8eeb41ee0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17311863

Change-Id: Ib54908a8a30c03e7e4b1b81dc6f3ad315d4dbb75
2022-03-26 00:39:32 +00:00
Jeremy Sim b8eeb41ee0 Fix issue with camera overlapping split staging UI
Fixes an issue on some devices where initiating a split in Overview would cause an icon to be placed partly under the camera cutout.

Fixed by adding some padding to FloatingTaskView#mSplitPlaceHolderView, so that it always respects the device's insets.

Fixes: 220997064
Test: Manual
Change-Id: I7270bde3320f562519ea8e36a38e49609e0d6cd7
2022-03-25 16:31:46 -07:00
kholoud mohamed 8d7cfd1d36 RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3
Bug: 217388602
Bug: 218875965
Test: atest EnterpriseResourcesTests
Test: manual
Change-Id: I095a1da30766e4b4eab33f42b034601b3322eb3d
(cherry picked from commit e210b47c20)
Merged-In: I095a1da30766e4b4eab33f42b034601b3322eb3d
2022-03-25 14:40:15 +00:00
Abhilasha Chahal 6f1862f494 Merge "Use numAllAppsColumns to calculate height of all apps icons" into tm-dev am: a35179d4ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17183243

Change-Id: I332a8ceca7eb060487b140eee8f33f135e221c0a
2022-03-24 11:20:52 +00:00
Abhilasha Chahal a35179d4ea Merge "Use numAllAppsColumns to calculate height of all apps icons" into tm-dev 2022-03-24 11:02:31 +00:00
TreeHugger Robot b8e0d2c052 Merge "Aligning Hotseat and Workspace icons in vertical bar mode" into tm-dev 2022-03-24 09:23:50 +00:00
Abhilasha Chahal dfd154f18d Use numAllAppsColumns to calculate height of all apps icons
Additionally opens up access of some fields to allow them to be overridden.

Test: Manually verified that Launcher3 layout does not change

Launcher3 APKs: https://drive.google.com/drive/folders/1hBcZU9xou4tZJxbTmkya_LyBbD2oYuwV?resourcekey=0-R0I1IQ2rSUIEfPjW8S_ppA&usp=sharing

Bug: 216150572

Change-Id: I4b97a7e9e15973fc5aa70a4b98f0b73dd5bf3c17
2022-03-23 21:09:54 +00:00
Sihua Ma 00663101b6 [automerge] Aligning Hotseat and Workspace icons in vertical bar mode 2p: 38bb3b0c5c 2p: 677d9c5aac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17314347

Change-Id: I0b978d16596e72ea3b7e9ffe988cd6a251bed9c7
2022-03-23 18:27:56 +00:00
Sihua Ma 677d9c5aac [automerge] Aligning Hotseat and Workspace icons in vertical bar mode 2p: 38bb3b0c5c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17314347

Change-Id: I90c98cbbcdfeb455785bb0dd3d364b62a2284e72
2022-03-23 18:27:50 +00:00