Commit Graph

4820 Commits

Author SHA1 Message Date
Alex Chau 179c289a6c Merge "Center drop target button alignment across devices" into tm-dev 2022-05-25 12:38:11 +00:00
Stefan Andonian af8b7d3313 Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev 2022-05-24 18:19:03 +00:00
Alex Chau 5b0193026a Center drop target button alignment across devices
- Partial re-land of http://ag/18520765

Fix: 229789612
Fix: 231711806
Test: manual
Change-Id: I0630c19901435a30379596378e9c0cd4beb2e764
2022-05-24 18:31:57 +01:00
TreeHugger Robot 6112a28b0b Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-05-24 00:38:21 +00:00
Stefan Andonian 28f61b5177 Fix folder app icon truncation after rotating to landscape.
The folder bubble text views were being recycled after the launcher's
cache was cleared. This caused the new orientation's folders to re-use
the old views with their stale configuration. After this change, the
cache won't recycle views whose cache entry has been recreated,
implying that their environment might have changed and new setup is
required.

Bug: 230304658
Test: Verified erroneous UX on device was no longer reproducible after fix.
Change-Id: Ib01cf5792d83df752e05534e5aa08ab8e8763bdc
2022-05-23 23:42:04 +00:00
Alex Chau 618047355d Merge "Update drop target button alignment across devices" into tm-dev 2022-05-23 18:49:55 +00:00
Brandon Dayauon 3e4d9c79d5 Merge "Label is no longer Unlabeled. Now says "closed"" into tm-dev 2022-05-23 18:21:26 +00:00
Alex Chau 906d882f91 Update drop target button alignment across devices
- Partial re-land of http://ag/18520765
- Layout the buttons from center of screen for two panels, or from center of workspace for all other cases

Bug: 229789612
Fix: 231706480
Fix: 232063941
Fix: 232283628
Test: manual
Change-Id: Icbc9e2a19140ce3127d5dfe9f798a8ada336cea8
2022-05-23 15:08:52 +00:00
Pat Manning b29dabce18 Revert "Update drop target button alignment across devices."
This reverts commit 27bfcaa651.

Reason for revert: b/232636570

Bug: 229789612
Bug: 231711806
Bug: 231706480
Bug: 232063941
Bug: 232283628
Change-Id: Ic83515173f4a64228a80f63d75db938243cbf625
2022-05-20 18:20:26 +00:00
Bill Yi 3c8c47778f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I32a0e75c040f0938a9addfe3f13d21eb576dd77e
2022-05-20 05:08:53 -07:00
Brandon Dayauon dee5fc561f Label is no longer Unlabeled. Now says "closed"
Bug: 230624621
Test: Manual
Change-Id: I1fbdffdcaf36aaebff89bb5f4a608d5c2dc94502
2022-05-18 15:39:35 -07:00
Bill Yi 27e7b1ca41 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iee29f1c8bc34c269aa8f8d0c6283286ba8dd188d
2022-05-17 00:28:51 -07:00
Brandon Dayauon 303b4e8aae Fix issue when preference screen title won't change depending on the device..
previously it defaults to just "Search your phone"
Now it correctly displays Phone/Tablet

Before: https://screenshot.googleplex.com/3PJrsP9mGvwMr98
After: https://screenshot.googleplex.com/B2nnUQHeHmEXXPd

Bug: 231611501
Change-Id: I49eab7e827ce4bb31a2722fbf21c244f98145907
2022-05-16 10:25:12 -07:00
Hyunyoung Song 8536fb78c7 Merge "App row padding is now consistent for all grid sizes. Also fix when 2x2 allApp icons get super big." into tm-dev 2022-05-15 06:08:18 +00:00
Brandon Dayauon 07ca884eea App row padding is now consistent for all grid sizes. Also fix when 2x2 allApp icons get super big.
Added consistent padding to each app row.

Bug: 229789736
Bug: 229791507
Bug: 228320417
Bug: 230870213
Test: Manual on Raven

Change-Id: Ice1c8be361f009994a8e0960a30da04fc1c0c218
2022-05-13 17:10:15 -07:00
Alex Chau 8a7617f168 Merge "Fix slow page animations on large devices" into tm-dev 2022-05-12 19:08:41 +00:00
Pat Manning 8909fc2dcb Merge "Update drop target button alignment across devices." into tm-dev 2022-05-12 18:41:54 +00:00
TreeHugger Robot 566c676dda Merge "Add Developer Options string to xml." into tm-dev 2022-05-12 14:49:49 +00:00
Pat Manning 27bfcaa651 Update drop target button alignment across devices.
Fix: 229789612
Fix: 231711806
Fix: 231706480
Fix: 232063941
Fix: 232283628
Test: manual.
Change-Id: I75d649b953ad1607dbba87a8f758884ff938b6dc
2022-05-12 13:49:58 +00:00
Andras Kloczl c2bd15fd2a Fix slow page animations on large devices
- Change non-fling page snap animation duration
- Change fling gesture related minVelocity

Test: Scroll between home pages, allapps, folder pages
Bug: 229073876
Change-Id: Ib39187ec9c832e65dd0b71f8f4a00e1b636423a4
Merge "Hide web settings, if web suggestions is disabled" into tm-dev

Change-Id: Ib39187ec9c832e65dd0b71f8f4a00e1b636423a4
2022-05-12 12:56:41 +01:00
Thales Lima 425f6828f1 Fix hotseat width to span a number of columns
Fix: 227344807
Fix: 231283023
Test: manual
Change-Id: Iad0f38c2323be6d9752a8e509fc7e1164edbcf4e
2022-05-11 10:09:03 -03:00
Luca Zuccarini e75b1c8a19 Merge "Update the NORMAL->ALL_APPS transition when tapping on QSB on phones." into tm-dev 2022-05-10 22:35:02 +00:00
James O'Leary 7ba0339b00 Merge "Use T50 base instead of T95" into tm-dev 2022-05-10 19:52:47 +00:00
Sunny Goyal 8ca6e815bd Merge "Fixing wrong alpha for disbled icon" into tm-dev 2022-05-10 15:51:59 +00:00
Sunny Goyal b0416cc478 Merge changes from topic "revert-17983445-hotseat_span-WQWWPUHOTD" into tm-dev
* changes:
  Revert "Fix hotseat width to span a number of columns"
  Revert "Update workspace, cell layout, shortcut and widget, and cell size calculations."
2022-05-09 23:14:38 +00:00
Sunny Goyal d333091d79 Fixing wrong alpha for disbled icon
Bug: 230852221
Test: Verified manually
Change-Id: I73fb1ac73ff374cd67b3f26367814ea5b0b49a3b
2022-05-09 16:12:06 -07:00
Sunny Goyal 89a89d63a4 Revert "Fix hotseat width to span a number of columns"
Revert submission 17983445-hotseat_span

Reason for revert: b/231283023
Reverted Changes:
Ice4e37929:Fix hotseat width to span a number of columns
I9ed508490:Fix hotseat width to span a number of columns

Change-Id: Iabf67c5efd8155131a0c8a88192ddd671a43747b
2022-05-09 19:32:07 +00:00
James O'Leary efff096bdd Use T50 base instead of T95
Colors with custom tones were using T95 as the base color, which has
very low chroma for most hues. By using T50, chroma is retained as
intended by design.

Bug: 213314628
Test: Manual inspection at runtime
Change-Id: I8ac519ea5e65abbb34b5ea2f64268474e0e2df66
2022-05-09 14:40:53 +00:00
Sunny Goyal f27d6c0dc7 Merge "Preventing widget preview from getting accessibility focus on internal content" into tm-dev 2022-05-06 22:15:04 +00:00
Brandon Dayauon 5a726787db Merge "changed name and dimensions of work_mode_toggle button, changed outline to surface for the (x) icon.." into tm-dev 2022-05-06 21:00:08 +00:00
Sunny Goyal d4cb76ebf0 Preventing widget preview from getting accessibility focus on internal content
Bug: 209579561
Bug: 209579521
Bug: 209579162
Test: Manual
Change-Id: If65a74acf021b19438cdc37b07ac508985f8909a
2022-05-06 11:10:41 -07:00
Brandon Dayauon e5142c5c53 changed name and dimensions of work_mode_toggle button, changed outline to surface for the (x) icon..
Fixed padding issue (tightness) between Personal/WorkTabs/EduDialog
Aligned Work Toggle button to be the same with the workTabs/eduCard
raised button up 20dp to align with specs

Fixed issue where allApps apps invade the tabs. Fixed RTL issues where it wasn't going RTL.
Fixed RTL issue for the workfab button where there was no margin on the left side of the button
Added DeviceProfile to constructor

Bug: 200810328
Bug: 224731300
Test:
	Before: https://screenshot.googleplex.com/6sRgNZQz4wKYn5n
	After: https://screenshot.googleplex.com/8hBLyDiMbMH9tn2
	After(showingLayoutBounds): https://screenshot.googleplex.com/MuVUXCegukAMzSr

Change-Id: Ibac3f5b8fe7d877c2f54a2c87f4393c1a91dc806
2022-05-06 09:52:05 -07:00
Luca Zuccarini ef006c7603 Update the NORMAL->ALL_APPS transition when tapping on QSB on phones.
- New interpolators
- New duration
- Removed workspace translation
- Removed overlapping fades -- are now sequential

See video in the bug.

Bug: 227745955
Test: manual
Change-Id: I19fa19a3806e963a04c5e694a52d3c1b921cf51f
2022-05-06 16:07:17 +00:00
TreeHugger Robot 8a341bda84 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-05-03 20:48:34 +00:00
Bill Yi 976cab3e09 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I22bbc4eda27d606c89e9a8881b14be240d7c3a71
2022-04-30 02:17:08 +00:00
Thales Lima 828875cd12 Fix hotseat width to span a number of columns
Bug: 227344807
Test: manual
Change-Id: Ice4e37929bcbb8c9cf3af340e67b6bec002578bd
2022-04-29 14:56:30 +00:00
Thales Lima d7a9408696 Merge "Increase empty space limits" into tm-dev 2022-04-28 09:41:56 +00:00
Anushree Ganjam fa693be19f Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev 2022-04-28 04:52:01 +00:00
Anushree Ganjam 5cc7ff0990 Revert "Refactors Search results into separate RV for Toast."
This reverts commit 6729f0b950.

Reason for revert: This change caused b/230648542.

Please see https://b.corp.google.com/issues/230648542#comment5 for the video after reverting this change.

Bug: 206905515
Bug: 230648542

Change-Id: I85f063c56cad137c05b810204244bba7e8f94ee7
2022-04-28 01:37:49 +00:00
Alex Chau a80efcee9f Merge "Update overview actions alignment" into tm-dev 2022-04-27 12:24:24 +00:00
TreeHugger Robot 0a6e9b4751 Merge "Refactors Search results into separate RV for Toast." into tm-dev 2022-04-26 15:06:49 +00:00
Pablo Gamito 7379074007 Merge "Use shared background color animation for settings activity" into tm-dev 2022-04-25 21:22:21 +00:00
Alex Chau a2fc764405 Update overview actions alignment
- Align overview actions to the top with a defined margin below task thumbnail, except for vertical bar layout
- In modal state, use task view's bottom as pivot, and expand using all the space about pivot
- Simplified overview actions margin calculation and moved some logic to DeviceProfile

Bug: 209981696
Test: manual on various devices
Change-Id: I4c96cb02c6f3d6adf30633ddeb883bc4eec16f36
2022-04-25 19:20:21 +01:00
Thales Lima 25ac8b804f Increase empty space limits
Bug: 227344807
Test: manual
Change-Id: Id5d484d57da60f3cf90db9bf0571919d93288de3
2022-04-25 18:49:33 +01:00
Andy Wickham 6729f0b950 Refactors Search results into separate RV for Toast.
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.

Some high level items of the refactor:
 - SearchRecyclerView is added; logic that populated the main
   (personal) tab with search results was simply redirected to
   this RV instead.
 - BaseAllAppsContainerView added isSearching() method. Returns
   false, and ActivityAllAppsContainerView overrides (as search
   is handled there).
 - Renamed BaseRecyclerView to FastScrollRecyclerView to better
   describe what it does. SearchRecyclerView extends this, but
   returns false for supportsFastScrolling().
 - AlphabeticalAppsList#mAllAppsStore is now optional, so the
   Search RV doesn't need to store/listen to apps. Note this
   doesn't affect the predicted app row which is still updated
   if one of the predicted apps is uninstalled (I tested this).

Future work:
 - Determine why dispatchRestoreInstanceState is not called for
   BaseAllAppsContainerView. Save is called, e.g. on rotation.
   Effect of restore not called: rotating while searching goes
   back to A-Z list.
 - Keep suggested apps in Header while searching. Currently they
   are rendered in the SearchRV above search results, as before.
 - Potentially extract Personal/Work tabs to move independently of
   header.
 - AlphabeticalAppsList is a misleading name because it can also
   contains search results. However, things are pretty intertwined
   between that and BaseAllAppsAdapter (effectively a circular
   dependency), so I figured cleaning all that up was out of the
   immediate scope of this refactor, which is mainly meant to
   unblock transition work.

Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
2022-04-24 17:36:48 -07:00
Pablo Gamito a9e9c667b4 Use shared background color animation for settings activity
Test: check that the launcher home settings activity transitions use the clear color activity animation with the correct background color

Bug: 229898866
Change-Id: Ic96ceb0fdbd6c4f10b411492dc5be18e979796c8
2022-04-22 11:39:53 +00:00
TreeHugger Robot 0bd7fbde6d Merge "Bring Widget Picker message style inline with All Apps message style." into tm-dev 2022-04-22 02:14:43 +00:00
Bill Yi db60e79024 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-04-22 00:17:18 +00:00
Zak Cohen 1dc4dea6ae Bring Widget Picker message style inline with All Apps message style.
Bug: 188227318
Test: Local flash with TestDPC to test message.
Change-Id: I63403f1472a582a63299e647604eaea25b50b8e7
2022-04-21 10:53:17 -07:00
Thales Lima 26aa8c2496 Making tablet grid scalable and tuning size
Bug: 227344807
Test: manual and HSV
Change-Id: I739cd814ecb8f693b4873cd78f2e8c182538be3b
2022-04-21 11:10:22 +00:00