Commit Graph

34209 Commits

Author SHA1 Message Date
TreeHugger Robot 6a01fe49a5 Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev 2021-07-22 18:53:32 +00:00
Sunny Goyal 12e3f1f2f7 Removing UI dependency from LauncherModel in case of 2-panel layout
Bug: 175939730
Bug: 192431856
Bug: 185515153
Test: Manual
Change-Id: I8baa1cf9e5a8a04d5b8bc38c1f4b0755265cd8a9
2021-07-22 10:34:25 -07:00
Jason Chang 12a0357c31 Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev am: 1b3f5d3883
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15311532

Change-Id: I6459733abb399137224fe9c24ac7cdc63282dd9e
2021-07-22 16:54:17 +00:00
TreeHugger Robot f3a387d731 Merge "resolve merge conflicts of 46378eb881 to sc-v2-dev" into sc-v2-dev 2021-07-22 16:49:35 +00:00
Alex Chau 41e77de54e Avoid seeing ClearAllButton for overview grid's snap position
- This is a follow-up of http://ag/15220572
- When determining if task's snap position is too close to ClearAllButton, avoid positions that will see part of ClearAllButton

Bug: 192254835
Test: manual
Change-Id: I09425075ff0c24835ac3c4e79856aef7985476b2
2021-07-22 16:14:15 +01:00
Steven Ng a606d344a6 Measure WidgetsFullSheet before estimating the recommended table
size

Issue: The header view height was obtained before any measurement.

Test: On Pixel 5 4x5 gird with Photo widget shown in recommended
      table, make the device in landscape. Then open the full widgets
      picker. The widgets picker can be scrolled. Before this fix,
      scrolling is not possible.
Fix: 194172597
Change-Id: Ib30cf4b95d2ed23ff28f3d24e103f0e919b3a551
2021-07-22 16:08:15 +01:00
TreeHugger Robot b971baefe1 Merge "Fix scaling on widget previews that have width / height set to wrap_content" into sc-v2-dev 2021-07-22 12:05:03 +00:00
TreeHugger Robot d32a472e5c Merge "Add null check for recents scaling during quick switch." into sc-v2-dev 2021-07-22 10:28:50 +00:00
Steven Ng 2b90d043f6 Fix scaling on widget previews that have width / height set to
wrap_content

If the widget preview has width / height set to wrap_content, we should
set the layout param width / height to the exact dimension after
measurement. Otherwise, we will end up clipping the previews.

Test: manual
Fix: 193144010
Change-Id: I101f7c6d3dbd264fee448b85c54029d5650d6630
2021-07-22 11:19:25 +01:00
Jason Chang 1b3f5d3883 Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev 2021-07-22 09:43:13 +00:00
Thales Lima 496ca0081e Merge "launcher: correct page spacing for multiple panels" into sc-v2-dev 2021-07-22 09:41:56 +00:00
Thales Lima e445774ab5 launcher: correct page spacing for multiple panels
This fixes 2 things:
- adding the correct space between pages as insets (eg camera) were
being discarded
- adding the space between pages instead of between panels as was before

This solution should work with more panels and don't create problems for
phones, where panels = 1.

Fixes 193194192
Test: manual testing in unfolded state in portrait and landscape, both
rotations

Change-Id: Ia3b148ceb773c6d5b6f8848ced07d7f9c1459e92
2021-07-22 09:41:43 +00:00
Pat Manning b442aee4c4 Add null check for recents scaling during quick switch.
Test: manual - FallbackRecentsTest.goToOverviewFromHome and
StartLauncherViaGestureTests.testStressPressHome were previously failing
due to null mActivity in AbsSwipeUpHandler#getScaleProgressDueToScroll.
Bug: 192470757
Change-Id: I562171c22ad3c89e64b4dc853a266c8b8b78402c
2021-07-22 08:52:28 +00:00
vadimt 6c1331ca42 Improving diags when Launcher is invisible when the test fails
Test: presubmit
Bug: 187761685
Change-Id: I69a930ef076dbf6cca5af516228ebe689fac91eb
2021-07-21 18:50:32 -07:00
Jonathan Miranda c2a49ee2bc resolve merge conflicts of 46378eb881 to sc-v2-dev
Folder icon polish.

- Increase the overlap between the preview items and the background
  so that it appears more intentional (lots of reports of users
  thinking that its a bug)
- Fix bug where clip path was still clipping icons when
  dragging and swiping to home.

Bug: 194339057
Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
      close folder on 2nd page, ensure clipping
      ensure no preview items are clipped in drag view
      ensure no preview items are clipped in swipe up to home
      test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
      of folder icons
      drag and drop folder in and out of hotseat
      create folders (2 icon, 3 icon, 4 icon)

Change-Id: I09ce9ef59e340b1009de3d26eed430a0a8dc4b33
Merged-In: Id49bae33438e10248bef05450d7e2c92c2140748
2021-07-22 00:43:27 +00:00
Jonathan Miranda 46378eb881 Merge "Folder icon polish." into sc-dev 2021-07-22 00:15:29 +00:00
TreeHugger Robot eb894b577a Merge "Scale recents during quick switch for large screens." into sc-v2-dev 2021-07-21 21:35:12 +00:00
Brian Isganitis a9b1814d42 Support overriding All Apps EDU animation on drag am: ec4a56a311
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15349065

Change-Id: Ie0caf9308989d8f3ba0b23ffb68b0157c5d2c22e
2021-07-21 20:15:33 +00:00
TreeHugger Robot 246b450f16 Merge "Reland "Move focused task to front when attaching RecentsView"" into sc-v2-dev 2021-07-21 20:08:41 +00:00
TreeHugger Robot 6c71f688b2 Merge "End recents animation when entering split select" into sc-v2-dev 2021-07-21 18:55:54 +00:00
Evan Rosky 2102a89ef6 Merge "Part of fixing Splashcreen cts tests" into sc-v2-dev 2021-07-21 18:01:09 +00:00
TreeHugger Robot 582a23260a Merge "Always use INSIDE_TO_OUTSIDE scope when swiping to home in tablets" into sc-v2-dev 2021-07-21 17:45:53 +00:00
Pat Manning 3786fa188d Scale recents during quick switch for large screens.
Test: manual
Fix: 192470757
Change-Id: I4522455e488213a6f461549a31e78edef35aac21
2021-07-21 17:43:04 +00:00
Brian Isganitis ec4a56a311 Support overriding All Apps EDU animation on drag
Test: Dragging during All Apps EDU animation overrides the animation.
Bug: 160218103
Change-Id: I1c0a2d047bcb43ea7ce30cf87182b392dac313e4
2021-07-21 17:39:00 +00:00
Alex Chau 2450adf56f Always use INSIDE_TO_OUTSIDE scope when swiping to home in tablets
- In tablets user is either in home screen or there is a taskbar on screen, so swipe to home will always touches the launcher

Bug: 193653850
Test: StartLauncherViaGestureTests
Change-Id: Id1b05708324302eb4b4c2d623ca9fe27090188fc
2021-07-21 14:52:01 +01:00
TreeHugger Robot 643060d4fa [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev am: 3a7df28e8d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15345231

Change-Id: Icf783cca68e5a2811ebcf00b9e2fb7336ffe5429
2021-07-21 12:59:55 +00:00
TreeHugger Robot 3a7df28e8d Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-07-21 12:46:42 +00:00
TreeHugger Robot 23a13c38d5 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-07-21 12:21:37 +00:00
Bill Yi 51ba91bf76 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I340d82d4b6e051e26eb9742bd7cf93cccec3cc80
2021-07-21 05:55:38 +00:00
Bill Yi ae99b65b1f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I828bb455fd6ce0c8e5552cac3bf2090f29021ccd
2021-07-21 05:55:06 +00:00
Jason Chang edc7917521 Fix unable to swipe up to exit one-handed mode under
2 button navigation

Remove redundant condition checking when consuming One-handed mode
gesture events.

Bug: 193761450

Test: manual
Test: atest WMShellUnitTests
Change-Id: Id4687cb579c17d7de1a08b32c003e656cbbce820
2021-07-21 11:54:52 +08:00
Brian Isganitis 015ab224f4 [automerger skipped] Merge "Revert "Merge "Revert "Use wallpaper colors for widgets in wallpaper change preview"" into sc-dev"" into sc-dev am: d9d525236a -s ours
am skip reason: Merged-In I3fb76b6036cb909771b789eac15742df78c2c742 with SHA-1 4a76315805 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15332433

Change-Id: I8412ef3db1a771bbabdc3eb37679302e533c9309
2021-07-21 00:41:28 +00:00
Brian Isganitis d9d525236a Merge "Revert "Merge "Revert "Use wallpaper colors for widgets in wallpaper change preview"" into sc-dev"" into sc-dev 2021-07-21 00:37:36 +00:00
Lucas Dupin f82c463672 Merge "Revert "Apply depth even when surface is null"" into sc-dev am: 8d43e46261
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15341690

Change-Id: I9faebe44fd95ed907376e93a3729bbdc3634b5ec
2021-07-21 00:36:24 +00:00
Lucas Dupin 8d43e46261 Merge "Revert "Apply depth even when surface is null"" into sc-dev 2021-07-21 00:20:30 +00:00
Vinit Nayak 6d2dd7a9e4 Merge "Move NavButtons to end of taskbar" into sc-v2-dev 2021-07-21 00:11:31 +00:00
Alex Chau 17e9b51e38 Merge "Wait for taskbar to become visible after closing launcher in tests" into sc-v2-dev 2021-07-20 22:59:31 +00:00
Jon Miranda 92c1b5d3ab Folder icon polish.
- Increase the overlap between the preview items and the background
  so that it appears more intentional (lots of reports of users
  thinking that its a bug)
- Fix bug where clip path was still clipping icons when
  dragging and swiping to home.

Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
      close folder on 2nd page, ensure clipping
      ensure no preview items are clipped in drag view
      ensure no preview items are clipped in swipe up to home
      test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
      of folder icons
      drag and drop folder in and out of hotseat
      create folders (2 icon, 3 icon, 4 icon)

Merged-In: Id49bae33438e10248bef05450d7e2c92c2140748
Change-Id: Ic3708bd402704f0a6f57ae5315ef602e2bbc6d82
2021-07-20 22:16:21 +00:00
Evan Rosky 8fb6c2156b Part of fixing Splashcreen cts tests
This passes the launcher component name into the transition filter
so that it only matches if the launcher is the current home activity

Bug: 194112093
Test: atest SplashscreenTests
Change-Id: Ie2185545a5bef8b317e104b6ac878f6cde0d7350
2021-07-20 14:23:55 -07:00
Lucas Dupin ee9099af7f Revert "Apply depth even when surface is null"
This reverts commit a6c38be150.

Fixes: 193333562
Test: manual
Change-Id: I4fae079e0cd056fc800e5a15389f4795c77e17fb
2021-07-20 14:14:50 -07:00
Vinit Nayak 8dcbde87c0 Move NavButtons to end of taskbar
* Layout hotseat icons from the end instead of the start
* IME down and system back arrow are now separate views

Bug: 191399224
Test: Tested w/ RTL + LTR in gesture
and 3 button nav w/ and w/o IME

Change-Id: I4d0ecd0bee0c519892c63eeefef45055b26d349b
2021-07-20 13:55:37 -07:00
Alex Chau cd791c5c9d Wait for taskbar to become visible after closing launcher in tests
- Taskbar takes some time to appear after closing launcher and launching test app

Bug: 193653850
Test: StartLauncherViaGestureTests
Change-Id: I714e35ee855660ac28bb214386f48ddbea0e834c
2021-07-20 21:11:08 +01:00
Alex Chau dc66ec82a0 Merge "Re-enable leak detection on tablets" into sc-v2-dev 2021-07-20 20:09:38 +00:00
Alex Chau 1387248378 Merge "Check if running task is null in onPrepareGestureEndAnimation" into sc-v2-dev 2021-07-20 20:09:28 +00:00
Vadim Tryshev 9d7cc7d59f Merge "Further improving TAPL error messages" into sc-v2-dev 2021-07-20 20:04:35 +00:00
Hyunyoung Song 46255ad68e Merge "Fix fast scroller issues / remove fast thumb access / fix wrong popup location" into sc-dev am: 56c33c3cb8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15331688

Change-Id: I103161ef85f4f546399793b40aa7054263e64c84
2021-07-20 19:36:14 +00:00
Hyunyoung Song 56c33c3cb8 Merge "Fix fast scroller issues / remove fast thumb access / fix wrong popup location" into sc-dev 2021-07-20 19:06:36 +00:00
Alex Chau c2181c2be4 Re-enable leak detection on tablets
Bug: 191449914
Test: NexustLauncherTests
Change-Id: Ia2fe0826c933e646260c16d8890aaf2a47023e6d
2021-07-20 12:27:51 +01:00
Alex Chau de6819a453 Check if running task is null in onPrepareGestureEndAnimation
- The crash happen when swiping to overview from home without any task in recents
- A simple null check fixes the issue

Fix: 194166137
Test: FallbackRecentsTest#goToOverviewFromHome
Change-Id: I9344a96a4a78fcfc88d2ad53e44ecd43b23114d5
2021-07-20 11:07:50 +01:00
Sunny Goyal be0b070019 Merge "Fixing quickswitch window not properly aligned in split-screen" into sc-dev am: c3f56d7628
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15331678

Change-Id: Icd63f65f52646e638c35229c6069455e9b9cd08e
2021-07-20 07:17:28 +00:00