Only when taskbar is unstashed in apps:
- Scrim workspace with the taskbar color when opening apps and in BackgroundAppState
- Crop opening apps to above the taskbar
- Crop TaskViews to above the taskbar during gestures
If taskbar is stashed in apps, behavior is the same as before, i.e. no scrim over the wallpaper and no cropping of tasks.
Added a field DeviceProfile#taskbkarPresentInApps to distinguish these cases. LauncherTaskbarUIController and TaskbarStashController ensure this value is set appropriately.
Test: Ensure tasks don't appear behind taskbar when it's unstashed; set ENABLE_SCRIM_FOR_APP_LAUNCH = true to test the whole screen scrimming when opening an app
Bug: 196257194
Fixes: 190681228
Change-Id: I481501457a5a6d49c380feea3db3b4058e4cf3f8
This reports more consistently and is cheaper.
Test: Log windowBounds.insets.bottom vs windowInsets.getSystemWindowInsetBottom() and note that the former is correct after fold/unfold even though the latter starts reporting 0
Bug: 196874770
Change-Id: I41eb0ab51d3761a988e680cd6d61e40bcacf567f
Linking header position to an empty entry in the recyclerView,
instead of calculating the vertical scroll position. This
allows the header to be in sync with the recyclerView scroll and
item animations
Other simplifications:
> Moving top collapse handle out of header view (it doesn't scroll)
> Removing background clipping logic from full-sheet
> Moving tab bar inside the header view
Bug: 196464142
Test: Verified on device
Change-Id: Iae5a0ae9af7ce258e1b391b8e85c5c270fe56197
The tasks that are not showing in the screen will be rearranged. This
doesn't change anything for tasks before the dismissed task because the
grid is already balanced there.
Fixes: 194189955
Test: manual with 10 tasks, normal and RTL mode
Change-Id: I07ddbb752110339751bd1ed6056fe9f645b5497f
This reverts commit 5f80e92bda.
Reason for revert: We need to see if this has caused b/196586808
Bug: 196586808
Test: presubmit
Change-Id: I078f0d4e83f5f1db19e9e0a5afec4f3058156745
- Remove all usage of LEFT_PANEL_ID and fixed left panel code
- For preview renderer, load screen 0 + screen 1 instead
- Added a split display specific default workspace layout, with a placeholder app to pass test before we implement page pairing(b/196376162)
- Known issue: If screenId 1 is deleted, right panel will disappear from Wallpaepr & Style because there is no screenId 1. Will be resovled after page pairing(b/196376162)
Bug: 175939730
Test: manual and TaplTestsLauncher3#testWorkSpace
Change-Id: Icac1c94165c14a49c17897c45355b6cdc4d87e91
The padding on left and right should be added only on the left for left
page and only on the right for right page.
Fixes: 195410512
Test: open Wallpaper & Style and check the space between the pages
Change-Id: Ib27c632d2fb07d4708bd101e555e14e31a26ff9d
Some grid options are too dense for foldables (those with 5 icons), so
we are hiding them on those devices.
This also move the parsing to be done on InvariantDeviceProfile only.
Fixes: 183140646
Test: open Wallpaper & style and change app grid options
Change-Id: I771571db02709db5d0f814236060c57ce0180cd1
Previously, we hint at user active in order to let the launcher know at
an earlier time that the user is about to go home, to provide PiP a
shelf offset. However with Shell Transitions, this is now being done
instantly as the launcher activity is resumed right as user touches down
on the gesture pill. We then no longer need this for shell transitions.
Bug: 165793917
Test: Enable Shell Transitions, go home to enter PIP, and open another
app - see that PIP auto moves downward now that shelf height has changed
Change-Id: I347c885425ce820a42ebfcc15082862d04aa1a7d
When a model preload call was made while the loader task is running
(eg: on enabling/disabling icon theme, Launcher reloads and then
launcher preview start a model-preload), it would cancel the original
loader and then start a new loader with empty callbacks. So the
model indeed get loaded, but the original callbacks never got notified
of it.
> Instead we only start preload if an existing task is not running.
> Also when preloading, we use existing callbacks, instead of using
empty callbacks
Bug: 193851085
Bug: 195155924
Test: Verified repro steps
Change-Id: I0a96310be8489756f364aa2a12e4345e1418733d
Alex Chau
vadimt
Tracy Zhou
Vinit Nayak
Tony Wickham
Thales Lima
Sunny Goyal
Dave Mankoff
TreeHugger Robot
Lucas Dupin
Ben Lin
Brian Isganitis
Andras Kloczl