When taskbar is in pinned mode with bubble bar expanded, in some
scenarios, we hide taskbar contents (i.e. when bubbles overlaps with
taskbar) and the scrim still shows.
One of the existing tests in TaskbarScrimViewController checks that
the scrim would be 0 when taskbar is not visible, however, in the
bubble bar case this isn't always true... I think there probably are
cases where taskbar isn't visible for other reasons (e.g. shade is
pulled down, but there are other tests specific to that). I'm
setting this test to only run when bubble bar isn't running, because
in that case bubbles never impacts taskbar visibility.
I added a test case to ensure scrim is hidden when pinned BUT bubble
bar is on home -- in this case we shouldn't show the scrim.
When adding the enableFlag/disableFlag I saw some NPEs in onDestroy
methods of some controllers so I protect against those as well.
Flag: EXEMPT test change
Test: atest NexusLauncherTest:TaskbarScrimViewControllerTest
atest NexusLauncherRoboTest:TaskbarScrimViewControllerTest
Bug: 377764181
Change-Id: I71001222aa8a4393b341dd2b43a4b2e46e617a70
When modalness is >0, the user is in select mode and the icon menu is
hidden, therefore Talkback shouldn't pick it up.
Fix: 320203664
Flag: NONE bugfix
Test: Manual. Turn Talkback on, navigate to Overview, enter select mode,
select the whole TaskView, Talkback shouldn't have any accessibility
actions to execute.
Change-Id: I83dffce60f42cc32d83c499dfb08ddf97888f527
When app is in DesktopTask being split, we need to bring tasks after last desktop task to correct position during split animation. Solution is to add additional primary translation from current desktopview to first non desktopview.
Refactored how primary translation is being calculated.
Test: Manual, split app from taskbar which is in desktop window
Fix: 377230397
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: Ic76b0e7d9a627158e5d521ed40f17279130a974a
When persistent taskbar is used, bubbles align with hotseat when
launcher state is home. But when user navigates to the -1 page or all
apps, we show the persistent taskbar instead of hotseat.
3 button navigation container shifts in this case. Apply the same shift
to bubble bar.
Bug: 376141984
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest PersistentBubbleStashControllerTest
Change-Id: I2765936e0bac43a790b628e7df2a1b4ddad32cae
- Stuff related to updating internal TIS state need to also run on the
main thread
Bug: 374197142
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ia62b665d9a39bc4a4c119fce8538bb147d92957a
- Provide both launch and minimize animations from
DesktopAppLaunchTransition
- Add support to TaskbarRecentAppsController to check whether an app is
visible vs. minimized vs. not showing at all in Desktop Mode
- Use DesktopAppLaunchTransition when clicking a Taskbar/AllApps app
icon (when in Desktop Mode and the app is not visible) to animate the
app launch
- The animation / transition is passed to Shell through ActivityOptions
Note: this CL does not add animations for launching managed/work
profile apps. That will be handled in b/376819104.
Test: launch apps in Desktop from Taskbar/AllApps
Bug: 327428659
Flag: com.android.window.flags.enable_desktop_app_launch_transitions
Change-Id: I44be96b9c53718b2082d2f630e1921356785fc4b
When a bubble is updated, we now suppress the animation when needed.
This prevents the animation from playing on the lock screen, when
the shade is open, when the IME is visible, etc.
Note that for new bubbles we were already suppressing the animation.
The issue fixed by this change is only observed for updated bubbles.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 377618253
Fixes: 377624611
Test: manual
- tap qsb or launch any app and show the keyboard
- send an update to a bubble
- observe the flyout is not appearing
- repeat with shade open and on lock screen
Change-Id: Id78e0cfbc413bcebaf6445cecacaaf34b36ed411
Shell can use the location update trigger information for logging
purposes.
Bug: 349845968
Test: manual
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I5af4375f88ea438b1aed9b3b2bd02d0c33fff53f
When a bubble is added or removed while we're collapsed, animate the
badge scale to make sure that only the badge for the top bubble is
visible.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 360652359
Test: manual
- add bubble while collapsed
- observe that badge only shows for top bubble
- remove bubble while collapsed
- observe that badge only shows for top bubble
Change-Id: I91472bb2ddeeeebd33ca64e20e065b2336c08589
When enough widgets are not passing the filter, additional randomly
selected widgets are added.
The count to decide whether to add more is a configuration, so that,
if some OEMs don't want any suggestions, can override the value to 0.
Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Unit tests
Change-Id: Iffa8619149a1a4b468d367fc7bbee381be59469d
The expected order to finish recents is first "setWillFinishToHome"
and then "finish" via RecentsAnimationControllerCompat.
Because RecentsAnimationController uses UI_HELPER_EXECUTOR to invoke
setWillFinishToHome, if "finish" is called on UI thread directly,
there may be a race that WillFinishToHome is not set yet (only when
animation is disabled), then the shell's RecentsTransitionHandler
will handle it as "return to app" rather than entering recents.
By using the regular finishRunningRecentsAnimation (forceFinish is
false), RecentsAnimationController#finishController will also post
to UI_HELPER_EXECUTOR, so the order between setWillFinishToHome can
be consistent.
Bug: 375667878
Flag: EXEMPT bugfix
Test: atest com.android.quickstep.FallbackRecentsTest#testOverview
Test: Set 3rd party home as default.
Disable animation (Settings's "Remove animations").
Press recents key on home. It should enter recents.
Change-Id: Ia449f77b317db812360092c2aaf9e3657b92cf7b
This CL does not include animating app icons / leave behind circle.
Bug: 376281549
Flag: com.android.launcher3.taskbar_overflow
Test: press the oveflow button, dismiss KQS in different ways
Change-Id: I1f830c6859a5be4fb5947ec38e6d30da79138b7f
Refactor the TaskbarDelegate to support multiple pass down displayId specific signals down to the taskbar level.
Flag: EXEMPT not adding new behavior
Bug: 376128251
Test: Manual
Change-Id: I61aef4eb746d671be69eefeb15d876d48dd9a8fa
The implementation in this CL is no-op i.e. all widgets will be shown
Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
Liran Binyamin
Treehugger Robot
Mady Mellor
Ats Jenk
samcackett
Johannes Gallmann
vinayjoglekar
Sihua Ma
Tracy Zhou
Gustav Sennton
Shamali P
Artsiom Mitrokhin
Jagrut Desai
Andy Wickham
Sukesh Ram
Schneider Victor-tulias
Riddle Hsu
Anushree Ganjam
Winson Chung
Uwais Ashraf
Tony Wickham
Matt Sziklay