Commit Graph

14643 Commits

Author SHA1 Message Date
TreeHugger Robot 2b0cf9b1ca Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev 2023-05-03 21:29:38 +00:00
Jagrut Desai 11c18bf7a2 Merge "Design review updates for Taskbar Pinning" into udc-dev am: 5dbfe1f238
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22956388

Change-Id: I07d0b29555abbae613b721817aee49a35793ed95
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-03 18:25:26 +00:00
Jeremy Sim 4c7355e4e3 Merge "Move test to presubmit" into udc-dev am: 8ecacd3624
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22970558

Change-Id: Ic98d4c14a931a73230724e6e58a8939a6f127ddb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-03 18:25:08 +00:00
Jagrut Desai 5dbfe1f238 Merge "Design review updates for Taskbar Pinning" into udc-dev 2023-05-03 18:24:07 +00:00
Saumya Prakash 5d6d5743f5 Merge "Remove unused Assistant gesture tutorial and add error checking" into udc-dev am: 32a38c9ff1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22939505

Change-Id: I555de589a9668f5b94c809f07adf40cd41e4376b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-03 18:23:17 +00:00
Jeremy Sim 8ecacd3624 Merge "Move test to presubmit" into udc-dev 2023-05-03 17:39:35 +00:00
Saumya Prakash 32a38c9ff1 Merge "Remove unused Assistant gesture tutorial and add error checking" into udc-dev 2023-05-03 17:37:52 +00:00
Kateryna Ivanova b6da07fe22 Merge "Revert^2 "Introduce library for public animation APIs"" into udc-dev am: 46b73c2338
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22890961

Change-Id: I37282c514979e70979810d424b0c8ab432c555cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-03 08:55:27 +00:00
Kateryna Ivanova 46b73c2338 Merge "Revert^2 "Introduce library for public animation APIs"" into udc-dev 2023-05-03 08:41:31 +00:00
Bill Yi f9aaebbd24 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie4fb20c4c92d26083261cc729b44d24f65a7c4d7
2023-05-02 22:50:29 -07:00
Fengjiang Li ffcad66fac Merge "[1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency" into udc-dev am: c15679d512
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22650115

Change-Id: I5102c2a2b96b26d5009a9019190c60daf4ab7e04
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-03 04:25:31 +00:00
Fengjiang Li c15679d512 Merge "[1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency" into udc-dev 2023-05-03 03:18:46 +00:00
Tracy Zhou 74aadeef4a Merge "Revert "Fix touch focus not updated correctly after launching overview with live tile."" into udc-dev am: 41bfd86c1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22976087

Change-Id: Ice98de9e628b666eb27c1a60f6ea824c8139159d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-03 01:14:27 +00:00
Tracy Zhou 41bfd86c1e Merge "Revert "Fix touch focus not updated correctly after launching overview with live tile."" into udc-dev 2023-05-03 00:41:34 +00:00
Fengjiang Li 5a36c17a32 [1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency
More details at "Log Startup Latency" section in go/launcher-startup-latency

Test: tested on phone, foldable and tablet, print latency logs in logcat
Bug: 278092752
Change-Id: Ibf269b0ecd6007d29b95e36f65ab6f02c45deb3a
2023-05-02 17:08:05 -07:00
Sihua Ma 8a2ef6250a Merge "Fix ConcurrentModificationException in QuickstepWidgetHolder" into udc-dev am: 8f85ad38ba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22934145

Change-Id: I71a5ff2f67b8e5e41ba2510e17aae43053d92241
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-02 22:07:07 +00:00
Tracy Zhou 3ec15b04f5 Revert "Fix touch focus not updated correctly after launching overview with live tile."
This reverts commit 8899f3a387.

Reason for revert: Regression b/280167174, b/280240591

Change-Id: Id82ab1dafb8c939b0e073ad4978d2782e3d953d8
2023-05-02 21:40:13 +00:00
Sihua Ma 8f85ad38ba Merge "Fix ConcurrentModificationException in QuickstepWidgetHolder" into udc-dev 2023-05-02 21:26:53 +00:00
Schneider Victor-tulias 1bbc534170 Merge "Add null checks for mRecentsView" into udc-dev am: db07d2223e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22939702

Change-Id: I820b3b00636af5756213dc6a49467aa2ebc61194
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-02 18:55:18 +00:00
Jeremy Sim deda0d0c05 Move test to presubmit
testSplitAppFromHomeWithItself() has been in postsubmit for approx. 4 months with no major flakes, moving to presubmit

Fixes: 270201357
Test: Android Test Investigate reports 2/45 test failure rate
Change-Id: I13cd5bc9e0ba376ffe97e8e61ed577a51b59bdb4
2023-05-02 18:25:39 +00:00
Schneider Victor-tulias db07d2223e Merge "Add null checks for mRecentsView" into udc-dev 2023-05-02 18:15:47 +00:00
Winson Chung d03767df3d Merge "Wait for shell drop target to be ready for handling drags in tests" into udc-dev am: 52cc03e42c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22935091

Change-Id: Idce0b714d7b368b44ef853ce58cb2e17da5ea01c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-02 16:51:07 +00:00
Winson Chung 52cc03e42c Merge "Wait for shell drop target to be ready for handling drags in tests" into udc-dev 2023-05-02 16:46:24 +00:00
Winson Chung c8ad4f7f43 Wait for shell drop target to be ready for handling drags in tests
- Wait for the shell drop target to be made visible and drawn before
  attempting to continue with the drag gesture

Bug: 234653212
Test: atest NexusLauncherTests

Change-Id: Ida851343873b51288460f25bba062f29019005d4
2023-05-02 05:29:36 +00:00
Tony Wickham 4ea805022d Merge "Simplify/correct Taskbar insetsRoundedCornerFrame calculation" into udc-dev am: 5e43031ed0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22939968

Change-Id: I823ade6704de7a2fea35123a25e5821e03afcc6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-02 01:34:00 +00:00
Tony Wickham 5e43031ed0 Merge "Simplify/correct Taskbar insetsRoundedCornerFrame calculation" into udc-dev 2023-05-02 00:56:38 +00:00
Jagrut Desai 1c9c6d0ea9 Design review updates for Taskbar Pinning
Changes:

- icon allignment animation for taskbar diviver view
- taskbar divider background color according to spec.

Test: Manual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ief45e48f4fc9f9b4cc30124c4c93cd3c5a880a33
2023-05-01 14:57:54 -07:00
Schneider Victor-tulias f77d2086c4 Add null checks for mRecentsView
Fixed a NPE and added some null checks for mRecentsView. These NPEs can happen if the launcher is destroyed unexpectedly.

Flag: not needed
Fixes: 279738827
Test: ran launcher and tested some gestures
Change-Id: I9c32e22a13d950346ce705ba3a6f11dd3f1da87f
2023-05-01 13:51:02 -07:00
Vinit Nayak d563920508 Merge "Refactor handling data launching split screen to separate class" into udc-dev am: 90dce8b8b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22840581

Change-Id: I4145cd1b949c9c3ae6ce3d3a81ff0aa2b649527e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-01 20:31:24 +00:00
Saumya Prakash 94c8cf49cf Remove unused Assistant gesture tutorial and add error checking
The Assistant gesture tutorial is unused in both the current and
redesigned gesture nav tutorials and can be removed. Left in, its
detections of gestures are leading to bugs with the tutorial.

Additionally, this change adds in error checking for side swipes in the
overview tutorial.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 280115831
Fix: 261239858
Fix: 278926113
Test: Manually went through both versions of gesture tutorial on
handheld, foldable, and tablet devices

Change-Id: Ie481d92ede2c2ab16ce2b3d1f729f6cb88f1b4c0
2023-05-01 17:58:54 +00:00
Treehugger Robot 32bb627fe4 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev 2023-04-29 07:57:32 +00:00
Vinit Nayak 2a014d4c0d Refactor handling data launching split screen to separate class
* SplitSelectDataHolder contains logic for knowing how
to launch split, separate from the actual API calls to launch split

Flag: ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Bug: 279494325
Test: Tested w/ all 6 types of launches noted in
SplitSelectDataHolder#@SplitLaunchType.
Also checked to make sure most-recent running tasks are
still being used where applicable.

Change-Id: I8114f87e9956b100622c80f578e291937ed4eeac
2023-04-28 18:00:22 -07:00
Tony Wickham 3cfada0a00 Simplify/correct Taskbar insetsRoundedCornerFrame calculation
Now we base it on the current tappableElement insets, which will only be
> 0 for the unstashed, persistent taskbar which draws rounded corners.
This inset also stays stable during temporary stash transitions such as
when the IME is showing.

Flag: ENABLE_TRANSIENT_TASKBAR=true, ENABLE_TASKBAR_PINNING=true
Test: in split screen for both transient and pinned (persistent)
taskbar, ensure split screen divider bottom is drawn appropriately
Fixes: 278028503

Change-Id: Iab56c5dc8f9fc81c34aa01f41b5212dd5c6fd7f0
2023-04-28 23:51:41 +00:00
Sihua Ma d72ce23707 Fix ConcurrentModificationException in QuickstepWidgetHolder
If the listeners would modify the listener list in the widget holder, this would cause a ConcurrentModificationException.

Fix: 275100497
Test: N/A
Change-Id: I3ae0e92db71f1c21d35dbf391dfcb92b46dd30f1
2023-04-28 14:21:24 -07:00
Saumya Prakash 71d05f963f Merge "Update the colors for gesture navigation tutorial." into udc-dev 2023-04-28 17:03:31 +00:00
Kateryna Ivanova c0a003ed77 Revert^2 "Introduce library for public animation APIs"
af289a1cd1

Bug: 271850966
Change-Id: Iddc1790fc3704ce20fde4377d05360a77b6c146c
2023-04-28 08:38:26 +00:00
Saumya Prakash 796ebc6006 Update the colors for gesture navigation tutorial.
This change introduces tokens for the lottie animations so that the
colors can be changed. In this change, the home gesture tutorial colors have
been updated to match the updated design at http://shortn/_VvbigpP0ys

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Test: Manually went through the tutorial on handheld, foldable, and tablet
Change-Id: Id2270cea41345e8f4d330097e10a7dae2b00032a
2023-04-27 22:06:17 +00:00
Bill Yi 7c3608a1bf Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6a557288c1c800f433e8a2dcbaa28be97d0d987a
2023-04-27 12:14:42 -07:00
Ats Jenk 0e068b1213 Pass in display when using DesktopMode APIs
Pass in the display id when asking wmshell to show desktop apps or when
querying the number of visible desktop tasks.

Bug: 278084491
Test: open some apps on the desktop, swipe up to recents, tap the
  desktop tile to open desktop again
Change-Id: Ia7328613244a1aa401e0e4792bc747a4b99b412d
2023-04-27 11:50:49 -07:00
Schneider Victor-tulias 8c1bffb24f Merge "Remove unused debug logs" into udc-dev 2023-04-27 17:44:42 +00:00
Tracy Zhou 07b5cb3351 Merge "Fix touch focus not updated correctly after launching overview with live tile." into udc-dev 2023-04-27 04:31:49 +00:00
Tracy Zhou 8899f3a387 Fix touch focus not updated correctly after launching overview with live tile.
Similar to ag/19938037

Fixes: 277625965
Test: Meta+Tab to launch overview from app, or swipe from app, then use DPAD_LEFT and DPAD_RIGHT to go through overview. Make sure the selected task is highlighted
Change-Id: Id0138878d32e4d37f30cef51ddb9ddb9df85fd65
2023-04-27 03:14:40 +00:00
Treehugger Robot a9a2ec9b55 Merge "Move setCurrentPlayTime before starting animation." into udc-dev 2023-04-27 01:00:56 +00:00
Jagrut Desai 0e5f1af6cb Merge "Adding Support for Change Navigation Mode Taskbar Divider Menu Option" into udc-dev 2023-04-26 22:12:08 +00:00
Schneider Victor-tulias a314b0375e Merge "Fix broken TaplTestsTaskbar splitscreen test cases" into udc-dev 2023-04-26 21:33:38 +00:00
Andy Wickham a4627d2235 Merge "Add long swipe from app to overview gesture (with flag)." into udc-dev 2023-04-26 21:30:53 +00:00
Jon Miranda 77b17547c3 Move setCurrentPlayTime before starting animation.
Otherwise when animations are turned off, the animation will start/end
and then gets stuck to the first frame of the animation.

Fixes: 278046913
Change-Id: I5f0ed4b99ab4737b5371d65754d1acb4fdb8edb0
Flag: none
Test: swipe to go home
2023-04-26 12:05:04 -07:00
Andy Wickham 830e4b7ce0 Add long swipe from app to overview gesture (with flag).
High level:
 - As you swipe up from an app (OtherActivityInputConsumer),
   a state transition animation to All Apps is created in
   AnimatorControllerWithResistance. The animation is played
   alongside the Recents resistance animation (i.e. past the
   settling point of Overview, which is at mCurrentShift 1).
 - The actual state transition to All Apps only happens if you
   release your finger in the "all apps region." This is set to
   mCurrentShift 2, so double the distance that Overview rests.
 - A haptic plays whenever you enter or exit this region, and
   the all apps animation is set to 0 until the region is
   active. This is so it's clear that something different is
   happening.
 - The panel that was previously used for tablets is now used
   for phones during this transition. It comes in at full
   opacity when you enter the region, and the contents (apps
   and search suggestions) fade in as you continue swiping.
 - The only gesture that is recognized in the all apps region
   is a fling downwards, which will return you to the previous
   app. Otherwise a left/right/up fling or slow release will
   finish the all apps transition.
 - The threshold is ignored if the flag is disabled (default)
   or if FallbackActivityInterface is active.

Flag:
The threshold is ignored if ENABLE_ALL_APPS_FROM_OVERVIEW is
disabled (default).

Bug: 259619990
Bug: 275132633
Test: Manual with and without the flag enabled
Change-Id: Ie311b77252416d97677b2c56fad61dfd392b6fe8
2023-04-26 10:52:04 -07:00
Schneider Victor-tulias ccc10128f1 Fix broken TaplTestsTaskbar splitscreen test cases
The split tasks no longer close between test orientation changes. Updating tests to close all tasks after TaplTestsTaskbar test cases

Flag: not needed
Fixes: 279063348
Test: TaplTestsTaskbar
Change-Id: Ie654aae0a16ff495555b48f85a8dec8537086649
2023-04-26 10:15:27 -07:00
Jordan Silva a68cd72a3c Merge "Fix digital wellbeing toast being initialized multiple times" into udc-dev 2023-04-26 17:15:09 +00:00