Commit Graph

12448 Commits

Author SHA1 Message Date
Ats Jenk e7d52f523d Merge "Handle swipe down on collapsed bubble bar" into main 2024-09-27 19:44:56 +00:00
Sunny Goyal 63c24aeacb Merge "Updating IconProvider API to use a single API to load icons" into main 2024-09-27 19:43:54 +00:00
Jordan Silva 04484049fa Extracting handheld task dismiss translation to smaller functions (2/4)
This CL extracts the logic to translate the tasks used when Overview grid is disabled (i.e., for handheld) to 2 smaller functions that will be used for desktop and grid translation in the follow up CL.

Bug: 353948136
Bug: 353948182
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: OverviewDesktopTaskImageTest
Change-Id: Ie25fffaaca4580a8a483003d220b4bf6cdccbc66
2024-09-27 16:32:00 +00:00
Mykola Podolian 6f231f694d Merge "Update placement of the hotseat according to the bubble bar location." into main 2024-09-27 15:45:04 +00:00
Matt Casey 3648100d45 Merge "Provide Display ID for overview screenshots" into main 2024-09-27 14:03:29 +00:00
Liran Binyamin 272eea45e6 Merge "Implement bubble bar flyout background animation" into main 2024-09-27 12:45:41 +00:00
Alex Chau e3dc1c5185 Merge "Fix grid task dismiss animation when desktop large tile is enabled (1/4)" into main 2024-09-27 09:01:50 +00:00
Jon Miranda e40cc40619 Close KeyboardQuickSwitch if user taps outside the container.
Bug: 368119679
Change-Id: I3f0b1cacb76077daa5879ad93c195018948497f9
Test: open KQS via taskbar affordance, tap outside the container,
      observe KQS close
Flag: com.android.launcher3.taskbar_overflow
2024-09-27 06:08:11 +00:00
Winson Chung 043025eb06 Merge "Update TIS logs to narrow down duplicate service creation" into main 2024-09-27 05:46:20 +00:00
Sunny Goyal a1cebfa0c0 Updating IconProvider API to use a single API to load icons
Bug: 366237794
Test: atest IconProviderTest
Flag: EXEMPT refactor, changes in underlying API

Change-Id: If8c6a4f13de7e7d262ee0b6d0c6897981f75e639
2024-09-26 22:13:11 -07:00
Jon Miranda cd00e8f2e4 Merge "Position KQS to the bottom if opened via taskbar." into main 2024-09-27 04:09:55 +00:00
Treehugger Robot 39341d19a9 Merge "Filter out running pinned app tasks from KeyboardQuickSwitch." into main 2024-09-27 03:21:16 +00:00
Tracy Zhou 649c900004 Merge "Cancel TASKBAR_COLLAPSE/EXPAND CUJ tracking when the stash animation is cancelled" into main 2024-09-27 03:05:40 +00:00
mpodolian dfb48214ea Update placement of the hotseat according to the bubble bar location.
Update the hotseat and Qsb placement according to the 3 nav buttons bar.

Test: Manual.
Set navigation mode to 3 buttons.
On launcher home screen move the bubble bar from one side to another.
Observe that the Hotseat and Qsb moving together with the navigation
bar.
Once moved the bubble bar, expand the bubble bar and collapse it.
Observe how the Hotseat is stashing and un-stashing.
After bubble bar changes position hit the recent apps button, observe
the transition.
On launcher home screen start application with the hotseat icon and exit
opened application. Observe that flying icon comes back to the correct
position in the hotseat.
Video with the above scenarios:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/blTYrKopTyufOcRoPuVpYK
Bug: 346381754
Flag: com.android.wm.shell.enable_bubble_bar_in_persistent_task_bar

Change-Id: Ic8c6acdffbbb111cbe4f3fd6bc60195578d7035d
2024-09-26 19:04:01 -07:00
Jon Miranda daa8779012 Merge "Taskbar overflow: only show if apps don't fit + limit # of icons" into main 2024-09-26 20:40:13 +00:00
Liran Binyamin f7fc19bec1 Implement bubble bar flyout background animation
Update the bubble bar flyout drawing behavior to allow to animate
from a collapsed position into an expanded position.

This change only handles the rounded rect and the triangle. The
text is still left unchanged.

When wired up this looks like this:
left: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/gIsckRmFKj8CceafiJnPTa
right: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/dpn51yXFCCkT6ViUegf351

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I85ae3bf908c04e5473655c9e536495f56d80f466
2024-09-26 14:38:41 -04:00
Jordan Silva 21ac8f1451 Fix grid task dismiss animation when desktop large tile is enabled (1/4)
- Fix bottom grid row size in createTaskDismissAnimation to subtract all large tiles from bottom row count.
This fixes the animation when dismissing a focused and a bottom row task turns into a focused task.

- Fix when snapping to last task, snap to focused task page instead of INVALID_PAGE (-1).
This prevents snapping to a wrong page (DesktopTask page) when last grid task is dismissed.

Bug: 353948136
Bug: 353948182
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: OverviewDesktopTaskImageTest
Change-Id: Ib4b0453eb6b99855615b22fe842ccbe1205c962d
2024-09-26 13:15:28 -03:00
Jon Miranda deaca33cc2 Position KQS to the bottom if opened via taskbar.
Bug: 368119679
Test: open KQS via taskbar, observe view at bottom of screen
      open KQS via keyboard, observe view at top of screen
Flag: com.android.launcher3.taskbar_overflow

Change-Id: I3e6f0d2ba51ec15cf7cb1f41ddc2a4414dfd60d6
2024-09-26 16:05:57 +00:00
Jon Miranda 9ce27637d7 Filter out running pinned app tasks from KeyboardQuickSwitch.
- Opening KQS from keyboard shortcuts shows all the tasks.
- Opening KQS from taskbar will filter out all the running pinned apps
  from the list of views.

Bug: 368119679
Change-Id: I6090679f9fc359212db00a325917892ae6e1eb39
Test: open KQS via taskbar affordance, obseerve filtered list,
      use alt + option
      observe list changes to show all tasks
      click affordance again, observe list changes back to filtered
Flag: com.android.launcher3.taskbar_overflow
2024-09-26 16:05:23 +00:00
Tracy Zhou 408b1e0103 Cancel TASKBAR_COLLAPSE/EXPAND CUJ tracking when the stash animation is cancelled
Bug: 362713428
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ib09a26056ed0d4bae64566eed92279241dd84a90
2024-09-25 21:11:37 -07:00
Ats Jenk 0b19598d36 Handle swipe down on collapsed bubble bar
Allow swiping down on collapsed bubble bar to stash it.

Bug: 325673340
Test: atest NexusLauncherTests:com.android.launcher3.taskbar.bubbles.BubbleBarSwipeControllerTest
Test: swipe up to show bubble bar and swipe down to stash it
Test: tap on stashed handle
Test: enable 3 button nav and tap on bubble bar
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I0367d36bdc1aef34dc71843052b691a95e293375
2024-09-25 13:06:22 -07:00
Matt Casey 43ea3e0444 Provide Display ID for overview screenshots
Bug: 367394043
Test: Manual test with logging
Flag: EXEMPT behavior changes are flagged, this is just passing in data.
Change-Id: I7c1998eaeadad40670b2942e80f2bac878a8f186
2024-09-25 16:54:22 +00:00
Schneider Victor-Tulias 62335be7c9 Track all ActiveGestureLogs in ProtoLog
Flag: com.android.launcher3.enable_active_gesture_proto_log
Bug: 293182501
Test: checked protolog traces in winscope
Doc: go/launcher-protolog-support

Change-Id: I2eb153aa9a94fe49f9c5e9b93b0be5e14fb4eb9c
2024-09-25 14:28:00 +00:00
Schneider Victor-tulias 8388a07673 Merge "Add protolog support to Quickstep" into main 2024-09-25 13:44:02 +00:00
Alex Chau fafecabbf8 Merge "Only call reset() when transitioning to a State that doesn't have RecentView visible" into main 2024-09-25 09:57:44 +00:00
Treehugger Robot d3e1d7ba42 Merge "Fixes to allow enabling of enable_refactor_task_thumbnail flag" into main 2024-09-25 02:48:24 +00:00
Winson Chung dd4145b917 Update TIS logs to narrow down duplicate service creation
Bug: 353903219
Test: Manual, force multiple registrations of the input consumer
Flag: EXEMPT bugfix
Change-Id: Ie42f4b2335f8264fe2dbdb99ca4472c5035346a2
2024-09-25 00:38:56 +00:00
Brian Isganitis bfe4d6b469 Merge changes Ie1b6609b,If115625c,I418675ba,I930e7458 into main
* changes:
  Add tests for TaskbarAllAppsViewController.
  Add tests for TaskbarAutohideSuspendController.
  Add tests for TaskbarScrimViewController.
  Add tests for TaskbarStashController.
2024-09-24 22:53:24 +00:00
Brian Isganitis d7dc6ba320 Add tests for TaskbarAllAppsViewController.
Test: TaskbarAllAppsViewControllerTest
Flag: TEST_ONLY
Bug: 346394506
Change-Id: Ie1b6609b243326eb11d03d2ea7b0e98bd60c3a71
2024-09-24 18:51:46 -04:00
Brian Isganitis 78f8d40519 Add tests for TaskbarScrimViewController.
Test: TaskbarScrimViewController
Bug: 346395034
Flag: TEST_ONLY
Change-Id: I418675ba9aeaa645a0b216d237c479ffd640baf9
2024-09-24 18:51:46 -04:00
Brian Isganitis 3231ba01e6 Add tests for TaskbarStashController.
Test: TaskbarStashControllerTest
Bug: 346394503
Flag: TEST_ONLY
Change-Id: I930e745826f2512d04434ad689a3e42cac7e9901
2024-09-24 18:51:46 -04:00
Ats Jenk bf09e036b3 Merge "Have bubble bar unstash gesture track finger" into main 2024-09-24 22:33:02 +00:00
Sunny Goyal e1b7ca566e Merge "Moving various application into related methods to a separate class" into main 2024-09-24 22:05:52 +00:00
Jon Miranda b319e24136 Taskbar overflow: only show if apps don't fit + limit # of icons
- Only shows the overflow icon if all of the recent apps do
  not fit in the taskbar.
- Limits the number of recent app icons on screen so that they
  do not go out of bounds.
- Removes the overflow if it's not needed.

Bug: 368119679
Test: open app, enter desktop windowing, overflow only shows
      when reaching max number of apps
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I96040495ee38f67bce8e41f9eb4ec17fcef5189a
2024-09-24 21:10:38 +00:00
Schneider Victor-Tulias 00b6996e6d Add protolog support to Quickstep
Flag: EXEMPT changes cannot be flagged
Bug: 293182501
Test: launcher builds
Doc: go/launcher-protolog-support
Change-Id: I302b442b99165c9591b9349ea200285a5b9c074c
2024-09-24 17:07:53 +00:00
Ats Jenk 26d74b9ec0 Have bubble bar unstash gesture track finger
Follow the taskbar motion for unstashing via gesture.
When swiping up in the handle area, move the handle slightly up with the
finger movement.
Once reaching a certain threshold, unstash the bubble bar.
If user swipes up past a certain other threshold, and lifts the finger,
expand the bubble bar. Otherwise leave bubble bar in collapsed state.

Only stashed handle or collapsed bar can be swiped up on.

Bug: 325673340
Test: atest NexusLauncherTests:com.android.launcher3.taskbar.bubbles.BubbleBarSwipeControllerTest
Test: swipe up on stashed handle
Test: tap on stashed handle
Test: enable 3 button nav and tap on bubble bar
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I6bb3c201cd03f05e2be55ebb0c972c577373ea79
2024-09-24 09:56:49 -07:00
Randy Pfohl 31aefc3290 Merge changes from topic "windowRecents" into main
* changes:
  Cleaning up unusued handlers
  Moving RecentsWindowManager away from the singleton pattern
  Limited recents in window introductory cl
  abstracting fallback views to support container instead of activity
2024-09-24 16:13:30 +00:00
Uwais Ashraf 61e6cb27ed Fixes to allow enabling of enable_refactor_task_thumbnail flag
Fix: 362664267
Test: presubmits
Test: Flakiness check run - https://android-build.corp.google.com/builds/abtd/run/L80100030006605258 (shows an acceptably low flake rate)
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I10ef75d6298498ae827de6408ad661fba09cbde5
2024-09-24 15:04:39 +00:00
Treehugger Robot 3227a4ecf7 Merge "Don't return TYPE_RECENTS task in TopTaskTracker.getCachedTopTask" into main 2024-09-24 11:37:22 +00:00
Sunny Goyal 28d6bbd6b4 Moving various application into related methods to a separate class
> This avoids duplicate RPCs when trying to get multiple properties
  from AppInfo
> This would be used in a followup cl when AppInfo is added to caching
  logic in IconCache

Bug: 366237794
Test: atest ApplicationInfoWrapperTest
Flag: EXEMPT refactor
Change-Id: I55b964d4f8cfa1ff1770e310ac278719495e285d
2024-09-23 22:09:24 -07:00
Treehugger Robot 91af098288 Merge "[Predictive Back] Enable predictive back in AndroidManifest.xml" into main 2024-09-24 04:08:06 +00:00
Treehugger Robot e792bc3a5c Merge "Revert "Add support for taskbar background to wrap around hotseat"" into main 2024-09-24 00:57:04 +00:00
Jeremy Sim 26a0afe14f Merge "Fix bug with over-expanding split task tile" into main 2024-09-24 00:52:24 +00:00
Fengjiang Li 45d79db4d7 [Predictive Back] Enable predictive back in AndroidManifest.xml
Calling "getApplicationInfo().setEnableOnBackInvokedCallback(true)" is only suggested in tests.

Fix: 337985862
Flag: NONE - release feature fix
Test: manual
Change-Id: I336bdbe31c726b518d9342b1d39ef9e92f4dd498
2024-09-23 16:11:28 -07:00
Jon Miranda 9c09196dfd Revert "Add support for taskbar background to wrap around hotseat"
This reverts commit 5dc07d786f.

Reason for revert: b/360116669

Bug: 345768019
Change-Id: Id70ceed141e2106f746d4a0e68a09675ba45dd28
Fixes: 360116669
Test: open taskbar, open all apps w/ ime, use ime back button
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
2024-09-23 22:38:35 +00:00
Jeremy Sim 803a4a5bb1 Fix bug with over-expanding split task tile
This CL changes GroupedTaskView#onMeasure() to return more robustly in the case where a single task from a GroupedTaskView is staged.

See bug for fine details, but basically we no longer allow onMeasure() to re-bound the split task to fullsize in split selection state -- we leave it in half size all the time (with scale and translation applied). To allow it to stay scaled-up and translated properly across rotations and stuff, we now avoid resetting translation and scale until split select is exited.

Fixes: 365476600
Test: Manual test with offscreen tiles, rotations, fake landscape and seascape
Flag: NONE bugfix
Change-Id: I0ee8d13d310ed1f134f3f396bb87541a5ea685ef
2024-09-23 15:31:02 -07:00
Jagrut Desai d3460af469 Merge "Refctor DisplayController#handleInfoChange" into main 2024-09-23 19:43:02 +00:00
Jagrut Desai 94c9fb7cf5 Refctor DisplayController#handleInfoChange
Test: Presubmit
Bug: 369140181
Flag: EXEMPT refactor DisplayController#handleInfoChange
Change-Id: I196fe0e843a60c518d882c25f9fbdcd3cb775ba6
2024-09-23 09:58:30 -07:00
Alex Chau 6deccd8ef2 Don't return TYPE_RECENTS task in TopTaskTracker.getCachedTopTask
- We have no use-case to show TYPE_RECENTS (NexusLauncher or RecentsActivity) in Overview, stripping TYPE_RECENTS avoids accidentally showing RecentsAcitivty as a tile on swipe up

Fix: 355263037
Test: manually verify it doesn't break 3P Launcher; the bug itself cannot be verified as it cannot be easily reproduced
Flag: EXEMPT BUG_FIX
Change-Id: Id1b8e43dc7ddb9ad9c781b9a860fe4fba97d4be6
2024-09-23 16:15:01 +01:00
Treehugger Robot 344bf3fd24 Merge "Simple implementation of Taskbar Overflow." into main 2024-09-21 06:36:15 +00:00