Commit Graph

2330 Commits

Author SHA1 Message Date
Jon Miranda e734efba8d Fix bug where rounded corners were being set despite being disabled.
Bug: 138117089
Change-Id: Icb852e2e07d80c45ad3406ef432b89720887fccf
2019-07-24 17:15:13 +00:00
Jon Miranda bc27826478 Fix bug where icon is no present during app close animation.
* WindowTransformSwipeHandler closes all AbstractFloatingViews, including
  ListenerView, which results in FloatingIconView getting removed.
* In IconLoadResult.onIconLoaded, we remove the check for isIconLoaded since
  its not needed. This was also causing a race condition since isIconLoaded
  is not set to true until after we tell onIconLoaded to run.
* In BaseDragLayer, we have a delay before checking if the view is open and
  then closing the floating view if true. This caused issues since we reycle
  the view. Now we check if the view is open before running the delay to call
  close.

Bug: 136044361
Change-Id: I7442a589a62c3cdf90b70d146e0ecf3e4300ddf7
(cherry picked from commit 826cdcd32f)
2019-07-17 22:16:40 +00:00
Hyunyoung Song 3739fbccdc [DO NOT MERGE] Disable swipe down to pull noti shade for Q
Merged-In: I74c682d39c70f785777b5a0804b31a0cc2369759
Bug: 136293958

Change-Id: Iac169d91a784b5f2d05410a06cd358f85b533562
(cherry picked from commit 4bfcf04ae9)
2019-07-11 00:02:44 +00:00
Hyunyoung Song 0a8243d463 Reset the UI_STATE_OVERVIEW statusbar/navbar flag when RecentsView resets
Bug: 135383592

TL;DR;; this reset is called when for instance OMS call happens

Change-Id: I57bb6c1c8833aff00e3be572dd19744afbb81eb5
(cherry picked from commit 4abfbd0670)
2019-07-09 21:07:33 +00:00
Sunny Goyal a0967d21e6 Merging ub-launcher3-qt-dev, build 5697268
Test: Manual

Bug:135038270 P1 Apps getting stuck while switching in the overiew screen.
Bug:135885458 P1 Arrow floating when in app switcher
Change-Id: Ifa132ba008423a95291a17deea3d8e3846dbbacc
2019-06-28 18:46:48 -07:00
TreeHugger Robot 66b1cc9675 Merge "Revert "Enable FLAG_SLIPPERY window flag when swipe down on workspace"" into ub-launcher3-qt-dev 2019-06-28 23:28:44 +00:00
Winson Chung c4c8b3c695 Revert "Enable FLAG_SLIPPERY window flag when swipe down on workspace"
This reverts commit 35062f8ed3.

Reason for revert: Moving to R1

Change-Id: Ifd19d78015a66c9fbe9a67845232d13e011943d3
2019-06-28 23:17:18 +00:00
Sunny Goyal 7d3c299a08 Resetting UI state when the last has launched from Launcher
Bug: 135038270
Change-Id: I4a563116d8c7715163671dfffdfcf0f886e21623
2019-06-28 15:51:27 -07:00
TreeHugger Robot 0e188d051e Merge "Make it a bit harder to break out of Overview once triggered" into ub-launcher3-qt-dev 2019-06-28 22:07:03 +00:00
TreeHugger Robot ed9127a732 Merge "Resetting UI state when the last has launched" into ub-launcher3-qt-dev 2019-06-28 21:59:23 +00:00
Adam Cohen daf2036a82 Make it a bit harder to break out of Overview once triggered
Change-Id: I8814f1d7e219ba11a3abb191bf55192e3811f191
2019-06-28 14:57:09 -07:00
Sunny Goyal 4f2d926d42 Resetting UI state when the last has launched
Bug: 135038270
Change-Id: Ie0af9c7d47f69b32caedd72f98ed1706bdbef5fa
2019-06-28 14:50:24 -07:00
Sunny Goyal 1dae67b49d Fixing accessibility arrow
> Hiding arrow in background state and during quick switch
> Preventing arrow overlapping with search box in overview state

Bug: 135885458
Change-Id: Iadefba044717351d69480cde7d784cd04289d086
2019-06-27 23:18:46 -07:00
Winson Chung 5cd4333b5c Merging ub-launcher3-qt-dev, build 5691374
Test: Manual

Bug:115582915 P2 [Testing] Make all launcher tests gesture-stable
Bug:121280703 P2 Finish implementation of PortraitLandscape annotation for tests
Bug:124524897 P2 Enable some tests in OOP mode
Bug:129158983 P1 Badge bubbles with app icon; use launcher lib for icon, dot, badge rendering
Bug:131116002 P2 Convert tests to TAPL and enable them
Bug:131356741 P1 use transferFocus to implement SWIPE DOWN on homescreen to open noti shade
Bug:131360075 P1 [Gesture Nav] Polish/finish landscape
Bug:132309376 P1 Launcher held ION buffers after clearing all apps in Recent Apps
Bug:132455160 P1 [Gesture Nav] Home to Overview Transition Improvement
Bug:132461400 P1 Fatal exceptions in Launcher3
Bug:132811175 P1 Jump cut if you quickly open an app after going home
Bug:133450867 P1 App window draws outside of icon shape during app to home transition
Bug:133765434 P1 [Flaky test] Launching task didn't open a new window
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:134609899 P1 Overscrolling on all apps leads to a wrong current task
Bug:135011207 P0 Corner Invocation / Inconsistent - F/C
Bug:135150619 P1 [Launcher] Trigger heapdump on RSS HWM measurements
Bug:135150767 P4 [Launcher] Test reduced resolution snapshots
Bug:135161289 P2 KB3 on qt-dev can't pick Launcher3GoIconRecents from vendor Makefile
Bug:135222111 P1 Major issues with hotseat when predictions are disabled
Bug:135287203 P1 Overview crashes on rotation
Bug:135299165 P1 Configuration changes might result in Launcher ending up in a corrupt state
Bug:135472635 P2 Bad overriden class: java.lang.ClassNotFoundException: com.android.quickstep.QuickstepProcessInitializer
Bug:135473571 P0 Pixel launcher keeps stopping in SuW
Bug:135571566 P4 Search bar is above icons. Even opening and closing launcher does not help
Bug:135686388 P1 Quickswitch sometimes jump
Bug:135687556 P1 Increase assistant gesture touch region on new devices
Bug:135766310 P2 Concerns over config changes during state transitions #2
Bug:135769778 P1 "System navigation changed" notification is shown during P4 setup
2019-06-26 18:36:10 -07:00
Winson Chung 937688bff4 Merge "Enable FLAG_SLIPPERY window flag when swipe down on workspace" into ub-launcher3-qt-dev 2019-06-26 21:48:56 +00:00
Hyunyoung Song 35062f8ed3 Enable FLAG_SLIPPERY window flag when swipe down on workspace
Bug: 131356741
Test: manual

Change-Id: Ibe0e3a03e7406d5d882a1c63265d6e4e0253983e
2019-06-26 21:48:29 +00:00
Winson Chung 0b70cd4ca4 Finish recents animation when starting a new activity
- Defer starting the activity when an activity is paused, and finish
  the current animation to trigger launcher to be resumed

Bug: 132811175
Test: Swipe up and launch a new app
Change-Id: I78b76800052512eb93f69ccf0523f4d752a82ece
2019-06-26 14:01:56 -07:00
Winson Chung fad3823420 Merge "Clean up some more refs to thumbnail data" into ub-launcher3-qt-dev 2019-06-26 18:25:58 +00:00
Vadim Tryshev 8a532e0bec Merge "Taking screenshots for local tests for FallbackRecentsTest" into ub-launcher3-qt-dev 2019-06-25 23:43:19 +00:00
vadimt 26cfff41ba Taking screenshots for local tests for FallbackRecentsTest
Change-Id: I604e7e90f2146069827b520d44db1854edc7aa77
2019-06-25 16:26:33 -07:00
Winson Chung df9fc63e8c Clean up some more refs to thumbnail data
- Always return a copy of the task list to ensure that the model doesn't
  hold refs to the thumbnail data if it was loaded into the same task
- Always clear the task thumbnail data ref once the visibility of the
  task view changes to be invisible

Bug: 132309376
Test: Enter overview scroll to the end of the list, relaunch app and take
      heap dump

Change-Id: I4437fd30172a5fe2a78c111f780163a1e6bbbb54
2019-06-25 14:44:05 -07:00
Sunny Goyal 700dc99d9b Enabling simple gesture navigation for 3P launcher
In case of 3P launcher, swipe-up will go to Launcher and there will be
no way to reach overview.

Bug: 135769778
Change-Id: Ib2c6bb1b13e6055d30b7360ec077b0a2fece66ff
2019-06-25 13:25:30 -07:00
TreeHugger Robot 0348bc21ab Merge "Increasing assistant touch region based on the corner radius" into ub-launcher3-qt-dev 2019-06-22 01:05:42 +00:00
Vadim Tryshev f58d811e98 Merge "Revert "Enable @PortraitLandscape for testBackground"" into ub-launcher3-qt-dev 2019-06-22 00:40:23 +00:00
Vadim Tryshev 7946f55742 Revert "Enable @PortraitLandscape for testBackground"
This reverts commit b6e2cd8546.

Reason for revert: b/135567630

Change-Id: I4cd87356177a141c99e3865b8794de58386d0f49
2019-06-22 00:30:57 +00:00
Sunny Goyal e9f1f093c7 Increasing assistant touch region based on the corner radius
Bug: 135687556
Change-Id: I86f0cf3b0e6f3cd6608eab55be6ebf56bfdddf1c
2019-06-21 15:08:49 -07:00
TreeHugger Robot 37dc5b1936 Merge "Cleaning up some animation states:" into ub-launcher3-qt-dev 2019-06-21 22:05:28 +00:00
vadimt b6e2cd8546 Enable @PortraitLandscape for testBackground
Now that Recents rotation crash is fixed

Change-Id: Ibca9460e45fc533e414537f7923a2d09fc59f58a
2019-06-21 14:32:17 -07:00
Sunny Goyal c4bb3739b1 Cleaning up some animation states:
> When running one-off animations during quickstep, cancelling prevoisly
  running animations.
> Cancelling such one-off animations when state is reset
> Preventing touch proxied from recent transition to affect quickswitch
  (by affecting pagedView)

Bug: 135686388
Bug: 135571566
Change-Id: Id647015a583761d8fd46a02e3e2d88027e282a79
2019-06-21 12:47:56 -07:00
Vadim Tryshev b4ff312181 Merge "Tests: waiting for nav bar to match nav mode" into ub-launcher3-qt-dev 2019-06-20 21:39:32 +00:00
vadimt e244a5802d Tests: waiting for nav bar to match nav mode
Change-Id: Ib17fce4577e1e2c585108f0e95a98fad710e5eb2
2019-06-20 14:26:19 -07:00
Winson Chung 73769f0a88 Fixing rounding error when computing bottom clip
- In TaskThumbnailView.updateThumbnailMatrix() we compare the rounded
  scaled bitmap height with the height of the task/thumbnail view.
  Since the position is also non-integer, the rounding of the sum
  is not equivalent to the rounding of the individual components, which
  causes the check to fail.

Bug: 135150767
Test: Quickswitch on sargo
Change-Id: I849b4732569e5b8699f00f5ff210f41fb505f1e7
2019-06-20 20:06:24 +00:00
Sunny Goyal b80941bb24 Using FloatProperty for spring animation, instead of a interface
to allow easier generalization of animation definitions

Change-Id: I37b1a604003ec007aa390eabdfe8c1ab733b7471
2019-06-19 21:31:43 -07:00
Sunny Goyal 676a795ebd Merge "Some improvements to home to overview transition for 0 button mode" into ub-launcher3-qt-dev 2019-06-19 22:20:05 +00:00
Winson Chung b703f91f83 Merge "Trigger heap dump when heap exceeds a limit" into ub-launcher3-qt-dev 2019-06-19 22:09:44 +00:00
Tony Wickham 59c6901823 Some improvements to home to overview transition for 0 button mode
- Peek in overview further, and with more overshoot
- Fade out and scale down workspace faster while swiping up
- Scale and translate workspace slower when letting go to enter
  overview (so it doesn't zoom out at warp speed)
- Fade in all apps shelf sooner

Bug: 132455160
Change-Id: Ieafad0ccf9bb587889bc35d536627661db10e358
2019-06-19 14:48:57 -07:00
Miranda Kephart 035770e421 Merge "Allow shallow-angle flings in AssistantTouchConsumer" into ub-launcher3-qt-dev 2019-06-19 19:25:23 +00:00
Miranda Kephart 7d2aed0cb5 Allow shallow-angle flings in AssistantTouchConsumer
While any angle above 22 degrees from horizontal is permitted for
drag invocations, the SwipeDetector used to detect flings only
allowed angles within 45 degrees of vertical. This changes to using
GestureListener and permits flings in the 22-45 degree region (as
well as up to vertical).

Test: manual
Bug: 135011207
Change-Id: I8e08650395917341869b27ff381f32268fadcb3c
2019-06-19 15:13:03 -04:00
Winson Chung e069291ecd Trigger heap dump when heap exceeds a limit
Bug: 135150619
Change-Id: I2b207bed1f66407f573abeae879aae34e98741bd
2019-06-19 11:58:30 -07:00
TreeHugger Robot a9a0dd7f3f Merge "Fix bug where recents animation is out of sync." into ub-launcher3-qt-dev 2019-06-19 15:37:21 +00:00
Tony Wickham 01a4c80c40 Merge "Fix bugs with hotseat in overview" into ub-launcher3-qt-dev 2019-06-18 21:51:54 +00:00
Tony 32cb616fab Fix bugs with hotseat in overview
- Allow touches to go through recents to the hotseat.
- Translate the hotseat with the all apps shelf when swiping
  up in background app state.

Bug: 135222111
Change-Id: Ib887fc25ccfeb406a44074198c11f7b1d245443c
2019-06-18 13:41:08 -07:00
Rajeev Kumar 873759a316 Merge "Add QuickstepProcessInitializer back to common src" into ub-launcher3-qt-dev 2019-06-18 12:09:55 +00:00
Winson Chung 398184c104 Adding check for no default home before registering new receiver
Bug: 135473571
Test: Manual, try restarting with no default launcher set?
Change-Id: Ibb68070ee95ca856b38a74823bcbfbc7890f329e
2019-06-18 01:21:44 +00:00
Kevin 71f06807a4 Add QuickstepProcessInitializer back to common src
While removing unused files in Go version of quickstep, I removed
QuickstepProcessInitializer which seemed unused but is actually
initialized as a resource based ovverride. This CL puts it back as
common src so that both Launcher3GoIconRecents and the rest of the
variants all use this class.

Bug: 135472635
Test: Run Launcher3GoIconRecents => no exception
Test: Run Launcher3 => no exception
Change-Id: I56f319bac536ec4da96285fab932fe574afa4520
2019-06-17 17:22:56 -07:00
Winson Chung 5ce8c9f73b Adding check for no default home before registering new receiver
Bug: 135473571
Test: Manual, try restarting with no default launcher set?
Change-Id: Ibb68070ee95ca856b38a74823bcbfbc7890f329e
2019-06-17 17:07:44 -07:00
TreeHugger Robot e1abaa64c2 Merge "TaskThumbnailView - post updates to overlays." into ub-launcher3-qt-dev 2019-06-17 23:02:18 +00:00
Zak Cohen 5095684e22 TaskThumbnailView - post updates to overlays.
Post the update of the overlay to handler.
No way of knowing if an overlay will add / remove views during the update
so assume its not safe to do in layout.

Bug: 135287203
Test: manual
Change-Id: I7bd0c86da096e7108b71b2d0530e99ee950d6f2e
2019-06-17 15:27:28 -07:00
vadimt 06d30e54d5 Enabling tests in landscape mode
Bug: 121280703
Change-Id: I3245ca8d0b0496035658ce2a602882a62942f3f1
2019-06-17 15:13:25 -07:00
Sunny Goyal 1461f48ef2 Merging ub-launcher3-qt-dev, build 5662436
Test: Manual

Bug:109954539 P4 Clock widget is not adaptively changing color based on wallpaper
Bug:122345781 P1 Inflation happens and a binder call during swipe up gesture, that may cause jank
Bug:130687624 P1 [B1C1][B4S4][QT][CTS-Verifier]OTHER-Screen Pinning Test
Bug:131698448 P2 Launcher makes a binder call to check Keygaurd.isDeviceLocked
Bug:132900132 P1 Apparently, tests start running while provisioning is still in progress
Bug:132906035 P1 [Metrics] add Home / Back button events even when Launcher is in the background
Bug:132915522 P1 Snap the window to the bottom if touch Y is below a threshold
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:134172603 P1 Tracing for lab-only flakes
Bug:135130011 P1 16ms delay when opening app due to dynamic icon loading
Bug:135214165 P1 Quickstep slop do not respect density changes
Bug:135257548 P1 Adding shortcut can crash Launcher
Bug:64712476 P3 Import translations for dev branches
Change-Id: I9af1d8260b45fba32841877d88bad5a53f2e5746
2019-06-17 07:51:19 -07:00