Commit Graph

14994 Commits

Author SHA1 Message Date
Treehugger Robot e70ea33de1 Merge "Make displaylib handler and coroutine scope singletons" into main 2025-05-27 10:37:42 -07:00
Xiaoqian (Daisy) Dai d108ef020b Merge "desktop-exploded-view: Fix various values for Task windows in desktop tile." into main 2025-05-27 09:25:51 -07:00
Saumya Prakash a272ff81ad Merge "Report lower insets for SUW if expressive theme enabled" into main 2025-05-27 08:57:52 -07:00
Will Osborn ef04a08427 Make displaylib handler and coroutine scope singletons
Bug: 407205884
Test: locally tested
Flag: EXEMPT bugfix
Change-Id: Ic4d8fd429d0f647c8a4d6a3dcf5ec16fa8014455
2025-05-27 14:55:43 +00:00
Cosmin Băieș 6396824a0c Merge "Remove unused imeDownButton in taskbar" into main 2025-05-26 02:59:59 -07:00
Tony Wickham 84cd5182ba Merge "Migrate some logs to OverviewCommandHelperProtoLogProxy" into main 2025-05-23 22:44:08 -07:00
Treehugger Robot d5b20e3940 Merge "Add recents animation start timeout handling to TaskAnimationManager" into main 2025-05-23 19:10:36 -07:00
Treehugger Robot 52608ce7cb Merge "pin-shortcut: Use unpin option for AllApps apps that are pinned" into main 2025-05-23 18:27:54 -07:00
Sebastián Franco aeab3c0d79 Merge "Revert "Revert "Moving DeviceProfile properties into DevicePrope..."" into main 2025-05-23 17:03:18 -07:00
Treehugger Robot 1d9cb00059 Merge "Fix a crash on home with autostashed taskbar" into main 2025-05-23 16:56:18 -07:00
Wen-Chien Wang 9942721299 pin-shortcut: Use unpin option for AllApps apps that are pinned
For the apps in All apps view, if the app is already pinned in the
taskbar, we should show the unpin option for users to unpin it
instead of a pin option that is no-op.

Bug: 375648361
Bug: 418058610
Test: manual + TaskbarPopupControllerTest
Flag: com.android.window.flags.enable_pinning_app_with_context_menu
Change-Id: I770afcf3abd6cb08c574230d27c4cbcbb83b29a6
2025-05-23 23:00:30 +00:00
Xiaoqian (Daisy) Dai a66268c9fc desktop-exploded-view: Fix various values for Task windows in desktop tile.
To match with the UX spec, this CL updates the insets based on the
number of tasks within a tile. It also sets a maximum height to the
task window when multiple apps are available.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: OrganizeDesktopTasksUseCaseTest
Bug: 414614454
Change-Id: Icfecc1e41dfd0b95bae10b495adae95fe10dfef2
2025-05-23 14:09:05 -07:00
Sebastián Franco e1d31e5406 Revert "Revert "Moving DeviceProfile properties into DevicePrope..."
Revert submission 33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Reason for revert: Error is fixed

Reverted changes: /q/submissionid:33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Change-Id: Ib86824134955903c11e51e52dbfd6368aba1cd50
2025-05-23 14:08:11 -07:00
Priyanka Advani (xWF) 1bec329180 Merge "Revert "Moving DeviceProfile properties into DeviceProperties da..."" into main 2025-05-23 14:03:53 -07:00
Priyanka Advani (xWF) 7705e92d93 Revert "Moving DeviceProfile properties into DeviceProperties da..."
Revert submission 33672643-DataDeviceProfile1

Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.

Fix: 419867875

Reverted changes: /q/submissionid:33672643-DataDeviceProfile1

Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
2025-05-23 13:53:04 -07:00
Treehugger Robot becba58cff Merge "Use expressive dismiss for clear all." into main 2025-05-23 13:43:53 -07:00
Sebastián Franco b80423b1b7 Merge "Moving DeviceProfile properties into DeviceProperties data class" into main 2025-05-23 13:17:32 -07:00
Saumya Prakash 7adea11bfa Report lower insets for SUW if expressive theme enabled
This change addresses the desire to lower the footer for SUW content if
the expressive theme is enabled in SUW. This would remove the extra gap
at the bottom of the screen.

Fix: 409897759
Test: Enable expressive theme and relaunch SUW. Check that the bottom
buttons are closer to the bottom edge of the screen.
Flag: EXEMPT bugfix

Change-Id: I7a4961549ec888e57c89a564028843f1e8c0000b
2025-05-23 20:06:14 +00:00
Li Lin 9f40588951 Merge "Add a auto hide flag for Growth Framework nudge." into main 2025-05-23 10:44:24 -07:00
Sebastian Franco e1111e28c2 Moving DeviceProfile properties into DeviceProperties data class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I638f88cd76b926917965dbf9e70b5bdfff5971e0
2025-05-23 10:42:26 -07:00
Toni Barzic bfe4503e9e Fix a crash on home with autostashed taskbar
Check whether autostash is disabled after init due to dependency on
destkop mode controller when taskbar is shown on home with
enable_desktop_taskbar_on_freeform_displays flag disabled.

Bug: 419824639
Test: see repro steps in the linked bug
Flag: EXEMPT bugfix
Change-Id: I53a1f00cef705f291c5e79c32d6508c5d832d45e
2025-05-23 16:50:00 +00:00
Treehugger Robot 2a4ad7f8a1 Merge "Share buttons change" into main 2025-05-23 08:47:09 -07:00
Treehugger Robot f8b3677c45 Merge "Don't launch a coroutine job if no jobs to cancel" into main 2025-05-23 06:44:33 -07:00
Helen Cheuk 73661fda2e Merge "[Action Corner] Add padding between action corner and taskbar" into main 2025-05-23 06:35:28 -07:00
Pat Manning 8cb1be9873 Use expressive dismiss for clear all.
Fix: 416446763
Test: TaplTestsQuickstep
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I6781e54901aa33d5f206fcb601cac76e99eee84f
2025-05-23 14:17:23 +01:00
Uwais Ashraf 7d640afaba Don't launch a coroutine job if no jobs to cancel
Flag: com.android.launcher3.enable_coroutine_threading_improvements
Bug: 417598777
Test: Presubmits
Change-Id: I474e3e12faf2886b593571e9625a1d16df742c0d
2025-05-23 10:50:38 +00:00
Vinay Joglekar 0b87a41376 Share buttons change
Update Share Button and Share Targets to support Blur background

Fix: 408439461
Test: Open chrome with a webpage, tap on smart chip
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: If9290676377a3a48a94800ac3084c52146b0c9ae
2025-05-23 09:48:40 +01:00
Treehugger Robot 1521df031c Merge "Remove RenderEffect on blur targets when no blur is desired." into main 2025-05-22 17:37:27 -07:00
Sebastián Franco 957fac9f54 Merge "Prevent recents rotation animation if we are in Fixed Landscape" into main 2025-05-22 15:08:11 -07:00
Pierre Barbier de Reuille 06ed9c93d4 Merge "Use the developer-option flag for pin to taskbar" into main 2025-05-22 15:01:03 -07:00
Sebastian Franco 376d628859 Prevent recents rotation animation if we are in Fixed Landscape
When in this mode we can let the system rotate the device. In other
cases we have a fake rotation and so we need to manually rotate.

Fix: 401484242
Flag: com.android.launcher3.one_grid_specs
Test: Manual testing
Change-Id: I74e5cb0363a34edb69b39f9a387b9020116d5632
2025-05-22 11:46:57 -07:00
Pat Manning 7207047000 Speed up dismiss springs on subsequent touches while blocking touch.
- This allows users to dimiss multiple apps as quickly as they want.
- Do not reset task dismiss translation if it is actively being dragged.

Fix: 409485085
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I939ef402ee23b3b1e8df1ae214c5ac60386a7772
2025-05-22 16:54:20 +01:00
helen cheuk 6e5225bd77 [Action Corner] Add padding between action corner and taskbar
This is to avoid triggering unstashing taskbar and action corner at the same time.
A padding is added between the two areas.

Bug: 411091884
Test: TaplTestsTransientTaskbar
Flag: com.android.systemui.shared.cursor_hot_corner

Change-Id: I4e380a3d004977c96502af23f6126f22749e0a8f
2025-05-22 12:23:34 +00:00
Pierre Barbier de Reuille b8c5350c07 Use the developer-option flag for pin to taskbar
Test: Manual
Flag: com.android.window.flags.enable_pinning_app_with_context_menu
Bug: 375648361
Change-Id: I2c26ae6a5f42fd01860d7534b86ff5ca11e7f7fc
2025-05-22 03:29:34 -07:00
Lucas Dupin 66923a912c Merge "Add recents position callback to SystemUiProxy" into main 2025-05-21 23:11:59 -07:00
Treehugger Robot 51291ec848 Merge "Create the RemoteTargetGluer based on the GroupedTaskInfo" into main 2025-05-21 22:57:56 -07:00
Tony Wickham e9ef7ad43c Migrate some logs to OverviewCommandHelperProtoLogProxy
This will allow us to see the logs in Winscope, including frame by
frame to make debugging easier.

Also added a log for Launcher#onNewIntent to help with Home button.

Test: EXEMPT log only update
Bug: 417248321
Bug: 384423890
Flag: NONE log only update
Change-Id: Ib24aeb78e44ff29542eb25411c51f77dba299a2e
2025-05-21 15:32:03 -07:00
Andy Wickham 492a170aaf Remove RenderEffect on blur targets when no blur is desired.
This change replaces 0 blur radius RenderEffect with null RenderEffect
when no blur is needed. This is because even a 0 radius RenderEffect
forces the targets to be rendered on a separate layer, which clips to
the view bounds (overriding clipChildren="false") and likely creates
a hit to performance.

Demo: https://drive.google.com/file/d/1fuFP_yaqU2KSd28aUhpuopQg6KlMKv_w/view?usp=sharing&resourcekey=0-GWMy5kKhYVo-5u69XTzihQ

Fix: 413784556
Bug: 413359333
Bug: 416815515
Test: enable all apps blur, enter spring loaded from All Apps and home
Flag: com.android.launcher3.all_apps_blur
Change-Id: I85b0ef6c8556866821679f2f02adb4938c6431d1
2025-05-21 15:27:44 -07:00
Jordan Silva 3d348a0d27 Add focus border animation to IconAppChipView
Fix: 366177160
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual using Keyboard. Access the app chip via TAB and navigate through the task menu.
Test: Manual using Mouse. Hover over the Chip and the Task Menu.
Change-Id: I785ad8723e5255186d744a20992ac0cd0968b380
2025-05-21 14:20:49 -07:00
Lucas Dupin 02c6fd6604 Add recents position callback to SystemUiProxy
Flag: com.android.systemui.enable_underlay
Test: atest AmbientCueRepositoryTest
Test: atest AmbientCueInteractorTest
Test: atest AmbientCueViewModelTest
Test: atest TaskbarNavButtonControllerTest
Bug: 415914274
Bug: 415914083
Change-Id: Ie6c7412d3bbc9cd64e4c9993db47821962e1b1fc
2025-05-21 14:04:18 -07:00
minch ded5807543 Create the RemoteTargetGluer based on the GroupedTaskInfo
Determine whether a `RemoteTargetGluer` for desktop should be
created based on GroupedTaskInfo instead of
`RecentsAnimationTargets.hasDesktopTasks`. The latter one is
inaccurate to assume that a desk may only have FREEFORM tasks.

Bug: 400866688
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: m
Change-Id: I6f35f41204790ada59317e0b4bd0a8965c9718eb
2025-05-21 13:42:08 -07:00
Schneider Victor-Tulias 124b010ea9 Add recents animation start timeout handling to TaskAnimationManager
In cases where a recents aniamtion transition was successfully requested but failed to start, we should clean up the gesture state to recover.

Flag: EXEMPT bug fix
Fixes: 415930274
Test: TaskAnimationManagerTest.testRecentsAnimationStartTimeout_cleansUpRecentsAnimation
Change-Id: If1a24d6c7baac7338c49056531bc01665f082ddf
2025-05-21 15:55:44 -04:00
Schneider Victor-Tulias 6d532fe59d Fix broken state when tapping nav handle from running app.
When tapping the nav handle from running app, OtherActivityInputConsumer will start the recents window through TaskAnimationManager. The recents window would then typically be closed through the StateManager, however since the state isn't changing, then RecentsWindowManger never actually gets any signal to close the recents window. Added a new callback to fix this flow.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit tests. tapped nev handle from a runnign app
Change-Id: If1fe7de195a9a8a98c72629c7904d469a5768d7f
2025-05-21 10:35:11 -07:00
Jordan Silva e14014cc88 Merge "Fix task icons sometimes not appearing in recents view" into main 2025-05-21 10:09:00 -07:00
Treehugger Robot 57de0ebf21 Merge "Make sure RecentsWindowManager is created for TaskbarUIController" into main 2025-05-21 09:56:04 -07:00
Helen Cheuk 444161df77 Merge "[Action Corner] Make home action corner irreversible" into main 2025-05-21 09:13:31 -07:00
Treehugger Robot 10b72a252d Merge "Revert "Temporarily revert allowing recents view to reapply load state"" into main 2025-05-21 07:15:41 -07:00
Alex Chau f29a8dd4e2 Make sure RecentsWindowManager is created for TaskbarUIController
Bug: 418965555
Flag: EXEMPT bugfix
Test: local + presubmit

Change-Id: Ib45df9c0f04534cd88a1b2ae1ff4ab49f8999dff
2025-05-21 14:13:20 +00:00
Treehugger Robot 2cc2843f03 Merge "Dismiss task on default display if it is moved to external" into main 2025-05-21 06:45:24 -07:00
helen cheuk 9598e4c78c [Action Corner] Make home action corner irreversible
The go home action for action corner should be irreversible for now.
When home action corner is triggered at homepage, it should just stay at homepage and would not go back to previous task.
Add flag for the reversible behavior for non-desktop mode home action corner. It is to be completed with dekstop mode in later release.

Bug: 397182595
Test: ActionCornerHandlerTest
Flag: com.android.launcher3.enable_reversible_home_action_corner
Change-Id: Ib36581d0d3d81d4a7ff8f8d6265d8d5d5f5872fd
2025-05-21 14:26:01 +01:00