Commit Graph

71 Commits

Author SHA1 Message Date
Alex Chau eececf272e Merge "Reset mTopRowIdSet in applyLoadPlan" into main 2024-08-22 09:49:27 +00:00
Alex Chau 9109b81a95 Reset mTopRowIdSet in applyLoadPlan
- All taskViewIds become obsolete after removing and re-adding, so we'll need to reset mTopRowIdSet when removing all taskViews
- OverviewActionsView.updateActionButtonsVisibility can be called before updateDimension (where mDp is set), so a null check is necessary
- Fixed TestStaibilityRule failing when running FallbackRecentsTest alone. FallbackRecentsTest runs with 3P Launcher, in that case launcherPackageName is our test activity, and launcherVersion can be null. This can only occur in a local run, thus return LOCAL in this case.

Fix: 355042336
Test: FallbackRecentsTest and manually testing dismiss
Flag: EXEMPT BUG_FIX
Change-Id: I9125ea38a567deb0d3028e7d7407397d1dc06ade
2024-08-21 12:37:14 +01:00
Sihua Ma 58e8573085 Migrate model tests to multivalent
Also migrating some other tests that have been verified

Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I072201b8e7b98945ca88657fe813fef4727f16e4
2024-08-20 07:28:35 +00:00
Uwais Ashraf 60b62d734d Improve performance of thumbnail retrieval - hot taskData flow
Bug: 357542209
Test: TasksRepositoryTest, manual with reduced speed video
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ie94daf61d8e41c4b9c12d67f5f45166104879325
2024-08-12 16:49:24 +00:00
Shamali Patwa b4d185e3cc Merge changes from topic "popup-refactor" into main
* changes:
  Delete the unused code from popup provider
  Update references that read popup data provider to use picker provider
  Update references that wrote widget data to popup data provider
  Move widget related listeners to widget picker data provider
  Define widget picker data provider separate from popup provider
  Create a separate class for widget related methods from popup provider
2024-07-24 18:46:35 +00:00
Shamali P 74d9fbd635 Define widget picker data provider separate from popup provider
Separate provider in ActivityContext and relevant implementations that
open widget picker

Bug: 353347512
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: I55df3d9ce6ae9b7d0a310a8686b188618d229065
2024-07-22 23:58:04 +00:00
Sihua Ma 587aa05f04 Fix an issue in SimpleBroadcastReceiverTest
Main thread tasks should be idled before verification

Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I6db696c73be2e9689dd290fd1a8c4deffa17ff01
2024-07-22 23:09:17 +00:00
Andrew Cole 6beb1964a4 Merge "Test Week - ShortcutUtilTest" into main 2024-07-22 13:42:14 +00:00
Fengjiang Li 2b5deb2fb9 Merge "[Test Week] Add VibratorWrapperTest" into main 2024-07-19 23:28:13 +00:00
Andrew Cole 9b3b54eb40 Test Week - ShortcutUtilTest
Adding simple tests for ShortcutUtils
* 1 New Class Covered
* 4 Methods Covered

Bug: 353303621
Test: ShortcutUtilTest
Flag: TEST_ONLY
Change-Id: I3f2fbb592cc5abe18524c3883fb0a0e96912fdfb
2024-07-19 23:04:03 +00:00
Fengjiang Li 979adecc7b [Test Week] Add VibratorWrapperTest
Number of new tested methods: 9

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Id6dde920d6365823cf859e97c7c0cfbb25e7270d
2024-07-19 14:10:32 -07:00
Fengjiang Li 1749bf0308 Merge "[Test Week] Add missing @RunWith(AndroidJUnit4.class) annotation" into main 2024-07-19 17:07:39 +00:00
Fengjiang Li 74861537f6 Merge "[Test Week] Add ScreenOnTrackerTest" into main 2024-07-19 17:07:26 +00:00
Marcelo Arteiro f38d98d1a6 Align color resources in launcher projects.
This is an effort to align/unify color usage across all launcher projects and the system itself.
This fix recreates all dynamic color attributes present in the OS since many launcher areas cannot access private attributes.
It is recomemnded to use these new local attributes in all launcher areas and avoid creating new color resources when these can be used directly.

Bug: 352690172
Test: Presubmits
Flag: EXEMPT bugfix
Change-Id: Ic36b8bf70ee37f2fdd32e459e66f0e2d001d6ba2
2024-07-19 14:22:21 +00:00
Fengjiang Li b7b3137261 [Test Week] Add ScreenOnTrackerTest
Number of new tested methods: 5

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Ieae1ed9bb215a52a12fef919c8dd407291c2b0f9
2024-07-19 00:49:58 -07:00
Fengjiang Li cda1c12ebe [Test Week] Add missing @RunWith(AndroidJUnit4.class) annotation
Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Ieb8f8ac3a8a94defe5f9ed2b8ca9812fd2ac1ba6
2024-07-18 22:29:18 -07:00
Fengjiang Li 3a33017797 Merge "[Test Week] Add SystemUiControllerTest" into main 2024-07-19 03:00:19 +00:00
Fengjiang Li a74d9d74c9 Merge "[Test Week] Add ViewPoolTest" into main 2024-07-19 00:33:38 +00:00
Fengjiang Li 5337a1ba31 Merge "[Test Week] Replace verifyZeroInteractions with verifyNoMoreInteractions in RunnableListTest" into main 2024-07-19 00:31:51 +00:00
Fengjiang Li f257aef6d7 [Test Week] Add SystemUiControllerTest
Number of new tested methods: 4

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I2c2b8101853b4b5a6562fe26dfa6b7358f0be17e
2024-07-18 15:47:26 -07:00
Fengjiang Li 5ad7a20e90 [Test Week] Add ViewPoolTest
Number of new tested methods: 3

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I13f1a7bad41c07368cff3d544120d1f41c92b603
2024-07-18 15:25:07 -07:00
Fengjiang Li 2eeb08f216 [Test Week] Replace verifyZeroInteractions with verifyNoMoreInteractions in RunnableListTest
Fix: 354021767
Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I85945c0a0f64ca0a65d28d66f3c47d83d0943c3b
2024-07-18 15:05:10 -07:00
Fengjiang Li f28a059e5b Merge "[Test Week] Move SimpleBroadcastReceiver to multivalentTests folder" into main 2024-07-18 21:06:30 +00:00
Fengjiang Li 5c4c3bcbf3 [Test Week] Move SimpleBroadcastReceiver to multivalentTests folder
Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I82a59b6d090df7a246ba283bbfa286c99417c876
2024-07-18 09:20:49 -07:00
Charlie Anderson 48ff57d7d1 [Test week] unit tests for ItemInfoMatcher
7 public methods tested
no previous test class

Flag: TEST_ONLY
Bug: 353303621
Test: unit tests
Change-Id: Ie327ab790b46326ee97165706c126c8ad0de7776
2024-07-18 11:59:01 -04:00
Fengjiang Li a92b80f357 Merge "[Test Week] Move ViewCacheTest.kt to multivalentTests folder" into main 2024-07-17 16:55:38 +00:00
Fengjiang Li 9569f54008 [Test Week] Add RunnableListTest
Number of new tested methods: 5

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I546a775530cdf61424f1047e81e79c28fa7c63e4
2024-07-16 15:26:36 -07:00
Fengjiang Li 6cd7630504 [Test Week] Move ViewCacheTest.kt to multivalentTests folder
Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Ie969e9bffecf61bbcfd7b2132ef7a5df1d97cbed
2024-07-16 11:36:31 -07:00
Sihua Ma 73c766d75d Migrate responsive tests to multivalent
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: TEST_ONLY
Fix: 325088640
Change-Id: I32cce09ff7ef070b6c86b6440723006b5cb503cf
2024-06-13 09:48:09 +00:00
Treehugger Robot e8638f4eb2 Merge "Run UiThreadTest in LauncherMultivalentJUnit" into main 2024-06-05 17:02:46 +00:00
Sihua Ma 3b2a136272 Run UiThreadTest in LauncherMultivalentJUnit
Additionally migrating DisplayControllerTest to multivalent

Flag: TEST_ONLY
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Change-Id: I9ff89218947b32f79b39bb0e6dd4beabec3b7369
2024-05-30 23:11:29 +00:00
Sihua Ma 9d093d5b57 Replace verifyZeroInteractions with verifyNoMoreInteractions
Also migrating LockedUserStateTest and AbstractFloatingViewHelperTest
to multivalent

Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: TEST_ONLY
Bug: 297950111
Change-Id: Ic476de791109e7892c86bf5ae77727fc0506f0b9
2024-05-29 22:03:43 +00:00
Sihua Ma 1159c2546f Reapply "Move widget picker tests to Robolectric"
This reverts commit 97ee134acc.

Reason for revert: Fixed an issue with UI_HELPER_EXECUTOR that caused the flakiness

Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: None Test migration
Fix: 325088642
Fix: 325088805
Fix: 325089116
Fix: 325088960

Change-Id: I2f50c30d2c861e3bba8a8fa3ec547ca2ade6153a
2024-05-22 19:41:11 +00:00
Uwais Ashraf fe2107c59d Merge "Revert "Move widget picker tests to Robolectric"" into main 2024-05-21 23:05:12 +00:00
Uwais Ashraf 97ee134acc Revert "Move widget picker tests to Robolectric"
This reverts commit efc24f9251.

Reason for revert: Potential cause for flakiness https://android-build.corp.google.com/test_investigate/?invocationId=I07000010279081631&testResultId=TR32129311605132927

Change-Id: I4f0154bc101b6bc840c11ff0b6bf42f4ebc5ed03
2024-05-21 19:44:41 +00:00
Uwais Ashraf 784b4f28b0 Fix some compile errors occurring as a result of robo enablement
Fix: 297950111
Test: :NexusLauncher.Robo:testGoogleWithQuickstepDebugUnitTest
Test: atest NexusLauncherRoboTests
Flag: NA
Change-Id: Ic9b09fff630d274558d09b7031d12ec28f10fbc7
2024-05-21 18:56:52 +00:00
Sihua Ma efc24f9251 Move widget picker tests to Robolectric
Test: atest Launcher3RoboTests
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: NONE test migration
Bug: 297950111
Change-Id: I9124d4f45feb0ded74ffe2e0aabffdf98459ff4f
2024-05-20 21:20:32 +00:00
Sunny Goyal 25f5e29418 Adding support for importing/exporting launcher layout
Bug: 338282246
Flag: None
Test: Manual, developer feature
      atest AutoInstallsLayoutTest
Change-Id: I8a5674080f3c156d97bc6118c51532c2fe8177d5
2024-05-16 15:24:41 -07:00
Sunny Goyal 0f4bc92653 Creating a custom runner for multivalent tests with Launcher specific features
Bug: 338128923
Test: Verified by modifying a test
Flag: None
Change-Id: I1f04e28847ff9c0f7af3c0d952038ad24d03c17e
2024-05-06 12:10:21 -07:00
Sunny Goyal 86145f49fb Adding a special runner to run simulate multiple devices when running robo tests
Bug: 338128923
Test: Verrified by modifying a test
Flag: None
Change-Id: I133842d68e437b971da39e2081c8859515463cd3
2024-05-03 15:54:40 -07:00
Sunny Goyal 993893895c Converting ModelTask to an interface instead of an abstract class
This allows extensibility and better use of lambdas

Bug: 338282246
Test: Presubmit
Flag: None

Change-Id: Ia41067f0068b3b631eeb4faf877dc77f8587e1f6
2024-05-01 15:43:26 -07:00
Sunny Goyal fdae170684 Fixing robolectric tests not running on UI thread after changing looper mode
Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: I9351474ba4d377e8e9539f9b3d22d5ba15ac6a44
2024-04-24 16:42:30 -07:00
Sunny Goyal 10fa016352 Fixing MainThreadInitializedObject
> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class

Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
2024-04-22 17:04:33 -07:00
Sunny Goyal 4a22ed81ea Using resource overrides for PluginManager instead of code-swap
Bug: 330920490
Test: Presubmit
Flag: None
Change-Id: Ib1cd50f95873928b9ce104e8e95d21f1dca9c6e3
2024-04-12 11:38:32 -07:00
Sunny Goyal 8049369af8 Freezing legacy feature flags
Legacy feature flags will be locked to their current values in code.
All new feature development should use aconfig flags

Bug: 332588958
Flag: None
Test: Presubmit
Change-Id: Ie72dd8276b7135620de279835d6721a34f82ede4
2024-04-09 15:26:07 -07:00
Sunny Goyal 8ecbaa422f Merge "Moving various nav-bar configs out of feature flags" into main 2024-04-09 05:45:21 +00:00
Sunny Goyal 89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00
Vadim Tryshev 785da8d60a Restoring the full set of combinations in testDragShortcutToMultipleWorkspaceCells in presubmit
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib345c94c79c7dda72283eb03515cd254e31e7c0b
2024-04-01 18:01:54 -07:00
Sunny Goyal 5ca50490a3 Making some classess accessible in multivalent tests
Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: I2e4b18fc279cb96b3f68d64f95703c11bb885b2a
2024-03-20 13:30:40 -07:00
Uwais Ashraf cf70589921 Merge "Enable tests which do not require any modification" into main 2024-03-13 15:42:07 +00:00