Commit Graph

20026 Commits

Author SHA1 Message Date
Alex Chau e6eca9c195 Promote TaplTestsQuickstep.testBackground to presubmit
- http://android-build/test_hub/search/?filter=&invfilter=unhealthyInvocations&invfilter=staleInvocations&query=test%3Acom.android.quickstep.TaplTestsQuickstep%23testBackground
- Latest result is <0.5% flaky

Bug: 364036214
Test: presubmit
Flag: EXEMPT TEST_ONLY
Change-Id: I97315a23e09c75a5f72cd3f6c959607598d9222d
2024-09-02 19:08:59 +01:00
Luca Zuccarini d75eacf30d 3/3 Move some Shell utils to the Shared package.
Bug: 322791067
Flag: EXEMPT move only
Test: NA
Change-Id: Iabc42e4c1d9c13667e9d91be5789cf295f3332e1
2024-09-02 09:23:34 +00:00
Ats Jenk ba6c9f06ed Merge "Scale bubble bar to the width of the handle" into main 2024-08-30 23:06:43 +00:00
Schneider Victor-tulias a4ce092bea Merge "Add a test base for AbsSwipeUpHandler and its subclasses" into main 2024-08-30 20:48:09 +00:00
Tracy Zhou 98febb5fa4 Merge "Skip updating taskbar background alpha in phone mode" into main 2024-08-30 20:31:27 +00:00
Ats Jenk dff855e702 Merge "Update bubble bar stash and unstash animation" into main 2024-08-30 19:30:14 +00:00
Mady Mellor 669445f707 Merge "Don't show the app badge on app bubbles" into main 2024-08-30 19:08:24 +00:00
Schneider Victor-tulias f5035847b1 Add a test base for AbsSwipeUpHandler and its subclasses
- Added a few basic tests for scenarios that should be contant across subclasses. These tests will not run on their own, they will only run when a subclass' test suite is run.
- Added test suites for LauncherSwipeHandlerV2 and FallbackSwipeHandler

Flag: EXEMPT adding tests
Bug: 353763639
Test: LauncherSwipeHandlerV2Test, FallbackSwipeHandlerTest
Change-Id: Ib44199f5d5281a544b433649d6ed49ae2a65ed70
2024-08-30 14:14:03 -04:00
Ats Jenk da9e36e4e7 Scale bubble bar to the width of the handle
When animating bubble bar from the stash handle, scale the width to the
handle.
Bubble bar is already almost the size of the handle, but a small scale
is still added.

Bug: 345488489
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest TransientBubbleStashControllerTest
Test: slow animations down and unstash and stash bubble bar, observe
  that the width of the bubble bar scales down to the handle
Change-Id: I54dc228fa41d4d494bfb15e191d2ba563c0970c7
2024-08-30 10:17:29 -07:00
Mady Mellor 3808adc58c Don't show the app badge on app bubbles
Flag: com.android.wm.shell.enable_bubble_anything
Test: manual - add an app bubble to bubble bar, observe it's not
               badged (with sysui CL)
Bug: 342245211
Change-Id: I768fa9bb478eeaba587b90d478f32f8c2ee88be1
2024-08-30 09:52:45 -07:00
Mady Mellor c4c5057c08 Merge "Follow RegionSamplingHelper being moved into shell" into main 2024-08-30 16:49:32 +00:00
Treehugger Robot 5b0e061b4e Merge "Only refresh TaskThumbnailViewDeprecated if runningTaskShowScreenshot has changed" into main 2024-08-30 15:46:20 +00:00
Treehugger Robot 5a5ff5235f Merge "Fixes wrong colors in SUW -> AllSet" into main 2024-08-30 15:19:47 +00:00
Schneider Victor-tulias 211751676c Merge changes I3e97ec83,Ib47a8a7f into main
* changes:
  Update KQS UX to better support square aspect ratio devices
  Update KQS recents apps and desktop mode launching UX
2024-08-30 13:48:05 +00:00
Schneider Victor-tulias f0a6d1df57 Update KQS UX to better support square aspect ratio devices
Flag: EXEMPT ENABLE_KEYBOARD_QUICK_SWITCH
Bug: 357512178
Test: Used KQS on a square device
Change-Id: I3e97ec834512521b417f2e707a6838c96bef5752
2024-08-30 13:47:38 +00:00
Schneider Victor-tulias 55c0c5e75d Update KQS recents apps and desktop mode launching UX
- Updated recent apps KQS task view
- Added a desktop mode KQS task view
- Did some code cleanup to support this more cleanly

Flag: EXEMPT ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 357512178
Test: Used KQS with and without desktop mode; opened recent apps and desktop mode
Change-Id: Ib47a8a7f41b56af1ba9d0cbec65ababf8aad7881
2024-08-30 13:46:23 +00:00
Alex Chau 31d465937b Only refresh TaskThumbnailViewDeprecated if runningTaskShowScreenshot has changed
- This is a follow-up of ag/28922223, which caused a RECENTS_SCROLLING jank regression
- The regression is probably caused by TaskThumbnailViewDeprecated unnecessarily redrawing, the fix is to only redraw when needed
- Also combined setShouldShowScreenshot and refreshThumbnails into a single method, so we can easily check inside TaskView if a refresh is necessary
- Centralize screenshotTasks logic into RecentsViewUtils, and centralize thumbnailView refreshing inside TaksView.setShouldShowScreenshot

Fix: 362294538
Test: Invoke Omnient or Screenshot hardware button on live tile, verify running task switches to screenshot after overlay closes
Test: Select/Screenshot swithces to screenshot normally
Flag: EXEMPT BUG_FIX
Change-Id: I7c6e73e52ebf18e7c59bb9afea029246b92681d2
2024-08-30 14:46:22 +01:00
Treehugger Robot 8da23e8c91 Merge "Refactoring OverviewCommandHelper (2/3)" into main 2024-08-30 13:31:58 +00:00
Treehugger Robot 09398bf183 Merge "Refactoring OverviewCommandHelper (1/3)" into main 2024-08-30 12:44:26 +00:00
Marcelo Arteiro c6fca0e16b Fixes wrong colors in SUW -> AllSet
Screenshot: https://screenshot.googleplex.com/6Yy9bQuQqox2rPB.png
Fixes: 355462084
Flag: EXEMPT bugfix
Test: Manual
Change-Id: I92b9839d345ab16f0229b546fb6c0e00ced02671
2024-08-30 12:41:34 +00:00
Jordan Silva ebfae18529 Refactoring OverviewCommandHelper (2/3)
This CL should not affect the behavior of OverviewCommandHelper.
- It splits executeCommand into smaller functions
- Rearrange public/private functions
- Adds extra logs.

Bug: 352046797
Bug: 351122926
Flag: EXEMPT bugfix.
Test: Manual.
Change-Id: I283f179794af812973a559db6291febe19e3c6d7
2024-08-30 12:30:54 +01:00
Ats Jenk 9ab2b8c785 Update bubble bar stash and unstash animation
Bubble bar should stash and unstash from the handle.
Update the animation to match what is used for the taskbar animation.
Fix the stash handle reveal animation to animate the stash bounds to
bubble bar bounds and back.
This gives the effect of the handle morphing into the bubble bar and
bubble bar morphing back into the handle.

Bug: 345680453
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest TransientBubbleStashControllerTest
Test: have bubbles in bubble bar and be in app, swipe up for taskbar and
  observe the bubble bar handle transforming into the bubble bar
Test: with taskbar and bubbles expanded, check that bubble bar
  transforms into the handle
Change-Id: I8508e9207092774cbdb990e65f7f84e56a924d0c
2024-08-29 22:34:19 -07:00
Winson Chung 380f11e9d5 Merge "5/ Remove unused recents code" into main 2024-08-30 03:00:49 +00:00
Treehugger Robot 5cfb887b68 Merge "Fix bug where PredictedIcon circle/dot flicker." into main 2024-08-30 01:02:19 +00:00
Treehugger Robot e7efecc52c Merge "Add some info about the overflow in bubble bar dump" into main 2024-08-30 00:24:53 +00:00
Winson Chung d159e61166 5/ Remove unused recents code
- The shell transit flag is already hardcoded to true in Launcher
  so we can remove the non-shell transit paths
- The minimized split was from legacy splitscreen where launcher would
  show in a minimized state, which is no longer the case

Flag: EXEMPT bugfix
Bug: 359608026
Test: atest NexusLauncherTests
Change-Id: Idea46fc065485233b9e508dae3ebc4ee87c29ba6
Signed-off-by: Winson Chung <winsonc@google.com>
2024-08-29 23:17:23 +00:00
Treehugger Robot 313b559076 Merge "[Predictive Back] Clean up flags" into main 2024-08-29 22:46:13 +00:00
Treehugger Robot 03cace2e6b Merge "Only handle taps on bubble bar when it was collapsed/stashed on down" into main 2024-08-29 22:37:49 +00:00
Jagrut Desai 9657710f29 Merge "Refactor TaskbarIconSpecs and TaskbarSpecsEvaluator" into main 2024-08-29 21:44:04 +00:00
Jagrut Desai bc98db6820 Merge "Use TaskbarAllAppsButtonContainer and TaskbarDividerContainer in TaskbarView" into main 2024-08-29 21:44:04 +00:00
Mady Mellor cc843823a6 Add some info about the overflow in bubble bar dump
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - add some bubbles to bubble bar, take a BR and look
               at the dump
Bug: 358304168
Change-Id: I91e50591df166e928d06ba9a29f69f923218de71
2024-08-29 14:20:38 -07:00
Treehugger Robot 9025fe918b Merge "FloatingWidgetView - avoid calling position callback when nothing changes." into main 2024-08-29 21:02:17 +00:00
Fengjiang Li 1f25f6405c [Predictive Back] Clean up flags
Fix: 270614790
Flag: NONE - clean up flag
Test: presubmit
Change-Id: I956ce6067dca5d2517b45046ae8a392df1023e49
2024-08-29 13:38:05 -07:00
Mady Mellor 4290d3cab1 Only handle taps on bubble bar when it was collapsed/stashed on down
When bubbles are expanded and you tap on the currently opened
bubble, the stack collapses. In the input consumer code, we also
get that tap & we handle it because at the "up" event at that time,
we're collapsed (or stashed in some cases). To fix this, only handle
the "up" event for the bar being collapsed / stashed, if it was in
that state when the gesture started (i.e. on down)

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 362165243
Test: manual - expand bubble bar in home / overview
             - tap on the currently expanded bubble
             => observe the animation is smooth
             - expand bubble bar in app
             - tap on currently expanded bubble
             => observe the animation is smooth
Change-Id: I1861af15c88bc0cbf2514faac7464de2f85aad1e
2024-08-29 11:39:40 -07:00
Mady Mellor 8104ad3321 Follow RegionSamplingHelper being moved into shell
- update imports for usages in launcher

Flag: EXEMPT updating imports & bp file for class moving to sysui
Test: make; gradle build for launcher; treehugger
Bug: 353160491
Change-Id: I6d9d004e8ab6f67f494927424d2651c5b848e967
2024-08-29 11:17:04 -07:00
Jagrut Desai 6060db4970 Use TaskbarAllAppsButtonContainer and TaskbarDividerContainer in TaskbarView
This cl includes
	- Usage of TaskbarAllAppsButtonContainer and TaskbarDividerContainer in TaskbarView. This can be seen as a refactor.
	- Animation refactor related to all apps button container refactor

Test: Presubmit
Bug: 356465292
Flag: com.android.launcher3.enable_taskbar_customization

Change-Id: I5b7c4f56aacac18fc6872f77b15e2e9ae896799e
2024-08-29 11:11:35 -07:00
Vadim Tryshev 1398d2268f Merge "Promote com.android.quickstep.TaplTestsQuickstep#testSwitchToOverview to presubmit" into main 2024-08-29 17:38:44 +00:00
Vinay Joglekar 858b76e7ed Merge "(1/2) Fix NPE for title description broken by ag/28991306. It can be nullable initially before its set." into main 2024-08-29 10:58:10 +00:00
Treehugger Robot 0816257f8d Merge "Revert "Add screenrecord and demote TaplTestsTrackpad#switchToOverview"" into main 2024-08-28 23:40:54 +00:00
Anushree Ganjam 7310809645 Merge "Setup Dagger for Launcher (1/n)" into main 2024-08-28 23:38:33 +00:00
Jagrut Desai 62fb48d247 Merge "Extend DesktopVisibilityController Funcationality to handle taskbar corner radius in desktop windowing mode" into main 2024-08-28 23:36:08 +00:00
Zak Cohen 7f9985af96 FloatingWidgetView - avoid calling position callback when nothing changes.
Previously, the position changed callback for the transition animation
was called on every layout change, whether or not the position has changed.

Now only call the callback and the layout changes if the targets don't
match the current state.

Bug: 327696338
Flag: EXEMPT bug fix
Test: manual
Change-Id: I3007a1c8d0a869866c66eb14d75f5b48d977f863
2024-08-28 16:33:03 -07:00
Treehugger Robot f73bca7a2c Merge "Make TasksRepository listen to changes in task visuals and update" into main 2024-08-28 22:31:22 +00:00
Treehugger Robot cf4666fbad Merge "Honors three_button_corner_swipe flag." into main 2024-08-28 21:25:45 +00:00
Federico Baron 374aa5a81f Revert "Add screenrecord and demote TaplTestsTrackpad#switchToOverview"
This reverts commit afe67917d1.

Reason for revert: no longer needed

Change-Id: I85e8928ef1def5583cfe6322bc522279bfeb62e1
2024-08-28 21:25:26 +00:00
Vadim Tryshev 144852b035 Promote com.android.quickstep.TaplTestsQuickstep#testSwitchToOverview to presubmit
Test is stable now

Change-Id: I747b79ae56107d91823bf0d1b02d83c717089d64
Test: presubmit
Bug: 187761685
Flag: NONE not a prod change
2024-08-28 20:50:05 +00:00
Anushree Ganjam bd8633133f Setup Dagger for Launcher (1/n)
Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration
Change-Id: Idbe19f1aa747f519417e21fe8a23a41c52ececc1
2024-08-28 12:11:47 -07:00
Uwais Ashraf 7640d97421 Make TasksRepository listen to changes in task visuals and update
To do this TaskVisualsChangedDelegate was added which multiplexes two listeners that are closely related.

Thumbnail overriding capabilities were also removed.

Fix: 342560598
Test: TaskVisualsChangedDelegateTest, TasksRepositoryTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: If065e4179cd1f15fe2cdf9b6bae51afcb57abcc6
2024-08-28 18:18:31 +00:00
Liam, Lee Pong Lam 60dfc4375e Ignore three finger trackpad for nav handle long press
To disable Omient trigger by three finger trackpad

Bug: 342143522
Flag: com.android.launcher3.ignore_three_finger_trackpad_for_nav_handle_long_press
Test: Manual

Change-Id: Ic283a4a376a6e628d6c16d6fd4088a9f5e10a0c5
# Conflicts:
#	aconfig/launcher.aconfig
2024-08-28 17:48:28 +00:00
Jagrut Desai dd737b590c Refactor TaskbarIconSpecs and TaskbarSpecsEvaluator
This cl includes
	- Because of IconNormalizer bug we are inflating iconsizes to match the specs.
	- specs changed from row x column to column X row.

Test: Presubmit
Bug: 356465292
Flag: com.android.launcher3.enable_taskbar_customization
Change-Id: I4b4856da92053149267e66a187f744c9c00ea3d9
2024-08-28 09:58:33 -07:00