Commit Graph

10567 Commits

Author SHA1 Message Date
fbaron e5e37faa1f Add logs to debug b/318394698
Flag: NONE
Test: n/a
Bug: 318394698
Change-Id: I3142dafeae0ba31713f514e690c5b7bb730541b0
2024-01-19 13:24:18 -08:00
Schneider Victor-tulias 0c8439e17d Merge "Update the KQS app launch animation to match the spec exactly" into main 2024-01-15 18:42:37 +00:00
Johannes Gallmann 898b9af9a2 Merge "Fix stuck wallpaper with predictive back" into main 2024-01-15 09:51:42 +00:00
Anushree Ganjam 64614a1ec6 Merge "Add null check since LauncherUserInfo can be null." into main 2024-01-13 05:04:14 +00:00
Anushree Ganjam 32b5ac61e0 Add null check since LauncherUserInfo can be null.
Bug: 319142187
Test: Manual
Flag: N/A. Crash in tests.
Change-Id: Iaa9fc1b8e7c2c09621d984bfdeb9012bcc479ef8
2024-01-12 18:05:29 -08:00
Tony Wickham dc566559d0 Merge "Improve Taskbar touchableRegion debuggability" into main 2024-01-13 01:38:18 +00:00
Jagrut Desai a15b88f484 Merge "Adding Taskbar Pinning Analytics again." into main 2024-01-13 00:54:14 +00:00
Sunny Goyal 39f235154e Merge "Fixing some launcher model tests" into main 2024-01-12 23:04:39 +00:00
Jagrut Desai fff93577e8 Merge "Update enableTaskbarNoRecreate logic" into main 2024-01-12 22:31:15 +00:00
Charlie Anderson 9fc2fa34b3 Merge "Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag." into main 2024-01-12 21:37:17 +00:00
Jagrut Desai 777f3a4b9d Merge "Fix TaskbarDividerPopupView vertrical Arrow offset" into main 2024-01-12 21:18:27 +00:00
Sunny Goyal 6449a21062 Fixing some launcher model tests
> Removing static mocks and using Sandbox context instead
> Removing inheritence in LauncherModel and converting LauncherApps.Callbacks
  to a separate class. decMaker sometimes fails because of API changes in
  LauncherApps.Callbacks

Bug: 319877828
Test: atest LoaderTaskTest
Flag: N/A
Change-Id: If78b5d83595627a355b284f52d887d75fef53014
2024-01-12 12:30:52 -08:00
Charlie Anderson da3138cd91 Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag.
This is necessary because the value of the read-write flag will not be updated in time for backup/restore.

Bug: 307527314
Test: compiles
Flag: ACONFIG ENABLE_LAUNCHER_BR_METRICS_FIXED TEAMFOOD
Change-Id: I67a1a820734d8881b3ed5be4a1f2f1556e6e4704
2024-01-12 14:33:29 -05:00
Jagrut Desai 057144e0f6 Update enableTaskbarNoRecreate logic
Test: Presubmit
Bug: 318567569
Flag: NONE
Change-Id: I6927f0bab0317219a00a7c09c08640825d54e91b
2024-01-12 10:59:10 -08:00
Anna Zhuravleva eb1966c278 Merge "Add shortcut to install an app to Private space" into main 2024-01-12 15:51:05 +00:00
Johannes Gallmann 9532717757 Merge changes I05d517a7,Ided0a095 into main
* changes:
  Minor clenaup in LauncherBackAnimationController
  Fix window corner radius for predictive back to home on Felix
2024-01-12 10:33:56 +00:00
Johannes Gallmann 09f29f7492 Merge "Align window clipping logic of back-to-home to cross-task-back" into main 2024-01-12 09:15:41 +00:00
Tracy Zhou 7a30de2fc3 Merge "Remove taskbar window from WindowManager in TaskbarManager.destroy()" into main 2024-01-12 06:05:44 +00:00
Tracy Zhou 78c548a829 Remove taskbar window from WindowManager in TaskbarManager.destroy()
When task bar crashes (from anything), task bar window is not cleaned up properly. This is because destroyExistingTaskbar() only removes the root layout from the window when we are no longer rendering task bar (one use case of that is folding the device). We need to clean it up in onDestroy() also.

Fixes: 319105323
Test: adb shell am crash com.android.systemui and make sure there is only one task bar window
Change-Id: Ia9c808e903422707bf4c270b2631fc913dde65d9
2024-01-11 16:13:06 -08:00
Tony Wickham 480448b059 Merge "Temporary workaround for taskbar hiding in Desktop" into main 2024-01-11 23:21:42 +00:00
Jagrut Desai 3fc1e3a45d Fix TaskbarDividerPopupView vertrical Arrow offset
Test: Manual
Bug: 310673489
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I6c6af315cb058c8da599af8120a6a903ab247006
2024-01-11 14:00:37 -08:00
Jagrut Desai 80cc62173e Adding Taskbar Pinning Analytics again.
Test: Presubmit
Bug: 265436916
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I742dccccc7648bb7ec8bf94d5f5f55430a5543ab
2024-01-11 11:33:02 -08:00
Anna Zhuravleva 29a3139815 Add shortcut to install an app to Private space
Introduce long-press shortcut to install a copy
of the main user app to private space.

Test: manual, installed apps in different stores
and tried shortcut
https://screenshot.googleplex.com/6oAVamTytiYmvPC.png
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT

Change-Id: I702cd2a27388e3cc6e9e126308d5479836ba6655
2024-01-11 12:40:28 +00:00
Riddle Hsu 1438af66f8 Merge "Fix leakage of GestureExclusionListener" into main 2024-01-11 05:54:05 +00:00
Tony Wickham 4e7411c54c Temporary workaround for taskbar hiding in Desktop
Taskbar still hides during the transition, but then reappears
after settling.

Flag: LEGACY ENABLE_HOME_TRANSITION_LISTENER enabled
Bug: 314207404
Test: manual
Change-Id: Ie3d29b3d40e513f39cb34176baa781c9f2853e57
2024-01-10 19:59:25 +00:00
Tracy Zhou e19c572ac2 Merge "Hook up luma sampling state change from CommandQueue" into main 2024-01-10 19:33:24 +00:00
Schneider Victor-tulias 7b019ef700 Update the KQS app launch animation to match the spec exactly
Updated the KQS to look exactly like the default app launch animation, in the opposite direction:
- animation interpolator
- task corner radius
- task margin
- animation duration

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313606549
Fixes: 313607264
Test: launched tasks from KQS from home and launched app
Change-Id: I3f49f9430b2148680816d904aced93d14f366123
2024-01-10 15:34:00 +00:00
Johannes Gallmann 376cde95d0 Align window clipping logic of back-to-home to cross-task-back
Bug: 315461656
Flag: ACONFIG com.android.systemui.predictive_back_system_animations STAGING
Test: Manual, i.e. visually verifying back to home behaviour on Felix
Change-Id: I075c38fc58c56108128fdf895c62b2f626da36ad
2024-01-10 14:18:39 +00:00
Helen Cheuk 78745df2b4 Merge "Fix wrong translation for swiping up split task" into main 2024-01-10 13:11:05 +00:00
helencheuk 06ddebb34f Fix wrong translation for swiping up split task
The wrong calculation is caused by using half size mTaskRect in Split task to calculate the translation X to middle
It should use the fullTaskSize instead of half size. This change refactors the code to store the full size so it does not need to re-calculate many times

Bug: 312371505
Test: Manual, swiping up split task diagonally from right side many times, test the case when mSplitBounds is not null in addAppToOverviewAnim
Test: Tested swipe up to overview for split task/single task in Phone, Tablet and Unfolded phone, with the flag on and off
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: Id2b008a7d9597271e077a125f3195b27196797d7
2024-01-10 11:40:58 +00:00
Riddle Hsu 96d7f9c2d7 Fix leakage of GestureExclusionListener
So the unregister/register are paired when launcher activity
is relaunched:

Launcher#onDestroy
 > mSplitWithKeyboardShortcutController.onDestroy()
+ > RecentsAnimationDeviceState#destroy
+  > unregisterExclusionListener

Launcher#onCreate
 > setupViews
  > new SplitWithKeyboardShortcutController
   > new RecentsAnimationDeviceState
    > onDisplayInfoChanged
     > registerExclusionListener

Bug: 319133753
Test: Toggle screen resolution many times and check the amount
      of DisplayContent#mSystemGestureExclusionListeners.
Change-Id: I2fb84415db71aaa14e653fea2592d6b9b5adad59
2024-01-10 17:59:28 +08:00
Tracy Zhou cf5407dfc6 Hook up luma sampling state change from CommandQueue
Currently when swiping up from some apps (maps), the stashed task bar color changes. Instead, sampling should be disabled during the transition (with a signal from the frameworks).

Bug: 230395757
Test: Swipe up from maps. Make sure the bar color doesn't change during transition
 to overview
Change-Id: Ifc30f4067a0e4d134b422d152f5b5caee0a77a33
2024-01-09 21:56:58 -08:00
Fengjiang Li ad3915e7dd Merge "Adding support for skipping animation cancel on reapply" into main 2024-01-10 02:28:19 +00:00
Sunny Goyal 40e7937af8 Merge "Simplifying pending widget inflation path" into main 2024-01-09 23:11:08 +00:00
Sunny Goyal 98b5e1f077 Adding support for skipping animation cancel on reapply
Bug: 314279319
Test: Verified on device
Flag: None
Change-Id: I0a6e9eef77a1d917c0fce7d4bddd079ceeb10c99
2024-01-09 10:35:43 -08:00
Orhan Uysal 9606989404 Merge "Fix z order of tasks in overview." into main 2024-01-09 17:46:49 +00:00
Schneider Victor-tulias 818b3ba092 Merge "Update KQS task launch animation" into main 2024-01-09 15:04:20 +00:00
Orhan Uysal 80484e6da0 Fix z order of tasks in overview.
The recent tasks list provided to launcher is ordered from most recent
to least recent. As a result, we need to add snapshot views always to
the start of the view list.

Test: Manual
Bug: 269664273
Bug: 317486696
Flag: None
Change-Id: I4efb3b3dbb21171cbbb52783e88e86d1b1778ec3
2024-01-09 14:35:47 +00:00
Johannes Gallmann 0614de59e1 Minor clenaup in LauncherBackAnimationController
Bug: 311365390
Flag: NONE
Test: presubmit
Change-Id: I05d517a7b49728ea66f6b805837f66b4a28ded53
2024-01-09 08:31:08 +00:00
Johannes Gallmann eb6f3ae46d Fix window corner radius for predictive back to home on Felix
Bug: 316873212
Flag: ACONFIG com.android.window.flags.predictive_back_system_animations DISABLED
Test: Manual, i.e. verifying on device that window corner radius matches the device corner radius during predictive back to home
Change-Id: Ided0a09597b88a75e82dbd2ff94e7d7af5fadaa9
2024-01-09 08:25:43 +00:00
Johannes Gallmann dacd86e053 Merge "Fix TaplTestsQuickstep.testPressback failure" into main 2024-01-09 08:13:39 +00:00
Ikram Gabiyev bb68dfec10 Merge "Send app bounds to Shell via stopSwipePipToHome" into main 2024-01-09 06:34:29 +00:00
Tracy Zhou bcdde0d1a6 Merge "Use KeyButtonRipple for button nav" into main 2024-01-09 02:42:08 +00:00
Sunny Goyal fdeb19e02c Simplifying pending widget inflation path
Instead of adding a PendingView in appWidgetHost, attaching a
listener in PendingView for widget-updates.

This moves the view inflation as the last stage of widget
binding. Eventually we can separate the model update and view
inflation to different threads

Bug: 318539160
Test: atest TaplBinderTests
Flag: None
Change-Id: I124edaa9622fa367302b80969036d128a978396e
2024-01-08 15:52:50 -08:00
Schneider Victor-tulias 5bc6a0aa1f Update KQS task launch animation
Updated the KQS app launch animation to match the spec: translate the launching app from the left (right in RTL) and translate the closing app to the right (left in RTL)

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313606549
Fixes: 313607264
Test: launched tasks from KQS from home and launched app
Change-Id: I0e903c741e4f930b377607b7eaf42a87177c3eb6
2024-01-08 16:19:17 -05:00
Tracy Zhou f46729fd23 Use KeyButtonRipple for button nav
- Matched ripple style
- Matched ripple bounds

Bug: 230395757
Test: Ripple looks the same as the one using navigation bar
Change-Id: I58c773b1f767fb8b0f2570bc4603ea953d589560
2024-01-08 11:54:48 -08:00
Tony Wickham a3daee40f3 Merge "Update kotlin formatting for TaskbarInsetsController" into main 2024-01-08 19:10:24 +00:00
Brandon Dayauon 4f673d2517 Merge "Increase predicted app row by 4dp to be same as SEARCH_RESULT_APP_ROW" into main 2024-01-08 18:00:05 +00:00
Sam Cackett ad51bc1df2 Merge "Reset AppChip chevron when closed" into main 2024-01-08 14:40:05 +00:00
samcackett 191b13e8d0 Reset AppChip chevron when closed
This CL fixes two issues:
1. It resets the chevron AnimatedVectorDrawable back to the start when
the TaskMenuView has finished closing. This stops it being re-opened in
any previously animated state and starts fresh each time.
2. The original position of the TaskMenuView is put back in its original
position when finished closing. If animations are disabled, the
TaskMenuView is never put back in its original position.

Video after this commit is applied: http://shortn/_gfy0pN6sKX

Fixes: 316998167
Fixes: 316996167
Test: Manual
  Open several apps. Open Overview. Expand a TaskMenuView. Swipe up to
  home. Open Overview again. TaskMenuView chevron should be facing down.
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD

Change-Id: I7d9e60b5c0a56cf809e9870573c3b51af5ded8c3
2024-01-08 13:44:51 +00:00