Commit Graph

18635 Commits

Author SHA1 Message Date
Charlie Anderson e5ace06d81 Merge "Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"" into main 2024-08-05 04:24:32 +00:00
Charlie Anderson fe23e711fd Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 00fb1adab4.
Also fixes test applyIconAndLabel_setsImageSpan_whenInactiveArchivedApp.

Bug: 350758155
Fixes: 356166053
Test: unit test
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I93f2ac47dc3a8fa81d59e0f089385d2b3fe93306
2024-08-02 17:26:02 +00:00
Fengjiang Li 7d7bd30491 Merge "Fix NPE of AllAppsRecyclerViewPool.kt" into main 2024-08-01 23:45:25 +00:00
Shamali Patwa b74b05336c Merge "Fix the getWidgetsByPackageItem method to return a copy" into main 2024-08-01 21:59:28 +00:00
Fengjiang Li 696a6c58d8 Fix NPE of AllAppsRecyclerViewPool.kt
Skip preinflating all apps icons if RecyclerView doesn't have layout manager yet. Also force crash in studio build to help find a repro case

Fix: 355192472
Flag: NONE - npe fix
Test: presubmit
Change-Id: I1e3e271eb6d5b732a7a71eb466bff402c172be0a
2024-08-01 14:39:02 -07:00
Sihua Ma 7eaf24840d Merge "Add unit test for LauncherAppWidgetHost" into main 2024-08-01 20:26:40 +00:00
Shamali P 74862f990b Fix the getWidgetsByPackageItem method to return a copy
Bug: 356545910
Fix: 356545910
Test: Unit test
Flag: EXEMPT BUGFIX
Change-Id: I90429983733eb5f2bb2d6df00799d2445eaeea31
2024-08-01 18:56:41 +00:00
Treehugger Robot a6e8616980 Merge "Revert "Add debug logs to TopTaskTracker"" into main 2024-08-01 16:07:57 +00:00
Sebastián Franco 7c434ddbde Merge "Adding logging for backup and restore" into main 2024-07-31 18:08:07 +00:00
Treehugger Robot 01a1169d57 Merge "Revert "Handles Bold Text setting for inline icon by providing bolded cloud icon"" into main 2024-07-31 16:47:15 +00:00
Charlie Anderson 00fb1adab4 Revert "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 114e84908f.

Reason for revert: b/356166053

Change-Id: I30dfbc5da1caecd89b4b23aafe4de8e9efede6a0
2024-07-31 14:08:16 +00:00
Sebastian Franco e356978869 Adding logging for backup and restore
Bug: 353505773
Test: compiles
Flag: EXEMPT bugfix
Change-Id: I4c1e56365332557fa95a11526498505bf2063e12
2024-07-30 18:47:37 -07:00
Treehugger Robot 779c79129b Merge "Fix grid migration item copy bug" into main 2024-07-30 20:19:19 +00:00
Brandon Dayauon dfb1722afc Merge "Make a dummy view at the bottom of all apps" into main 2024-07-30 20:15:26 +00:00
fbaron 5ff84328f0 Fix grid migration item copy bug
When migrating from a grid with 2+ copies of the same item to a grid that has less copies of that item, but more than 0, the extra copies don't migrate to the new grid.

Bug: 354946925
Test: ValidGridMigrationUnitTest
Flag: EXEMPT bugfix
Change-Id: I76ad0cb0f5abe9b5bf895c07467fc05986e9fea4
2024-07-30 10:11:58 -07:00
Jon Miranda e8b47c540f Merge "Add support for taskbar background to wrap around hotseat" into main 2024-07-30 15:59:48 +00:00
Brandon Dayauon 4a024c0834 Make a dummy view at the bottom of all apps
This is so that user can scroll all the way to bottom of all apps.
- updated tests to account for this new view

bug:340936636
Test manually:
before:https://drive.google.com/file/d/18mKMAedQh2uUOR2G4U_ZORIKP2tkRmEk/view?usp=sharing
after:https://drive.google.com/file/d/1UEl3kBfeInqxsgF2HwCfzOBEcsEqdbJ4/view?usp=sharing
Flag: NONE addingViewToBottomOfAllApps

Change-Id: Ib4b67a66cfc7ec2ba0dbbe211a241f244d204aaf
2024-07-29 14:58:25 -07:00
Charlie Anderson 6f699d23ea Merge "Handles Bold Text setting for inline icon by providing bolded cloud icon" into main 2024-07-29 16:15:58 +00:00
Jagrut Desai 65b5eb472e Merge "Unit Testing for TaskbarEduTooltipController" into main 2024-07-26 22:44:16 +00:00
Schneider Victor-tulias c8a533d542 Revert "Add debug logs to TopTaskTracker"
This reverts commit 86b9ad4ff7.

Reason for revert: debug logs no longer needed

Change-Id: Ia64f9e50934ac685f75f5109fc694720a07f17ac
2024-07-26 19:25:36 +00:00
Jagrut Desai 5af1bfbf52 Unit Testing for TaskbarEduTooltipController
This CL includes
	- TaskbarEduTooltipController Unit Test for all edu logic and hide tooltip
	- Test util class for taskbar controller test to run the test on main thread.
	- Refactored other controller test to use the new util function to run test on main thread.
	- Ability to disable running test in test harness mode.

Test: Presubmit
Bug: 346394824
Flag: TEST_ONLY
Change-Id: Ic623df8e7a58ac48d260e592ffab61d1f0658aef
2024-07-26 12:14:50 -07:00
Charlie Anderson 114e84908f Handles Bold Text setting for inline icon by providing bolded cloud icon
Bug: 350758155
Test: locally tested + unit tests
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I6e1fccbb7c8cb87a7e2675a60b05bf0cb402acf2
2024-07-26 11:17:39 -04:00
Jon Miranda 5dc07d786f Add support for taskbar background to wrap around hotseat
Currently only enabled for app launch animation

Future work is planned:
- Overview to home
- App dismiss
- When QSB is drawn inline

Bug: 345768019
Test: Launch an app, taskbar background and stashed handle will
      first wrap around hotseat before transforming into the
      stashed handle.
      Verified by locally forcing taskbar background and
      stashed handle to always draw.
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I9ab1870f87247b6a1b53a352ac3eb0183b7a1a1d
2024-07-26 08:10:50 -07:00
Brandon Dayauon 0ffb2d5530 Merge "Create floatingMaskViewTest and make FloatingMaskView testable." into main 2024-07-25 05:00:46 +00:00
Brandon Dayauon b6528c92ba Merge "Make settings/text alpha animation happen in parallelSet instead of when headerSetter starts." into main 2024-07-25 05:00:00 +00:00
Brandon Dayauon 29b374bcda Merge "Don't let settings button clickable during animation." into main 2024-07-24 23:28:10 +00:00
Brandon Dayauon a616e79764 Create floatingMaskViewTest and make FloatingMaskView testable.
bug: 354209068
Test: presubmit locally
Flag: NONE writing test for floatingmaskview
Change-Id: I90cbed18a908279365af185330fb2dc1e747ebff
2024-07-24 15:32:36 -07:00
Brandon Dayauon 1fe2da0d5d Make settings/text alpha animation happen in parallelSet instead of when headerSetter starts.
With the addition of floating mask views, settingsAlpha and textAlpha animation shouldn't be played in the beginning when animatorSet starts but more so during the parallel set. Otherwise, the text/settings alpha will start first before/same time as translationView. You can see this if you were to look at the video at the bottom of this commit message, specifically during the collapse case.

bug:355042924
Test manually -
before:https://drive.google.com/file/d/1BoCA5rlr9m3QDVfF5zfp9G12Ldst3kn0/view?usp=sharing
after:https://drive.google.com/file/d/1y84uxmAfJ7_SNh26jT2O-m2xOFWCMkJm/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I98248f4b9aa2a4e1287183710ffdc66093cef022
2024-07-24 15:18:57 -07:00
Liam, Lee Pong Lam 058559e3db [Launcher3] Supports child Settings navigation on Search
After adding all launcher settings to search, adding support for navigating to child settings if the setting isn't on the current screen.

result: go/launcher-settings-navigate-to-child

Bug: 293390881
Flag: com.android.launcher3.navigate_to_child_preference
Test: Manual

Change-Id: I5eecbf9a3c569f58b6c8830443d86ba122e4f53b
2024-07-24 21:23:29 +00:00
Brandon Dayauon da9520355f Don't let settings button clickable during animation.
Otherwise the user will open settings instead of unlocking the container like normal.

bug: 349115995
Test:
before: https://drive.google.com/file/d/1jmd9Pxp6d0aGSC5Sp7efrlY6JLCPvKLR/view?usp=sharing
after: https://drive.google.com/file/d/1xyKPd_hT9ut10r5B1PHxLO9gE3zh9vxK/view?usp=sharing
Flag: com.android.launcher3.enable_private_space
Change-Id: Icefaf7de72678ccf0b976039f4a3ee88c6712167
2024-07-24 14:02:54 -07:00
Liran Binyamin f93199cbe3 Merge "Fix squished hotseat due to bubbles" into main 2024-07-24 19:13:02 +00:00
Shamali Patwa b4d185e3cc Merge changes from topic "popup-refactor" into main
* changes:
  Delete the unused code from popup provider
  Update references that read popup data provider to use picker provider
  Update references that wrote widget data to popup data provider
  Move widget related listeners to widget picker data provider
  Define widget picker data provider separate from popup provider
  Create a separate class for widget related methods from popup provider
2024-07-24 18:46:35 +00:00
Charlie Anderson edc93ed7fe Merge "Handle when archiving icon flag is turned off by setting overlay back on" into main 2024-07-24 17:55:53 +00:00
Liran Binyamin 2a47a4a68d Fix squished hotseat due to bubbles
Hotseat supports adjusting its layout to make room for bubbles when
needed. There are 2 events that trigger this:
  1. When Hotseat's layout is reset, it checks for whether bubbles
     are showing.
  2. When Bubble Bar visibility changes it notifies hotseat so that
     it can update itself.

Folding the device is recreated triggers both hotseat layout reset
and recreation of taskbar, but the order in which these happen is not
guaranteed. Sometimes hotseat checks for the status of bubble bar
which may be visible if taskbar hasn't been recreated yet.

This change makes sure that hotseat updates itself after taskbar is
recreated and the ui controller is set, so that it cleans up any
adjustments it may have if bubbles are not visible.

This change also updates the way QSB adjusts itself for bubbles.
Previously it always animated from the same start value to a target
value. Now the animation starts from its current width to the target,
so that if the current width is already equal to the target width,
there is no visible change.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349430356
Test: manual
       - unfold the device
       - create bubbles
       - observe hotseat adjusts itself for the bubble bar
       - fold the device
       - observe bubble bar is gone and hotseat shows correctly
Test: manual
       - start a youtube video in full screen
       - swipe from the edge of the screen to show the gesture nav
       - swipe on the gesture nav to go home
       - observe that the QSB does not animate
Change-Id: Ia0267ec518d6af9c3c3b68f17bb20ea67a49e5fd
2024-07-24 12:49:17 -04:00
Kevin Lim 5ca6219003 Merge "[UniversalSearchInput] Support search box dynamic height adjustment in ActivityAllAppsContainerView" into main 2024-07-24 16:10:16 +00:00
Charlie Anderson 241fba24d0 Handle when archiving icon flag is turned off by setting overlay back on
Bug: 350758155
Test: locally
Flag: com.android.launcher3.enable_new_archiving_icon
Change-Id: Ied5c1a3c0674aa14556cbc225b157ad309b93db4
2024-07-23 19:38:33 -04:00
Shamali P ecf35935d5 Delete the unused code from popup provider
Test: Existing tests
Flag: EXEMPT minor refactoring
Bug: 353347512
Change-Id: Iff81e5dc46542da2d59dfa4f54bd8fc06851a9c1
2024-07-23 20:16:50 +00:00
Shamali P 5a1b372536 Update references that read popup data provider to use picker provider
Covers the UI references related to widget picker or its shortcut.

Test: Existing tests
Flag: EXEMPT minor refactoring
Bug: 353347512
Change-Id: Ifed1b7600ca9836df147949f3740ca1e89acd04a
2024-07-23 20:16:50 +00:00
Brandon Dayauon 72054af897 Merge "Adding more information to logs like content description to help with debugging." into main 2024-07-23 19:54:18 +00:00
Charlie Anderson e17788e9b8 Merge "[Test Week] add unit tests for InstallSessionTracker" into main 2024-07-23 18:55:55 +00:00
Charlie Anderson 528c716182 [Test Week] add unit tests for InstallSessionTracker
6 public methods tested, 8 unit tests total
no previous test class

Bug: 353303621
Test: unit tests
Flag: TEST_ONLY
Change-Id: Ie2b5c88566c1a512e534654ccc7db1ec6b277a83
2024-07-23 13:05:28 -04:00
Anushree Ganjam bad6ce487a Merge "Add SEARCH_TARGET_UTIL_LOG for debugging searchtargetutil logs" into main 2024-07-23 16:58:28 +00:00
Charlie Anderson 2abb3eb582 Merge "[Test Week] Add unit tests for UserCache" into main 2024-07-23 16:34:39 +00:00
Sebastián Franco 7d780ce71d Merge "Revert change to rotateBounds" into main 2024-07-23 00:49:14 +00:00
Shamali P 66614049eb Update references that wrote widget data to popup data provider
Migrates to write to widget picker data provider instead

Test: Existing tests
Flag: EXEMPT minor refactoring
Bug: 353347512
Change-Id: I1735151e133db0358dfd4f7fa824c6bc7d792307
2024-07-22 23:58:04 +00:00
Shamali P 00d4e05072 Move widget related listeners to widget picker data provider
The change listener on popup provider was for listening to widget
updates. With the widget now updated in widgets picker data provider,
 this moves over the listeners to it.

Test: Existing tests
Flag: EXEMPT minor refactoring
Bug: 353347512
Change-Id: I163529d207ea65044f8e3d6e77e87e0e674b82be
2024-07-22 23:58:04 +00:00
Shamali P 74d9fbd635 Define widget picker data provider separate from popup provider
Separate provider in ActivityContext and relevant implementations that
open widget picker

Bug: 353347512
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: I55df3d9ce6ae9b7d0a310a8686b188618d229065
2024-07-22 23:58:04 +00:00
Shamali P 9e7d288f67 Create a separate class for widget related methods from popup provider
Child cl removes those methods from popup provider and updates its
references

Bug: 353347512
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: Id559e8c8d32a40adab961e7c710ec835d5a92184
2024-07-22 23:58:04 +00:00
Brandon Dayauon 6c5a875927 Adding more information to logs like content description to help with debugging.
Using appTitle doesn't seem to work and instead returns null. Content description seems to work
better anyways and show what user type (work/private)

bug: 353796175
Test: after: https://screenshot.googleplex.com/8ysLRHc9cRPg3JF
Flag: NONE adding logs
Change-Id: I4ddab1c02d795d87190592471f84faa6c98f0bfd
2024-07-22 16:27:19 -07:00
Sebastian Franco 28e89bd10f Revert change to rotateBounds
Reason: Breaking Tapl tests.

Bug: 353965234
Flag: EXEMPT bugfix
Test: UtilitiesTest.kt
Change-Id: I2c513a190e5e9cba3f27b14c3835d3b039241467
2024-07-22 15:18:48 -07:00