Commit Graph

1876 Commits

Author SHA1 Message Date
Sebastian Franco e4965124ad Moving startBinding and clearPendingBinds to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I49eb6f88bb680c289f4e73cc108671b37b18fae7
2023-12-05 13:04:42 -06:00
Sebastián Franco f601447877 Merge "Moving bindAppsAdded and setIsFirstPagePinnedItemEnabled to ModelCallbacks" into main 2023-12-01 17:58:11 +00:00
Thales Lima 09d42d5340 Revert "Make numFolderRows/numFolderColumns accept more values"
Revert submission 25438456-5x5_folder
Reason for revert: http://b/313567919
Reverted changes: /q/submissionid:25438456-5x5_folder

Revert "Use DeviceProfile numFolderRows and numFolderColumns"
Revert submission 25313018-numFolder
Reason for revert: http://b/313567919
Reverted changes: /q/submissionid:25313018-numFolder

Change-Id: I4890016e310c0a2122861f36fcdbf33e98e727c0
2023-11-30 11:47:37 +00:00
Vadim Tryshev 54dbd42cae Merge "Waiting for Launcher activity to stop when starting a Launchable" into main 2023-11-29 21:57:45 +00:00
Vadim Tryshev 1b058fd467 Waiting for Launcher activity to stop when starting a Launchable
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I8bed0225617a225c2dc9587a75d004b98395fe1f
2023-11-29 13:55:46 -08:00
Sunny Goyal eb29313595 Updating WidgetSheets so that it can be displayed in any
activity and not just Launcher

Bug: 307306823
Test: atest Launcher3Tests
Flag: NA
Change-Id: I0e33323805c6e895e3a1639ecf5933e698212c65
2023-11-27 11:17:04 -08:00
Jordan Silva 2e1b287038 Merge "Use DeviceProfile numFolderRows and numFolderColumns" into main 2023-11-24 12:29:19 +00:00
Sebastian Franco 6dda7c770c Moving bindAppsAdded and setIsFirstPagePinnedItemEnabled to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I79a651c9d57e443037e330728540616b0d01434a
2023-11-22 11:19:20 -06:00
Thales Lima 07c6b8d96d Use DeviceProfile numFolderRows and numFolderColumns
Invariant hold values that are not related to current DP in use. This is a change needed for IDP to hold more values in the future akin to iconSize.

Bug: 309800141
Change-Id: Iefb388a5f6590d7da3452d2c388c02bd5e9d32bb
Flag: N/A
Test: NexusLauncherTests
2023-11-21 11:47:21 +00:00
Fengjiang Li f05c0f5843 Merge "Only log COLD_DEVICE_REBOOTING startup latency logs" into main 2023-11-18 16:36:35 +00:00
Sebastián Franco 5f14285de1 Merge "Moving bindSmartspaceWidget to ModelCallbacks" into main 2023-11-17 22:50:07 +00:00
Fengjiang Li e5f91a4c7a Only log COLD_DEVICE_REBOOTING startup latency logs
Fix: 305391017
Test: Unit test
Flag: NA
Change-Id: I976add25ea14d49e2ea84e395985edb9f559370c
2023-11-17 14:00:51 -08:00
Sebastian Franco 50b74c341a Moving bindSmartspaceWidget to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I960cb767e3c4db4a952e019ee489ec1611e2dbd2
2023-11-16 17:18:06 -06:00
Sebastián Franco da18b9e435 Merge "Use the number of shown hotseat icons instead of database items to store into the DB" into main 2023-11-16 15:33:51 +00:00
Sebastian Franco 2d023e26c6 Use the number of shown hotseat icons instead of database items to store into the DB
It seems this issue was originated from ag/14129534 and we should no
longer use numDatabaseHotseatIcons form IDP and use numShownHotseatIcons
from the DP.

Fix: 305119735
Flag: NA
Test: manuall testing, we don't have this test for landscape
Change-Id: Ie530748f9b77d89ac3298c187ae767643d505cb3
2023-11-15 21:34:38 -06:00
Tracy Zhou bf021974f4 Merge "[Trackpad] Do not reverse two-finger gestures on the homescreen when reverse scrolling is on" into main 2023-11-15 02:22:20 +00:00
Anushree Ganjam af4f41b9dc Merge "Hide overlay if the overlay was shown when Meta key is tapped." into main 2023-11-09 22:14:41 +00:00
Anushree Ganjam b736982bab Hide overlay if the overlay was shown when Meta key is tapped.
Before fix : https://b.corp.google.com/issues/300492676#comment13
When Meta key is tapped in -1 screen, the toggleAllAppsFromIntent is called and
AllApps Drawer is shown in home screen. But the user is still in -1 screen.

After fix: https://b.corp.google.com/issues/300492676#comment15
When meta key is tapped in -1 screen, we hide -1 screen and transition
to 0 screen and then show AllAppsDrawer.

Bug: 300492676
Test: Manual, https://b.corp.google.com/issues/300492676#comment15
Flag: NA

Change-Id: I1234e4defdd0b53be35271b9f7567b0719eec7ac
2023-11-08 17:08:57 -08:00
Sebastián Franco 5054899552 Merge "Moving some constants in Launcher.java to a separate file for ease of readability" into main 2023-11-07 21:22:11 +00:00
Sebastian Franco 974cc94839 Moving some constants in Launcher.java to a separate file for ease of readability
Part of  go/launcher_SoR

Flag: N/A
Bug: 306465626
Test: compiling, no-op change
Change-Id: I5ea40acb2ba1ea5840021e297516a511b032a043
2023-11-07 10:12:26 -06:00
Tracy Zhou de8e25cf11 [Trackpad] Do not reverse two-finger gestures on the homescreen when reverse scrolling is on
- Swipe up to pull up all apps
- Swipe down to pull down notifications
- Same gesture to close in reverse scrolling mode

Bug: 301966246
Bug: 301966690
Test: manual
Change-Id: Ia3770ce8b279d24b2de4844f441f14e0feaf57c7
2023-11-02 12:30:50 -07:00
Federico Baron 0282c107fa Merge "Fix page indicator bugs for foldable" into main 2023-11-02 17:34:18 +00:00
fbaron 95ed863d96 Fix page indicator bugs for foldable
There are bugs when unfolding the felix device where the page indicator will appear in the wrong place, and have to animate all the way back to where it should go. This was originally fixed with ag/24399441 but it seems that the issue is still happening when flag FOLDABLE_SINGLE_PAGE is off. Here we fix that issue..

Fix: 294231977
Fix: 291822492
Flag: NONE
Test: n/a
Change-Id: I6ae97ebbb034f5b520a4f5ace729b44b89ea73a0
2023-11-01 14:19:07 -07:00
Ats Jenk 866e77101c Merge "Use aconfig flag for desktop mode" into main 2023-10-31 05:07:02 +00:00
Sunny Goyal e82a20a44d Removing some dependencies on Activity
> Removing activtiy from overlay callbacks
> Removing usage on activtiyLifecycleCallbacks and managing the callbacks ourselves

Bug: 306225896
Test: Existing tests cover the lifecycle changes
Flag: N/A
Change-Id: I79941e364328eecdc8a72cac4d35b75d50a25319
2023-10-30 08:23:15 -07:00
Ats Jenk 5c25c3a19d Use aconfig flag for desktop mode
Refactors all flag access in Launcher to be from DesktopTaskView and using a method instead of a static field.
Also using static import for the method so if we need to move it, only imports needs to be updated.

Bug: 304778354
Flag: ACONFIG com.android.wm.shell.enable_desktop_windowing TEAMFOOD
Test: enable the aconfig flag, check that desktop windowing is available

Change-Id: Ia2bdfd865802a635878d72cfb5a90c21dad6ed08
2023-10-27 10:58:07 -07:00
Vinit Nayak a1be4c1123 Use aconfig flag enable_split_contextual
Bug: 276361926
Test: Basic split contextual operations work
as expected

Change-Id: I7202654f8452a0c57e5e728c9baaadf85fa22a96
2023-10-25 01:37:17 +00:00
Luca Zuccarini 2bb6abadd7 Clean up ENABLE_KEYBOARD_TRANSITION_SYNC flag.
Fix: 297592348
Flag: NA
Test: manual
Change-Id: I995acd511a3c7ebc630aaac977f8c380ddfa445f
2023-10-24 13:12:38 +00:00
Fengjiang Li 6bde22cdcd Merge "Fix bug where we should not have changed when to log end of workspace binding in launche startup" into main 2023-10-20 03:16:15 +00:00
Fengjiang Li b739372438 Fix bug where we should not have changed when to log end of workspace binding in launche startup
In ag/25052869 we should only change when we end LAUNCHER_LATENCY_STARTUP_TOTAL_DURATION, but leave LAUNCHER_LATENCY_STARTUP_WORKSPACE_LOADER_SYNC/ASYNC unchanged.

Fix: 305243183
Test: lock screen, force stop launcher, verify COLD startup is logged before user unlocks screen
Flag: N/A
Change-Id: I206b7fcbe07fca99cdbcc3a53213550e6b8c7369
2023-10-19 13:52:35 -07:00
Fengjiang Li 063f14e5bc Merge "If COLD startup occurs while launcher is backgrounded, do not wait until user goes to home to end startup session." into main 2023-10-19 19:51:46 +00:00
Fengjiang Li 6dff0925c0 If COLD startup occurs while launcher is backgrounded, do not wait until user goes to home to end startup session.
Fix: 305243183
Test: lock screen, force stop launcher, verify COLD startup is logged before user unlocks screen
Flag: N/A
Change-Id: I2d93dc3346e1aec82555162c9bb868cc4ddb621b
2023-10-19 10:54:44 -07:00
Sebastián Franco c3a2919fd1 Merge "Moving getPagesToBindSynchronously to ModelCallbacks" into main 2023-10-13 23:49:02 +00:00
Sebastian Franco 69fd742a60 Moving getPagesToBindSynchronously to ModelCallbacks
Changes are part of go/launcher_SoR .

Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I5e57b73edfa23e9f12ea94c0f9c5005e2d8fccd2
2023-10-13 11:34:23 -07:00
Sunny Goyal cd44740567 Moving onboarding prefs to use LauncherPrefs
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: Iec8a5e739f394a152d5ffc57b01e0449e94b4084
2023-10-10 11:47:33 -07:00
Sunny Goyal b834d6eca8 Merge "Removing some usage of shared prefs" into main 2023-10-10 18:44:15 +00:00
Vinit Nayak b95ee09a69 Merge "Dismiss split selection for workspace long-press" into main 2023-10-09 16:13:52 +00:00
Vinit Nayak 4f850a42a0 Merge changes I9e56ddbe,I8767deea into main
* changes:
  Disallow taskbar long click when in split selection state
  Add method to determine if launcher is in split selection state
2023-10-07 00:20:24 +00:00
Vinit Nayak d0fc718a0a Dismiss split selection for workspace long-press
Bug: 295426148
Test: Enter split contextual from homescreen,
long-press on empty space, split gets dismissed
Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE

Change-Id: I3a893bea7b22645fe60c65c4c5ab8c2087d769da
2023-10-06 16:05:54 -07:00
Vinit Nayak 1525cd7269 Add method to determine if launcher is in split selection state
* Available for both launcher and taskbar via
ActivityContext

Bug: 295981634
Change-Id: I8767deea0b2432da3047209037874c966b83c3b3
2023-10-06 14:40:49 -07:00
Sunny Goyal 576f7a5e80 Removing some usage of shared prefs
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: I158e9a5148d2c9404ea4d2e9e239696b29dbeb20
2023-10-06 14:35:56 -07:00
Federico Baron 0bd2c4ea75 Merge "Add smartspace removal option as a toggle" into main 2023-10-06 20:35:14 +00:00
Sunny Goyal 6ad6cfa300 Merge "Removing unused interfaces from Launcher" into main 2023-10-05 21:00:49 +00:00
Sebastián Franco 86efdfb964 Merge "Moving the simple methods related to binding to a delegate" into main 2023-10-05 19:48:22 +00:00
Mark Fasheh 9a0a03d080 Merge "Add tracepoint to track Launcher cold startup latency" into main 2023-10-05 18:26:54 +00:00
fbaron c0e687bad8 Add smartspace removal option as a toggle
Bug: 303471576
Test: try removing smartspace by going to home settings and turning it off
Flag: ENABLE_SMARTSPACE_REMOVAL
Change-Id: Idd95da1b302927885a8c469e38db6d3c5130f8c1
2023-10-05 17:26:03 +00:00
Sebastian Franco bd7919c97a Moving the simple methods related to binding to a delegate
Other more involved methods should require their own cl so that
we can do a more thurough analysis.

Changes are part of go/launcher_SoR .

Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I332a6b92cfd8dc6a9632c225da634bc4b57f01e2
2023-10-05 09:50:16 -07:00
fbaron 80b0ce819c Cleanup SHOW_DOT_PAGINATION flag
Fix: 270395278
Flag: no flag
Test: verify everything still works the same
Change-Id: I803d9c22ac4c7040c47410b97cbdb2b11e33e8c9
2023-10-03 21:59:02 +00:00
Federico Baron 80c138f293 Merge "Add smartspace as a widget to first page (implementation 2)" into main 2023-10-03 21:57:54 +00:00
Sunny Goyal 81039b2d73 Removing unused interfaces from Launcher
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: Ia042805080bd314efff5a9bb4877f4f830fb3998
2023-10-03 10:19:39 -07:00