Commit Graph

10622 Commits

Author SHA1 Message Date
Saumya Prakash e3d14a686a Allow gesture tutorial to work for both orientations for square aspect ratios.
Devices with a square aspect ratio were previously seeing a prompt to rotate the screen for the gesture navigation tutorial. This change enables the tutorial for such devices but will still show the prompt to rotate the device if the aspect ratio would make the tutorial animations look wrong.

Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Fix: 321650001
Test: Tried gesture tutorial on various devices of different aspect
ratios and ensured that the prompt to rotate the device only shows up on
devices that do not have a square aspect ratio.

Change-Id: I7a6ca40e09a8202a9b54d898e0c68cc142694342
2024-01-24 23:39:39 +00:00
Tracy Zhou e49c26dd79 Merge "Use nearest region for all the nav buttons in 3-button folded mode" into main 2024-01-24 22:12:14 +00:00
Ats Jenk feb2b098cb Merge "Move bubble bar stashed handle to the left for RTL" into main 2024-01-24 19:22:58 +00:00
Tracy Zhou 9c9befae5f Use nearest region for all the nav buttons in 3-button folded mode
Bug: 230395757
Test: In 3-button folded mode, make sure that the touches that happen between nav buttons go to the nearest button. No regression in other modes.

Change-Id: Icb776a9a4ed4fc31d33dc3267c7053f2b0da0bfc
2024-01-24 11:06:01 -08:00
Vinit Nayak 5f3b761451 Merge "Rename isSplitSelectionEnabled() to isSplitSelectionActive()" into main 2024-01-24 05:53:44 +00:00
Ats Jenk e1701b05f0 Merge "Skip bubble bar arrow animation if arrow detached" into main 2024-01-24 01:23:49 +00:00
Ats Jenk 14f76fe13b Move bubble bar stashed handle to the left for RTL
When system language is set to an RTL language, we move the bubble bar
to the left.
Move the stashed bubble bar handle to the left in this case.
Tweak the bubble bar expand animation so that the bubbles expand from
the left edge.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: repeat following steps with LTR and RTL system languages
  - add couple of bubbles to bubble bar, open an app, observe stashed
    handle on the left
  - swipe up from system navbar to show taskbar and bubble bar
  - swipe up from bubble bar handle to show bubble bar and expand it
  - drag bubble bar to dismiss target and back out and release
Change-Id: Ia3b7892bba732a5278168d63db0594087f55fad4
2024-01-23 17:16:49 -08:00
Tracy Zhou 05ca003b41 Merge "Do not enter stage split from keyboard shortcuts if the user is already in split" into main 2024-01-24 00:26:31 +00:00
Vinit Nayak 7c7ece3efe Rename isSplitSelectionEnabled() to isSplitSelectionActive()
Bug: 295467097
Change-Id: I5c518c3e7227c034956fb92590b7472ba4a71d39
2024-01-23 15:41:14 -08:00
Ats Jenk e0b2ef481c Skip bubble bar arrow animation if arrow detached
Arrow can become detached from the bubble bar background. This can
happen when bubble bar is pinned to the left and the right-most bubble
is selected. When the selected, right-most bubble is removed by drag and
dismiss, the view is removed and bubble bar background is immediately
updated. But we try to animate the arrow to the new selected position.
Before starting to animate arrow position, check if arrow position is
greater than bubble bar width. If it is, the arrow is detached and we
should not try to animate it to the new position. Just move it.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: switch to RTL language, have 3 bubbles in bar, expand and select
  the right-most bubble, then dismiss it via drag, observe arrow jumps
  to new position and does not become detached from background
Test: switch to LTR language, try the same, 3 bubbles and dismiss the
  left-most bubble, observe arrow jumps the same and does not become
  detached
Test: select other bubbles, observe arrow position animates to the new
  position
Change-Id: I399db3c3e32b65b9125262bba0a0c32e45865bba
2024-01-23 15:18:09 -08:00
Ats Jenk 1721e8a7ae Merge "Bubble bar expland/collapse animation when on left" into main 2024-01-23 21:44:25 +00:00
Himanshu Gupta 4b75bca8c9 Merge "Allowing ProxyActivityStarter without result." into main 2024-01-23 11:03:13 +00:00
Himanshu Gupta 70fd052cd9 Allowing ProxyActivityStarter without result.
This is required in some cases, when we do not want
the Launcher (ProxyActivityStarter) Activity to come
in recents.

Bug: 320664417
Flag: ACONFIG com.android.launcher3.private_space_app_installer_button TEAMFOOD
Test: Manual build and flash.
Change-Id: I94d9dfab19f8a2410fa82adc0c0c22a3ac238a0b
2024-01-23 05:17:20 +00:00
Tracy Zhou be498432cd Do not enter stage split from keyboard shortcuts if the user is already in split
Fixes: 319640005
Test: Nothing happens when triggering split shortcuts in full split
Change-Id: I7bfe82a9255d2822ca90ed5bb1733021e2465602
2024-01-22 20:17:00 -08:00
Ats Jenk feb3a68db7 Bubble bar expland/collapse animation when on left
Fix bubble bar collapse and expand animations when bubble bar is pinned
to the left.
When system language is set to an RTL language, bubble bar gets pinned
to the left edge of the screen.
Bubble bar should expand to the right and collapse to the left. Bubbles
in the bubble bar should be ordered from right to left. The most recent
bubble should be at the right in the bubble bar.

Known issue:
  - when the most recent bubble is removed, the arrow animates to a new
    position, but the background is not animated, resulting in arrow
    getting detached from the container. Will be fixed by animating the
    background.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: with LTR language set as the system language
  - expand bubble bar with 1 bubble
  - expand bubble bar with multiple bubbles
  - select second bubble, observe after collapse it is set as first
  - dismiss a bubble from bubble bar by dragging
Test: with RTL language set as the system language
  - expand bubble bar with 1 bubble
  - expand bubble bar with multiple bubbles
  - select second bubble, observe after collapse it is set as first
  - dismiss a bubble from bubble bar by dragging

Change-Id: Ic46a5b1a6e45ad225ba509a61147cc6a8cdd0397
2024-01-22 19:06:29 -08:00
Mady Mellor 0e08d300e4 Merge "Add Ats and Liran as owners to taskbar bubbles" into main 2024-01-23 00:34:10 +00:00
Winson Chung 5a1c88629b Merge "Remove path to provide Launcher with the nav bar surface" into main 2024-01-22 21:10:51 +00:00
Vinit Nayak 520f284e3a Merge "Implement bounce animation for invalid split target" into main 2024-01-22 20:57:29 +00:00
Jagrut Desai d176477b7f Merge "Fixing folder drawLeaveBehind() with Taskbar Pinning enabled" into main 2024-01-22 19:40:58 +00:00
Mady Mellor befb26ca11 Add Ats and Liran as owners to taskbar bubbles
Flag: N/A
Test: treehugger
Bug: none
Change-Id: I16c3c45c109d0bcc4f536dfebc5d40c8ea3d2f31
2024-01-22 11:28:47 -08:00
Sunny Goyal 7ec2e11b0c Merge "Implementing an unfold animation using CannedAnimationController" into main 2024-01-22 19:06:41 +00:00
Anushree Ganjam e6760e6855 Merge "Pause the prediction update until the app launch transition ends." into main 2024-01-22 19:05:36 +00:00
Jagrut Desai f5a27ac0c5 Fixing folder drawLeaveBehind() with Taskbar Pinning enabled
Test: Manual
Bug: 320579559
Flag: NONE
Change-Id: If0c7cb7cf8deb89868cb34c310c91fd0cf028643
2024-01-22 10:08:09 -08:00
Anushree Ganjam b3bf0276e4 Pause the prediction update until the app launch transition ends.
b/319162661 issue is similar to hotseat updates on app click : b/148800229 and ag/10235572

So we will pause the prediction updates until the app launch transition is complete.

See https://b.corp.google.com/issues/319162661#comment9 and https://b.corp.google.com/issues/319162661#comment10 for bug report
analysis.

Before fix: https://b.corp.google.com/issues/319162661#comment11

After fix: https://b.corp.google.com/issues/319162661#comment12

Bug: 319162661
Test: Manual
Flag: NA
Change-Id: I797ce982569c7950628368b854fb3b6766f0fc28
2024-01-22 09:51:05 -08:00
Sam Cackett 77a7bf2ac7 Merge "Use app short name in Overview IconAppChipView" into main 2024-01-22 14:46:00 +00:00
Jeremy Sim d9c91a45e8 Implement bounce animation for invalid split target
When the user selects an app pair as a split target, the split instructions view will now bounce up and down to prompt the user to select something else.

Fixes: 315529271
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I1ff194449db2263b266404f42a75ebc35ee6077c
2024-01-22 12:23:58 +08:00
Winson Chung c05363a620 Remove path to provide Launcher with the nav bar surface
- It's not currently being used at all, and with the taskbar/navbar
  unification we will likely not need it going forward as well

Fixes: 318651465
Test: Builds
Change-Id: I909c0165468e8da9c3ca2df4ba98da9dcc43eb53
2024-01-20 22:13:41 +00:00
Tracy Zhou e66ed03992 Merge "Update task bar height update logic to consider screen rotation cases" into main 2024-01-20 02:12:19 +00:00
Sunny Goyal 3ef2768922 Merge "Simplyfing SystemShortcut rendering" into main 2024-01-20 01:11:36 +00:00
Tracy Zhou a009a5e82e Update task bar height update logic to consider screen rotation cases
When home screen rotation is enabled, instead of updating taskbar height (assuming that folded task bar is always on the bottom of screen display), we should update taskbar width instead.

Bug: 313371759
Test: try out both folded and unfolded 3-button and gesture nav modes, enable home rotation, make sure all the nav buttons are functional and visible when they should be.
Change-Id: I16f53d9e9c3cd0229fc50b73613b032a96322b97
2024-01-19 16:58:03 -08:00
Tony Wickham 7eceb5b101 Merge "Revert to passing mIsStashed to StashedHandleViewController again" into main 2024-01-20 00:38:16 +00:00
Federico Baron 2b691f67b4 Merge "Add logs to debug b/318394698" into main 2024-01-19 22:38:23 +00:00
fbaron e5e37faa1f Add logs to debug b/318394698
Flag: NONE
Test: n/a
Bug: 318394698
Change-Id: I3142dafeae0ba31713f514e690c5b7bb730541b0
2024-01-19 13:24:18 -08:00
Tony Wickham c4df8c2ec6 Revert to passing mIsStashed to StashedHandleViewController again
- Fixes case where handle is initially invisible but will be stashed
  and visible, e.g. when launching an app from home screen
- To fix the original issue of sampling happening unnecessarily for
  three button nav, also check supportsVisualStashing()

Fixes: 321257120
Flag: None
Test: Launch an app from home in gesture nav mode
Test: testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Change-Id: I1f26436de3081fd00f75a5921010e361e9a9f34e
2024-01-19 20:25:25 +00:00
Sunny Goyal 9f226dff72 Simplyfing SystemShortcut rendering
Instead of opening the popup again when the status of AppSharing
changes, updating the UI in-place.

Bug: 321179015
Test: Presubmit
Flag: N/A
Change-Id: I6d7bd8cdf2014fd881324347e3e01b8e7e84ef1e
2024-01-19 10:48:54 -08:00
Sunny Goyal defc9058a1 Merge "Cleaning up some unused notifications functionality" into main 2024-01-19 16:39:12 +00:00
samcackett 548c4d0e8d Use app short name in Overview IconAppChipView
Fixes: 313649435
Test: Build & Run
  Open an app with a longer name, like Google News or Youtube Music.
  Open "Overview". IconAppChipMenu should have a short name like "News"
  or "YT Music"
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Ieb449c5e574dd3c7b88a9cd3979175cbc91ef3eb
2024-01-19 14:35:13 +00:00
Johannes Gallmann 3cbcdaff19 Merge "Attach launcher protection scrim to the opening target instead of Launcher's surface." into main 2024-01-19 08:31:32 +00:00
Sunny Goyal e0c1649d87 Cleaning up some unused notifications functionality
Bug: 321154530
Test: Presubmit
Flag: N/A
Change-Id: I1ff2a4f19595659d89e7d72ee1b29036bbd54d8f
2024-01-19 00:21:02 -08:00
Anushree Ganjam 917619a06a Merge "Remove Pin Prediction shortcut from private space app." into main 2024-01-18 21:45:23 +00:00
Sunny Goyal 2c206400a2 Implementing an unfold animation using CannedAnimationController
Bug: 297057373
Flag: aconfig enable_unfold_state_animation DISABLED
Test: Manual
Change-Id: Iaa352133ebf06ab74b9ba4b8c4d3523f27666089
2024-01-18 11:49:37 -08:00
Anushree Ganjam 245402984d Remove Pin Prediction shortcut from private space app.
Before: https://screenshot.googleplex.com/68S4y4efJWQkyYk.png
After: https://screenshot.googleplex.com/8XdwUFGsYvHkEQ4.png

Bug: 319250810
Test: Manual
Flag: aconfig com.android.launcher.enable_delete_private_space_pin_shortcut DEVELOPMENT

Change-Id: I33ef2cc35c31f86101197405502d84ad98b36bdc
2024-01-18 11:17:09 -08:00
Saumya Prakash b617daa6c6 Merge "Add standalone taskbar edu tooltip for the pinnable taskbar feature" into main 2024-01-18 01:41:14 +00:00
Anushree Ganjam cbfa8043c8 Merge "Add "Don't suggest app" shortcut to suggested apps." into main 2024-01-17 22:25:17 +00:00
Saumya Prakash dddebdff0c Add standalone taskbar edu tooltip for the pinnable taskbar feature
This change adds in a standalone edu window for the pinnable taskbar
feature. The reason for the change is to educate users about pinnable
taskbar to those who have already seen taskbar edu before.

Fixes: 302589411, 300161174
Test: Went through taskbar education taskbar with the flag on and off.
Check that the standalone pinning taskbar only shows up if previous
taskbar education was already completed.
Flag:  ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I03a5fb05ae5f15892421a57355f6d503de56d9fd
2024-01-17 21:23:30 +00:00
Andy Wickham 32f2cae290 Merge "Allow stashed taskbar to be long pressed." into main 2024-01-17 21:09:15 +00:00
Shamali Patwa 56fd022d10 Merge "Filter shortcuts in the widget picker activity." into main 2024-01-17 14:15:51 +00:00
Pat Manning 5b7f564395 Merge "Add flag guard to hover actions in TouchInteractionService." into main 2024-01-17 13:05:20 +00:00
Pat Manning 8bcf485ac4 Add flag guard to hover actions in TouchInteractionService.
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states NEXTFOOD
Test: Manual.
Bug: 306745595
Change-Id: I74818f517b84c4aba8a7dd4a77397495595bbef5
2024-01-17 11:44:31 +00:00
Andy Wickham caf0c35661 Allow stashed taskbar to be long pressed.
Bug: 319175012
Test: Manual and unit test
Flag: NA
(see other change)

Change-Id: Ic8ac68d21c64a909a1035339d36f9c3b50a8963c
2024-01-16 21:43:46 -08:00