This reverts commit 238f630001.
Reason for revert: Root cause of P0 b/205278434
Bug: 205278434
Test: Local reverted and now launcher works on wembley
Change-Id: I5ee18d3ee1b671fcaedda633e7a268addd5c5c15
Foldables use a different menu from phones, positioned either to the
right or left of the app icon, and display an arrow. Since TaskMenuView
is very specific for handhelds, it was cleaner to create another class
to handle foldables case extending from ArrowPopup.
This creates a working menu, the correct style will come in later CLs.
Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: Icb068954e1e20a52d80c16c52d8e38ce9a181a8b
- There is an edge case that when ClearAllButton is visible, no split translation is applied, the offset adjustment needs to be calculated differently in that case
- Also, apply the scrollOffset to the TaskViews / ClearAllButton instead of updating min/max scroll
Bug: 200537659
Test: Split right in grid, split left with clear all button, split left without clear all button
Change-Id: I869c448bbec6aec8fa070e47193a692be6f75e84
- Open task menu directly instead of snapping to task, as there are spaces to do so unlike small screen
Fix: 201428316
Test: Tap task icon with clear all button shown in overview grid, no snapping
Test: Tap task icon with clear all button shown in non-grid overview, snapped to last task
Change-Id: Ief79f7c758c4109e5c7722b2f35647db98a9f05c
The proactive chips code has bit rotted and doesn't work properly anymore.
The product direction is not being pursued, so remove the code.
Bug: 201568600
Test: local
Change-Id: Ia00ceb027719c841bed665c1c50a132230bffe89
Add ActivityOptions#setLaunchDisplayId to the display that the TaskView
is currently on. So the task will be moved to the display as the user is
interactiving with.
This change is adding ag/15604010 back since b/197293995 is fixed.
Bug: 183461428
Test: Manually tested using Exo. Open appliction(e.g.Calculator) on
Exo virtual display, and tapping on the phone's recents to bring the
application back to phone.
The demo video https://drive.google.com/file/d/1JMncvsI-VPosK4ql2xeVA8csVAF7Rb16/view?usp=sharing&resourcekey=0-PYRw1k3KdtY0-KZNo6OqjQ
Change-Id: I39b1825b69d55001f66ee01a982e3cd366da56bd
Fixes: 200851336
Test: Split with one app from overview,
tap on app icon for second app. Gets
selected as second app.
Change-Id: I312169fe7bc42007c2f1a0146a5fef5f8d5f46d6
* For now we only show the App Info option
for each task icon clicked for GroupedTaskView
* Have TaskMenuView operate on a specific task instead
of only a TaskView
* NOTE: getItemInfo() in TaskIdAttributeContainer needs to
dynamically call getItemInfo(Task) because at the time of
creation of the container in TaskView#bind(), the task
object provided initially is a palceholder task which only
has a taskId and no other attributes set.
getItemInfo() needs a non-null baseIntent, which the
placeholder task doesn't have.
Right fix for this is to have GestureState hold onto
multiple running tasks when in split screen that are
provided by ActivityManagerWrapper when the gesture starts
(but that change is extensive and out of scope w/ this
workaround available)
Bug: 181704764
Test: Open TaskMenuView's w/ either task icon for
GroupedTaskView, opens up corresponding tasks menu.
Change-Id: I70b7c13394ad4980cabbd611cb928bb03d8a2924
* Hide all overview actions for GroupedTaskView
* Move some logic from TaskView into respective
PagedOrientationHandlers
* Remove unused methods from PagedOrientationHandler
* NOTE this is just visual changes. Properly showing
task menu's is still in-progress
Bug: 181704764
Test: Tested GroupedTaskView in portrait/landscape,
fake landscape in small screen, and real portrait/landscape
in large screen
Change-Id: I9c13ca114024db0a8e3fa5d295951696adb8516f
* TaskViewUtils only used one TVS, now it can use
multiple necessary for staged split.
* Consolidate creating RemoteAnimationTargets into
TaskViewSimulators/TransformParams into RemoteTargetGluer
Test: Swipe to overview, tap on running task.
Swipe to overview, tap on adjacent task (single + split)
Bug: 195675206
Change-Id: I31e4aece60e2eaf94ce87ffc736b33fe7e0e5804
* Also call it when user swipes to home
Fixes: 198310766
Test: Tested QS'ing split to fullscreen,
full to split, swipe to home from split and fullscreen
Change-Id: I6a465ead7fcd68dc85e0ab401789f4a5c3feb0d1
Regression from ag/15158868, we should not send onUserLeaveHint on
tapping on the app icon in Recents / Overview.
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/fr0fdecPEned7rMjgdWhCQ
Bug: 198682451
Test: manual, tap on app icon in Recents, see video
Change-Id: I66888a75eec30d7e8ba7e09059399381516812ac
and clear all.
- Stagger animation starts
- Adds a grid translation property to TaskView for animating these
translations.
Also fixes an issue where the gap between clear all and focused task is
greater than spacing between grid tasks and clear all.
Test: manual
Fix: 188793333
Change-Id: Ib2ba8b1b84dc63c4ba186bd0b9b4962d3c66ce5a
Shows up only for large screen devices, not phones.
Tested for NexusLauncher, general 3P launcher support
needed for staged split (TODO b/195607777)
Bug: 195423591
Change-Id: I4d455769b17637174b590c640516b9fbb6352c3d
This reverts commit 2cdc359b84.
Reason for revert: this brokes split screen and result to device reboot.
Bug: 197293995
Change-Id: I154287230fa3849cad1c0e337e3bf3fd826257a4
Update from getWindowCornerRadius(Resources) to
getWindowCornerRadius(Context)
Bug: 131221697
Test: make
Change-Id: Ia5f10e9292e205dab7e69d97dfc82d17690816fb
Add ActivityOptions#setLaunchDisplayId to the display that the TaskView
is currently on. So the task will be moved to the display as the user is
interactiving with.
Bug: 183461428
Test: Manually tested using Exo. Open appliction(e.g.Calculator) on
Exo virtual display, and tapping on the phone's recents to bring the
application back to phone.
The demo video https://drive.google.com/file/d/1JMncvsI-VPosK4ql2xeVA8csVAF7Rb16/view?usp=sharing&resourcekey=0-PYRw1k3KdtY0-KZNo6OqjQ
Change-Id: Iaed5aed4d698b71b0d0fc2b78843f4aedd586ecb
* Currently only works for portrait 50/50 split
* Have gesture swipe animation flow use multiple
TaskViewSimulators, one for each app in split
* Added new APIs in shell to query for actively running
tasks to determine if we're in split screen
* Lots of UI polish needed during gesture
* Launching into staged split after live tile ends
not implemented yet.
Bug: 181704764
Change-Id: Ib90e99e1e10b19121e8709385e1334b9380d6502
- Focused and non focused grid now have differnt margin between icon and snapshot
- The overall margin above snapshot is still the same
- Invoke updateChildTaskOrientations when focus task changes to update the margin
- Also lowered the row spacing according to spec
Bug: 194194694
Test: manual
Change-Id: I25267bef19d5a8b1dc1cf96fc1babdc3ebc39330
Only when taskbar is unstashed in apps:
- Scrim workspace with the taskbar color when opening apps and in BackgroundAppState
- Crop opening apps to above the taskbar
- Crop TaskViews to above the taskbar during gestures
If taskbar is stashed in apps, behavior is the same as before, i.e. no scrim over the wallpaper and no cropping of tasks.
Added a field DeviceProfile#taskbkarPresentInApps to distinguish these cases. LauncherTaskbarUIController and TaskbarStashController ensure this value is set appropriately.
Test: Ensure tasks don't appear behind taskbar when it's unstashed; set ENABLE_SCRIM_FOR_APP_LAUNCH = true to test the whole screen scrimming when opening an app
Bug: 196257194
Fixes: 190681228
Change-Id: I481501457a5a6d49c380feea3db3b4058e4cf3f8
- onRecycle removes the icon cache resulting on icon disappearing when entering overview
- only call necessary view transform reset in moveFocusedTaskToFront
Bug: 195415765
Test: quick switch, launch app then swipe up
Change-Id: Iadb7287ea307a3a4aa0acce2e37837142aeb90db
- Center the icon drawable in center of IconView with and allow a smlaler size to be set
Bug: 194194694
Test: dismiss focus task, swipe from app etc.
Change-Id: I2855249b13e2ccdb45f101bfb7afef4311f7b46f
* Follow up CL coming to introduce a TaskView that
can have multiple Tasks, so a taskID won't be particularly useful
in that scenario.
Bug: 192292305
Test: Manual, w/ and w/o live tile
Change-Id: I1900b999ac51aa99923239f2af400c90c71c3dae
- Simplified a lot of dp.isTablet && FeatureFlags.ENABLE_OVERVIEW_GRID.get() usage
Bug: 194194694
Test: manual
Change-Id: Idfb0ad192048106bbe6f8e2a28fa5613b86e5208
Allow starting split selection from live tile task.
Animation is still funky, but that's in a separate
CL altogether.
Fixes: 193212975
Test: Repro steps in bug no longer happen
Change-Id: I507628d3ef474936694dfbabfef5e0acf9f55b5d
These tooltips are added to educate the user about NIU buttons actions. We have added tooltips for Translate and Listen NIU actions buttons.
Bug: 186006700
Test: Manual
Change-Id: Ib076c2a44055b62f2daf06bddf45aca220a28756
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355
Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.
Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
Merged-In: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355
Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.
Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
Currently we place app surface below launcher and punch a hole through task view to display live tile in overview. In this change the order will be flipped, with a few benefits not limited to the following. For example, we have a surface view lifecycle bug where the surface view in a live tile app can go blank during app launch transition. This change will significantly mitigate the issue visually as the background wallpaper will not be revealed.
In order to make sure visually everything still looks the same, we will need to finish the recents animation when the user taps on the task view icon, since the menu overlaps with the task snapshort view.
This change also addresses fading out the task view when it's getting dismissed.
Test: manual
Fixes: 186531762
Fixes: 189265196
Change-Id: Ieae67fb89b60136fd81ceb8abde1a0cab8718b27
Greg Kaiser
Thales Lima
Tracy Zhou
Alex Chau
Zak Cohen
Iris Yang
Vinit Nayak
TreeHugger Robot
Pat Manning
Hongwei Wang
Shawn Lin
Jerry Chang
Tony Wickham
Ashish Gupta
Winson Chung