Commit Graph

34630 Commits

Author SHA1 Message Date
Sunny Goyal c52c0782a7 Merge "Adding support for determining split layout for launcher." into sc-dev 2021-05-04 22:33:38 +00:00
Steven Ng 3e6b93cedb Merge "Add a flag to enable custom local filter for recommended widgets" into sc-dev 2021-05-04 22:02:25 +00:00
TreeHugger Robot 7d54a31ba9 Merge "AssistContentRequester-weaken references to system callback" into sc-dev 2021-05-04 21:28:22 +00:00
Tracy Zhou a570b82aff Merge "Revert "Revert "Revert "Finish recents animation upon home rotation"""" into sc-dev 2021-05-04 21:17:45 +00:00
Tracy Zhou 06df8fe4d8 Revert "Revert "Revert "Finish recents animation upon home rotation"""
This reverts commit ef7b4d5dae.

Reason for revert: Possibly broke a test
Bug: 187112839

Change-Id: I16ac2a155af9a0ae2ea60f55c52e0b3bf4307089
2021-05-04 21:17:36 +00:00
zakcohen 7167c3f3c9 Make overview color tinting work properly.
Bug: 179922117
Test: Local
Change-Id: I0b6620be8184bab836ed91d087739df57817eb37
2021-05-04 13:56:34 -07:00
Evan Rosky 04fb7ee44c Fix a bug in TouchInteractionService for fixed-display input rotation
DisplayManager display size seems to be pre-rotation, so adjust
logic in TouchInteractionService to account for that.

Bug: 179274888
Test: atest Launcher3Tests:com.android.launcher3.ui.TaplTestsLauncher3
Change-Id: Ie89d7b7d74c8bece8a2c109a0b350bc190356bf2
2021-05-04 11:52:26 -07:00
Cyrus Boadway 04b8ac607e Add NEW_TASK flag to Quickstep App Widget activity start
Include the NEW_TASK flag to activity starts launched from Quickstep
hosted App Widgets.

This is consistent with the default non-Quickstep generated
ActivityOptions from RemoteViews::getLaunchOptions.

Bug: 169042867
Test: manual
Change-Id: Iba370731f4126d92a11a4e348e74888b533d4d8b
2021-05-04 18:38:48 +00:00
TreeHugger Robot 4a96831745 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-05-04 17:55:35 +00:00
Steven Ng 79d76b5041 Fix LayoutParams cast exception in drag-n-drop
Test: Pick up a widget from home screen. Then drop it and immediately
      pick it up again before the resize frame is dismissed. No crash
      is observed.
Bug: 186663184
Change-Id: Ia40676fbbf5d6dc2e2043aa7acd6ae00f1fa4179
2021-05-04 18:46:51 +01:00
Cyrus Boadway 3c94052bb5 Merge "Change flag type to control Quickstep widget app launch" into sc-dev 2021-05-04 17:34:01 +00:00
Jon Miranda 88b7f6a0d5 Move color extraction utils to extractor class so each instance can
have its own set of temp variables.

- Pass in float[] param to not create new obj in each frame
  for dragging widget case.

Bug: 175329686
Bug: 187019711
Test: manual, verify
Change-Id: I4350fb7e66a80c73def5659fb41abc14d357e667
2021-05-04 09:00:01 -07:00
Jonathan Miranda 21930da9a2 Revert "Revert "Use color extraction for arrow popup.""
This reverts commit 17fda29bf3.

Reason for revert: Fixing the memory leak

Leak was detected in caused launcher tapl tests to fail.
For instructions on how to debug leaks, see go/launcher-testing.
Using AS memory profiler, the color extractor class is holding
onto a reference to launcher that has already been destroyed.
The fix is to set the listener to null when view is closed.

Bug: 175329686
Test: run profiler in AS, open and close popups, and verify no leaks

Change-Id: I2d4a87f0481cbc88f3587dce91278e85ca113545
2021-05-04 08:53:58 -07:00
Samuel Fufa 30ffc3f95c Merge changes Ice83b544,If0bc2a6d into sc-dev
* changes:
  [Search][Motion] Modify interpolator for AllApps background scrim
  Cleanup/consolidate normal<->all apps interpolators
2021-05-04 15:06:51 +00:00
Cyrus Boadway 197c909483 Change flag type to control Quickstep widget app launch
Previously we'd relied on a SystemProperties to control which
InteractionHandler was used by Quickstep for widget app launches.

This switches to a more conventional FeatureFlag.

Bug: 169042867
Test: manual
Change-Id: I7abf815c6e204daf996ac0a81b1a354c4e3d5cda
2021-05-04 12:04:36 +00:00
Alex Chau 90f587f350 Maintain TaskView's scroll invariant when swiping down
Fixes: 186881810
Test: Swipe down from task other than running task, snaps in proper position in fullscreen
Change-Id: If1a667246804ebff8432b295a0bb22d17feb5c31
2021-05-04 12:51:23 +01:00
Bill Yi 9f8530948b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia5ca69da14eee63aa7d18caeb1a57d1556ab737a
2021-05-04 11:16:51 +00:00
TreeHugger Robot cc65b07d44 Merge "Adding support for using themed icons on workspace" into sc-dev 2021-05-04 06:03:17 +00:00
Winson Chung 7fbc961933 Allow binder calls from creating recents orientated state for now
- Should probably remove if possible since this is on a hot path

Bug: 187074722
Test: Presubmit
Change-Id: I104e1175acba7b90cd9824b905ffe68089beed9e
2021-05-03 22:27:24 -07:00
Samuel Fufa 3ab273da0c [Search][Motion] Modify interpolator for AllApps background scrim
Also rename ANIM_WORKSPACE_SCRIM_FADE to ANIM_SCRIM_FADE since
the scrim is shared between states now.

Bug: 183001675
Test: Manual in 3 button and 0 button modes
Change-Id: Ice83b54480bdf74155e8593c421b68d7186cf78a
2021-05-03 21:13:20 -07:00
Tony Wickham 154b1c928b Cleanup/consolidate normal<->all apps interpolators
We no longer need to have a different behavior for no button mode,
so make PortraitStatesTouchController the source of truth

Also remove unused ANIM_ALL_APPS_HEADER_FADE & RECENTS_FADE_THRESHOLD

Test: manually in 0 button and 3 button modes
Bug: 183001675
Bug: 175137718
Change-Id: If0bc2a6d6d3bf1649fad45226a4e6055f30e4880
2021-05-03 21:07:24 -07:00
TreeHugger Robot 13e4618b57 Merge "Fade out empty Overview message." into sc-dev 2021-05-04 03:49:54 +00:00
TreeHugger Robot 60f6662fa3 Merge "Temporary wait to check that waiting after swiping from context menu is a way to the real fix." into sc-dev 2021-05-04 03:18:07 +00:00
Santiago Etchebehere 7e6e1693ef Update the label of Wallpapers button
Use the updated name

Bug: 179129352
Test: manual
Change-Id: Ia4878ce924b7d7f3ba1d8d661c8ac00c7310ee20
2021-05-03 20:12:50 -07:00
Sunny Goyal 9ab43772ab Adding support for using themed icons on workspace
Bug: 183641907
Test: Manual

Change-Id: Ieda7e73b3ae4dfe3009e3f23754aff5f8826a967
2021-05-03 20:00:38 -07:00
Tony Wickham b55372cea6 Merge "Check for memory leaks after tests in FallbackRecentsTest" into sc-dev 2021-05-04 02:19:06 +00:00
vadimt e9ce95bed8 Temporary wait to check that waiting after swiping from context menu is a way to the real fix.
Test: presubmit
Bug: 187080582
Change-Id: Ief09857c267e8786bb6f67203db26b47f27060ea
2021-05-03 19:05:35 -07:00
Zak Cohen fed2a01fe4 Fade out empty Overview message.
When Overview is empty, fade out its contents on transitions.


Bug: 185447800
Test: Local build and test on P5
Change-Id: I9a0cd649f2f7353e4a7af21a93fb18be36f616a8
2021-05-03 16:47:35 -07:00
Tony Wickham 9b505e3148 Check for memory leaks after tests in FallbackRecentsTest
Test: e.g. goToOverviewFromApp()
Bug: 185806101
Change-Id: I6e618e850740afa69989f652321d4075d3cda13d
2021-05-03 16:46:16 -07:00
Jon Miranda 8fbf5cd263 Set swipe_up_rect_xy_stiffness back to 200 for existing app close anim.
Bug: 173107751
Test: manual
Change-Id: Ic878a2f788c35bffe97d83cb364d3878638272a1
2021-05-03 15:58:43 -07:00
Sunny Goyal 19ff728b92 Adding support for determining split layout for launcher.
> Simulating the windo wmanager API to get available device
  profiles until final API
> When a device has multiple internal displays, and with both
  tablet and phone possibilities, it uses a split workspace layout

Bug: 186160341
Bug: 175782275
Test: Manual
Change-Id: Ieff2329acac7cdd6b9abe6f96cd459cd45bd0efe
2021-05-03 14:48:28 -07:00
Zak Cohen daa3b8b9a3 AssistContentRequester-weaken references to system callback
The callback objects used to call into system server can
outlive the parent requester object. This can cause leaked
activities (on rotation for example). Use a weaker collection
of callback objects that aren't tied to the lifecycle of
the callback.

Bug: 186670923
Test: Ran TAPL tests to check for leaked activities
Change-Id: I33f556ad55b823652b06410d264f1473d3003320
2021-05-03 13:55:59 -07:00
Jon Spivack c71f134ec6 Merge "Add app package names to NIU Actions Intents" into sc-dev 2021-05-03 20:23:45 +00:00
Adam Cohen 0a1b030bb3 Merge "Don't fade out active page outline during drag-and-drop" into sc-dev 2021-05-03 19:15:22 +00:00
TreeHugger Robot f892756e62 Merge "Revert "Use color extraction for arrow popup."" into sc-dev 2021-05-03 18:27:53 +00:00
Vadim Tryshev 17fda29bf3 Revert "Use color extraction for arrow popup."
This reverts commit 242c805f82.

Reason for revert: Introduces a leak. I haven't seen a bug for it yet, but this CL is the only in the culprit list; the leak can block multiple teams presubmits, and the leak is via ArrowPopup. Enough evidence.
https://fusion2.corp.google.com/invocations/4b50db71-d598-4e52-9076-e91d42b65014/targets

Change-Id: I1700a9eea8705983598aee43c0a63e67c1d9cf71
Bug: 187075409
2021-05-03 18:27:41 +00:00
Tracy Zhou 299de3f292 Merge "Revert "Revert "Finish recents animation upon home rotation""" into sc-dev 2021-05-03 18:08:37 +00:00
Tracy Zhou ef7b4d5dae Revert "Revert "Finish recents animation upon home rotation""
This reverts commit 0f8787db80.

Reason for revert: Revert and fix the broken tapl test

Fixes: 184054813
Change-Id: Ib647e11bfa0a2dc79a5a815be56452bb07e04ddf
2021-05-03 18:08:31 +00:00
Sunny Goyal ada0acd75c Merge "Fixing nullPointer exception when wallpaper colors is null" into sc-dev 2021-05-03 17:59:05 +00:00
Zak Cohen 554cf58401 Merge "Overview - fade task icon instead of scaling it per new ux" into sc-dev 2021-05-03 17:52:46 +00:00
Cyrus Boadway 92af1bfe5b Merge "Create return-to-home app widget animation" into sc-dev 2021-05-03 17:51:45 +00:00
Samuel Fufa db9b483c02 [WorkProfile] Update work/personal tab to pills
Bug: 186857875
Test: Manual
Screenshot: https://screenshot.googleplex.com/89jD32tHqNkBUWb
Change-Id: Ia4bb91372896d8a53017e3eadbe985878ce7f0ec
2021-05-03 10:53:33 -05:00
yangbill 5f0f1abae2 Add workaround for testing Launcher3Tests
Correct test config path and adding LOCAL_COMPATIBILITY_SUPPORT_FILES.

Bug: 183540376
Test: atest Launcher3Tests
Change-Id: Ifd2a863cc1af838d78ed023a4405e3d2c450b62b
2021-05-03 15:01:51 +08:00
Hyunyoung Song e72dd4a859 Call windowInsetController.hide method when hiding keyboard
Bug: 186608200
Test: manual
Change-Id: I9a819aec217a91e8b6de58d074dbdb134dacaeb8
2021-05-02 23:20:55 -07:00
TreeHugger Robot cff951ab18 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-05-02 06:34:02 +00:00
Zak Cohen 20d00faf72 Overview - fade task icon instead of scaling it per new ux
Bug: 186256286
Test: Local build and run on p5
Change-Id: I318b62ddbf9cb475736d2844489a7ed2d9a8a409
2021-05-01 22:41:08 +00:00
Winson Chung 7c53f5d907 Merge "Take screenshot on ui helper thread in live tile" into sc-dev 2021-05-01 20:47:26 +00:00
Bill Yi b3609ce590 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia1732615c64fdae549156761932647f4dd14b4ba
2021-05-01 19:57:46 +00:00
Hyunyoung Song 0c1901bddd Merge "Check IME visibility check before calling IMM.hide()" into sc-dev 2021-05-01 19:32:46 +00:00
Jonathan Miranda 8d7bc38c34 Merge "Use color extraction for arrow popup." into sc-dev 2021-05-01 14:00:41 +00:00