Commit Graph

34630 Commits

Author SHA1 Message Date
TreeHugger Robot 5e6fc66eae Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-05-17 16:14:18 +00:00
Hyunyoung Song be26cb271f Merge "Fix searchbox font and other specs" into sc-dev 2021-05-17 15:56:36 +00:00
Alex Chau 58367f5346 Removed page spacing scaling
- Removed page spacing scaling as it casuses page jump problem without too much benefit, as the RecnetView's fullscale is less significant now (see b/187839470)

Fixes: 184262404
Test: Swipe up after quick switching
Change-Id: I1e080aa2d6530fdac120426ff4b92e19e128ec30
2021-05-17 13:32:39 +01:00
Bill Yi 420c767862 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia5ccecac9aa14e4d00d1beced9d823d80f8c1fcd
2021-05-17 10:51:51 +00:00
Bill Yi 8132baf3de Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I71372d68317892f9044ff5c8f9397f8f6fd70e71
2021-05-17 10:50:49 +00:00
Bill Yi 8d233cd42a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie6f2bc52b3b9f8af036e67d3527d2c77b89be7a0
2021-05-17 10:49:53 +00:00
Stevie Kideckel 360793ed01 Merge "Add start to widget app name layout gravity" into sc-dev 2021-05-17 10:34:54 +00:00
Hyunyoung Song 05d3e86401 Fix searchbox font and other specs
Bug: 187654557
Test: manual, see attached image on the bug

Change-Id: I570df1bcc926258ca406810ea10b3d1fdd3cd2ec
2021-05-17 01:08:44 -07:00
Hyunyoung Song 2cecad8e75 Catch NPE for AllAppsContainerView.dispatchRestoreInstanceState
TL;DR;;
Missing view id for work profile recycler view
caused restore failure as there are different type of
views that contains same id. However, even after that fix,
lack of view id in slice views generated by other process
causes failure when mFlags on these not restored slice
views needs to be accessed.

Bug: 186596139
Test: manual
Change-Id: I8a97598c27acbc05ac8a39c50fe5862e541d62ad
2021-05-17 00:47:28 -07:00
Yogisha Dixit 07449132fb Merge "Log widget features." into sc-dev 2021-05-15 15:07:40 +00:00
vadimt 2ecf126256 Removing @Stability flavors for unbundled.
They can be accidentally used.

Test: presubmit.
Bug: 187761685
Change-Id: I0cf859a51fb708ed51ba2f9506ab76af42ee3d5c
2021-05-14 17:42:24 -07:00
Winson Chung 8b74cbbf96 Merge "Add a content overlay for auto-enter w/o a source hint rect" into sc-dev 2021-05-14 23:44:24 +00:00
Yogisha Dixit 0b15c7ee07 Log widget features.
Design doc: go/widgets-logging
Note that this doesn't log dynamic colors yet. I'll work on that in a
follow-up CL.

Bug: 185778648
Test: manual
Change-Id: I04249ef267907b4112c220fb206e077d1bee783a
2021-05-15 00:26:41 +01:00
Tony Wickham 82d5a0681d Revert to overview coming from the side instead of bottom
Test: Visually checking all of these. As appropriate, repeat in 0, 2, 3
button modes, landscape/portrait/fake landscape, and 3P launcher
- Quick switch from home
- Home to overview
- Overview to home (swipe up)
- Overview to home (tap outside)
- Overview to home (back invocation)
- Quick switch from app
- Swipe up and hold from app
- Dismiss an app
- Empty recents
- Split select state to home
- Modal state to home
Fixes: 185411781

Change-Id: If00a22fee35c832a259bfc62808efbac5990ce2e
2021-05-14 16:06:44 -07:00
Schneider Victor-tulias 262ae769b0 Reapply All Apps icons on download complete.
Fixes: 187853323
Test: manual
Change-Id: I800a13a3665997f323f23667c8128c8034a7b4d3
2021-05-14 15:29:18 -07:00
Tony Wickham 41c73d4a23 Merge "Fix AnimatorListeners.forEndCallback()" into sc-dev 2021-05-14 22:18:58 +00:00
Zak Cohen 02ca6c14dd Merge "Overview - don't update task overlay on thumbnail update." into sc-dev 2021-05-14 21:52:55 +00:00
Tony Wickham 38dd6ec901 Fix AnimatorListeners.forEndCallback()
Override onAnimationEnd(Animator), rather than (Animator, boolean)
which may not be called.

Test: Swipe right to quick switch from home, then swipe back left
(in the same gesture), ensure next quick switch isn't broken.
Bug: 185554764

Change-Id: I53e7526ed5b55fbae9aa654ace70a6ef7561e1d8
2021-05-14 14:49:08 -07:00
vadimt 9400d2be3e Leak 2 views for the view leak detection test
This compensates for the noise in the view count.

Test: labtest
Bug: 187761685
Change-Id: I04a256f2b36a62e6c7c602d51cccf3a6f1c75ee0
2021-05-14 14:06:22 -07:00
Vadim Tryshev 217e7100bc Merge "Revert "Temporarily demoting failing tests from presubmits"" into sc-dev 2021-05-14 18:17:41 +00:00
vadimt f9ccf0175d Revert "Removing workaround for battery defender"
This reverts commit f4bb052ca0.

Reason: we have new episodes of phone locking during the test.
https://flakes-clusters.corp.google.com/#?androidAtpBranch=git_sc-dev&androidAtpModule=com.google.android.apps.nexuslauncher.out_of_proc_tests&d=3&maxResults=10

https://flakes-clusters.corp.google.com/#?androidAtpBranch=git_sc-dev&androidAtpModule=com.google.android.apps.nexuslauncher.tests&d=3&maxResults=10

Search for "Phone is locked" and "Keyguard is visible".

Also, for new devices, the phone is locked consistently, see for example
Redfin here:
https://blackbox.googleplex.com/dashboard/Launcher3Main_new_devices/testsuite/git_master/nexuslauncher_oop_tests_platform/2/bramble-userdebug/0

Reverting to see whether this helps.

Bug: 151613234
Test: presubmit
Change-Id: I44a94f9722deaa21d89fdfd79646ae661ebe972d
2021-05-14 11:14:35 -07:00
Cyrus Boadway a27ebc1633 Merge "Add interaction jank monitoring for widget app launch CUJ" into sc-dev 2021-05-14 17:40:16 +00:00
Tracy Zhou 7ad2e846b4 Detach nav bar from app after settling into overview
Fixes: 185042209
Test: manual
Change-Id: Id302ac9f8e86c3af6b2c05a4314401505eb26b1e
2021-05-14 10:37:44 -07:00
Alina Zaidi d80cec62b4 Modify pin widget dialog open-close animation.
Pin widget sheet should open from bottom up and close on drag down.
Behaviour with navigation bar is similar to that of widgets bottom sheet.

Add a drag layer and reuse AbstractSlideInView for open-close
animation.

Test: Tested manually- opening, closing through dragging/ cancel button/
back button. Adding widget to screen by dragging/ add to home screen
button.
Bug: 186124244

Change-Id: I4b77d5bdd4ed1689b651847dfed69d19cafa7456
2021-05-14 17:59:50 +01:00
Cyrus Boadway 960ab121db Fix SDK guard
Use dev-friendly utility instead of Build version codes.

Bug: 169042867
Test: manual
Change-Id: I528bafdcad8644e6f96caf5ada4f44ed2b8dff06
2021-05-14 16:35:40 +00:00
Steven Ng 3503e6fa25 Add a scrim underneath the top section of search & recommendation UI
Test: In the full widgets picker, scroll up. Recommended widgets are
      not visible behind the search bar when they overlap.
Bug: 188021019
Change-Id: I13144ad534c74393bb1b12c651e734bb8bee0bc2
2021-05-14 17:03:01 +01:00
Sunny Goyal 10dfa61db8 Merge "Revert "Revert "Exposing AnimatorListeners in StateManager to receive both success and failure callback""" into sc-dev 2021-05-14 15:46:14 +00:00
Stevie Kideckel 5fc74c7f8f Add start to widget app name layout gravity
This fixes the alignment issue in RTL. Seems like the default is start
if layout_gravity isn't set, but if you set layout_gravity to
center_vertical, you need to explicitly set start or it will go to the
left.

Bug: 188147009
Test: validated locally and in AS layout preview
Change-Id: Ic4b4d7e6dfe03e1e6dd3ead5c3821e77261b4bb5
2021-05-14 12:37:44 +00:00
Tracy Zhou c9bf0f6161 Pass home rotation state to SysUI
Fixes: 185962767
Test: manual

Change-Id: I3d2103b665f099a087545a97fdb84bc240b8d261
2021-05-13 22:12:12 -07:00
zakcohen a6ca69aa53 Overview - don't update task overlay on thumbnail update.
Only init and reset the task overlay on the enabled state of the overlay
changing.
Previously the overlay was also updated when the thumbnail changed, but
this can happen for lots of different reasons so was causing janky
transitions and potentially excess work in code that was following the
overlay.

The overlay code really only cares about the thumbnail after the task has
settled, so should be safe to ignore the thumbnail updates.



Bug: 188097940
Test: local build and run on p5
Change-Id: I4ad1767046cb0316af19713bc188788d8f581d7c
2021-05-13 16:35:49 -07:00
TreeHugger Robot e010332efd Merge "Enable free scroll immediately if gesture goes to overview" into sc-dev 2021-05-13 21:23:05 +00:00
Tony Wickham 1eea52296b Merge "Remove mOnRecentsScrollListener when continuing quick switch gesture" into sc-dev 2021-05-13 19:49:41 +00:00
Alex Chau 6a5920c682 Enable free scroll immediately if gesture goes to overview
Fixes: 186871947
Test: Swipe up from app, scroll immediately, free scroll should be enabled
Change-Id: I20b782df04fb6e61dfd5c7e82e1ab90dbd6ed8fc
2021-05-13 20:39:15 +01:00
Cyrus Boadway a1d303e531 Merge "Register a remote animation for the next activity start" into sc-dev 2021-05-13 19:33:59 +00:00
Cyrus Boadway c169e5b9af Register a remote animation for the next activity start
Widgets are permitted to start broadcast receivers which launch
activities, otherwise known as a broadcast trampoline. Unfortunately,
launch animations provided through ActivityOptions are not applied to
the activity launch.

If a widget interaction's pending intent is not an activity, set a
return animation for the next activity start, in the event it starts an
activity.

Bug: 169042867
Test: presubmit
Change-Id: Ibbee9cadcd5153e285433fcb1b8038d77b1384a2
2021-05-13 17:56:14 +00:00
Winson Chung 549ea0b3a9 Merge "Skip setting up ui if the handler is already invalidated" into sc-dev 2021-05-13 17:28:06 +00:00
Sunny Goyal 01b32466c3 Revert "Revert "Exposing AnimatorListeners in StateManager to receive both success and failure callback""
This reverts commit d7f11d5fb9.

Reason for revert: Fixed initial error
Bug: 185554764

Change-Id: I32cc49f9b3820166736ceb347f33577939aa6efa
2021-05-13 10:23:35 -07:00
Vadim Tryshev a7c9c14444 Revert "Temporarily demoting failing tests from presubmits"
This reverts commit 395c58d303.

Reason for revert: The bug was fixed

Bug: 187899876
Change-Id: I73f93f5fb1ec0ab0352ba174aabbaf6935dd9fc4
Test: presubmit
2021-05-13 17:20:36 +00:00
TreeHugger Robot c632e36dc0 Merge "Fix CastError on SecondaryDisplay" into sc-dev 2021-05-13 17:12:51 +00:00
Samuel Fufa ff9fcd8e6b Fix CastError on SecondaryDisplay
Bug: 185566696
Test: Manual
Change-Id: I0dbf0edccc40172e802cc197e200a8fb9502b4ec
2021-05-13 10:27:11 -05:00
Hyunyoung Song e2522016ae Merge "Use IMM.hideSoftInputFromWindow to close the window" into sc-dev 2021-05-13 15:23:44 +00:00
TreeHugger Robot 4b374c6680 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-05-13 14:09:49 +00:00
TreeHugger Robot 72aa0c119d Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-05-13 14:09:18 +00:00
TreeHugger Robot 1634de1d18 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-05-13 14:06:53 +00:00
Hyunyoung Song af6686bf1f Use IMM.hideSoftInputFromWindow to close the window
Bug: 187589678
Test: manual
Change-Id: Id46a36432a03638877f854f32bfa03183c7cb019
2021-05-13 01:13:57 -07:00
TreeHugger Robot 85584c9eba Merge "Add workaround for testing Launcher3Tests" into sc-dev 2021-05-13 07:42:47 +00:00
Bill Yi 57d250944a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I01c33a3b97106b9b40c6175118e9d47153d8599c
2021-05-13 07:40:05 +00:00
Bill Yi 6b2be3789c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia6bc84a966d24fa30a9a5d812c76bd18066acf31
2021-05-13 07:39:28 +00:00
Bill Yi 2a99f41b95 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iadb532dd2ccc98ba1437e944adf69a9ffb62fba2
2021-05-13 07:38:56 +00:00
Winson Chung af7c86ada5 Skip setting up ui if the handler is already invalidated
- Also unregister the task stack listener in case the restart
  message comes in right before the animation is finished

Bug: 186760990
Test: Swipe up/quickswitch repeatedly
Change-Id: I5af7a26f05e7c15e099d6666e4662fd1af9aa861
2021-05-12 20:33:32 -07:00