Commit Graph

34630 Commits

Author SHA1 Message Date
Samuel Fufa 41f15a107f [Search] Resolve afterimage when closing allapps
Preview: https://drive.google.com/file/d/1AM6WAY4kImCgHueNvH6eXUtnHgK3U6vo/view?usp=sharing&resourcekey=0-3mzBobzFuzQXCNZRUlToYA
Test: Manual
Bug: 184711608
Bug: 188556051
Change-Id: Ib43c71083460c236347dd1f340b1ad95d7d4aa15
2021-05-25 17:34:18 -05:00
zakcohen dad8a80d19 Overview - Remove the space withheld for proactive chips
Remove the space in the ui that was being used for chips.
Centralize some of the logic around calculating the action margins to aid
that.

Bug: 179922117
Test: Local build and flash and run
Change-Id: Icd2f894c858fab475c5411f3f7c412b899d5b220
2021-05-25 15:29:08 -07:00
Steven Ng 0bc0f10aac Merge "Fix tabs abruptly reset during swipe" into sc-dev am: 530f644788
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690878

Change-Id: I0fdaead265b85eac1221add68a0d1ca8ed20331f
2021-05-25 22:23:54 +00:00
Steven Ng 530f644788 Merge "Fix tabs abruptly reset during swipe" into sc-dev 2021-05-25 22:21:25 +00:00
TreeHugger Robot 9d308d0af0 Merge "Fix full widgets picker fast scroller height." into sc-dev am: 17385ce33e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14683794

Change-Id: I778e855c91ace63fc7386a6995056adf4fe9e228
2021-05-25 22:16:12 +00:00
TreeHugger Robot 17385ce33e Merge "Fix full widgets picker fast scroller height." into sc-dev 2021-05-25 21:43:40 +00:00
Vinit Nayak 063cb2d892 TaskMenu in overview UI polish
Bug: 188168717
Test: TaskMenuLooks closer to mocks.
Change-Id: I1560b66a48c4c70c7c79f7307b2b76f22e30c653
2021-05-25 14:42:35 -07:00
Schneider Victor-tulias 8a3a857668 Update Gesture nav tutorial.
- Seperated back left and right edge tutorial steps
- updated back left and right tutorial step strings
- Removed feedback view timeout
- Added accessibility focus on title when feedback view appears
- Added logic to show feedback when the tutorial fragment is stopped then resumed

Test: manual

Bug: 169687177
Fixes: 188116424
Fixes: 188115939
Fixes: 188124784
Fixes: 188555152
Fixes: 188972969

Change-Id: I97755a455bf3fa4674955d5cc91ed8b02f484b76
2021-05-25 14:16:41 -07:00
Winson Chung e6ba6cf940 Merge "Revert "Enable SplitSelect flag by default"" into sc-v2-dev 2021-05-25 20:27:49 +00:00
Winson Chung bdaa6036ec Revert "Enable SplitSelect flag by default"
This reverts commit 3f47826339.

Reason for revert: b/189245318

Bug: 189245318

Change-Id: I5e6704711cc7577102123ffc67c97a5644e7e86b
2021-05-25 20:26:01 +00:00
Samuel Fufa 880fc577c0 Remove AllApps prediction edu
Test: Manual
Bug: 183579072
Change-Id: Ibaffc5ac711e35df5256baed8be57159046fbdda
2021-05-25 14:48:14 -05:00
Sunny Goyal 6ba7479cf5 Merge "Using icon color for dot and halo" into sc-dev am: 47da5d628c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14684870

Change-Id: I4683179ba16afb819a7059ea3fa5f1f2321c72ff
2021-05-25 18:43:35 +00:00
Sunny Goyal 867aeb5436 Merge "Updating method for getting themed icon" into sc-dev am: a71269e372
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14682086

Change-Id: I5a328837285d1600dd80d0ff9a17cf577f546210
2021-05-25 18:43:23 +00:00
Sunny Goyal c4c3269206 Crossfading splashscreen if icon is themed
Bug: 188840653
Test: Manual
Change-Id: Ibd00bb1a94576a7512872eba39a936c174f9871d
2021-05-25 18:25:18 +00:00
Sunny Goyal 47da5d628c Merge "Using icon color for dot and halo" into sc-dev 2021-05-25 18:24:56 +00:00
Sunny Goyal a71269e372 Merge "Updating method for getting themed icon" into sc-dev 2021-05-25 18:24:38 +00:00
Alina Zaidi ba4eaf73b5 Merge "Add more education tips for widgets. (1/3)" into sc-dev am: e6521ad542
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14620021

Change-Id: I5f8e69315a7752ac2bf0484ec5729016ee1a5687
2021-05-25 17:56:30 +00:00
Alina Zaidi e6521ad542 Merge "Add more education tips for widgets. (1/3)" into sc-dev 2021-05-25 17:35:27 +00:00
Evan Rosky e902918a31 Fix launcher-in-transition-targets detection
Shell transitions promotes animation up to root task so
we can't compare to leaf-taskid derived from ActivityRecord.getTaskId
since home tasks are all children of a root and thus aren't
organized.

This replaces the task-id check with a componentname check.

Bug: 172695387
Test: with shell transit enabled, launch an app from launcher
      and observer launcher content animating.
Change-Id: Ieeca72b57ec47c9cbe15e635f5026b53edebd0ad
2021-05-25 10:22:54 -07:00
TreeHugger Robot 1919443e37 Merge "Enable SplitSelect flag by default" into sc-v2-dev 2021-05-25 16:29:10 +00:00
Stevie Kideckel 43a6be4b82 Remove intrinsic padding from widget previews
Also, scale down the preview size if it's wider than the target cell.

The intrinsic padding prevents the corners of the preview from being
rounded correctly and can lead to clipping or no rounding, especially at
larger sizes.

Bug: 187141692
Test: verified locally
Change-Id: Ie57ad57ba7c102330324bd0439acc55ff4fd83ff
2021-05-25 16:26:32 +00:00
András Klöczl adbe369451 Merge "Add two panel home support for page binding logic" into sc-v2-dev 2021-05-25 12:04:55 +00:00
TreeHugger Robot 21d92dc101 Merge "Fix ripple effect shown when tapping an app row in widgets picker" into sc-dev am: 8deaffed89
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14701660

Change-Id: I7b7c006bf4af71badad74897592fbbd273fc5961
2021-05-25 11:59:30 +00:00
TreeHugger Robot 4cd5fee186 Merge "Adjust padding, margin of tabs in the WidgetsFullSheet" into sc-dev am: 1002981fd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14602830

Change-Id: Iab84c81890bbcc9ee50507513f62e0e8cddd812a
2021-05-25 11:59:13 +00:00
Steven Ng 2ed3087743 Merge "Remove all apps tabs elevation" into sc-dev am: 2c7c629704
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14682327

Change-Id: Id206122b6b60ab3228388dca8db67db8318fefd3
2021-05-25 11:58:29 +00:00
shawnlin b3b2b64588 Support the nav animation in widget launch remote animation am: 3380ab3053
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14694591

Change-Id: I9e8632a69c8baa0ffdb4b3d1e83d3f361e40d340
2021-05-25 11:55:07 +00:00
TreeHugger Robot 8deaffed89 Merge "Fix ripple effect shown when tapping an app row in widgets picker" into sc-dev 2021-05-25 11:53:33 +00:00
TreeHugger Robot 1002981fd7 Merge "Adjust padding, margin of tabs in the WidgetsFullSheet" into sc-dev 2021-05-25 10:49:39 +00:00
Steven Ng 2c7c629704 Merge "Remove all apps tabs elevation" into sc-dev 2021-05-25 10:33:14 +00:00
Alina Zaidi 9d24de1353 Add more education tips for widgets. (1/3)
Show Arrow education tip on WidgetsBottomSheet. This tip is shown only
once either in widgets full sheet or bottom sheet.

Test: Tested manually
Bug: 185354491
Change-Id: I6d770ed0906a5cb0f5bcfe6ae0cd327b790cf164
2021-05-25 10:50:02 +01:00
shawnlin 3380ab3053 Support the nav animation in widget launch remote animation
Launcher now support remote animation for widget but doesn't add the nav
animation for this type of animation.

Add the nav animation in widget launch remote animation in launcher.

Bug: 185303414
Test: manual - launch a widget in launcher and observe the nav bar
Change-Id: I11f4bd75b9624118b8ffef09c99f54fc7f1fbbca
2021-05-25 03:43:25 +00:00
Jon Miranda 6a7a7f6bad Set FLAG_IMMUTABLE flag on FirstScreenBroadcast PendingIntent.
Bug: 179289753
Bug: 183927137
Test: restore phone and ensure broadcast is sent
Change-Id: I8d8e38a1aa6bdf13879d460cfa84cabe6c6bb1f2
(cherry picked from commit b62fba0d01)
Merged-In: I8d8e38a1aa6bdf13879d460cfa84cabe6c6bb1f2
2021-05-25 02:48:33 +00:00
vadimt 6fad078a31 Adding more diags for WellbeingModel
Test: presubmit
Bug: 189139513
Change-Id: Ic52ef42d2cd0a3f19f55aee048911526dd8c732f
2021-05-24 16:42:07 -07:00
Steven Ng 21979aca50 Fix tabs abruptly reset during swipe
The indicator position has already been updated by
PersonalWorkPagedView#onScrollChanged. The updateIndicatorPosition
call in setActiveMarker has abruptly reset the mScrollOffset to a page
index rather than a [0f, 1f] offset.

Test: On a work profile device, swipe left & right in the all apps.
      Then, swipe left & right in the full widgets picker. In both
      cases, I no longer observe an abruptly reset of the tabs
      transition animation.
Bug: 187704466
Change-Id: I53c4ed3a98219093f3d61dfa4de2fe21ec88851c
2021-05-24 23:57:28 +01:00
Schneider Victor-tulias b199e20acc Enable unpausing apps from the workspace.
Fixes: 188675002
Test: manual
Change-Id: I02715450016e9b91fff774525b5e32c337c74547
2021-05-24 21:44:29 +00:00
Andras Kloczl 55edfe55f7 Add two panel home support for page binding logic
There's a logic which prioritizes the binding for the
current page and defers the other pages' binding.
If two panel home is enabled, we want to bind both pages
together. LauncherPageRestoreHelper has been created to
contain the logic for persisting restoring and calculating
which pages to load immediately.

Test: manual + run LauncherPageRestoreHelperTest robo test
Bug: 174464691
Change-Id: I57ac3f7150303b95b272e922f44bda26f9d5ce2a
2021-05-24 23:22:06 +02:00
Alex Chau 7d964726d5 Ensure RecentsOrientedState.mRecentsRotation is up to date on swipe up
- Updates RecentsOrientedState.mRecentsRotation after launcher is started, as it's not updated when RecentsView is in foreground when device rotates e.g. inside another app
- No longer calls updateOrientationHandler in onConfigurationChanged, as updateOrientationHandler is already called in setInsets, which get called on rotation

Bug: 181550945
Test: Swipe up to enter overview, launch app, rotate, then swipe up again
Test: Swipe up to enter overview from landscape only app, while holding device in portrait
Change-Id: I268093617d51333678e510c910ed15275706f984
2021-05-24 19:10:49 +01:00
Alex Chau 960a2b2696 Always focus a task in overview
- Focus first task when applying load plan
- Focus the next task in shorter row when focused task is dismissed, scale the snapshot and translate the task into focused position
- Always show actions view as there is always a focused task. Update scroll alpha when toggling grid enabled
- In fallback recents, take into account that home task will be dismissed when determining rows for the grid, ensuring next focused task won't affect row balancing
- Bring back clearAllShortTotalCompensation as there isn't always a snappedTaskView (e.g. when snapped to ClearAllButton)
- Ensure that getFocusedTaskView is only used when showAsGrid is true

Bug: 187839470
Fixes: 188001858
Fixes: 189057812
Test: manual
Change-Id: I6f31ef469c58fda70d2dd8caa2ee7d8a80c7f03b
2021-05-24 18:13:04 +01:00
Steven Ng e90dddaaa0 Fix full widgets picker fast scroller height.
1. Fix the app title to one line.
2. Use the measured height of a header view to estimate the available
   fast scroll bar height.

Test: Open full widgets picker. Scroll to the bottom by scroll gesture.
      Observe the fast scroll bar indicator is correctly shown.
      Scroll back to top and then use the fast scroll bar to scroll to
      the end of the page. Observe the last app row is aligned to the
      bottom of the page.
Bug: 188914448
Change-Id: I57a2419d1fbfc8f946a932eebfefb67ae0c07eb6
2021-05-24 18:05:56 +01:00
Steven Ng f375e8bebc Fix ripple effect shown when tapping an app row in widgets picker
Test: Open the full widgets and tap an app. Ripple effect is applied
      to the entire row rather than just on the arrow.
Bug: 188873069
Change-Id: Id77b2055f6bc31c12bb19e695ea44aeaff36c4a6
2021-05-24 16:32:56 +01:00
Steven Ng f4afb6bc17 Remove all apps tabs elevation
Test: Set up a work profile. Open all apps and observe no shadow around
      tabs.
Bug: 188727345
Change-Id: I5b8594002dbd8155b45376103d44fbda12ebe001
2021-05-24 14:55:33 +01:00
Steven Ng ede641bd77 Adjust padding, margin of tabs in the WidgetsFullSheet
Also remove elevation set to tab to remove unwanted shadow.

Test: Set up a work profile. Then, open the full widgets picker.
      Observe padding & margin of the work / personal tabs.
Bug: 188221455
Change-Id: I761cb1c1410f87c80a5fdca3803fb8b099d499d6
2021-05-24 11:40:16 +01:00
Jonathan Miranda f3649f5e98 Merge "Fix PathParser error when parsing app close interpolator in RTL languages." into sc-dev am: 81f5ff3b3b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14688336

Change-Id: I4090adb746e959d66ac33940e1989ea30c97ee8f
2021-05-22 04:38:50 +00:00
Jonathan Miranda 81f5ff3b3b Merge "Fix PathParser error when parsing app close interpolator in RTL languages." into sc-dev 2021-05-22 03:45:29 +00:00
Sunny Goyal 12829aee27 Merge "Renamin TaskbarContainerView to TaskbarDragLayer" into sc-dev am: 2f0595e76e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14680570

Change-Id: Ic3aa579ebc2df7b3053f8df14bceebea0e2850aa
2021-05-22 02:32:40 +00:00
Sunny Goyal 2f0595e76e Merge "Renamin TaskbarContainerView to TaskbarDragLayer" into sc-dev 2021-05-22 02:16:34 +00:00
TreeHugger Robot b841731a35 Merge "Fixing missing unlinktoDeath" into sc-dev am: eb0a14ad79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14684233

Change-Id: I3acf3f5c5a340b3686e41e67fb885b072de44ead
2021-05-22 01:25:26 +00:00
TreeHugger Robot eb0a14ad79 Merge "Fixing missing unlinktoDeath" into sc-dev 2021-05-22 01:05:05 +00:00
Jon Miranda 7c9dca2df2 Fix PathParser error when parsing app close interpolator in RTL languages.
Setting locale to english so that the numbers don't get reverted

Bug: 188552618
Test: set language to arabic, swipe up to home
Change-Id: I736c83984b472d9ad09207927743c87b18637db4
2021-05-21 17:20:07 -07:00
Sunny Goyal b5596f72e4 Fixing missing unlinktoDeath
Bug: 186712316
Test: Manual
Change-Id: If06737403c346c5ccca533dec647e3a0691f1bfa
2021-05-21 15:29:33 -07:00