Commit Graph

34630 Commits

Author SHA1 Message Date
Tobias Dubois 4cb241ff5e Merge "Use View.getHeight() instead of Canvas.getHeight() for PageIndicatorDots" am: c66f5ebd63
am: bb57b5bfab

Change-Id: I7661ca288a88c23b9458b2a91bfc285b567b13f9
2018-08-23 12:14:07 -07:00
Tobias Dubois bb57b5bfab Merge "Use View.getHeight() instead of Canvas.getHeight() for PageIndicatorDots"
am: c66f5ebd63

Change-Id: I248336bdb569519ecf8b17657344bc154373f197
2018-08-23 12:08:07 -07:00
Sunny Goyal 911378c8d9 Merge "Use View.getHeight() instead of Canvas.getHeight() for PageIndicatorDots" into ub-launcher3-master 2018-08-23 18:57:06 +00:00
Treehugger Robot c66f5ebd63 Merge "Use View.getHeight() instead of Canvas.getHeight() for PageIndicatorDots" 2018-08-23 18:56:39 +00:00
Vadim Tryshev d819b8f743 Comment fix
Bug: 110103162
Test: ReflectionBasicUiTest
Change-Id: Ic9cfe925bb396e3fa0257009d5d9f53db728f9f0
2018-08-23 18:48:06 +00:00
Tobias Dubois 53da286c05 Use View.getHeight() instead of Canvas.getHeight() for PageIndicatorDots
Use View.getHeight() instead of Canvas.getHeight() to get the same height
regardless of using hardware or software accelerated drawing.

Test: manual
Change-Id: I475afef017102d7968f28a7aab8116238af3d90d
2018-08-23 10:37:58 -07:00
Tobias Dubois 9c0ad56d11 Lint fix: IS_DEBUG_DEVICE: Implied default locale
Use the ROOT locale to make sure toLowerCase has consistent behavior
regardless of the currently set language.

Test: Manual
Change-Id: Ie43f76cbc15eee0d96314e92d2acd5abb22f7077
2018-08-23 10:32:59 -07:00
Vadim Tryshev 9aca88cbf9 Fixing tests on a larger device
See atp for failed tests.

Widget container may return objects outside of screen, hence the test
failures.

Test: AddConfigWidgetTest.com.android.launcher3.ui.widget.AddConfigWidgetTest etc
Change-Id: Ia402dae0c9bc8f0585e57ac5f562a59e8ff4ed53
2018-08-22 17:35:18 -07:00
TreeHugger Robot 99d586a4fb Merge "Passing instrumentation to LauncherInstrumentation" into ub-launcher3-master 2018-08-22 23:54:06 +00:00
Winson Chung 6ed64355b4 Use clear-all recent tasks call
Change-Id: I1c93bffa0573d0a37a86b62f5a7ec948ac11799e
2018-08-22 16:16:16 -07:00
Sunny Goyal 018e3c4447 Update the shared lib for lambda definitions removal
Bug: 112849320
Change-Id: I9b8971a84368eee88bf6fc5a4c0e39b32e7ea891
2018-08-22 15:46:38 -07:00
Jon 170be9beb0 Merge branch 'ub-launcher3-edmonton-polish' into pi-dev
Bug: 112854572
Bug: 80134723
Test: manual
Change-Id: I9dacb5203e16ddad8d685058cdd19b689585acc8
2018-08-22 18:12:49 -04:00
TreeHugger Robot a75f0395ee Merge "Preventing padding from getting reset when the widget updates" into ub-launcher3-edmonton-polish 2018-08-22 21:41:33 +00:00
Android Build Merger (Role) 840bd3762c [automerger] Preventing padding from getting reset when the widget updates am: 4cbbaedb2c
Change-Id: I851c06714e0809a9afb108b8c66a0d01384e3c41
2018-08-22 21:34:10 +00:00
Sunny Goyal 4cbbaedb2c Preventing padding from getting reset when the widget updates
Bug: 112854572
Change-Id: Ia2963310997ca13f2e1f18f7268b0b9b54a53590
2018-08-22 14:34:03 -07:00
TreeHugger Robot 2eb4708960 Merge "Revert "Use clear-all recent tasks call"" into ub-launcher3-edmonton-polish 2018-08-22 21:22:47 +00:00
Android Build Merger (Role) b055da40fa [automerger] Revert "Use clear-all recent tasks call" am: dbbed57094
Change-Id: I9326766a3fe2b6334a885eebada339ea2e33a64c
2018-08-22 21:12:57 +00:00
Winson Chung dbbed57094 Revert "Use clear-all recent tasks call"
This reverts commit 68df758665.

Reason for revert: Should be in master

Change-Id: I1a0d54c606c8cf1e52d5bdbfcd1acc6d0211ab49
2018-08-22 21:12:56 +00:00
Vadim Tryshev fd34b94b33 Passing instrumentation to LauncherInstrumentation
UiDevice, the old param, belongs to a support lib; as TAPL switched to
AndroidX, it became impossible to pass it from platform tests
that still use the old support lib.

Bug: 110103162
Test: TaplTests
Change-Id: I1f82099b432912fa40da96df0d6179579aab66a3
2018-08-21 18:45:02 -07:00
TreeHugger Robot 23bb710b3d Merge "Converting tests to Androidx" into ub-launcher3-master 2018-08-22 01:22:56 +00:00
Android Build Merger (Role) dcd6be2fa2 [automerger] Kill launcher when display size changes am: f2b97f8cd8
Change-Id: I7fef11b9369f0ac54c21afeac84fd9e756658a2e
2018-08-21 20:37:42 +00:00
Sunny Goyal f2b97f8cd8 Kill launcher when display size changes
Bug: 112876936
Test: Verified by changing display cutout overlay
Change-Id: I3ca13c7be873509334457e3484ac5604731adeae
2018-08-21 13:37:38 -07:00
Vadim Tryshev 0a9f3ab4a6 Converting tests to Androidx
Bug: 112610679
Change-Id: I712826e668f1fbeb4e47cc541d4f5296d8eb74c0
2018-08-21 15:04:48 -04:00
TreeHugger Robot ae6d9ed3c5 Merge "Reducing time of TaplTests run" into ub-launcher3-master 2018-08-20 22:29:47 +00:00
arangelov e6627ebfed Don't call BottomUserEducationView#close() while running animation.
If while the work profile info card opening animation was
playing you pressed the Work tab repeatedly, close() was
called. That caused the animation to never complete
properly (onAnimationEnd() was never called). This CL
makes sure to not call close() if the animation is
still running.

Bug: 112471462
Bug: 112188042
Test: Manual
Change-Id: I2e62e0c5c6f1d6132ea359a85cb6aadf57639c30
2018-08-20 17:23:15 +01:00
Tony Wickham 2bcc9ba5ef Merge "Cancel badge scale anim when setting new badge scale" into ub-launcher3-master 2018-08-17 21:24:10 +00:00
Tony 4043b05cde Cancel badge scale anim when setting new badge scale
Otherwise it's possible the badge scale animation will override the
non-animated set value, which could mean a badge continues to show
even though it shouldn't:
- Animate badge scale to 1
- Before animation finishes, set badge scale to 0
- Badge scale ends at 1, since animation wasn't cancelled, so we
  continue to show it indefinitely

Also exported some properties in case a similar issue arises.

Bug: 111791593
Change-Id: Ia1a417239b909886adf9351e9bdc06a3b22d8b73
2018-08-17 13:47:39 -07:00
arangelov ad78305862 Highlight work tab when user already in All Apps after creating WP.
When a user created a work profile and was already in the All Apps
view, the work tab was not highlighted, because the logic for that
was only in AllAppsContainerView#onScrollUpEnd(). This CL
highlights the tab when the user has resumed and the All Apps view
is expanded.

Bug: 79242814
Test: Manual
Change-Id: I40af0d513c95f8084e21f4e276e9f56bcb06555e
2018-08-17 20:28:52 +01:00
Vadim Tryshev 923b81c14f Reducing time of TaplTests run
From ~245 to ~150 sec.

Done by removing testing behaviors that don't depend on QS from tests
marked with QuickstepOnOff attribute.

Also fixing a bug that went unnoticed: now restoring Launcher QS mode
after each test.

Bug: 110103162
Test: TaplTests suite
Change-Id: I715158b47ac1e370f578b8d4f13d9633283763fe
2018-08-16 17:55:34 -07:00
Tobias Dubois d38f791b68 Lint fix: IS_DEBUG_DEVICE: Implied default locale
Use the ROOT locale to make sure toLowerCase has consistent behavior
regardless of the currently set language.

Test: Manual
Change-Id: Ie43f76cbc15eee0d96314e92d2acd5abb22f7077
2018-08-16 20:10:25 +00:00
Tony Wickham 58ad76fd62 Merge "Make arrow feel more connected to popup" into ub-launcher3-master 2018-08-16 17:48:07 +00:00
Tobias Dubois 83b042c897 Use View.getHeight() instead of Canvas.getHeight() for PageIndicatorDots
Use View.getHeight() instead of Canvas.getHeight() to get the same height
regardless of using hardware or software accelerated drawing.

Test: manual
Change-Id: I475afef017102d7968f28a7aab8116238af3d90d
2018-08-16 10:46:34 +02:00
Tony c677417d7a Polish shelf tracking
- Offset distance based on where gesture started, so that the shelf is
  always under your finger even if you swiped up high on the nav bar
- Use the same distance when swiping down to launch a task as we use for
  swiping up from an app (so that the swipe feels more reversible)
- Allow swiping up in the gap between hotseat and overview, so there's
  no "dead zone"

Bug: 109709720
Change-Id: I828d82e8feb250fd31e382d42aeefcb11d4a07d5
2018-08-15 15:53:24 -07:00
Tony 977690e931 Make arrow feel more connected to popup
- Clip the arrow that is overlapped by the popup, so that it doesn't
  show when that part of the popup is highlighted
- Animate the arrow first instead of last. Now the animation feels
  like one continuous motion as the arrow grows into the popup.

Bug: 111159923
Bug: 111006276
Change-Id: I22fb3037d950d55fe6c8ed4dc5345279874f0a3a
2018-08-15 15:22:28 -07:00
TreeHugger Robot 9e26e26f00 Merge "Prevent the work mode switch thumb from being dragged." into ub-launcher3-master 2018-08-15 17:39:24 +00:00
arangelov 1502c673d0 Prevent the work mode switch thumb from being dragged.
When we normally press the work mode switch, it waits for the profile to
receive the ACTION_MANAGED_PROFILE_AVAILABLE broadcast before the button
UI actually toggles. The user never interacts directly with that switch.
However, dragging the switch thumb used to bypass that logic. This CL
makes sure dragging the switch thumb cannot happen in the first place.

Change-Id: Ib3b4ae7591136c35e6d02783387d752e246cfb5b
Fixes: 111211805
Test: Manual
2018-08-15 16:46:13 +01:00
android-build-team Robot 49c340d592 Snap for 4954221 from 1fc98f011e to qt-release
Change-Id: Iccf2381b134b95a8ff53ecfd9b2a01b287bbc67d
2018-08-15 03:11:28 +00:00
Vadim Tryshev b6398a1eb8 Sharing protocol constants between Launcher and TAPL
Bug: 110103162
Test: TaplTests
Change-Id: I5b2a2b8576a7a6ea4a156f00858711496d6b5bba
2018-08-14 19:53:43 -07:00
TreeHugger Robot e1c4a90635 Merge "Migrating to android-x" into ub-launcher3-master 2018-08-14 22:53:40 +00:00
TreeHugger Robot d7f266fee1 Merge "Removing static launcher activity dependency from FirstFrameAnimationHelper" into ub-launcher3-master 2018-08-14 22:30:00 +00:00
Sunny Goyal d230307a95 Migrating to android-x
Change-Id: I9a774152d13a541e8496dd84f2469bfed407f86d
2018-08-14 15:22:12 -07:00
TreeHugger Robot a950d40d09 Merge "Started converting Launcher to be gesture-stable" into ub-launcher3-master 2018-08-14 19:18:46 +00:00
Sunny Goyal 5bbe9e16b6 Merge "Changing Condition to an interface to allow using lambdas" into ub-launcher3-master 2018-08-14 19:10:13 +00:00
Lucas Dupin f3c4f77809 Merge "Respect night mode flag on Q and beyond" into ub-launcher3-master 2018-08-14 18:32:34 +00:00
Lucas Dupin eca08a10bd Respect night mode flag on Q and beyond
Test: manual
Change-Id: I01c51d02e787557717c12567adc8276943dbd1bc
Fixes: 110758454
2018-08-14 11:18:42 -07:00
Winson Chung 7debc53f93 Skip logic to find the dominant color when loading recent task icons
- Also move some allocations in ColorExtractor into thread locals to reduce
  allocations

Bug: 78777731
Change-Id: I8819106d476a9af02e864135a2f44b55fe9219cd
2018-08-14 10:30:33 -07:00
Vadim Tryshev dc755e718d Started converting Launcher to be gesture-stable
All tests keep passing.

WorkTabTest.workTabExists was made gesture-stable. There is no need to
use TAPL, as the point is not to check answering to gestures, but to
check presence of tabs, which is better to do using launcher internal
state. (It still fails if run as a part of all tests, presumably,
because after Launcher's start, changes in user configuration are not
recognized, so I've commented the failing part)

Bug: 110103162
Test: Run all tests
Change-Id: Ic30b8e8475d16cee3880332f12311a44ddfa26cb
2018-08-14 10:29:57 -07:00
Sunny Goyal 6edb1b84bf Changing Condition to an interface to allow using lambdas
Change-Id: Ib7ad6a45d2ce556f843cd3a9767001904707dced
2018-08-14 10:27:48 -07:00
Xin Li 1fc98f011e Merge stage-dr1-aosp-master into stage-aosp-master am: ec037c9092
am: a56aa613c8

Change-Id: Ie1361c4eb276fee324bb7e54f10ca398fab8631f
2018-08-13 18:40:50 -07:00
Xin Li a56aa613c8 Merge stage-dr1-aosp-master into stage-aosp-master
am: ec037c9092

Change-Id: Ifc27f22fa368ca8259a9e51a410adbfc253b4caf
2018-08-13 17:34:41 -07:00