Commit Graph

34630 Commits

Author SHA1 Message Date
Kevin 27831e1b01 Fix thumbnail views not rotating w/ orientation
View has an optimization where it will not measure again if it
is exact and the measurement has not changed. This means that when an
onMeasure pass starts off for each task view on orientation change,
it does not get passed down to the view holding the thumbnail and
icon as its measure specs have not changed. This causes an issue as
we use this measure call to react to orientation changes and
re-measure the thumbnail view to match the orientation of the device.

To fix this, we call forceLayout on the child explicitly on orientation
change to ensure that we get the measure call. This sets the flag to
force a re-measure in the next layout.

Bug: 131427332
Test: Do repro in bug, view rotates correctly
Change-Id: I0ef84dfcd0b3883582c8903d99d5e8a757ae8e74
2019-04-29 17:15:20 -07:00
Kevin cf4255336b Merge "Add 1.5x dimens for screens that are large enough" into ub-launcher3-qt-dev
am: 67b6541d7e

Change-Id: Ieb470638587ce4c060de7adcb689fe9e06b3e295
2019-04-29 17:07:41 -07:00
Kevin 798353cd2b Merge "Don't clip recents items with system bars" into ub-launcher3-qt-dev
am: ee8caf680a

Change-Id: I56befc5a089db2b9e5663b9907507f3a84923bfc
2019-04-29 17:07:16 -07:00
TreeHugger Robot 67b6541d7e Merge "Add 1.5x dimens for screens that are large enough" into ub-launcher3-qt-dev 2019-04-29 23:55:29 +00:00
TreeHugger Robot ee8caf680a Merge "Don't clip recents items with system bars" into ub-launcher3-qt-dev 2019-04-29 23:44:44 +00:00
Kevin 3dae6383f4 Add 1.5x dimens for screens that are large enough
For phones with smallest width at least 480 dp, we can scale
everything by 1.5x to fill in the space better. For phones with less
width than this, we maintain the current 320 dp specification.

Bug: 131610834
Test: Emulate on 240x320 ldpi, 480x800 hdpi, 480x800 mdpi, 800x1280 mdpi
on both portrait and landscape and layouts work as intended
Change-Id: I3f7d28dc22aa3a2de96b3de51b1aa5b5c2cb19fc
2019-04-29 16:43:12 -07:00
Vadim Tryshev 7fd3c6fc66 Merge "Not switching nav mode on a virtual device for now" into ub-launcher3-qt-dev
am: ac8494bfd9

Change-Id: I8d2fe47624b8c4959187f9092fe4207806de854b
2019-04-29 16:36:47 -07:00
Vadim Tryshev 51f364a184 Merge "Disabling AppPredictionsUITests" into ub-launcher3-qt-dev
am: 203dde3999

Change-Id: If6a73efb41042957d674d75fcc303e87b8a41495
2019-04-29 16:36:19 -07:00
Kevin 5cfd599f49 Align layout to dp grid for landscape
am: dd165d2d7c

Change-Id: I224627063dbab99807a80a97c7de6605fa9e0784
2019-04-29 16:35:47 -07:00
vadimt de84db9890 Disabling fallback overview tests until the bug is fixed
Please reenable once fixed.

Bug: 131630813
Change-Id: Idb6f59c5e785180c96fce10365a2b070558abcdd
2019-04-29 16:28:29 -07:00
Vadim Tryshev ac8494bfd9 Merge "Not switching nav mode on a virtual device for now" into ub-launcher3-qt-dev 2019-04-29 23:22:10 +00:00
Kevin 0448ab6d7d Don't clip recents items with system bars
In order for items to go under the system bars, we have the recents view
consume the insets by setting padding to the recyclerview instead of
setting the margins with it. Then, we ensure the recycler view does not
clip to padding so that items are still visible even when scrolled past.

Bug: 131626311
Test: Manual test; items go under system bars
Change-Id: Iecbab537b8f9e2993ad5f74f87ba2e0c56fb0f63
2019-04-29 16:06:32 -07:00
Vadim Tryshev 203dde3999 Merge "Disabling AppPredictionsUITests" into ub-launcher3-qt-dev 2019-04-29 23:03:17 +00:00
vadimt 8dca8a7328 Not switching nav mode on a virtual device for now
Change-Id: Ie089638b6252073e5e495e87c7bc0d252a58e95f
2019-04-29 16:01:47 -07:00
Kevin 694e0fccad Merge changes Id401f273,I0b21c8ea,Ieb7936bd into ub-launcher3-qt-dev
am: 384a0aade0

Change-Id: Id250130cd3f1b2b563556cbd76603f6cf8d2015a
2019-04-29 15:22:51 -07:00
Kevin dd165d2d7c Align layout to dp grid for landscape
Set a fixed width for the recyclerview and center it for landscape mode.
In addition, put a margin below the clear all button as we no longer
have the nav bar padding the area below.

Bug: 131610834
Test: Manual; See recents UI in landscape mode
Change-Id: I8c74d2d7cc363a76c4c978befdc975693d700f86
2019-04-29 15:21:08 -07:00
Sunny Goyal da8105cc9f Merge "Adding support for accessibiliy gesture" into ub-launcher3-qt-dev
am: c6e7a38fb6

Change-Id: I6cb983919cd85e21b937b3e55ff98ecb2f2058d3
2019-04-29 15:17:38 -07:00
TreeHugger Robot 384a0aade0 Merge changes Id401f273,I0b21c8ea,Ieb7936bd into ub-launcher3-qt-dev
* changes:
  Layout aligned to dp grid for portrait (3/3)
  Layout aligned to dp grid for portrait (2/3)
  Layout aligned to dp grid for portrait (1/3)
2019-04-29 22:08:29 +00:00
TreeHugger Robot c6e7a38fb6 Merge "Adding support for accessibiliy gesture" into ub-launcher3-qt-dev 2019-04-29 21:54:41 +00:00
Kevin fc3a79e45e Layout aligned to dp grid for portrait (3/3)
Remove old custom view functionality to size based off device height
since we now specify dimensions exactly.

Bug: 131610834
Test: Builds, layout meets spec in portrait mode
Change-Id: Id401f27360f6bb2450d3ffb77888a1f709dc62f8
2019-04-29 14:52:56 -07:00
Kevin ad8ca82e61 Layout aligned to dp grid for portrait (2/3)
Add vertical margins to all recycler items. In the future, we will
change these dynamically to ensure a task item is semi-visible on screen

Bug: 131610834
Test: Builds
Change-Id: I0b21c8ea7249e7fac640705e8128e309b954815b
2019-04-29 14:48:48 -07:00
Sunny Goyal 4580149897 Adding support for accessibiliy gesture
Bug: 130905838
Change-Id: If796b6e6036c2f216abf87386d8eebcaa6368d02
2019-04-29 14:40:41 -07:00
Sunny Goyal 2acea9f872 Enabling quick-switch gesture in landscape mode (2 button UI)
Bug: 130689544
Change-Id: I6b424be4d80b3bf8263f456a024a81c63100030e
2019-04-29 14:33:56 -07:00
Tim Joines de7ef8c619 Merge "Launcher3GoIconRecents should override Launcher3Go" into ub-launcher3-qt-dev
am: 03225dba44

Change-Id: I2b529a21ae9573a4d21a585cd5585d4a81d39999
2019-04-29 13:37:24 -07:00
Kevin eb815415da Layout aligned to dp grid for portrait (1/3)
This CL sets fixed dp values for the recents item views based off the UX
spec.  Vertical margins will be handled by an item decorator in the next
CL to handle special cases.

Bug: 131610834
Test: Builds
Change-Id: Ieb7936bd24933552844a6bd1bdb9e3101b8cdca4
2019-04-29 13:12:54 -07:00
Tim Joines 03225dba44 Merge "Launcher3GoIconRecents should override Launcher3Go" into ub-launcher3-qt-dev 2019-04-29 20:05:21 +00:00
Sunny Goyal b4a03febfc Releasing SurfaceControl when they are no longer needed
am: 0382dd76e8

Change-Id: I5038e4ecd892a7e23658c9aa7c59a2e3beef7363
2019-04-29 12:33:25 -07:00
Ryan Mitchell 369725db43 Rename launcher:iconSize attribute to prevent overriding material am: 09328442d6
am: 7a86547199

Change-Id: I36017d544f9c6581d44e85722dcfbe47ca0412f4
2019-04-29 12:10:00 -07:00
Sunny Goyal 0382dd76e8 Releasing SurfaceControl when they are no longer needed
Bug: 123874711
Change-Id: I9c06723a3e5d4a23b8a6c60352806bb12daba598
2019-04-29 12:04:11 -07:00
Ryan Mitchell 7a86547199 Rename launcher:iconSize attribute to prevent overriding material
am: 09328442d6

Change-Id: I9d4b09b5de318197a9cb553c2c989959d5d436c8
2019-04-29 11:09:58 -07:00
Tim Joines 31d569e324 Launcher3GoIconRecents should override Launcher3Go
The default recommended launcher should be Launcher3GoIconRecents for
low_ram devices.

Bug: 131434765
Test: manual, check out dir
2019-04-29 10:32:49 -07:00
Sunny Goyal cd9b01c1a7 Merge "Updating the touch proxy logic:" into ub-launcher3-qt-dev
am: 34c630bf14

Change-Id: I69efef010a7b3449c84f2999000e65f2648125ca
2019-04-29 09:39:59 -07:00
TreeHugger Robot 34c630bf14 Merge "Updating the touch proxy logic:" into ub-launcher3-qt-dev 2019-04-29 16:27:03 +00:00
android-build-team Robot 4246d8db74 Snap for 5511022 from d4e8bdbc62 to qt-release
Change-Id: I022dcba5978eddbd42f873885ce261ddd1aa51c6
2019-04-27 23:25:35 +00:00
vadimt a72408300f Attempt to fix broken tests by having different nav models
am: 3be3f03e90

Change-Id: Id45ddab14bb3242361addb91780b0d96fa1354c0
2019-04-26 18:42:32 -07:00
vadimt 3be3f03e90 Attempt to fix broken tests by having different nav models
Change-Id: I1adae9f5897269bda9019b1cce0479b6d4af1c72
Pixel1: 3 button
Pixel2: 0 button
Pixel3: 2 button
2019-04-26 18:29:07 -07:00
vadimt 3226070826 Quick for for broken OOP tests
am: b3a934d984

Change-Id: I97b441a13348b318460c6d697fa3315792ac4d5b
2019-04-26 17:50:21 -07:00
vadimt b3a934d984 Quick for for broken OOP tests
Change-Id: I1009381a58ca28b3ef922f1c6bb872f811f88716
2019-04-26 17:28:25 -07:00
Winson Chung 3323b68a99 Merge "Reset the task's curve scale prior to calculating the recents view scale" into ub-launcher3-qt-dev
am: 308f356eb4

Change-Id: Ib1bf7b2fe675ffa2d534d7d70199481ff9c16247
2019-04-26 17:16:47 -07:00
Vadim Tryshev e7556b524d Merge "Not starting Chrome for testing as it's unstable" into ub-launcher3-qt-dev
am: fa671826e3

Change-Id: I0eaa6b4af63173b6785bf5719277e476a4d4ea28
2019-04-26 17:16:22 -07:00
TreeHugger Robot 308f356eb4 Merge "Reset the task's curve scale prior to calculating the recents view scale" into ub-launcher3-qt-dev 2019-04-27 00:07:30 +00:00
Vadim Tryshev fa671826e3 Merge "Not starting Chrome for testing as it's unstable" into ub-launcher3-qt-dev 2019-04-26 23:58:15 +00:00
Winson Chung 8153b69da8 Reset the task's curve scale prior to calculating the recents view scale
Bug: 131436393
Test: Swipe to next task, before it can settle, touch and start quick
      switching again

Change-Id: I568ec059be4c5c2f8c663980da0931c01d784f1f
2019-04-26 16:45:33 -07:00
vadimt 91b01f6c7f Not starting Chrome for testing as it's unstable
Bug: 131420412
Change-Id: Ief57e8a9ba37feddfc7c2bddc66209e99c796052
2019-04-26 14:38:21 -07:00
vadimt 1d20590310 Disabling AppPredictionsUITests
Also I recommend not using TAPL here, but follow this:
https://docs.google.com/presentation/d/1jyS_AIqevT22mk3SpfFS6paW98QLoJ_Fu7DgpXIgZ2g/edit#slide=id.g3f7630d0d8_0_9
https://docs.google.com/presentation/d/1jyS_AIqevT22mk3SpfFS6paW98QLoJ_Fu7DgpXIgZ2g/edit#slide=id.g435cf3d76d_1_113

Bug: 131188880
Change-Id: Ib01197acbe3ea68e27f121b1c6d8304bbff9696f
2019-04-26 14:12:29 -07:00
vadimt 71aaf94504 Running tests only in 1 nav mode
am: 9565c2a071

Change-Id: Iebf5fef1205d9f3e9e53cbfc6f0062b228cd9f89
2019-04-26 14:11:44 -07:00
vadimt 9565c2a071 Running tests only in 1 nav mode
Pixel1: 3-button
Pixel2: 2-button
Pixel3: 0-button

This is a temporary workaround for the listed bugs.

Bug: 130558787
Bug: 131419978
Change-Id: Ic57422c7ca8e9985fc0613239c803149e66d907f
2019-04-26 13:22:28 -07:00
Vadim Tryshev 342402ea22 Merge "Temporarily disabling 3-button testing mode" into ub-launcher3-qt-dev
am: 6f09dd61af

Change-Id: I0f91e24bb49ce8625c5839356c4553f02a08a87e
2019-04-26 12:04:22 -07:00
Vadim Tryshev 6f09dd61af Merge "Temporarily disabling 3-button testing mode" into ub-launcher3-qt-dev 2019-04-26 19:00:45 +00:00
Matthew Ng cd5ed8b28f Merging ub-launcher3-qt-dev, build 5508646
Test: Manual

Bug:112934365 [STOP SHIP BUG] Sysui Navigation Bar Prototype Tracking Bug:114136250 Have a more spartan RecentsActivity on android go Bug:118758133 Add logging to track undo box usage Bug:119992316 Widget screen won't close when tapping back or home button Bug:128857973 With dark display and black accent device theme, App list header not visible on all apps screen. Bug:129279637 [Logging] Long press|tap on app icon from Task should be logged Bug:129497226 Remove setInteractionState from the contract Bug:129723135 Broken tests: swipe from killed launcher doesn't open overview Bug:129806241 [a11y][Qt] Remove an app icon in Home screen, the popup "Item removed" with UNDO doesn't follow the settings of Time to take action. Bug:129985827 [Fully Gestural Navigation] Delay Recents animation when swiping up Bug:130851537 Recents and notification shelf both became nonresponsive after I "palmed" the screen while it was on. Bug:131095241 Recents Go should support landscape app => landscape thumbnail transition Bug:131303610 Backedup shortcut icons are not badged Bug:131339235 Don't layout empty task views if we have the real content Bug:131364673 [Failing test] FallbackRecentsTest
Change-Id: I04018e14bd6d9ba77005e72fe20f4a3ede886abf
2019-04-26 11:59:39 -07:00