Commit Graph

34630 Commits

Author SHA1 Message Date
TreeHugger Robot 13da82576f Merge "Only do content fill anim after layout anim" into ub-launcher3-qt-dev 2019-05-10 18:24:18 +00:00
Kevin 3792c733f8 Fix missing early return.
Fix a missing early return for when we don't have the bottom view laid
out on remote animation start.

Test: Builds
Change-Id: Iba0d5097ce59d017dc43030552f2171c5e6e4fb1
2019-05-10 11:19:37 -07:00
Jonathan Miranda e8deb9ce63 Merge "Initial app open/close polish using tuned values." into ub-launcher3-qt-dev
am: 57730ed095

Change-Id: I478a00fb48c4e0cef8a7086428f5afbae9b16f6a
2019-05-10 10:41:07 -07:00
Jonathan Miranda 57730ed095 Merge "Initial app open/close polish using tuned values." into ub-launcher3-qt-dev 2019-05-10 17:30:46 +00:00
Kevin 32f55bf02d Set "usingRemoteAnim" for fallback recents
Ensure fallback recents uses the correct layout animation by hooking
into usingRemoteAnim API.

Bug: 132112131
Test: Manual test
Change-Id: I9bb96dbf436018e5488ede0c5ca48af787180aec
2019-05-10 10:28:07 -07:00
Kevin 47fc4f1316 Only do content fill anim after layout anim
The new remote animation may start after the tasks are loaded and we
start the content fill animation. This means the layout happens after
and the content fill animation will conflict with the layout animation.
To fix this, we should only do the content fill animation after the
layout animation as intended. If the tasks load before we start the
layout animation, we should just directly update to the latest UI
without animating as the views won't be visible before the layout
animation starts.

Bug: 132381412
Test: Manual test
Change-Id: Ibb55d8ef4499260ffa4bef5c6bba605ffdc85da7
2019-05-10 10:18:05 -07:00
Alex Mang 1c8e1d1353 Merge "Adding query length parameter to protobuf" into ub-launcher3-qt-dev
am: 9b39df068e

Change-Id: I33d48cfa60a82464772ee5f1e4b5425572f3f8ca
2019-05-10 10:16:02 -07:00
Jon Miranda 2da1da3076 Initial app open/close polish using tuned values.
* Rect and radius now match the app window size.

Bug: 124510042
Bug: 122843905
Change-Id: Ibc85bfe1d75d01cefe00b6bf32557e04a0ee4716
2019-05-10 10:11:35 -07:00
Alex Mang 9b39df068e Merge "Adding query length parameter to protobuf" into ub-launcher3-qt-dev 2019-05-10 17:04:57 +00:00
Govinda Wasserman 9b99128350 Merge "Implements the new subscript proactive suggestions style" into ub-launcher3-qt-dev
am: c8dc2ecb4a

Change-Id: Iccf2010b768ecd25a7b4784a72cdce8d53d05d5b
2019-05-10 09:50:55 -07:00
Govinda Wasserman c8dc2ecb4a Merge "Implements the new subscript proactive suggestions style" into ub-launcher3-qt-dev 2019-05-10 16:30:04 +00:00
Govinda Wasserman ede5052227 Implements the new subscript proactive suggestions style
Change-Id: I89575a315f1468bde2a0f7894cd19b1124afa840
2019-05-10 10:40:10 -04:00
Bill Yi ff0a533676 [automerger skipped] Merge "Import translations. DO NOT MERGE" into ub-launcher3-qt-dev
am: 0f07b87420 -s ours
am skip reason: subject contains skip directive

Change-Id: I97086bc294d8cb19b8935234b4759462d882f486
2019-05-10 01:06:31 -07:00
TreeHugger Robot cf2393e056 Merge "Import translations. DO NOT MERGE" into ub-launcher3-master 2019-05-10 07:40:17 +00:00
TreeHugger Robot 0f07b87420 Merge "Import translations. DO NOT MERGE" into ub-launcher3-qt-dev 2019-05-10 07:34:58 +00:00
Bill Yi 229ecc4224 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: Iee3e02b60f19e7230c327b7bfe324ba72195de01
2019-05-09 23:30:10 -07:00
Bill Yi 3d4ae35081 Import translations. DO NOT MERGE
Change-Id: I89b0e8ca9c0fe116df9745bf5b5b184bdec242a6
Auto-generated-cl: translation import
2019-05-09 23:28:30 -07:00
Kevin f67bccf446 Merge "Fix anim done callback not being called sometimes" into ub-launcher3-qt-dev
am: fc65c357a1

Change-Id: Ib3c7b34219cb1748379c6f6206880739d93d99f6
2019-05-09 18:45:15 -07:00
TreeHugger Robot fc65c357a1 Merge "Fix anim done callback not being called sometimes" into ub-launcher3-qt-dev 2019-05-10 01:42:47 +00:00
Kevin 78ae5ae909 Ending pending anim should set to end values.
am: f574bd5535

Change-Id: I8c3faecf1c35cea0b421370d31dc2cb66d15fcfa
2019-05-09 18:34:02 -07:00
Kevin 8ec906fc6a Move shared end pending anim logic for reusability
am: b0fcded7aa

Change-Id: Icce5133038bf2fbeec0eb78cd4f8478cc3faf447
2019-05-09 18:12:40 -07:00
Kevin b2fae14ef0 Merge changes from topic "polish-app-recents-anim" into ub-launcher3-qt-dev
am: f079b277cf

Change-Id: Id7c445cd5ba6f801fb148bafe1c4406392db944f
2019-05-09 18:12:11 -07:00
Kevin f574bd5535 Ending pending anim should set to end values.
Pending animations have not started but when ending animations, we
should ensure they are set to their end values based off the
documentation for ItemAnimator's endAnimations and endAnimation.

Bug: 132285006
Test: Build using endAnimations and manual test
Change-Id: I3039a4f192d68a0ead700cd81675b3e7b4ef51f9
2019-05-09 17:47:37 -07:00
Kevin b0fcded7aa Move shared end pending anim logic for reusability
Some of the logic in endAnimations and endAnimation is shared and should
be moved to a common helper method.

Test: Builds and functions as before
Change-Id: I4973d50ad8778bb397938b5d65d9f95f48ff145b
2019-05-09 17:40:08 -07:00
Kevin cbfa4ae7a8 Merge "Use Animator cancel instead of end" into ub-launcher3-qt-dev
am: 1350be3c21

Change-Id: Id9c598d1e23a33c02a5615a65d44c827cf825d80
2019-05-09 17:07:58 -07:00
Kevin bc96edba63 Merge "Fix fallback recents not updating list from app" into ub-launcher3-qt-dev
am: f66f6aefcc

Change-Id: I92e347865038e89ddb7e01f0cd2533da65fbd039
2019-05-09 17:07:32 -07:00
TreeHugger Robot f079b277cf Merge changes from topic "polish-app-recents-anim" into ub-launcher3-qt-dev
* changes:
  Polish app => recents animation (5/5)
  Polish app => recents animation (4/5)
  Polish app => recents animation (3/N)
  Polish app => recents animation (2/N)
  Polish app => recents animation (1/N)
2019-05-10 00:07:18 +00:00
Tony f0b2d2ecf8 Merge "Add ScreenPinnedInputConsumer" into ub-launcher3-qt-dev
am: 693c5f5287

Change-Id: I8cbceafef56338891545c32ece03a41e8ff62e6d
2019-05-09 17:06:54 -07:00
Kevin 5c0ee7ca37 Polish app => recents animation (5/5)
Add the part of the animation where task views fade in from bottom to
top. For the app animating in, we only fade in the label and the icon as
the snapshot needs to be visible as the app window scales down to it.

Bug: 132112131
Test: Manual test animation
Change-Id: Ia3fb98fde0b14fa4f72b53a1941cc2ee6b9f2294
2019-05-09 16:38:54 -07:00
TreeHugger Robot 1350be3c21 Merge "Use Animator cancel instead of end" into ub-launcher3-qt-dev 2019-05-09 23:25:54 +00:00
TreeHugger Robot f66f6aefcc Merge "Fix fallback recents not updating list from app" into ub-launcher3-qt-dev 2019-05-09 23:24:53 +00:00
TreeHugger Robot 693c5f5287 Merge "Add ScreenPinnedInputConsumer" into ub-launcher3-qt-dev 2019-05-09 23:24:44 +00:00
vadimt 04d9751d4e Merge "Disabling updating All Apps during a long-press recognition" into ub-launcher3-qt-dev
am: 9104c2323a

Change-Id: I7cadb4e181ecc5c209db2d4bb6ef7aecf53ebbdb
2019-05-09 16:15:36 -07:00
Tony 918863083b Add ScreenPinnedInputConsumer
When screen pinning is active, swipe up and hold to stop it.

Bug: 130828539
Change-Id: I343050d2a224ac723143cd3be4f78bc321f1a026
2019-05-09 18:10:10 -05:00
Kevin 4ff2a278a2 Use Animator cancel instead of end
Animtor's cancel() skips some animator init logic that end() does so
we'd like to use that instead. The on end callback will still set the
animation value to its target end value so this doesn't affect
correctness.

Bug: 132285006
Test: Build and manual test endAnimations
Change-Id: I450a888c7b37a7dc74f24035d9abc5bda1cbbbd8
2019-05-09 16:08:09 -07:00
TreeHugger Robot 9104c2323a Merge "Disabling updating All Apps during a long-press recognition" into ub-launcher3-qt-dev 2019-05-09 23:04:05 +00:00
Kevin 63517a7a07 Fix anim done callback not being called sometimes
We should call dispatchFinishedWhenDone in endAnimations instead of
calling dispatchAnimationsFinished as the former will run the listener.
However, we only do this if we were running animations in the first
place.

Bug: 132285006
Test: Build and manual test endAnimations() call
Change-Id: I31afdc4c9e3ef5f56eda6178569d5c264c16ae78
2019-05-09 16:01:01 -07:00
vadimt 24d31d4b6e Disabling updating All Apps during a long-press recognition
This is supposed to eliminate test flakes in the lab.

When an app gets updated while all apps is opened, all-apps will be
re-laid-out.

If the layout happens while we are recognizing a long-press on an app
icon in all Apps, the long-press won't be recognized.

In the lab, this happened so frequently that it caused considerable
flakiness. Even after we started running tests in airplane mode, this
still keeps happening. The bug refers an example with airplane mode on.

The fix will be also mildly beneficial for users.

Bug: 132177321
Change-Id: Ie7c7473fe94b8af83f04cd719286bae69e2d9de0
2019-05-09 15:48:32 -07:00
Alex Mang 68c67540cd Adding query length parameter to protobuf
Bug: 131940434
Change-Id: Iaa7ca520406df882e154db3662a190607eb61b23
2019-05-09 15:13:52 -07:00
Tony 523db93ac3 Move InputConsumers to new inputconsumers package
am: 9aaa92672d

Change-Id: I208cacd95d61f0b079416eb78a882b5404654ba0
2019-05-09 14:49:53 -07:00
Lucas Dupin 904c429b99 Implement scrim method
Bug: 130451254
Test: make
Change-Id: Ifd66f9e53dd86d21fe66e4617cc4b209fecd7328
2019-05-09 14:35:13 -07:00
George Hodulik 7cf4b40a97 Use strings "home" and "overview" rather than GEL
Bug:129421797
Test: Flashed to QP1A.190508.001, installed launcher with change.
      Observed both home and overview predictions were as expected.

Change-Id: I127d489eae382f4cee75afdd6d615d6d7a8227ee
2019-05-09 14:23:23 -07:00
Kevin 90137b035c Add task launch logging to Recents Go
Add logging points for launching tasks in Recents Go to match up with
non-Go Recents.

Bug: 131840601
Test: Log calls to confirm writing to stats log on task launch
Change-Id: I3d7b1ed30f99ce9f551c3481628ca81540e366b5
2019-05-09 14:12:40 -07:00
Tony 9aaa92672d Move InputConsumers to new inputconsumers package
Change-Id: I3318784523b8ff1b9468cbfed3a2682985274ea8
2019-05-09 14:37:37 -05:00
Kevin 4e53010917 Merge "Apply insets correctly to fallback Recents Go" into ub-launcher3-qt-dev
am: 75d2bcbe41

Change-Id: I44d4fb375f14e99032c93b39e651719922737ae0
2019-05-08 18:56:14 -07:00
Kevin 5b596328ad Merge "Fix 1.5x layout values" into ub-launcher3-qt-dev
am: 8c61598243

Change-Id: Iefbf2d6e86b8790ac7667ee4281dd7aced841689
2019-05-08 18:55:43 -07:00
Vadim Tryshev 6bbac66535 Merge "Not using magic constants for navbar height" into ub-launcher3-qt-dev
am: 94dbfb9bdb

Change-Id: I7d28814a0e06c24c77b8a0c9a32c7040f4874630
2019-05-08 18:50:44 -07:00
Kevin cde60e24b0 Fix fallback recents not updating list from app
When launching an from recents, onStop is not called until the app is
fully taken over and the remote animation finishes. As a result, if the
user hits the overview button right before the animation finishes, we
animate back to recents but never call onStart which is where we hook in
to update the recents list.

The fix naturally is to move this to onResume instead as once the
animation begins, the activity is paused.

Bug: 132293341
Test: Repro from bug, correctly updates
Change-Id: Ie6cfdc4d5aa6b1742a3bce3e14ab5ab6a4f05526
2019-05-08 18:23:52 -07:00
TreeHugger Robot 75d2bcbe41 Merge "Apply insets correctly to fallback Recents Go" into ub-launcher3-qt-dev 2019-05-09 01:21:19 +00:00
TreeHugger Robot 8c61598243 Merge "Fix 1.5x layout values" into ub-launcher3-qt-dev 2019-05-09 00:59:48 +00:00